Re: [Regression] fstrim hangs on Hyper-V: caused by "block: improve handling of the magic discard payload"

2017-01-12 Thread Christoph Hellwig
On Fri, Jan 13, 2017 at 06:16:02AM +, Dexuan Cui wrote: > IMO this means not only SCSI Unmap command is affected, but > some other SCSI commands can be affected too? > And it looks the bare metal can be affected too? This affects all drivers looking at the sdb.length field for the total I/O

RE: [Regression] fstrim hangs on Hyper-V: caused by "block: improve handling of the magic discard payload"

2017-01-12 Thread Dexuan Cui
> From: Dexuan Cui > Sent: Friday, January 13, 2017 11:05 > To: 'Christoph Hellwig' > Cc: linux-block@vger.kernel.org; KY Srinivasan ; Chris > Valean (Cloudbase Solutions SRL) > Subject: RE: [Regression] fstrim hangs on Hyper-V: caused by

RE: [Regression] fstrim hangs on Hyper-V: caused by "block: improve handling of the magic discard payload"

2017-01-12 Thread Dexuan Cui
> From: Christoph Hellwig [mailto:h...@lst.de] > Sent: Friday, January 13, 2017 02:19 > To: Dexuan Cui > Cc: linux-block@vger.kernel.org; KY Srinivasan ; Chris > Valean (Cloudbase Solutions SRL) > Subject: Re: [Regression] fstrim

RE: [Regression] fstrim hangs on Hyper-V: caused by "block: improve handling of the magic discard payload"

2017-01-12 Thread Chris Valean (Cloudbase Solutions SRL)
Hi Christoph, Adding Nick and Alex to the thread. We'll give it a try along with Dexuan and update you with the results. Thank you! Chris Valean -Original Message- From: Christoph Hellwig [mailto:h...@lst.de] Sent: Thursday, January 12, 2017 8:19 PM To: Dexuan Cui

Re: [Regression] fstrim hangs on Hyper-V: caused by "block: improve handling of the magic discard payload"

2017-01-12 Thread Christoph Hellwig
Next try: (I've also dropped most of the Cc list) diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c index c35b6de..2f358f7 100644 --- a/drivers/scsi/scsi_lib.c +++ b/drivers/scsi/scsi_lib.c @@ -1018,7 +1018,10 @@ static int scsi_init_sgtable(struct request *req, struct

Re: [Regression] fstrim hangs on Hyper-V: caused by "block: improve handling of the magic discard payload"

2017-01-12 Thread Christoph Hellwig
Can you check if this debug printk triggers for the discard commands? --- diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c index 888e16e..7ab7d08 100644 --- a/drivers/scsi/storvsc_drv.c +++ b/drivers/scsi/storvsc_drv.c @@ -1031,6 +1031,10 @@ static void

RE: [Regression] fstrim hangs on Hyper-V: caused by "block: improve handling of the magic discard payload"

2017-01-12 Thread Dexuan Cui
> From: Christoph Hellwig [mailto:h...@lst.de] > Sent: Thursday, January 12, 2017 21:44 > To: Dexuan Cui > Cc: Christoph Hellwig ; linux-block@vger.kernel.org; Jens Axboe > ; Vitaly Kuznetsov ; linux- > ker...@vger.kernel.org;

Re: [Regression] fstrim hangs on Hyper-V: caused by "block: improve handling of the magic discard payload"

2017-01-12 Thread Christoph Hellwig
Hi Dexuan, sorry for dropping the ball on the previous private report, I hoped I could get my hands on a Hyper-V VM and reproduce it myself, but that has obviously not happened. Can you send me the output of the provisioning_mode file for the scsi disk in question to get started? -- To