Re: nvmf regression with mq-deadline

2017-02-27 Thread Jens Axboe
On Mon, Feb 27 2017, Sagi Grimberg wrote: > > >Now I'm getting a NULL deref with nvme-rdma [1]. > > > >For some reason blk_mq_tag_to_rq() is returning NULL on > >tag 0x0 which is io queue connect. > > > >I'll try to see where this is coming from. > >This does not happen with loop though... > >

Re: nvmf regression with mq-deadline

2017-02-27 Thread Sagi Grimberg
Hey Jens, I'm getting a regression in nvme-rdma/nvme-loop with for-linus [1] with a small script to trigger it. The reason seems to be that the sched_tags does not take into account the tag_set reserved tags. This solves it for me, any objections on this? -- diff --git a/block/blk-mq-sched.c

Re: nvmf regression with mq-deadline

2017-02-27 Thread Sagi Grimberg
Now I'm getting a NULL deref with nvme-rdma [1]. For some reason blk_mq_tag_to_rq() is returning NULL on tag 0x0 which is io queue connect. I'll try to see where this is coming from. This does not happen with loop though... That's because the loop driver does not rely on the cqe.command_id