Re: blk-mq breaks suspend even with runtime PM patch

2017-08-08 Thread Jens Axboe
On 08/08/2017 12:33 PM, Mike Galbraith wrote: > On Tue, 2017-08-08 at 18:50 +0200, Mike Galbraith wrote: >> On Tue, 2017-08-08 at 09:44 -0700, Greg KH wrote: >>> >>> Should these go back farther than 4.12? Looks like they apply cleanly >>> to 4.9, didn't look older than that... >> >> I met prerequ

Re: blk-mq breaks suspend even with runtime PM patch

2017-08-08 Thread Mike Galbraith
On Tue, 2017-08-08 at 18:50 +0200, Mike Galbraith wrote: > On Tue, 2017-08-08 at 09:44 -0700, Greg KH wrote: > > > > Should these go back farther than 4.12? Looks like they apply cleanly > > to 4.9, didn't look older than that... > > I met prerequisites at 4.11... FWIW, I took/modified 2d0364c8

Re: blk-mq breaks suspend even with runtime PM patch

2017-08-08 Thread Mike Galbraith
On Tue, 2017-08-08 at 09:44 -0700, Greg KH wrote: > > Should these go back farther than 4.12? Looks like they apply cleanly > to 4.9, didn't look older than that... I met prerequisites at 4.11, but I wasn't patching anything remotely resembling virgin source. -Mike

Re: blk-mq breaks suspend even with runtime PM patch

2017-08-08 Thread Oleksandr Natalenko
Greg, this is 765e40b675a9566459ddcb8358ad16f3b8344bbe. On úterý 8. srpna 2017 18:43:33 CEST Greg KH wrote: > On Tue, Aug 08, 2017 at 06:36:01PM +0200, Oleksandr Natalenko wrote: > > Could you queue "block: disable runtime-pm for blk-mq" too please? It is > > also related to suspend-resume freeze

Re: blk-mq breaks suspend even with runtime PM patch

2017-08-08 Thread Greg KH
On Tue, Aug 08, 2017 at 06:34:01PM +0200, Mike Galbraith wrote: > On Tue, 2017-08-08 at 09:22 -0700, Greg KH wrote: > > On Sun, Jul 30, 2017 at 03:50:15PM +0200, Oleksandr Natalenko wrote: > > > Hello Mike et al. > > > > > > On neděle 30. července 2017 7:12:31 CEST Mike Galbraith wrote: > > > > FW

Re: blk-mq breaks suspend even with runtime PM patch

2017-08-08 Thread Greg KH
On Tue, Aug 08, 2017 at 06:36:01PM +0200, Oleksandr Natalenko wrote: > Could you queue "block: disable runtime-pm for blk-mq" too please? It is also > related to suspend-resume freezes that were observed by multiple users. What is the git commit id of that patch? thanks, greg k-h

Re: blk-mq breaks suspend even with runtime PM patch

2017-08-08 Thread Oleksandr Natalenko
Could you queue "block: disable runtime-pm for blk-mq" too please? It is also related to suspend-resume freezes that were observed by multiple users. Thanks. On úterý 8. srpna 2017 18:33:29 CEST Jens Axboe wrote: > On 08/08/2017 10:22 AM, Greg KH wrote: > > On Sun, Jul 30, 2017 at 03:50:15PM +02

Re: blk-mq breaks suspend even with runtime PM patch

2017-08-08 Thread Mike Galbraith
On Tue, 2017-08-08 at 09:22 -0700, Greg KH wrote: > On Sun, Jul 30, 2017 at 03:50:15PM +0200, Oleksandr Natalenko wrote: > > Hello Mike et al. > > > > On neděle 30. července 2017 7:12:31 CEST Mike Galbraith wrote: > > > FWIW, first thing I'd do is update that 4.12.0 to 4.12.4, and see if > > > sta

Re: blk-mq breaks suspend even with runtime PM patch

2017-08-08 Thread Jens Axboe
On 08/08/2017 10:22 AM, Greg KH wrote: > On Sun, Jul 30, 2017 at 03:50:15PM +0200, Oleksandr Natalenko wrote: >> Hello Mike et al. >> >> On neděle 30. července 2017 7:12:31 CEST Mike Galbraith wrote: >>> FWIW, first thing I'd do is update that 4.12.0 to 4.12.4, and see if >>> stable fixed it. >> >>

Re: blk-mq breaks suspend even with runtime PM patch

2017-08-08 Thread Greg KH
On Sun, Jul 30, 2017 at 03:50:15PM +0200, Oleksandr Natalenko wrote: > Hello Mike et al. > > On neděle 30. července 2017 7:12:31 CEST Mike Galbraith wrote: > > FWIW, first thing I'd do is update that 4.12.0 to 4.12.4, and see if > > stable fixed it. > > My build already includes v4.12.4. > > > I

Re: blk-mq breaks suspend even with runtime PM patch

2017-07-30 Thread Oleksandr Natalenko
Hello Mike et al. On neděle 30. července 2017 7:12:31 CEST Mike Galbraith wrote: > FWIW, first thing I'd do is update that 4.12.0 to 4.12.4, and see if > stable fixed it. My build already includes v4.12.4. > If not, I'd find these two commits irresistible. > > 5f042e7cbd9eb blk-mq: Include all

Re: blk-mq breaks suspend even with runtime PM patch

2017-07-29 Thread Mike Galbraith
On Sat, 2017-07-29 at 17:27 +0200, Oleksandr Natalenko wrote: > Hello Jens, Christoph. > > Unfortunately, even with "block: disable runtime-pm for blk-mq" patch applied > blk-mq breaks suspend to RAM for me. It is reproducible on my laptop as well > as in a VM. > > I use complex disk layout inv

Re: blk-mq breaks suspend even with runtime PM patch

2017-07-29 Thread Oleksandr Natalenko
Recompiled kernel with lockdep enabled gives me this: === [ 368.655051] Showing all locks held in the system: [ 368.656387] 1 lock held by khungtaskd/37: [ 368.657171] #0: (tasklist_lock){.+.+..}, at: [] debug_show_all_locks+0x3d/0x1a0 [ 368.658725] 1 lock held by md0_raid10/458: [ 368.659

blk-mq breaks suspend even with runtime PM patch

2017-07-29 Thread Oleksandr Natalenko
Hello Jens, Christoph. Unfortunately, even with "block: disable runtime-pm for blk-mq" patch applied blk-mq breaks suspend to RAM for me. It is reproducible on my laptop as well as in a VM. I use complex disk layout involving MD, LUKS and LVM, and managed to get these warnings from VM via seri