Re: dm crypt: fix lost ioprio when queuing crypto bios from task with ioprio

2018-12-07 Thread Mike Snitzer
On Fri, Dec 07 2018 at 2:43pm -0500, Christoph Hellwig wrote: > On Thu, Dec 06, 2018 at 05:15:07PM -0500, Mike Snitzer wrote: > > From: Eric Wheeler > > > > Since dm-crypt queues writes (and sometimes reads) to a different kernel > > thread (workqueue), the bios will dispatch from tasks with d

Re: [dm-devel] [PATCH] dm crypt: fix lost ioprio when queuing crypto bios from task with ioprio

2018-12-07 Thread Christoph Hellwig
On Thu, Dec 06, 2018 at 05:15:07PM -0500, Mike Snitzer wrote: > From: Eric Wheeler > > Since dm-crypt queues writes (and sometimes reads) to a different kernel > thread (workqueue), the bios will dispatch from tasks with different > io_context->ioprio settings than the submitting task, thus givin

Re: [PATCH] dm crypt: fix lost ioprio when queuing crypto bios from task with ioprio

2018-12-06 Thread Jens Axboe
> diff --git a/block/bio.c b/block/bio.c > index 0c2208a5446d..ed68fdd78547 100644 > --- a/block/bio.c > +++ b/block/bio.c > @@ -647,6 +647,30 @@ struct bio *bio_clone_fast(struct bio *bio, gfp_t > gfp_mask, struct bio_set *bs) > } > EXPORT_SYMBOL(bio_clone_fast); > > +/** > + * bio_set_tas

[PATCH] dm crypt: fix lost ioprio when queuing crypto bios from task with ioprio

2018-12-06 Thread Mike Snitzer
From: Eric Wheeler Since dm-crypt queues writes (and sometimes reads) to a different kernel thread (workqueue), the bios will dispatch from tasks with different io_context->ioprio settings than the submitting task, thus giving incorrect ioprio hints to the io scheduler. By assigning the ioprio t

Re: [dm-devel] dm-crypt: fix lost ioprio when queuing crypto bios from task with ioprio

2017-03-10 Thread Eric Wheeler
On Thu, 5 Jan 2017, Mike Snitzer wrote: > On Thu, Dec 29 2016 at 11:08pm -0500, > Eric Wheeler wrote: > > > On Sat, 17 Dec 2016, Mike Snitzer wrote: > > > On Fri, Dec 16 2016 at 5:29pm -0500, > > > Eric Wheeler wrote: > > > > On Wed, 14 Dec 2016, Eric Wheeler wrote: > > > > > Since dm-crypt qu

Re: dm-crypt: fix lost ioprio when queuing crypto bios from task with ioprio

2017-01-05 Thread Mike Snitzer
On Thu, Dec 29 2016 at 11:08pm -0500, Eric Wheeler wrote: > On Sat, 17 Dec 2016, Mike Snitzer wrote: > > On Fri, Dec 16 2016 at 5:29pm -0500, > > Eric Wheeler wrote: > > > On Wed, 14 Dec 2016, Eric Wheeler wrote: > > > > Since dm-crypt queues writes (and sometimes reads) to a different kernel >

Re: dm-crypt: fix lost ioprio when queuing crypto bios from task with ioprio

2016-12-29 Thread Eric Wheeler
On Sat, 17 Dec 2016, Mike Snitzer wrote: > On Fri, Dec 16 2016 at 5:29pm -0500, > Eric Wheeler wrote: > > On Wed, 14 Dec 2016, Eric Wheeler wrote: > > > Since dm-crypt queues writes (and sometimes reads) to a different kernel > > > thread (workqueue), the bios will dispatch from tasks with differ

Re: dm-crypt: fix lost ioprio when queuing crypto bios from task with ioprio

2016-12-18 Thread Kent Overstreet
On Sun, Dec 18, 2016 at 06:17:55PM -0500, Mike Snitzer wrote: > Spinning it as a pure bugfix is a reach (as Eric's header documents the > patch, the case is weak for cc'ing stable). Reality is the change is > needed to enable a new bcache feature. I'm not going to rush > feature-enabling change t

Re: dm-crypt: fix lost ioprio when queuing crypto bios from task with ioprio

2016-12-18 Thread Mike Snitzer
On Sun, Dec 18 2016 at 5:54pm -0500, Kent Overstreet wrote: > On Sat, Dec 17, 2016 at 10:58:00AM -0500, Mike Snitzer wrote: > > The time for 4.10 inclusion has passed. This needs to wait until 4.11. > > > > It also needs more review, testing and possible re-working. Each DM > > target shouldn

Re: dm-crypt: fix lost ioprio when queuing crypto bios from task with ioprio

2016-12-18 Thread Kent Overstreet
On Sat, Dec 17, 2016 at 10:58:00AM -0500, Mike Snitzer wrote: > The time for 4.10 inclusion has passed. This needs to wait until 4.11. > > It also needs more review, testing and possible re-working. Each DM > target shouldn't have to worry about these details (though I do grant > that dm-crypt.c

Re: dm-crypt: fix lost ioprio when queuing crypto bios from task with ioprio

2016-12-17 Thread Mike Snitzer
On Fri, Dec 16 2016 at 5:29pm -0500, Eric Wheeler wrote: > On Wed, 14 Dec 2016, Eric Wheeler wrote: > > Since dm-crypt queues writes (and sometimes reads) to a different kernel > > thread (workqueue), the bios will dispatch from tasks with different > > io_context->ioprio settings than the submi

Re: [dm-devel] [PATCH] dm-crypt: fix lost ioprio when queuing crypto bios from task with ioprio

2016-12-16 Thread Eric Wheeler
On Wed, 14 Dec 2016, Eric Wheeler wrote: > Since dm-crypt queues writes (and sometimes reads) to a different kernel > thread (workqueue), the bios will dispatch from tasks with different > io_context->ioprio settings than the submitting task, thus giving > incorrect ioprio hints to the io scheduler

[PATCH] dm-crypt: fix lost ioprio when queuing crypto bios from task with ioprio

2016-12-14 Thread Eric Wheeler
Since dm-crypt queues writes (and sometimes reads) to a different kernel thread (workqueue), the bios will dispatch from tasks with different io_context->ioprio settings than the submitting task, thus giving incorrect ioprio hints to the io scheduler. By assigning the ioprio to the bio before queu