On Fri, Dec 07 2018 at 2:43pm -0500,
Christoph Hellwig wrote:
> On Thu, Dec 06, 2018 at 05:15:07PM -0500, Mike Snitzer wrote:
> > From: Eric Wheeler
> >
> > Since dm-crypt queues writes (and sometimes reads) to a different kernel
> > thread (workqueue), the bios will dispatch from tasks with d
On Thu, Dec 06, 2018 at 05:15:07PM -0500, Mike Snitzer wrote:
> From: Eric Wheeler
>
> Since dm-crypt queues writes (and sometimes reads) to a different kernel
> thread (workqueue), the bios will dispatch from tasks with different
> io_context->ioprio settings than the submitting task, thus givin
> diff --git a/block/bio.c b/block/bio.c
> index 0c2208a5446d..ed68fdd78547 100644
> --- a/block/bio.c
> +++ b/block/bio.c
> @@ -647,6 +647,30 @@ struct bio *bio_clone_fast(struct bio *bio, gfp_t
> gfp_mask, struct bio_set *bs)
> }
> EXPORT_SYMBOL(bio_clone_fast);
>
> +/**
> + * bio_set_tas
From: Eric Wheeler
Since dm-crypt queues writes (and sometimes reads) to a different kernel
thread (workqueue), the bios will dispatch from tasks with different
io_context->ioprio settings than the submitting task, thus giving
incorrect ioprio hints to the io scheduler.
By assigning the ioprio t
On Thu, 5 Jan 2017, Mike Snitzer wrote:
> On Thu, Dec 29 2016 at 11:08pm -0500,
> Eric Wheeler wrote:
>
> > On Sat, 17 Dec 2016, Mike Snitzer wrote:
> > > On Fri, Dec 16 2016 at 5:29pm -0500,
> > > Eric Wheeler wrote:
> > > > On Wed, 14 Dec 2016, Eric Wheeler wrote:
> > > > > Since dm-crypt qu
On Thu, Dec 29 2016 at 11:08pm -0500,
Eric Wheeler wrote:
> On Sat, 17 Dec 2016, Mike Snitzer wrote:
> > On Fri, Dec 16 2016 at 5:29pm -0500,
> > Eric Wheeler wrote:
> > > On Wed, 14 Dec 2016, Eric Wheeler wrote:
> > > > Since dm-crypt queues writes (and sometimes reads) to a different kernel
>
On Sat, 17 Dec 2016, Mike Snitzer wrote:
> On Fri, Dec 16 2016 at 5:29pm -0500,
> Eric Wheeler wrote:
> > On Wed, 14 Dec 2016, Eric Wheeler wrote:
> > > Since dm-crypt queues writes (and sometimes reads) to a different kernel
> > > thread (workqueue), the bios will dispatch from tasks with differ
On Sun, Dec 18, 2016 at 06:17:55PM -0500, Mike Snitzer wrote:
> Spinning it as a pure bugfix is a reach (as Eric's header documents the
> patch, the case is weak for cc'ing stable). Reality is the change is
> needed to enable a new bcache feature. I'm not going to rush
> feature-enabling change t
On Sun, Dec 18 2016 at 5:54pm -0500,
Kent Overstreet wrote:
> On Sat, Dec 17, 2016 at 10:58:00AM -0500, Mike Snitzer wrote:
> > The time for 4.10 inclusion has passed. This needs to wait until 4.11.
> >
> > It also needs more review, testing and possible re-working. Each DM
> > target shouldn
On Sat, Dec 17, 2016 at 10:58:00AM -0500, Mike Snitzer wrote:
> The time for 4.10 inclusion has passed. This needs to wait until 4.11.
>
> It also needs more review, testing and possible re-working. Each DM
> target shouldn't have to worry about these details (though I do grant
> that dm-crypt.c
On Fri, Dec 16 2016 at 5:29pm -0500,
Eric Wheeler wrote:
> On Wed, 14 Dec 2016, Eric Wheeler wrote:
> > Since dm-crypt queues writes (and sometimes reads) to a different kernel
> > thread (workqueue), the bios will dispatch from tasks with different
> > io_context->ioprio settings than the submi
On Wed, 14 Dec 2016, Eric Wheeler wrote:
> Since dm-crypt queues writes (and sometimes reads) to a different kernel
> thread (workqueue), the bios will dispatch from tasks with different
> io_context->ioprio settings than the submitting task, thus giving
> incorrect ioprio hints to the io scheduler
Since dm-crypt queues writes (and sometimes reads) to a different kernel
thread (workqueue), the bios will dispatch from tasks with different
io_context->ioprio settings than the submitting task, thus giving
incorrect ioprio hints to the io scheduler.
By assigning the ioprio to the bio before queu
13 matches
Mail list logo
