Re: Discrepant st_rdev and st_dev stats in btrfs block and fs device ids

2009-09-06 Thread David Zeuthen
Hey, > Can anyone repeat this? Any ideas why this could be happening? > Is this expected? There was some discussion about this some time ago, see http://news.gmane.org/find-root.php?message_id=%3c7b13a0f80904120735r41736455hb7e226ab8ad30bd7%40mail.gmail.com%3e I don't think it's resolved yet

Re: Discrepant st_rdev and st_dev stats in btrfs block and fs device ids

2009-09-06 Thread Josef Bacik
On Sun, Sep 06, 2009 at 04:51:55PM +0100, Marcus wrote: > Hello, > > I think I found a btrfs 0.19 problem when used in an lvm2 volume; > btrfs is returning a st_dev stat from the mounted filesystem / that is > different from the lvm2 blockdevice st_rdev stat in > /dev/mapper/vg0-os0. > > This btr

Discrepant st_rdev and st_dev stats in btrfs block and fs device ids

2009-09-06 Thread Marcus
Hello, I think I found a btrfs 0.19 problem when used in an lvm2 volume; btrfs is returning a st_dev stat from the mounted filesystem / that is different from the lvm2 blockdevice st_rdev stat in /dev/mapper/vg0-os0. This btrfs behavior is different from ext4, where the st_dev and st_rdev stats m

Re: [PATCH] Btrfs: potential NULL dereferences

2009-09-06 Thread Andi Kleen
Roel Kluin writes: > Allocations may fail, prevent NULL dereferences. > > Signed-off-by: Roel Kluin > --- > In several sections of fs/btrfs code a kmalloc() occurs without a > check whether it succeeded. this potentially leads to dereferences > of a NULL pointer. Are there reasons why we do not