Re: Kernel oops with 2.6.31 in btrfs_set_acl

2009-09-18 Thread Chris Ball
Hi, > Hi, I got an oops this morning with btrfs on the Ubuntu 2.6.31 > kernel. I mounted with compress and thread_pool=4. This is on a > 64 bit quad AMD machine. > > [614439.132228] [] ? btrfs_set_acl+0x87/0x230 Could you tell us what line of the source code that is? This shoul

Re: Updated performance results

2009-09-18 Thread Chris Mason
On Thu, Sep 17, 2009 at 05:04:11PM -0500, Steven Pratt wrote: > Chris Mason wrote: > >On Thu, Sep 17, 2009 at 04:17:14PM -0400, Chris Mason wrote: > >>[ crashes on runs involving unmounts ] > >> > >>The run is still going here, but it has survived longer than before. > >>I'm trying with Yan Zheng's

Kernel oops with 2.6.31 in btrfs_set_acl

2009-09-18 Thread Elladan
Hi, I got an oops this morning with btrfs on the Ubuntu 2.6.31 kernel. I mounted with compress and thread_pool=4. This is on a 64 bit quad AMD machine. Sep 18 04:00:07 caper kernel: [614439.131866] BUG: unable to handle kernel NULL pointer dereference at 0004 Sep 18 04:00:07 caper

[PATCH] btrfsctl: add snapshot/subvolume destroy ioctl

2009-09-18 Thread Yan, Zheng
resend Aaron Straus's patch Signed-off-by: Yan Zheng --- diff --git a/btrfsctl.c b/btrfsctl.c index b323818..66c4e89 100644 --- a/btrfsctl.c +++ b/btrfsctl.c @@ -46,7 +46,7 @@ static inline int ioctl(int fd, int define, void *arg) { return 0; } static void print_usage(void) { printf("

[PATCH] btrfsck: check root back/forward references

2009-09-18 Thread Yan, Zheng
This patch adds semantic checks for links to snapshot/subvolume and root back/forward references. Signed-off-by: Yan Zheng --- diff -urp btrfs-progs-unstable/btrfsck.c btrfs-progs-1/btrfsck.c --- btrfs-progs-unstable/btrfsck.c 2009-06-12 21:33:43.467764155 +0800 +++ btrfs-progs-1/btrfsck.c

[PATCH 4/4] add snapshot/subvolume destroy ioctl

2009-09-18 Thread Yan, Zheng
This patch adds snapshot/subvolume destroy ioctl. Subvolume that isn't being used and doesn't contains links to other subvolumes can be destroyed. Signed-off-by: Yan Zheng --- diff -urp 4/fs/btrfs/ctree.h 5/fs/btrfs/ctree.h --- 4/fs/btrfs/ctree.h 2009-09-18 15:48:21.807350311 +0800 +++ 5/fs/btr

[PATCH 3/4] change how subvolumes are organized

2009-09-18 Thread Yan, Zheng
btrfs allows subvolumes and snapshots anywhere in the directory tree. If we snapshot a subvolume that contains a link to other subvolume called subvolA, subvolA can be accessed through both the original subvolume and the snapshot. This is similar to creating hard link to directory, and has the very

[PATCH 2/4] do not reuse objectid of deleted snapshot/subvol

2009-09-18 Thread Yan, Zheng
The new back reference format does not allow reusing objectid of deleted snapshot/subvol. So we use ++highest_objectid to allocate objectid for new snapshot/subvol. Now we use ++highest_objectid to allocate objectid for both new inode and new snapshot/subvolume, so this patch removes 'find hole' c

[PATCH 1/4] speed up snapshot dropping

2009-09-18 Thread Yan, Zheng
This patch contains two changes to avoid unnecessary tree block reads during snapshot dropping. First, check tree block's reference count and flags before reading the tree block. if reference count > 1 and there is no need to update backrefs, we can avoid reading the tree block. Second, save when s