Re: reserving an IOCTL number; other details

2010-09-12 Thread David Nicol
this I can release, the user-facing API. diff --git a/man/btrfsctl.8.in b/man/btrfsctl.8.in index c2d4488..94403a4 100644 --- a/man/btrfsctl.8.in +++ b/man/btrfsctl.8.in @@ -35,6 +35,10 @@ Scans all devices present in the system for btrfs filesystem. .TP \fB\-c\fR Forces a filesystem sync. +.T

reserving an IOCTL number; other details

2010-09-12 Thread David Nicol
I have written and am currently testing a patch that provides a new ioctl that waits for snapshot deletion to finish before returning; The work is being sponsored, and I can't distribute it until the sponsorship details are more solid, but I'd like to reserve ioctl #21 for this purpose (the next on

Re: [PATCH] Btrfs: Remove useless condition

2010-09-12 Thread Mike Fedyk
On Sun, Sep 12, 2010 at 6:56 AM, Jaswinder Singh Rajput wrote: > Hello, > > On Sun, Sep 12, 2010 at 5:59 PM, Johannes Weiner wrote: >> On Sun, Sep 12, 2010 at 04:32:20PM +0530, Jaswinder Singh Rajput wrote: >>> >>> if (ret) is useless as it will be never NULL as in previous statement >>> we are s

Re: [PATCH] Btrfs: Remove useless condition

2010-09-12 Thread Jaswinder Singh Rajput
Hello, On Sun, Sep 12, 2010 at 5:59 PM, Johannes Weiner wrote: > On Sun, Sep 12, 2010 at 04:32:20PM +0530, Jaswinder Singh Rajput wrote: >> >> if (ret) is useless as it will be never NULL as in previous statement >> we are setting ret = prev for !ret > > If there is no match and no extent below t

Re: [GIT PULL] Btrfs updates

2010-09-12 Thread Felipe Contreras
On Thu, May 27, 2010 at 6:15 PM, Chris Mason wrote: >    Btrfs: Fix block generation verification race (+1/-1) This seems to cause a hang when there are "parent transid verify failed" errors. Somebody on #btrfs told me to revert it, and at least the system doesn't hang any more. -- Felipe Cont

Re: [PATCH] Btrfs: Remove useless condition

2010-09-12 Thread Johannes Weiner
On Sun, Sep 12, 2010 at 04:32:20PM +0530, Jaswinder Singh Rajput wrote: > > if (ret) is useless as it will be never NULL as in previous statement > we are setting ret = prev for !ret If there is no match and no extent below the given file offset, `prev' will be NULL as well, no? So the check is

[PATCH] Btrfs: Remove useless condition

2010-09-12 Thread Jaswinder Singh Rajput
if (ret) is useless as it will be never NULL as in previous statement we are setting ret = prev for !ret Signed-off-by: Jaswinder Singh Rajput Cc: Chris Mason --- fs/btrfs/ordered-data.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/fs/btrfs/ordered-data.c b/fs/btr

Re: [PATCH] fs/btrfs/ordered-data.c: fixed compiler warnings for using uninitialized variable

2010-09-12 Thread Felipe Contreras
On Fri, Sep 10, 2010 at 5:42 PM, Frank Morales II wrote: > >From 1c304defc543738f82ccb18fe10b558dd2098d74 Mon Sep 17 00:00:00 2001 > From: Frank Morales II > Date: Fri, 10 Sep 2010 07:34:23 -0700 > Subject: [PATCH] fs/btrfs/ordered-data.c: fixed compiler warnings for using > uninitialized variab