[PATCH] btrfs: check NULL or not

2011-01-04 Thread Tsutomu Itoh
Should check if functions returns NULL or not. Signed-off-by: Tsutomu Itoh --- fs/btrfs/ctree.c |6 ++ fs/btrfs/disk-io.c |8 fs/btrfs/extent_io.c |2 ++ 3 files changed, 16 insertions(+), 0 deletions(-) diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c index 9ac17

Re: [PATCH v2 1/5] add metadata_incore ioctl in vfs

2011-01-04 Thread Shaohua Li
On Tue, 2011-01-04 at 17:40 +0800, Arnd Bergmann wrote: > On Tuesday 04 January 2011 06:40:32 Shaohua Li wrote: > > > +static int ioctl_metadata_incore(struct file *filp, void __user *argp) > > +{ > > + struct super_block *sb = filp->f_path.dentry->d_inode->i_sb; > > + struct metadata_

Re: [PATCH v2 3/5]add metadata_readahead ioctl in vfs

2011-01-04 Thread Shaohua Li
On Tue, 2011-01-04 at 17:51 +0800, Arnd Bergmann wrote: > On Tuesday 04 January 2011 06:40:37 Shaohua Li wrote: > > /* > > * When you add any new common ioctls to the switches above and below > > * please update compat_sys_ioctl() too. > > @@ -664,6 +682,9 @@ int do_vfs_ioctl(struct file *filp

Re: [PATCH v2 0/5] add new ioctls to do metadata readahead in btrfs

2011-01-04 Thread Shaohua Li
On Wed, 2011-01-05 at 00:14 +0800, Jeff Moyer wrote: > Shaohua Li writes: > > > Hi, > > We have file readahead to do asyn file read, but has no metadata > > readahead. For a list of files, their metadata is stored in fragmented > > disk space and metadata read is a sync operation, which impacts

Re: Odd mkbtrfs behavior inside of chroot

2011-01-04 Thread J G
You're little trick with touching a blank /proc/mounts works, FWIW. You're "--force" patch works even better however ;) Thanks! .:Justin:. --- On Sun, 1/2/11, Goffredo Baroncelli wrote: > From: Goffredo Baroncelli > Subject: Re: Odd mkbtrfs behavior inside of chroot > To: "J G" > Cc: linux-

Re: Odd mkbtrfs behavior inside of chroot

2011-01-04 Thread J G
Binding /sys proved futile. .:Justin:. --- On Sun, 1/2/11, Jérôme Poulin wrote: > From: Jérôme Poulin > Subject: Re: Odd mkbtrfs behavior inside of chroot > To: "J G" > Cc: "linux-btrfs@vger.kernel.org" > Date: Sunday, January 2, 2011, 1:06 PM > Did you try using -o bind on /proc > and /sys

Re: [PATCH v2 0/5] add new ioctls to do metadata readahead in btrfs

2011-01-04 Thread Jeff Moyer
Shaohua Li writes: > Hi, > We have file readahead to do asyn file read, but has no metadata > readahead. For a list of files, their metadata is stored in fragmented > disk space and metadata read is a sync operation, which impacts the > efficiency of readahead much. The patches try to add meata

Re: [PATCH v2 3/5]add metadata_readahead ioctl in vfs

2011-01-04 Thread Arnd Bergmann
On Tuesday 04 January 2011 06:40:37 Shaohua Li wrote: > /* > * When you add any new common ioctls to the switches above and below > * please update compat_sys_ioctl() too. > @@ -664,6 +682,9 @@ int do_vfs_ioctl(struct file *filp, unsi > case FIMETADATA_INCORE: > return

Re: [PATCH v2 1/5] add metadata_incore ioctl in vfs

2011-01-04 Thread Arnd Bergmann
On Tuesday 04 January 2011 06:40:32 Shaohua Li wrote: > +static int ioctl_metadata_incore(struct file *filp, void __user *argp) > +{ > + struct super_block *sb = filp->f_path.dentry->d_inode->i_sb; > + struct metadata_incore_args args; > + struct metadata_incore_ent ent; > +