[PATCH] Btrfs: check return value of kmalloc()

2011-04-18 Thread Tsutomu Itoh
The check on the return value of kmalloc() in inode.c is added. Signed-off-by: Tsutomu Itoh --- fs/btrfs/inode.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index a4157cf..c718d27 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inod

[PATCH] Btrfs: cleanup error handling in inode.c

2011-04-18 Thread Tsutomu Itoh
The error processing of several places is changed like setting the error number only at the error. Signed-off-by: Tsutomu Itoh --- fs/btrfs/inode.c | 15 +-- 1 files changed, 9 insertions(+), 6 deletions(-) diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index a4157cf..e8e3a18 10

Fwd: module/kernel crash while trying to delete missing device/balance

2011-04-18 Thread brandon lansing
Hello, Distro: Ubuntu 10.10 Kernel: Linux 2.6.35-28-generic #50-Ubuntu SMP Fri Mar 18 18:42:20 UTC 2011 x86_64 GNU/Linux Btrfs tools version: Btrfs Btrfs v0.19 I currently have 2 X 500GB hard drives in 'raid1' mode with about 400GB used.  Recently one of the hard drives crashed (but I have a back

[PATCH 1/2] tracing: add __print_symbolic_u64 to avoid warnings on 32bit machine

2011-04-18 Thread liubo
Filesystem, like Btrfs, has some "ULL" macros, and when these macros are passed to tracepoints'__print_symbolic(), there will be 64->32 truncate WARNINGS during compiling on 32bit box. Signed-off-by: Liu Bo --- include/linux/ftrace_event.h | 12 include/trace/ftrace.h | 1

Re: [PATCH 1/2] Btrfs: allocate extent state and check the result properly

2011-04-18 Thread Xiao Guangrong
On 04/12/2011 04:14 PM, Xiao Guangrong wrote: > It doesn't allocate extent_state and check the result properly: > - in set_extent_bit, it doesn't allocate extent_state if the path is not > allowed wait > > - in clear_extent_bit, it doesn't check the result after atomic-ly allocate, > we trigge

[PATCH 2/2] tracing: update btrfs's tracepoints to use u64 interface

2011-04-18 Thread liubo
To avoid 64->32 truncating WARNING, update btrfs's tracepoints. Signed-off-by: Liu Bo --- include/trace/events/btrfs.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/trace/events/btrfs.h b/include/trace/events/btrfs.h index f445cff..4114129 100644 --- a/incl

Re: [PATCH] Trace: add __print_symbolic_u64 to avoid warnings on 32bit machine

2011-04-18 Thread liubo
On 04/19/2011 02:11 AM, Steven Rostedt wrote: > On Wed, 2011-04-06 at 17:18 +0800, liubo wrote: >> Btrfs has some "ULL" macros, and when these macros are passed to tracepoints' >> __print_symbolic(), there will be 64->32 truncate WARNINGS during compiling >> on 32bit box. >> >> Signed-off-by: Liu B

writes got stuck

2011-04-18 Thread Cheng Shao
Hi there, I'm periodically having issues with btrfs running in a Ubuntu VM using VirtualBox. After the VM has been running for a while (a couple days), any write operation seems getting stuck. The read seems totally fine. I tried a simple dd of a 4M file and it got stuck after writing 131K worth o

Re: resize ate my root node

2011-04-18 Thread Peter Stuge
Chris Mason wrote: > > > Which tool and which version of the tool did you use to delete the > > > partition? > > > > fdisk from util-linux-2.18 > > Straight from util-linux, or with distro patches? Yes a few Gentoo patches, but nothing that seems relevant: epatch "${FILESDIR}"/${P}-ncursesw.pat

Re: resize ate my root node

2011-04-18 Thread Peter Stuge
Sorry for not following up on this until now. :( I've been busy and have been using a backup. But I'm still very interested in restoring the btrfs and finding this bug! Let me know if I should refresh any details. Chris Mason wrote: > > In any case changing the partition table shouldn't affect th

[PATCH] Btrfs: free bitmaps properly when evicting the cache

2011-04-18 Thread Josef Bacik
If our space cache is wrong, we do the right thing and free up everything that we loaded, however we don't reset the total_bitmaps counter or the thresholds or anything. So in btrfs_remove_free_space_cache make sure to call free_bitmap() if it's a bitmap, this will keep us from panicing when we ch

Re: [PATCH] Trace: add __print_symbolic_u64 to avoid warnings on 32bit machine

2011-04-18 Thread Steven Rostedt
On Wed, 2011-04-06 at 17:18 +0800, liubo wrote: > Btrfs has some "ULL" macros, and when these macros are passed to tracepoints' > __print_symbolic(), there will be 64->32 truncate WARNINGS during compiling > on 32bit box. > > Signed-off-by: Liu Bo > --- > include/linux/ftrace_event.h | 12

RE: [PATCH] xen: cleancache shim to Xen Transcendent Memory

2011-04-18 Thread Ian Campbell
On Mon, 2011-04-18 at 07:12 -0700, Dan Magenheimer wrote: > > From: Ian Campbell [mailto:ian.campb...@eu.citrix.com] > > > > > > > > On Thu, 2011-04-14 at 14:20 -0700, Dan Magenheimer wrote: > > > > > > > > There's no need to build this into a kernel which doesn't have > > > > cleancache (or one of

Re: Btrfs Partition out of free space - no mount possible

2011-04-18 Thread Josef Bacik
On 04/18/2011 03:57 AM, c.mo...@web.de wrote: Hello! My Btrfs partition (/home) is out of free space. The partition is a logical drive within a LVM configuration. I've already extended the LVM logical volume. However, it's impossible to mount the partition from a live CD system (SystemRescue

Re: [RFC] Add a new file op for fsync to give fs's more control

2011-04-18 Thread Chris Mason
Excerpts from liubo's message of 2011-04-18 02:49:51 -0400: > On 04/16/2011 03:32 AM, Josef Bacik wrote: > > On 04/15/2011 03:24 PM, Christoph Hellwig wrote: > >> Sorry, but this is too ugly to live. If the reason for this really is > >> good enough we'll just need to push the filemap_write_and_wa

[GIT PULL] Btrfs updates

2011-04-18 Thread Chris Mason
Hi everyone, The master branch of the btrfs unstable repo: git://git.kernel.org/pub/scm/linux/kernel/git/mason/btrfs-unstable.git master Has a nice pile of btrfs fixes. Josef tackled a variety of DIO problems including latencies and crc errors. He also fixed a crash in the mount -o free_space_

RE: [PATCH] xen: cleancache shim to Xen Transcendent Memory

2011-04-18 Thread Dan Magenheimer
> From: Ian Campbell [mailto:ian.campb...@eu.citrix.com] > > > > > > On Thu, 2011-04-14 at 14:20 -0700, Dan Magenheimer wrote: > > > > > > There's no need to build this into a kernel which doesn't have > > > cleancache (or one of the other frontends), is there? I think there > > > should be a Kconf

Re: [RFC] Add a new file op for fsync to give fs's more control

2011-04-18 Thread Josef Bacik
On 04/18/2011 02:49 AM, liubo wrote: On 04/16/2011 03:32 AM, Josef Bacik wrote: On 04/15/2011 03:24 PM, Christoph Hellwig wrote: Sorry, but this is too ugly to live. If the reason for this really is good enough we'll just need to push the filemap_write_and_wait_range and i_mutex locking into e

Re: [PATCH 1/2] E2fsprogs: use the generic inode flags

2011-04-18 Thread Christoph Hellwig
On Mon, Apr 18, 2011 at 07:15:41PM +0800, Coly Li wrote: > It seems chattr and lsattr is not an ext[234] only utilities any more... They haven't been for a long time. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org Mo

Re: [PATCH 1/2] E2fsprogs: use the generic inode flags

2011-04-18 Thread Coly Li
On 2011年04月18日 17:01, liubo Wrote: > On 04/18/2011 04:41 PM, Coly Li wrote: >> On 2011年04月18日 15:37, liubo Wrote: >>> Signed-off-by: Liu Bo >>> --- >>> debugfs/htree.c|2 +- >>> e2fsck/pass1.c | 22 +++--- >>> e2fsck/pass2.c |2 +- >>> e2fsck/pass

Re: [PATCH 1/2] E2fsprogs: use the generic inode flags

2011-04-18 Thread liubo
On 04/18/2011 04:41 PM, Coly Li wrote: > On 2011年04月18日 15:37, liubo Wrote: >> Signed-off-by: Liu Bo >> --- >> debugfs/htree.c|2 +- >> e2fsck/pass1.c | 22 +++--- >> e2fsck/pass2.c |2 +- >> e2fsck/pass4.c |2 +- >> e2fsck/rehash.c

Re: [PATCH 1/2] E2fsprogs: use the generic inode flags

2011-04-18 Thread Coly Li
On 2011年04月18日 15:37, liubo Wrote: > > Signed-off-by: Liu Bo > --- > debugfs/htree.c|2 +- > e2fsck/pass1.c | 22 +++--- > e2fsck/pass2.c |2 +- > e2fsck/pass4.c |2 +- > e2fsck/rehash.c|4 ++-- > ext2ed/inode_com.c |

Btrfs Partition out of free space - no mount possible

2011-04-18 Thread c . monty
Hello! My Btrfs partition (/home) is out of free space. The partition is a logical drive within a LVM configuration. I've already extended the LVM logical volume. However, it's impossible to mount the partition from a live CD system (SystemRescue CD). The error in dmesg is: BTRFS: inode 8443 st

[PATCH 2/2] E2fsprogs: add compress and cow support in chattr, lsattr

2011-04-18 Thread liubo
Modify command 'chattr' and 'lsattr' to support compress and cow. - use 'C' to indicate NOCOW attribute. - still use 'c' to indicate compress attribute. Also update the man doc. Signed-off-by: Liu Bo --- lib/e2p/pf.c |1 + lib/ext2fs/ext2_fs.h |1 + misc/chattr.1.in | 15 +

[PATCH 1/2] E2fsprogs: use the generic inode flags

2011-04-18 Thread liubo
Signed-off-by: Liu Bo --- debugfs/htree.c|2 +- e2fsck/pass1.c | 22 +++--- e2fsck/pass2.c |2 +- e2fsck/pass4.c |2 +- e2fsck/rehash.c|4 ++-- ext2ed/inode_com.c | 14 +++--- lib/e2p/fgetflags.c|6 ++