Re: [PATCH] xfstests 255: add a seek_data/seek_hole tester

2011-06-29 Thread Christoph Hellwig
On Wed, Jun 29, 2011 at 04:53:07PM +1000, Dave Chinner wrote: > On Tue, Jun 28, 2011 at 11:33:19AM -0400, Josef Bacik wrote: > > This is a test to make sure seek_data/seek_hole is acting like it does on > > Solaris. It will check to see if the fs supports finding a hole or not and > > will > > ad

Re: Mis-Design of Btrfs?

2011-06-29 Thread Ric Wheeler
On 06/27/2011 07:46 AM, NeilBrown wrote: On Thu, 23 Jun 2011 12:53:37 +0200 Nico Schottelius wrote: Good morning devs, I'm wondering whether the raid- and volume-management-builtin of btrfs is actually a sane idea or not. Currently we do have md/device-mapper support for raid already, btrfs

Re: [PATCH] xfstests 255: add a seek_data/seek_hole tester

2011-06-29 Thread Pádraig Brady
On 29/06/11 08:40, Christoph Hellwig wrote: > On Wed, Jun 29, 2011 at 04:53:07PM +1000, Dave Chinner wrote: >> On Tue, Jun 28, 2011 at 11:33:19AM -0400, Josef Bacik wrote: >>> This is a test to make sure seek_data/seek_hole is acting like it does on >>> Solaris. It will check to see if the fs supp

Re: [PATCH v8 2/8] btrfs: Cancel filesystem balance

2011-06-29 Thread David Sterba
On Wed, Jun 29, 2011 at 02:00:20PM +0800, Li Zefan wrote: > Hugo Mills wrote: > > @@ -2149,6 +2150,10 @@ int btrfs_balance(struct btrfs_root *dev_root) > >bal_info->completed, bal_info->expected); > > } > > ret = 0; > > + if (bal_info->cancel_pending) { > > +

Re: Mis-Design of Btrfs?

2011-06-29 Thread A. James Lewis
On Wed, 2011-06-29 at 10:29 +0100, Ric Wheeler wrote: > On 06/27/2011 07:46 AM, NeilBrown wrote: > > On Thu, 23 Jun 2011 12:53:37 +0200 Nico Schottelius > > wrote: > > > >> Good morning devs, > >> > >> I'm wondering whether the raid- and volume-management-builtin of btrfs is > >> actually a sane

Re: [PATCH] xfstests 255: add a seek_data/seek_hole tester

2011-06-29 Thread Josef Bacik
On 06/29/2011 02:53 AM, Dave Chinner wrote: On Tue, Jun 28, 2011 at 11:33:19AM -0400, Josef Bacik wrote: This is a test to make sure seek_data/seek_hole is acting like it does on Solaris. It will check to see if the fs supports finding a hole or not and will adjust as necessary. So I just loo

subvolumes missing from "btrfs subvolume list" output

2011-06-29 Thread Stephane Chazelas
Hiya, I've got a btrfs FS with 84 subvolumes in it (some created with "btrfs sub create", some with "btrfs sub snap" of the other ones). There's no nesting of subvolumes at all (all direct children of the root subvolume). The "btrfs subvolume list" is only showing 80 subvolumes. The 4 missing one

Re: subvolumes missing from "btrfs subvolume list" output

2011-06-29 Thread Stephane Chazelas
2011-06-29 15:37:47 +0100, Stephane Chazelas: [...] > I found > http://thread.gmane.org/gmane.comp.file-systems.btrfs/8123/focus=8208 > > which looks like the same issue, with Li Zefan saying he had a > fix, but I couldn't find any mention that it was actually fixed. > > Has anybody got any updat

[btrfs-transacti] & btrfs-endio-wri] - WAS: Re: [btrfs-delalloc-]

2011-06-29 Thread Proskurin Kirill
On 06/27/2011 05:21 PM, Hubert Kario wrote: On Monday 27 of June 2011 11:04:06 Proskurin Kirill wrote: Hello all. What we have: SL6 - kernel 2.6.32-131.2.1.el6.x86_64 btrfs on mdadm RAID5 with 8 HDD - 27T partition. I see this at top: 1182 root 20 0 000 R 100.0 0.0 16:39.7

Re: [btrfs-transacti] & btrfs-endio-wri] - WAS: Re: [btrfs-delalloc-]

2011-06-29 Thread Josef Bacik
On 06/29/2011 11:37 AM, Proskurin Kirill wrote: > On 06/27/2011 05:21 PM, Hubert Kario wrote: >> On Monday 27 of June 2011 11:04:06 Proskurin Kirill wrote: >>> Hello all. >>> >>> What we have: >>> SL6 - kernel 2.6.32-131.2.1.el6.x86_64 >>> btrfs on mdadm RAID5 with 8 HDD - 27T partition. >>> >>> I

Re: subvolumes missing from "btrfs subvolume list" output

2011-06-29 Thread Josef Bacik
On 06/29/2011 11:00 AM, Stephane Chazelas wrote: > 2011-06-29 15:37:47 +0100, Stephane Chazelas: > [...] >> I found >> http://thread.gmane.org/gmane.comp.file-systems.btrfs/8123/focus=8208 >> >> which looks like the same issue, with Li Zefan saying he had a >> fix, but I couldn't find any mention t

[PATCH v3 0/6] btrfs: generic readeahead interface

2011-06-29 Thread Arne Jansen
This series introduces a generic readahead interface for btrfs trees. The intention is to use it to speed up scrub in a first run, but balance is another hot candidate. In general, every tree walk could be accompanied by a readahead. Deletion of large files comes to mind, where the fetching of the

[PATCH v3 4/6] btrfs: hooks for readahead

2011-06-29 Thread Arne Jansen
This adds the hooks needed for readahead. In the readpage_end_io_hook, the extent state is checked for the EXTENT_READAHEAD flag. Only in this case the readahead hook is called, to keep the impact on non-ra as low as possible. Additionally, a hook for a failed IO is added, otherwise readahead would

[PATCH v3 2/6] btrfs: state information for readahead

2011-06-29 Thread Arne Jansen
Add state information for readahead to btrfs_fs_info and btrfs_device Changes v2: - don't wait in radix_trees - add own set of workers for readahead Signed-off-by: Arne Jansen --- fs/btrfs/ctree.h |5 + fs/btrfs/disk-io.c | 11 +++ fs/btrfs/volumes.c |8 fs/bt

[PATCH v3 3/6] btrfs: initial readahead code and prototypes

2011-06-29 Thread Arne Jansen
This is the implementation for the generic read ahead framework. To trigger a readahead, btrfs_reada_add must be called. It will start a read ahead for the given range [start, end) on tree root. The returned handle can either be used to wait on the readahead to finish (btrfs_reada_wait), or to sen

[PATCH v3 6/6] btrfs: use readahead API for scrub

2011-06-29 Thread Arne Jansen
Scrub uses a simple tree-enumeration to bring the relevant portions of the extent- and csum-tree into the page cache before starting the scrub-I/O. This is now replaced by using the new readahead-API. During readahead the scrub is being accounted as paused, so it won't hold off transaction commits.

[PATCH v3 5/6] btrfs: test ioctl for readahead

2011-06-29 Thread Arne Jansen
This ioctl is added to trigger a readahead from user mode. It implements a readahead using the new interface and also a traditional tree walk. This way it's possible to measure the two side by side. Signed-off-by: Arne Jansen --- fs/btrfs/ioctl.c | 93 ++

[PATCH v3 1/6] btrfs: add READAHEAD extent buffer flag

2011-06-29 Thread Arne Jansen
Add a READAHEAD extent buffer flag. Add a function to trigger a read with this flag set. Changes v2: - use extent buffer flags instead of extent state flags Signed-off-by: Arne Jansen --- fs/btrfs/disk-io.c | 32 fs/btrfs/disk-io.h |2 ++ fs/btrfs/ext

Re: subvolumes missing from "btrfs subvolume list" output

2011-06-29 Thread Hugo Mills
On Wed, Jun 29, 2011 at 12:16:06PM -0400, Josef Bacik wrote: > On 06/29/2011 11:00 AM, Stephane Chazelas wrote: > > 2011-06-29 15:37:47 +0100, Stephane Chazelas: > > [...] > >> I found > >> http://thread.gmane.org/gmane.comp.file-systems.btrfs/8123/focus=8208 > >> > >> which looks like the same iss

Re: subvolumes missing from "btrfs subvolume list" output

2011-06-29 Thread Hugo Mills
On Wed, Jun 29, 2011 at 05:47:41PM +0100, Hugo Mills wrote: > (*) The limited cases where both behaviours return the same set of > keys are: > > (i_0, 0, 0) to (i_1, -1UL, -1UL) I clearly meant (i_1, 255, -1UL) here... > (i, t_0, 0) to (i, t_1, -1UL) > (i, t, o_0) to (i, t, o_1) -- === Hugo M

Re: [PATCH] xfstests 255: add a seek_data/seek_hole tester

2011-06-29 Thread Sunil Mushran
On 06/29/2011 12:40 AM, Christoph Hellwig wrote: On Wed, Jun 29, 2011 at 04:53:07PM +1000, Dave Chinner wrote: On Tue, Jun 28, 2011 at 11:33:19AM -0400, Josef Bacik wrote: This is a test to make sure seek_data/seek_hole is acting like it does on Solaris. It will check to see if the fs supports

Re: [PATCH] xfstests 255: add a seek_data/seek_hole tester

2011-06-29 Thread Sunil Mushran
On 06/29/2011 03:42 AM, Pádraig Brady wrote: There is the argument, that if this interface can distinguish these dirty unwritten extents, then why can't the fiemap interface too? The advantage of the fiemap interface is that it can distinguish empty extents vs holes. Empty extents will become inc

Re: [PATCH] xfstests 255: add a seek_data/seek_hole tester

2011-06-29 Thread Christoph Hellwig
On Wed, Jun 29, 2011 at 10:29:02AM -0700, Sunil Mushran wrote: > I'm not too sure about that. Atleast not enabled by default. Most users > use cp to backup data. Not empty space. In this case, this empty extent > may not even be de-dupable. > > Frankly I'd be happier of cp started to exploited fal

Re: [PATCH] xfstests 255: add a seek_data/seek_hole tester

2011-06-29 Thread Sunil Mushran
On 06/29/2011 10:36 AM, Christoph Hellwig wrote: On Wed, Jun 29, 2011 at 10:29:02AM -0700, Sunil Mushran wrote: I'm not too sure about that. Atleast not enabled by default. Most users use cp to backup data. Not empty space. In this case, this empty extent may not even be de-dupable. Frankly I'd

Re: [PATCH] xfstests 255: add a seek_data/seek_hole tester

2011-06-29 Thread Josef Bacik
On 06/29/2011 01:10 PM, Sunil Mushran wrote: > On 06/29/2011 12:40 AM, Christoph Hellwig wrote: >> On Wed, Jun 29, 2011 at 04:53:07PM +1000, Dave Chinner wrote: >>> On Tue, Jun 28, 2011 at 11:33:19AM -0400, Josef Bacik wrote: This is a test to make sure seek_data/seek_hole is acting like it >>

[PATCH] remove unused variables

2011-06-29 Thread Hubert Kario
fixes compilation warnings with gcc 4.6.0 20110429 Signed-off-by: Hubert Kario --- mkfs.c|3 --- volumes.c |2 -- 2 files changed, 0 insertions(+), 5 deletions(-) diff --git a/mkfs.c b/mkfs.c index 1b5ef06..d40b2e8 100644 --- a/mkfs.c +++ b/mkfs.c @@ -1060,7 +1060,6 @@ static int ma

[PATCH] initialize all fields of commands[] struct

2011-06-29 Thread Hubert Kario
some help messages don't use advanced help message (shown when invoked as `btrfs command subcommand --help`) initialize them to NULL (meaning "use regular help message"). Signed-off-by: Hubert Kario --- this patch is for the branch integration-20110626 in http://git.darksatanic.net/repo/btrfs-pr

Re: [PATCH v3 1/6] btrfs: add READAHEAD extent buffer flag

2011-06-29 Thread Josef Bacik
On 06/29/2011 12:32 PM, Arne Jansen wrote: > Add a READAHEAD extent buffer flag. > Add a function to trigger a read with this flag set. > > Changes v2: > - use extent buffer flags instead of extent state flags > > Signed-off-by: Arne Jansen > --- > fs/btrfs/disk-io.c | 32 +

Re: [PATCH v3 1/6] btrfs: add READAHEAD extent buffer flag

2011-06-29 Thread Arne Jansen
On 29.06.2011 20:13, Josef Bacik wrote: On 06/29/2011 12:32 PM, Arne Jansen wrote: Add a READAHEAD extent buffer flag. Add a function to trigger a read with this flag set. Changes v2: - use extent buffer flags instead of extent state flags Signed-off-by: Arne Jansen --- fs/btrfs/disk-io.c

Re: [PATCH v3 1/6] btrfs: add READAHEAD extent buffer flag

2011-06-29 Thread Arne Jansen
On 29.06.2011 20:24, Arne Jansen wrote: On 29.06.2011 20:13, Josef Bacik wrote: On 06/29/2011 12:32 PM, Arne Jansen wrote: Add a READAHEAD extent buffer flag. Add a function to trigger a read with this flag set. Changes v2: - use extent buffer flags instead of extent state flags Signed-off-by

[PATCH v4 0/6] btrfs: generic readeahead interface

2011-06-29 Thread Arne Jansen
This series introduces a generic readahead interface for btrfs trees. The intention is to use it to speed up scrub in a first run, but balance is another hot candidate. In general, every tree walk could be accompanied by a readahead. Deletion of large files comes to mind, where the fetching of the

[PATCH v4 7/7] btrfs: use readahead API for scrub

2011-06-29 Thread Arne Jansen
Scrub uses a simple tree-enumeration to bring the relevant portions of the extent- and csum-tree into the page cache before starting the scrub-I/O. This is now replaced by using the new readahead-API. During readahead the scrub is being accounted as paused, so it won't hold off transaction commits.

[PATCH v4 6/7] btrfs: test ioctl for readahead

2011-06-29 Thread Arne Jansen
This ioctl is added to trigger a readahead from user mode. It implements a readahead using the new interface and also a traditional tree walk. This way it's possible to measure the two side by side. Signed-off-by: Arne Jansen --- fs/btrfs/ioctl.c | 93 ++

[PATCH v4 1/7] btrfs: add an extra wait mode to read_extent_buffer_pages

2011-06-29 Thread Arne Jansen
read_extent_buffer_pages currently has two modes, either trigger a read without waiting for anything, or wait for the I/O to finish. The former also bails when it's unable to lock the page. This patch now adds an additional parameter to allow it to block on page lock, but don't wait for completion.

[PATCH v4 5/7] btrfs: hooks for readahead

2011-06-29 Thread Arne Jansen
This adds the hooks needed for readahead. In the readpage_end_io_hook, the extent state is checked for the EXTENT_READAHEAD flag. Only in this case the readahead hook is called, to keep the impact on non-ra as low as possible. Additionally, a hook for a failed IO is added, otherwise readahead would

[PATCH v4 4/7] btrfs: initial readahead code and prototypes

2011-06-29 Thread Arne Jansen
This is the implementation for the generic read ahead framework. To trigger a readahead, btrfs_reada_add must be called. It will start a read ahead for the given range [start, end) on tree root. The returned handle can either be used to wait on the readahead to finish (btrfs_reada_wait), or to sen

[PATCH v4 3/7] btrfs: state information for readahead

2011-06-29 Thread Arne Jansen
Add state information for readahead to btrfs_fs_info and btrfs_device Changes v2: - don't wait in radix_trees - add own set of workers for readahead Signed-off-by: Arne Jansen --- fs/btrfs/ctree.h |5 + fs/btrfs/disk-io.c | 11 +++ fs/btrfs/volumes.c |8 fs/bt

[PATCH v4 2/7] btrfs: add READAHEAD extent buffer flag

2011-06-29 Thread Arne Jansen
Add a READAHEAD extent buffer flag. Add a function to trigger a read with this flag set. Changes v2: - use extent buffer flags instead of extent state flags Signed-off-by: Arne Jansen --- fs/btrfs/disk-io.c | 32 fs/btrfs/disk-io.h |2 ++ fs/btrfs/ext

Re: subvolumes missing from "btrfs subvolume list" output

2011-06-29 Thread Goffredo Baroncelli
Hi Hugo On 06/29/2011 06:47 PM, Hugo Mills wrote: > On Wed, Jun 29, 2011 at 12:16:06PM -0400, Josef Bacik wrote: >> On 06/29/2011 11:00 AM, Stephane Chazelas wrote: >>> 2011-06-29 15:37:47 +0100, Stephane Chazelas: >>> [...] I found http://thread.gmane.org/gmane.comp.file-systems.btrfs/

Re: [PATCH v4 1/7] btrfs: add an extra wait mode to read_extent_buffer_pages

2011-06-29 Thread Josef Bacik
On 06/29/2011 04:10 PM, Arne Jansen wrote: > read_extent_buffer_pages currently has two modes, either trigger a read > without waiting for anything, or wait for the I/O to finish. The former > also bails when it's unable to lock the page. This patch now adds an > additional parameter to allow it to

Re: [PATCH v4 2/7] btrfs: add READAHEAD extent buffer flag

2011-06-29 Thread Josef Bacik
On 06/29/2011 04:10 PM, Arne Jansen wrote: > Add a READAHEAD extent buffer flag. > Add a function to trigger a read with this flag set. > > Changes v2: > - use extent buffer flags instead of extent state flags > > Signed-off-by: Arne Jansen > --- > fs/btrfs/disk-io.c | 32 +

Re: [PATCH v4 3/7] btrfs: state information for readahead

2011-06-29 Thread Josef Bacik
On 06/29/2011 04:10 PM, Arne Jansen wrote: > Add state information for readahead to btrfs_fs_info and btrfs_device > > Changes v2: > - don't wait in radix_trees > - add own set of workers for readahead > You can add Reviewed-by: Josef Bacik Thanks, Josef -- To unsubscribe from this list: s

Re: [PATCH] xfstests 255: add a seek_data/seek_hole tester

2011-06-29 Thread Pádraig Brady
On 29/06/11 18:29, Sunil Mushran wrote: > On 06/29/2011 03:42 AM, Pádraig Brady wrote: >> There is the argument, that if this interface can distinguish >> these dirty unwritten extents, then why can't the fiemap interface too? >> The advantage of the fiemap interface is that it can distinguish >> e

Re: [PATCH v4 4/7] btrfs: initial readahead code and prototypes

2011-06-29 Thread Josef Bacik
On 06/29/2011 04:10 PM, Arne Jansen wrote: > This is the implementation for the generic read ahead framework. > > To trigger a readahead, btrfs_reada_add must be called. It will start > a read ahead for the given range [start, end) on tree root. The returned > handle can either be used to wait on

Re: subvolumes missing from "btrfs subvolume list" output

2011-06-29 Thread Li Zefan
Stephane Chazelas wrote: > 2011-06-29 15:37:47 +0100, Stephane Chazelas: > [...] >> I found >> http://thread.gmane.org/gmane.comp.file-systems.btrfs/8123/focus=8208 >> >> which looks like the same issue, with Li Zefan saying he had a >> fix, but I couldn't find any mention that it was actually fixe

Re: please review snapshot corruption path with delayed metadata insertion

2011-06-29 Thread Miao Xie
Hi, Itoh-san Could you test the following patch to check whether it can fix the bug or not? I have tested it on my x86_64 machine by your test script for two days, it worked well. Thanks Miao Subject: [PATCH] btrfs: fix oops when doing space balance When doing space balance, the following oops

btrfs lock-up on copying files

2011-06-29 Thread Roman Mamedov
Hello, I was copying a set of files to a btrfs filesystem, and the copy process locked-up with the following messages in dmesg. The kernel version is 2.6.39.1; the filesystem was recently resized from 3 to 4TB (if that matters). It is mounted remotely via AoE but the remote host is up and no e

Re: please review snapshot corruption path with delayed metadata insertion

2011-06-29 Thread Tsutomu Itoh
(2011/06/30 15:32), Miao Xie wrote: > Hi, Itoh-san > > Could you test the following patch to check whether it can fix the bug or not? Sure. After running my test script by about a day, I will report on the result. Thanks, Tsutomu > I have tested it on my x86_64 machine by your test script for t