Re: [PATCH] xfstests 255: add a seek_data/seek_hole tester

2011-08-26 Thread Marco Stornelli
2011/8/26 Dave Chinner da...@fromorbit.com: On Thu, Aug 25, 2011 at 12:51:56AM -0600, Andreas Dilger wrote: On 2011-08-25, at 12:40 AM, Dave Chinner wrote: On Thu, Aug 25, 2011 at 02:06:32AM -0400, Christoph Hellwig wrote: On Tue, Jun 28, 2011 at 11:33:19AM -0400, Josef Bacik wrote: This

Re: BTRFS and power loss ~= corruption?

2011-08-26 Thread Arne Jansen
On 26.08.2011 01:01, Gregory Maxwell wrote: On Wed, Aug 24, 2011 at 9:11 AM, Berend Dekens bt...@cyberwizzard.nl wrote: [snip] I thought the idea of COW was that whatever happens, you can always mount in a semi-consistent state? [snip] It seems to me that if someone created a block

[PATCH] Btrfs: make some functions return void

2011-08-26 Thread Tsutomu Itoh
The type of some functions that return only 0 is changed to 'void'. In addition, the check on the return value in the caller of these functions becomes unnecessary. So, these check is removed. Signed-off-by: Tsutomu Itoh t-i...@jp.fujitsu.com --- fs/btrfs/async-thread.c | 17

Re: BTRFS and power loss ~= corruption?

2011-08-26 Thread Mike Fleetwood
On 26 August 2011 07:37, Arne Jansen sensi...@gmx.net wrote: On 26.08.2011 01:01, Gregory Maxwell wrote: On Wed, Aug 24, 2011 at 9:11 AM, Berend Dekens bt...@cyberwizzard.nl wrote: It seems to me that if someone created a block device which recorded all write operations a rather excellent

Re: BTRFS and power loss ~= corruption?

2011-08-26 Thread Arne Jansen
On 26.08.2011 09:48, Mike Fleetwood wrote: On 26.08.2011 01:01, Gregory Maxwell wrote: This article describes evaluating ext3, reiserfs and jfs using fault injection using a custom Linux block device driver. Model-Based Failure Analysis of Journaling File Systems

Re: bug#8061: Introduce SEEK_DATA/SEEK_HOLE to extent_scan module

2011-08-26 Thread Jeff Liu
Dear All, As the SEEK_HOLE/SEEK_DATA has been implemented on Btrfs in 3.1.0+ and Glibc, I have worked out a new version for your guys review. Changes: == extent_scan.[c|h]: 1. add a function pointer to struct extent_scan: /* Scan method. */ bool (*extent_scan) (struct extent_scan

don't fetch the inode size beforehand.

2011-08-26 Thread Jeff Liu
Hello, I think we don't need to fetch the inode size in advance. :-P. diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c index e7872e4..f8ad957 100644 --- a/fs/btrfs/file.c +++ b/fs/btrfs/file.c @@ -1698,7 +1698,7 @@ static int find_desired_extent(struct inode *inode, loff_t *offset, int origin)

Re: [PATCH] xfstests 255: add a seek_data/seek_hole tester

2011-08-26 Thread Zach Brown
Hole: a range of the file that contains no data or is made up entirely of  NULL (zero) data. Holes include preallocated ranges of files that have not had actual data written to them. No for me. A hole is made up of zero data? It's a strange definition for me. It's a very natural

autodegrag: WARNING: at fs/inode.c:1315 iput+0x20b/0x210()

2011-08-26 Thread Sergei Trofimovich
I used 3.1.0-rc2+ kernel for some weeks before without any dmesg warnings. I've decided to enable autodegrag feature for my btrfs / today and got warning in $SUBJ. It's an: static void iput_final(struct inode *inode) ... WARN_ON(inode-i_state I_NEW); Looks scary. Tried latest mainline

Re: WARNING in -rc3-00023-g14c62e7

2011-08-26 Thread Mitch Harder
On Thu, Aug 25, 2011 at 2:17 PM, Diego Calleja dieg...@gmail.com wrote: This is what I got in my dmesg...I have lots of these warnings, didn't notice it until now. [  235.705766] [ cut here ] [  235.705772] WARNING: at fs/inode.c:1309 iput+0x1ed/0x210() [  235.705773]

Re: WARNING in -rc3-00023-g14c62e7

2011-08-26 Thread Diego Calleja
On Viernes, 26 de Agosto de 2011 22:59:54 Mitch Harder escribió: Do you have autodefrag enabled? Yes -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html