RE: [PATCH] btrfs/ioctl.c: quiet sparse warnings

2011-09-23 Thread H Hartley Sweeten
On Friday, September 23, 2011 11:16 AM, Joe Perches wrote: > On Fri, 2011-09-23 at 11:07 -0700, H Hartley Sweeten wrote: >> Quiet the following sparse warnings: > [] >> diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c > [] >> @@ -2705,7 +2705,7 @@ long btrfs_ioctl_space_info(struct btrfs_root *root

Re: [PATCH] btrfs/extent_map.c: quiet sparse noise

2011-09-23 Thread Valdis . Kletnieks
On Thu, 22 Sep 2011 18:45:56 PDT, H Hartley Sweeten said: > Quiet the sparse noise: > > warning: symbol '__lookup_extent_mapping' was not declared. Should it be > static? Patch itself is correct, changelog is bad. You're not quieting sparse noise, you're making a declaration static because it d

[PATCH] btrfs/delayed-inode.c: quiet sparse noise

2011-09-23 Thread H Hartley Sweeten
Quiet the following sparse noise: warning: symbol 'btrfs_first_delayed_node' was not declared. Should it be static? warning: symbol 'btrfs_next_delayed_node' was not declared. Should it be static? warning: symbol 'btrfs_first_prepared_delayed_node' was not declared. Should it be static? warning:

[PATCH] btrfs/compression.c: quiet sparse noise

2011-09-23 Thread H Hartley Sweeten
Quiet the sparse warning: warning: symbol 'btrfs_compress_op' was not declared. Should it be static? Signed-off-by: H Hartley Sweeten Cc: Chris Mason --- diff --git a/fs/btrfs/compression.c b/fs/btrfs/compression.c index 8ec5d86..3e8c133 100644 --- a/fs/btrfs/compression.c +++ b/fs/btrfs/com

[PATCH] btrfs/free-space-cache.c: quiet sparse warnings

2011-09-23 Thread H Hartley Sweeten
Quiet the following sparse warnings: warning: symbol '__create_free_space_inode' was not declared. Should it be static? warning: symbol '__load_free_space_cache' was not declared. Should it be static? warning: symbol '__btrfs_write_out_cache' was not declared. Should it be static? warning: symbol

Re: [PATCH] btrfs/ioctl.c: quiet sparse warnings

2011-09-23 Thread Joe Perches
On Fri, 2011-09-23 at 11:07 -0700, H Hartley Sweeten wrote: > Quiet the following sparse warnings: [] > diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c [] > @@ -2705,7 +2705,7 @@ long btrfs_ioctl_space_info(struct btrfs_root *root, > void __user *arg) > up_read(&info->groups_sem); >

[PATCH] btrfs/ioctl.c: quiet sparse warnings

2011-09-23 Thread H Hartley Sweeten
Quiet the following sparse warnings: warning: cast removes address space of expression warning: incorrect type in assignment (different address spaces) expected struct btrfs_ioctl_space_info [noderef] *user_dest got struct btrfs_ioctl_space_info * warning: symbol 'btrfs_ioctl_space_info' was

Re: Btrfs bug with g38867a2 and a question

2011-09-23 Thread Mathieu Chouquet-Stringer
On Fri, Sep 23, 2011 at 11:34:40AM -0400, Josef Bacik wrote: > Yeah this is a different problem that's fixed upstream, so reboot into > your other newer kernel with -o clear_cache. Thanks, Ok I'm back in business now, thanks... Now I'll try to understand why my pc sometimes hangs doing write IOs

Re: Btrfs bug with g38867a2 and a question

2011-09-23 Thread Josef Bacik
On 09/23/2011 11:31 AM, Mathieu Chouquet-Stringer wrote: > On Fri, Sep 23, 2011 at 10:49:22AM -0400, Josef Bacik wrote: >> Ok I have no idea how this could happen. Can you mount -o clear_cache >> and see if it's just the cache that's bad? Thanks, > > Did that and got this (it's a never ending st

Re: Btrfs bug with g38867a2 and a question

2011-09-23 Thread Mathieu Chouquet-Stringer
On Fri, Sep 23, 2011 at 10:49:22AM -0400, Josef Bacik wrote: > Ok I have no idea how this could happen. Can you mount -o clear_cache > and see if it's just the cache that's bad? Thanks, Did that and got this (it's a never ending story, this is from a F16 alpha boot cd hence stack trace could be

Re: Btrfs bug with g38867a2 and a question

2011-09-23 Thread Josef Bacik
On 09/23/2011 08:55 AM, Mathieu Chouquet-Stringer wrote: > On Thu, Sep 22, 2011 at 10:32:13PM +0200, Mathieu Chouquet-Stringer wrote: >> On Thu, Sep 22, 2011 at 09:30:07PM +0200, Mathieu Chouquet-Stringer wrote: >>> On Thu, Sep 22, 2011 at 03:00:03PM -0400, Josef Bacik wrote: Oh wow sorry I se

[patch 2/2/4] mm: try to distribute dirty pages fairly across zones

2011-09-23 Thread Johannes Weiner
The maximum number of dirty pages that exist in the system at any time is determined by a number of pages considered dirtyable and a user-configured percentage of those, or an absolute number in bytes. This number of dirtyable pages is the sum of memory provided by all the zones in the system minu

[patch 1/2/4] mm: writeback: cleanups in preparation for per-zone dirty limits

2011-09-23 Thread Johannes Weiner
On Thu, Sep 22, 2011 at 10:52:42AM +0200, Johannes Weiner wrote: > On Wed, Sep 21, 2011 at 04:02:26PM -0700, Andrew Morton wrote: > > Should we rename determine_dirtyable_memory() to > > global_dirtyable_memory(), to get some sense of its relationship with > > zone_dirtyable_memory()? > > Sounds g

[patch 1/4 v2] mm: exclude reserved pages from dirtyable memory

2011-09-23 Thread Johannes Weiner
The amount of dirtyable pages should not include the full number of free pages: there is a number of reserved pages that the page allocator and kswapd always try to keep free. The closer (reclaimable pages - dirty pages) is to the number of reserved pages, the more likely it becomes for reclaim to

Re: [PATCH] xfstests: add new getdents test

2011-09-23 Thread Alex Elder
On Fri, 2011-09-23 at 16:03 +0300, Grazvydas Ignotas wrote: > On Thu, Sep 22, 2011 at 11:18 PM, Alex Elder wrote: > > On Mon, 2011-09-12 at 03:19 +0300, Grazvydas Ignotas wrote: > >> The test checks if no duplicate d_off values are returned and that > >> those values are seekable to the right inod

Re: Honest timeline for btrfsck

2011-09-23 Thread Erik Jensen
Chris, Now that you're back from vacation, I was wondering if you would be able to provide a revised estimate on how long this will take. Also, of the four parts, which will be necessary to correct a 'parent transid verify failed' error? Thank you for your time, --Erik On Thu, Aug 18, 2011 at 1:

Re: [PATCH] xfstests: add new getdents test

2011-09-23 Thread Grazvydas Ignotas
On Thu, Sep 22, 2011 at 11:18 PM, Alex Elder wrote: > On Mon, 2011-09-12 at 03:19 +0300, Grazvydas Ignotas wrote: >> The test checks if no duplicate d_off values are returned and that >> those values are seekable to the right inodes. >> >> Signed-off-by: Grazvydas Ignotas > > I have two minor com

Re: Btrfs bug with g38867a2 and a question

2011-09-23 Thread Mathieu Chouquet-Stringer
On Thu, Sep 22, 2011 at 10:32:13PM +0200, Mathieu Chouquet-Stringer wrote: > On Thu, Sep 22, 2011 at 09:30:07PM +0200, Mathieu Chouquet-Stringer wrote: > > On Thu, Sep 22, 2011 at 03:00:03PM -0400, Josef Bacik wrote: > > > Oh wow sorry I sent you the completely wrong patch, I wish I had caught > >