Re: [PATCH/RFC] Btrfs: Add conditional ENOSPC debugging.

2012-02-10 Thread Jan Schmidt
Hi Mitch, having this patch on the list is a good idea. I've two remarks, just in case it will be included sometimes: On 09.02.2012 22:38, Mitch Harder wrote: diff --git a/fs/btrfs/delayed-inode.c b/fs/btrfs/delayed-inode.c index fe4cd0f..31b717f 100644 --- a/fs/btrfs/delayed-inode.c +++

Re: [PATCH] mkfs: Handle creation of filesystem larger than the first device

2012-02-10 Thread Jan Kara
On Wed 08-02-12 22:05:26, Phillip Susi wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/08/2012 06:20 PM, Jan Kara wrote: Thanks for your reply. I admit I was not sure what exactly size argument should be. So after looking into the code for a while I figured it should be a

[PATCH] Btrfs: fix scrub statistics report

2012-02-10 Thread Stefan Behrens
Fixed that errors had been counted multiple times. Signed-off-by: Stefan Behrens sbehr...@giantdisaster.de --- fs/btrfs/ioctl.h | 30 -- fs/btrfs/scrub.c | 115 -- 2 files changed, 85 insertions(+), 60 deletions(-) diff --git

[PATCH 4/4] btrfs: Use generic handlers of O_SYNC AIO DIO

2012-02-10 Thread Jan Kara
Use generic handlers to queue fsync() when AIO DIO is completed for O_SYNC file. Although we use our own bio-end_io function, we call dio_end_io() from it and thus, because we don't set any specific dio-end_io function, generic code ends up calling generic_dio_end_io() which is all what we need

[PATCH 0/4] Generic O_SYNC AIO DIO handling

2012-02-10 Thread Jan Kara
Hi Jeff, these patches implement generic way of handling O_SYNC AIO DIO. They work for all filesystems except for ext4 and xfs. Thus together with your patches, all filesystems should handle O_SYNC AIO DIO correctly. I've tested ext3, btrfs, and xfs (to check that I didn't break anything

[PATCH 2/4] ocfs2: Use generic handlers of O_SYNC AIO DIO

2012-02-10 Thread Jan Kara
Use generic handlers to queue fsync() when AIO DIO is completed for O_SYNC file. Signed-off-by: Jan Kara j...@suse.cz --- fs/ocfs2/aops.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/ocfs2/aops.c b/fs/ocfs2/aops.c index 78b68af..3d14c2b 100644 ---

[PATCH 1/4] vfs: Handle O_SYNC AIO DIO in generic code properly

2012-02-10 Thread Jan Kara
Provide VFS helpers for handling O_SYNC AIO DIO writes. Filesystem wanting to use the helpers has to pass DIO_SYNC_WRITES to __blockdev_direct_IO. Then if they don't use direct IO end_io handler, generic code takes care of everything else. Otherwise their end_io handler is passed struct

[PATCH 3/4] gfs2: Use generic handlers of O_SYNC AIO DIO

2012-02-10 Thread Jan Kara
Use generic handlers to queue fsync() when AIO DIO is completed for O_SYNC file. Signed-off-by: Jan Kara j...@suse.cz --- fs/gfs2/aops.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/gfs2/aops.c b/fs/gfs2/aops.c index 501e5cb..9c381ff 100644 --- a/fs/gfs2/aops.c

Re: [PATCH 0/4] Generic O_SYNC AIO DIO handling

2012-02-10 Thread Jeff Moyer
Jan Kara j...@suse.cz writes: Hi Jeff, these patches implement generic way of handling O_SYNC AIO DIO. They work for all filesystems except for ext4 and xfs. Thus together with your patches, all filesystems should handle O_SYNC AIO DIO correctly. I've tested ext3, btrfs, and xfs (to

Re: Packed small files

2012-02-10 Thread Phillip Susi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 1/31/2012 11:46 AM, Hugo Mills wrote: So you're looking at a minimum of 413 bytes of metadata overhead for an inline file, plus the length of the filename. Also note that the file is stored in the metadata, so by default it's stored with

[LSF/MM TOPIC] COWing writeback pages

2012-02-10 Thread Sage Weil
Hi everyone, The takeaway from the 'stable pages' discussions in the last few workshops was that pages under writeback should remain locked so that subsequent writers don't touch them while they are en route to the disk. This prevents bad checksums and DIF/DIX type failures (whereas

can't read superblock (but could mount)

2012-02-10 Thread btrfs
Hi! I used to have arch linux running on 1 btrfs partition (sda1, incl. /boot). When switching to 3.2.5 recently the system fails to boot: (after udevd) /etc/rc.sysinit: line 15: 117 Bus error mountpoint -q /proc and so on, no idea. It used to boot with 3.2.4, but 1) I obviously had some

Re: btrfs-raid questions I couldn't find an answer to on the wiki

2012-02-10 Thread Phillip Susi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 1/31/2012 12:55 AM, Duncan wrote: Thanks! I'm on grub2 as well. It's is still masked on gentoo, but I recently unmasked and upgraded to it, taking advantage of the fact that I have two two-spindle md/raid-1s for /boot and its backup to test

Re: [LSF/MM TOPIC] COWing writeback pages

2012-02-10 Thread Josef Bacik
On Fri, Feb 10, 2012 at 11:25:27AM -0800, Sage Weil wrote: Hi everyone, The takeaway from the 'stable pages' discussions in the last few workshops was that pages under writeback should remain locked so that subsequent writers don't touch them while they are en route to the disk. This

Re: [LSF/MM TOPIC] COWing writeback pages

2012-02-10 Thread Sage Weil
On Fri, 10 Feb 2012, Josef Bacik wrote: On Fri, Feb 10, 2012 at 11:25:27AM -0800, Sage Weil wrote: Hi everyone, The takeaway from the 'stable pages' discussions in the last few workshops was that pages under writeback should remain locked so that subsequent writers don't touch them

Re: [LSF/MM TOPIC] COWing writeback pages

2012-02-10 Thread Josef Bacik
On Fri, Feb 10, 2012 at 12:49:50PM -0800, Sage Weil wrote: On Fri, 10 Feb 2012, Josef Bacik wrote: On Fri, Feb 10, 2012 at 11:25:27AM -0800, Sage Weil wrote: Hi everyone, The takeaway from the 'stable pages' discussions in the last few workshops was that pages under writeback

[PATCH] btrfs: honor umask when creating subvol root

2012-02-10 Thread Florian Albrechtskirchinger
Set the subvol root inode permissions based on the current umask. --- fs/btrfs/inode.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index 32214fe..b88e71a 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -6696,8 +6696,10

Re: btrfs unmountable after failed suspend

2012-02-10 Thread Chris Mason
On Thu, Feb 09, 2012 at 06:54:42PM -0600, Chester wrote: Output for btrfs-debug-tree for that specific block in dmesg And available here ( http://pastebin.com/AgdvS5JM ) in case the lines wrap and look ugly leaf 653297209344 items 43 free space 673 generation 332442 owner 2 fs uuid

Re: subvolume info in /proc/mounts

2012-02-10 Thread Nikos Voutsinas
On Sat, Feb 04, 2012 at 08:40:51PM +0200, Nikos Voutsinas wrote: There was a patch to include the subvolume mount option into /proc/mounts. Did that make it into the kernel; If not, what is the formal way to find out which subvolume is mounted; see /proc/self/mountinfo there is 'fs root'

Hot data Tracking

2012-02-10 Thread Timo Witte
What happened to the hot data tracking feature in btrfs? There are a lot of old patches from aug 2010, but it looks like the feature has been completly removed from the current version of btrfs. Is this feature still on the roadmap? signature.asc Description: OpenPGP digital signature

Re: btrfs-raid questions I couldn't find an answer to on the wiki

2012-02-10 Thread Duncan
Phillip Susi posted on Fri, 10 Feb 2012 14:45:43 -0500 as excerpted: On 1/31/2012 12:55 AM, Duncan wrote: Thanks! I'm on grub2 as well. It's is still masked on gentoo, but I recently unmasked and upgraded to it, taking advantage of the fact that I have two two-spindle md/raid-1s for /boot

Re: can't read superblock (but could mount)

2012-02-10 Thread btrfs
Quoting Chris Mason chris.ma...@oracle.com: On Fri, Feb 10, 2012 at 05:18:42PM -0500, Chris Mason wrote: Ok, step one: Pull down the dangerdonteveruse branch of btrfs-progs: git://git.kernel.org/pub/scm/linux/kernel/git/mason/btrfs-progs.git dangerdonteveruse Run btrfs-debug-tree -r