Re: trim malfunction in linux 3.3.6

2012-05-17 Thread Tomasz Torcz
On Thu, May 17, 2012 at 08:10:20PM +0400, Sergey E. Kolesnikov wrote: > Hello. > I've been running Ubuntu 12.04 kernel and btrfs on two partitions of > two GPT partitioned SSDs. Rootfs was btrfs subvol "@" and homes were > at "@home". When I was batch trimming with "fstrim /" using Ubuntu's > stand

Re: trim malfunction in linux 3.3.6

2012-05-17 Thread Liu Bo
On 05/18/2012 12:10 AM, Sergey E. Kolesnikov wrote: > Hello. > I've been running Ubuntu 12.04 kernel and btrfs on two partitions of two > GPT partitioned SSDs. Rootfs was btrfs subvol "@" and homes were at > "@home". When I was batch trimming with "fstrim /" using Ubuntu's > standard kernel 3.2.0

Re: [PATCH 5/5] Btrfs: fix memory leak in btrfs_pause_balance()

2012-05-17 Thread Miao Xie
On thu, 17 May 2012 18:20:04 +0300, Ilya Dryomov wrote: > On Thu, May 17, 2012 at 07:58:53PM +0800, Miao Xie wrote: >> We forget to free fs_info->balance_ctl in the btrfs_pause_balance() >> when umounting the fs. >> >> Signed-off-by: Miao Xie >> --- >> fs/btrfs/volumes.c |3 +++ >> 1 fil

Re: [PATCH 2/5] Btrfs: count the chunks which will be relocated at first

2012-05-17 Thread Miao Xie
On Thu, 17 May 2012 17:58:56 +0300, Ilya Dryomov wrote: > On Thu, May 17, 2012 at 07:56:53PM +0800, Miao Xie wrote: >> the balance function should count the chunks which will be relocated at >> first, >> and then relocate those chunks one by one. >> >> Signed-off-by: Miao Xie >> --- >> fs/btrfs/

Re: Ceph on btrfs 3.4rc

2012-05-17 Thread Martin Mailand
Hi Josef, I hit exact the same bug as Christian with your last patch. -martin -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Ceph on btrfs 3.4rc

2012-05-17 Thread Christian Brunner
2012/5/17 Josef Bacik : > On Thu, May 17, 2012 at 05:12:55PM +0200, Martin Mailand wrote: >> Hi Josef, >> no there was nothing above. Here the is another dmesg output. >> > > Hrm ok give this a try and hopefully this is it, still couldn't reproduce. > Thanks, > > Josef Well, I hate to say it, but

Re: Ceph on btrfs 3.4rc

2012-05-17 Thread Josef Bacik
On Thu, May 17, 2012 at 05:12:55PM +0200, Martin Mailand wrote: > Hi Josef, > no there was nothing above. Here the is another dmesg output. > Hrm ok give this a try and hopefully this is it, still couldn't reproduce. Thanks, Josef diff --git a/fs/btrfs/btrfs_inode.h b/fs/btrfs/btrfs_inode.h ind

trim malfunction in linux 3.3.6

2012-05-17 Thread Sergey E. Kolesnikov
Hello. I've been running Ubuntu 12.04 kernel and btrfs on two partitions of two GPT partitioned SSDs. Rootfs was btrfs subvol "@" and homes were at "@home". When I was batch trimming with "fstrim /" using Ubuntu's standard kernel 3.2.0 - everything was fine. Then I compiled vanilla 3.3.6 kerne

Re: btrfs: initial readahead code and prototypes

2012-05-17 Thread Arne Jansen
On 05/17/12 15:46, Dan Carpenter wrote: On Thu, May 17, 2012 at 03:31:50PM +0200, Arne Jansen wrote: The assumption here is that if err == 0, eb is always != NULL. There's even a tiny comment above the function stating this: 107 /* in case of err, eb might be NULL */ Ah,

Re: [PATCH 5/5] Btrfs: fix memory leak in btrfs_pause_balance()

2012-05-17 Thread Ilya Dryomov
On Thu, May 17, 2012 at 07:58:53PM +0800, Miao Xie wrote: > We forget to free fs_info->balance_ctl in the btrfs_pause_balance() > when umounting the fs. > > Signed-off-by: Miao Xie > --- > fs/btrfs/volumes.c |3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/fs/btrf

Re: Ceph on btrfs 3.4rc

2012-05-17 Thread Martin Mailand
Hi Josef, no there was nothing above. Here the is another dmesg output. Was there anything above those messages? There should have been a WARN_ON() or something. If not thats fine, I just need to know one way or the other so I can figure out what to do next. Thanks, Josef -martin [ 63.0

Re: [PATCH 3/5] Btrfs: pause/recover the space balance when doing remount

2012-05-17 Thread Ilya Dryomov
On Thu, May 17, 2012 at 07:57:40PM +0800, Miao Xie wrote: > pause the space balance threads when remounting the fs to be readonly, > and recover it when remounting it from r/o to r/w > > Signed-off-by: Miao Xie > --- > fs/btrfs/super.c |9 - > fs/btrfs/volumes.c |8 +++- >

Re: [PATCH 2/5] Btrfs: count the chunks which will be relocated at first

2012-05-17 Thread Ilya Dryomov
On Thu, May 17, 2012 at 07:56:53PM +0800, Miao Xie wrote: > the balance function should count the chunks which will be relocated at first, > and then relocate those chunks one by one. > > Signed-off-by: Miao Xie > --- > fs/btrfs/volumes.c |2 +- > 1 files changed, 1 insertions(+), 1 deletion

SSD format/mount parameters questions

2012-05-17 Thread Martin
For using SSDs: Are there any format/mount parameters that should be set for using btrfs on SSDs (other than the "ssd" mount option)? General questions: How long is the 'delay' for the delayed alloc? Are file allocations aligned to 4kiB boundaries, or larger? What byte value is used to pad un

Re: Ceph on btrfs 3.4rc

2012-05-17 Thread Josef Bacik
On Thu, May 17, 2012 at 12:29:32PM +0200, Martin Mailand wrote: > Hi Josef, > > somehow I still get the kernel Bug messages, I used your patch from > the 16th against rc7. > Was there anything above those messages? There should have been a WARN_ON() or something. If not thats fine, I just need

Btrfs storage advice

2012-05-17 Thread Jim
Hi btrfs list, I am looking for some counsel regarding how to best (and most safely) utilize extra space on my btrfs installation. I set up a btrfs installation about 6 months ago. I wanted to test the system while waiting for mainline acceptance and support. The machine being used has 13 1

Re: [PATCH 1/5] btrfs: extend readahead interface

2012-05-17 Thread Arne Jansen
On 05/09/12 16:48, David Sterba wrote: On Thu, Apr 12, 2012 at 05:54:38PM +0200, Arne Jansen wrote: @@ -97,30 +119,87 @@ struct reada_machine_work { +/* + * this is the default callback for readahead. It just descends into the + * tree within the range given at creation. if an error occurs, just

Re: btrfs: initial readahead code and prototypes

2012-05-17 Thread Dan Carpenter
On Thu, May 17, 2012 at 03:31:50PM +0200, Arne Jansen wrote: > The assumption here is that if err == 0, eb is always != NULL. There's > even a tiny comment above the function stating this: > > 107 /* in case of err, eb might be NULL */ > Ah, right. I missed the comment. > Th

Re: btrfs: initial readahead code and prototypes

2012-05-17 Thread Arne Jansen
On 05/17/12 09:14, Dan Carpenter wrote: Hi, I'm working on some new Smatch code and it complains about this patch from last year. -Dan This is a semi-automatic email about new static checker warnings. The patch 7414a03fbf9e: "btrfs: initial readahead code and prototypes" from May 23, 2011,

[PATCH 2/2] Btrfs: resize all devices when we dont assign a specific device id

2012-05-17 Thread Liu Bo
This patch fixes two bugs: When we do not assigne a device id for the resizer, - it will only take one device to resize, which is supposed to apply on all available devices. - it will take 'id 1' device as default, and this will cause a bug as we may have removed the 'id 1' device from the fil

[PATCH 1/2] Btrfs: do not resize a seeding device

2012-05-17 Thread Liu Bo
Seeding devices are not supposed to change any more. Signed-off-by: Liu Bo --- fs/btrfs/ioctl.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index f056469..ec2245d 100644 --- a/fs/btrfs/ioctl.c +++ b/fs/btrfs/ioctl.c @@ -1303,

[PATCH 5/5] Btrfs: fix memory leak in btrfs_pause_balance()

2012-05-17 Thread Miao Xie
We forget to free fs_info->balance_ctl in the btrfs_pause_balance() when umounting the fs. Signed-off-by: Miao Xie --- fs/btrfs/volumes.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index c536d52..fd7fe80 100644 --- a/fs/btrf

[PATCH 4/5] Btrfs: cancel the scrub when remounting a fs to ro

2012-05-17 Thread Miao Xie
If the filesystem is mounted to readonly, we should not run scrub. Signed-off-by: Miao Xie --- fs/btrfs/super.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c index ea17f0a..817b3a7 100644 --- a/fs/btrfs/super.c +++ b/fs/btrfs/super.

[PATCH 3/5] Btrfs: pause/recover the space balance when doing remount

2012-05-17 Thread Miao Xie
pause the space balance threads when remounting the fs to be readonly, and recover it when remounting it from r/o to r/w Signed-off-by: Miao Xie --- fs/btrfs/super.c |9 - fs/btrfs/volumes.c |8 +++- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/fs/btrfs/s

[PATCH 2/5] Btrfs: count the chunks which will be relocated at first

2012-05-17 Thread Miao Xie
the balance function should count the chunks which will be relocated at first, and then relocate those chunks one by one. Signed-off-by: Miao Xie --- fs/btrfs/volumes.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index 759d024

[PATCH 1/5] Btrfs: stop defrag the files automatically when doin readonly remount or umount

2012-05-17 Thread Miao Xie
If we remount the fs to be readonly or umount it, we should not continue defraging the files, it is because - the auto defragment will introduce lots of dirty pages, it breaks the rule of a readonly file system. - it make the time of remount/umount become longer. Signed-off-by: Miao Xie --- fs

Re: How can I create useful bug reports? Here are 50 lines of messages including Call Trace from a system crash.

2012-05-17 Thread Hugo Mills
On Thu, May 17, 2012 at 12:26:42PM +0200, Peter Maloney wrote: > I am using btrfs at home on my root system because I want to be able to > send useful bug reports when things go wrong. > > And I have 3 questions: > > What kernel should I be using? One of: - josef's "btrfs-next"[1], - Chris

Re: Ceph on btrfs 3.4rc

2012-05-17 Thread Martin Mailand
Hi Josef, somehow I still get the kernel Bug messages, I used your patch from the 16th against rc7. -martin Am 16.05.2012 21:20, schrieb Josef Bacik: Hrm ok so I finally got some time to try and debug it and let the test run a good long while (5 hours almost) and I couldn't hit either the or

How can I create useful bug reports? Here are 50 lines of messages including Call Trace from a system crash.

2012-05-17 Thread Peter Maloney
Hi, I am using btrfs at home on my root system because I want to be able to send useful bug reports when things go wrong. And I have 3 questions: What kernel should I be using? And how do I create good bug reports? Is a "Call Trace" that I find in /var/log/messages enough, or do I need to insta

Re: [PATCH v3 0/3] Btrfs-progs: support get/reset device stats via ioctl

2012-05-17 Thread Andrei Popa
On Thu, 2012-05-17 at 10:44 +0200, Stefan Behrens wrote: > On 05/16/2012 19:03, Andrei Popa wrote: > > It would be nice if this function could show the file names affected by > > errors, in case of a single, non-redundant drive, btrfs-progs should > > show what files are affected by errors. > > Th

Re: 3.4.0-rc6: WARNING: at fs/btrfs/super.c:219 __btrfs_abort_transaction+0xae/0xc0 [btrfs]()

2012-05-17 Thread Martin Mailand
Hi, I got the same Warning but triggered it differently, I created a new cephfs on top of btrfs via mkcephfs, the command than hangs. [ 100.643838] Btrfs loaded [ 100.644313] device fsid 49b89a47-76a0-45cf-9e4a-a7e1f4c64bb8 devid 1 transid 4 /dev/sdc [ 100.645523] btrfs: setting nodatacow

Re: [PATCH v3 3/3] Btrfs: read device stats on mount, write modified ones during commit

2012-05-17 Thread Stefan Behrens
On 05/17/2012 03:52, Liu Bo wrote: On 05/17/2012 12:50 AM, Stefan Behrens wrote: The device statistics are written into the device tree with each transaction commit. Only modified statistics are written. When a filesystem is mounted, the device statistics for each involved device are read from

Re: [PATCH v3 0/3] Btrfs-progs: support get/reset device stats via ioctl

2012-05-17 Thread Stefan Behrens
On 05/16/2012 19:03, Andrei Popa wrote: It would be nice if this function could show the file names affected by errors, in case of a single, non-redundant drive, btrfs-progs should show what files are affected by errors. Then, an admin could restore only those files from backup. On Wed, 2012-05-

re: btrfs: initial readahead code and prototypes

2012-05-17 Thread Dan Carpenter
Hi, I'm working on some new Smatch code and it complains about this patch from last year. -Dan This is a semi-automatic email about new static checker warnings. The patch 7414a03fbf9e: "btrfs: initial readahead code and prototypes" from May 23, 2011, leads to the following Smatch complaint