Re: [PATCH 1/2] btrfs: Drop unused function btrfs_abort_devices()

2012-06-06 Thread David Sterba
On Wed, Jun 06, 2012 at 10:17:28AM +0800, Asias He wrote: Hello, Jeff This was added in 49b25e0540904be0bf558b84475c69d72e4de66e adding a transaction abort infrastructure. I'm not sure if Jeff had some intentions with it or whether it got obsolete during the patchset long evolution, CCed.

Re: [PATCH 1/2] btrfs: Drop unused function btrfs_abort_devices()

2012-06-06 Thread Asias He
On 06/06/2012 05:24 PM, David Sterba wrote: On Wed, Jun 06, 2012 at 10:17:28AM +0800, Asias He wrote: Hello, Jeff This was added in 49b25e0540904be0bf558b84475c69d72e4de66e adding a transaction abort infrastructure. I'm not sure if Jeff had some intentions with it or whether it got obsolete

Re: New btrfs-progs integration branch

2012-06-06 Thread Helmut Hullen
Hallo, Hugo, Du meintest am 05.06.12: The branch is fetchable with git from: http://git.darksatanic.net/repo/btrfs-progs-unstable.git/ integration-20120605 There seems to be a bug inside: [...] gcc -g -O0 -o btrfsck btrfsck.o ctree.o disk-io.o radix-tree.o extent- tree.o print-tree.o

Re: New btrfs-progs integration branch

2012-06-06 Thread Hugo Mills
On Wed, Jun 06, 2012 at 01:48:00PM +0200, Helmut Hullen wrote: Hallo, Hugo, Du meintest am 05.06.12: The branch is fetchable with git from: http://git.darksatanic.net/repo/btrfs-progs-unstable.git/ integration-20120605 There seems to be a bug inside: [...] gcc -g -O0 -o

Re: New btrfs-progs integration branch

2012-06-06 Thread Helmut Hullen
Hallo, Hugo, Du meintest am 06.06.12: However, the third line with the problem looks like something out of date. Possibly a mis-merge? Where should I search? Viele Gruesse! Helmut -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to

Re: New btrfs-progs integration branch

2012-06-06 Thread Hugo Mills
On Wed, Jun 06, 2012 at 05:03:00PM +0200, Helmut Hullen wrote: Hallo, Hugo, Du meintest am 06.06.12: However, the third line with the problem looks like something out of date. Possibly a mis-merge? Where should I search? Well, the first thing would be to try a completely new clone

Re: New btrfs-progs integration branch

2012-06-06 Thread Hugo Mills
On Wed, Jun 06, 2012 at 05:52:00PM +0200, Helmut Hullen wrote: Hallo, Hugo, Du meintest am 06.06.12: However, the third line with the problem looks like something out of date. Possibly a mis-merge? Where should I search? Well, the first thing would be to try a completely new

Re: New btrfs-progs integration branch

2012-06-06 Thread Helmut Hullen
Hallo, Hugo, Du meintest am 06.06.12: git checkout integration-20120605 [...] Can you compare your Makefile with the one at [1] -- in particular the progs variable at line 21-23, the all target on line 37, and the btrfs-convert target on line 97. There definitely should not be a plain

Re: Help with data recovering

2012-06-06 Thread Maxim Mikheev
Option -i was helpful. Some date was restored. during restoring some files I got message ret is -3. This files has 0 size. Can anyone tell me what is code -3 mean. Is it recoverable? So basically data is on harddrives but not completely available. the questions is: Is it possible to btrfs

Re: New btrfs-progs integration branch

2012-06-06 Thread Hugo Mills
On Wed, Jun 06, 2012 at 06:18:00PM +0200, Helmut Hullen wrote: Hallo, Hugo, Du meintest am 06.06.12: git checkout integration-20120605 [...] Can you compare your Makefile with the one at [1] -- in particular the progs variable at line 21-23, the all target on line 37, and the

Re: [PATCH v5 2/3] Btrfs-progs: make two utility functions globally available

2012-06-06 Thread Hugo Mills
On Fri, May 25, 2012 at 04:07:17PM +0200, Stefan Behrens wrote: Two convenient utility functions that have so far been local to scrub are moved to utils.c. They will be used in the device stats code in a following commit. [snip] - -static int scrub_fs_info(int fd, char *path, -

Re: New btrfs-progs integration branch

2012-06-06 Thread Helmut Hullen
/filebox/Linux/slackware/ap/btrfs-progs-20120606-i486-1hln.txz Viele Gruesse! Helmut -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCHv2 3/4] avoid several strncpy-induced buffer overruns

2012-06-06 Thread Hugo Mills
Hi, Jim, I picked this up to go in integration-*, and Alex Block spotted a problem, so I did a bit of a more in-depth review. Comments below. On Fri, Apr 20, 2012 at 09:27:25PM +0200, Jim Meyering wrote: From: Jim Meyering meyer...@redhat.com * restore.c (main): Ensure strncpy-copied

Re: [PATCHv2 4/4] mkfs: avoid heap-buffer-read-underrun for zero-length size arg

2012-06-06 Thread Hugo Mills
On Fri, Apr 20, 2012 at 09:27:26PM +0200, Jim Meyering wrote: From: Jim Meyering meyer...@redhat.com * mkfs.c (parse_size): ./mkfs.btrfs -A '' would read and possibly write the byte before beginning of strdup'd heap buffer. All other size-accepting options were similarly affected.

Re: [PATCHv2 3/4] avoid several strncpy-induced buffer overruns

2012-06-06 Thread Hugo Mills
On Wed, Jun 06, 2012 at 08:31:47PM +0100, Hugo Mills wrote: @@ -378,6 +380,7 @@ static int cmd_snapshot(int argc, char **argv) args.fd = fd; strncpy(args.name, newname, BTRFS_SUBVOL_NAME_MAX); + args.name[BTRFS_PATH_NAME_MAX-1] = 0; This, however, is wrong. args here is

Re: [PATCHv2 3/4] avoid several strncpy-induced buffer overruns

2012-06-06 Thread Jim Meyering
Hugo Mills wrote: Hi, Jim, I picked this up to go in integration-*, and Alex Block spotted a problem, so I did a bit of a more in-depth review. Comments below. On Fri, Apr 20, 2012 at 09:27:25PM +0200, Jim Meyering wrote: From: Jim Meyering meyer...@redhat.com * restore.c (main):

Leaving Oracle

2012-06-06 Thread Chris Mason
Hello everyone, Oracle has been a fantastic place to work, and I really appreciate their support for my projects. But, I've decided to take a new position at Fusion-io. I will start the new job on Monday, June 11. From a Btrfs point of view, very little will change. I'll still maintain Btrfs

Re: New btrfs-progs integration branch

2012-06-06 Thread Jérôme Poulin
On Tue, Jun 5, 2012 at 3:09 PM, Hugo Mills h...@carfax.org.uk wrote:   I've just pushed out a new integration branch to my git repo. This is purely bugfix patches -- there are no new features in this issue of the integration branch. I've got a stack of about a dozen more patches with new

Re: locating a func in btrfs-progs

2012-06-06 Thread Hugo Mills
On Thu, Jun 07, 2012 at 09:38:13AM +0800, Sonu wrote: Hi   Any clues on where I can find the function  'btrfs_header_level' in btrfs-progs ?  It's a getter/setter pair. See line 1555 of ctree.h. Hugo. -- === Hugo Mills: hugo@... carfax.org.uk | darksatanic.net | lug.org.uk

Re: Help with data recovering

2012-06-06 Thread Maxim Mikheev
Hi Everyone, Is it possible to extract specific file instead of downloading everything? Thanks On 06/06/2012 12:25 PM, Maxim Mikheev wrote: Option -i was helpful. Some date was restored. during restoring some files I got message ret is -3. This files has 0 size. Can anyone tell me what is