Re: [PATCH] Btrfs: fix dio write vs buffered read race V2

2012-07-01 Thread Christoph Hellwig
On Fri, Jun 29, 2012 at 09:05:10AM -0400, Chris Mason wrote: > > It is better that update i_size in endio, I think. because during endio, we > > are sure that > > the data is flushed into the disk successfully, and can update i_size at > > ease. and if the > > error happens when flushing the data

Re: Please hammer my for-linus branch

2012-07-01 Thread Liu Bo
On 07/02/2012 11:35 AM, Daniel J Blueman wrote: >> Hi everyone, >> >> I've got a nice set of fixes from Josef, Jan, Ilya and others in my >> for-linus branch: >> >> git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus >> >> Some of the changes are fixes for the tree loggin

Re: Please hammer my for-linus branch

2012-07-01 Thread Daniel J Blueman
> Hi everyone, > > I've got a nice set of fixes from Josef, Jan, Ilya and others in my > for-linus branch: > > git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus > > Some of the changes are fixes for the tree logging code, so I ran some > extra crash runs against them Fri

Re: [PATCH 1/3] Btrfs-progs: add support to set subvolume/snapshot readonly

2012-07-01 Thread Liu Bo
On 06/29/2012 06:21 PM, Ilya Dryomov wrote: > On Fri, Jun 29, 2012 at 06:00:36PM +0800, Liu Bo wrote: >> Setting subvolume/snapshot readonly has been missing for a long time. >> >> With this patch, we can set a subvolume/snapshot readonly via: >> >> obtrfs subvolume set-ro > > Alexander's 'b

Re: [PATCH 2/3] Btrfs-progs: make get default report correctly

2012-07-01 Thread Liu Bo
On 06/29/2012 06:36 PM, Ilya Dryomov wrote: > On Fri, Jun 29, 2012 at 06:00:37PM +0800, Liu Bo wrote: >> We have both set-default and get-default, but actually our get-default >> does not show which one is the default one. >> >> This patch plus the kernel side patch fix this. > > Are you referrin

Re: Strange directories in /

2012-07-01 Thread Markus Rothe
On 1 July 2012 17:06, Helmut Hullen wrote: > Hallo, Markus, > > Du meintest am 01.07.12: > >> I am running btrfs for a few months now. I just realized that I have >> a few strange directories in / > >> % ls / -1 >> ? >> ???J?? >> Q??? >> PL >> PR >> bin >> boot >> dev >> etc >> home >> li

Re: Strange directories in /

2012-07-01 Thread Helmut Hullen
Hallo, Markus, Du meintest am 01.07.12: > I am running btrfs for a few months now. I just realized that I have > a few strange directories in / > % ls / -1 > ? > ???J?? > Q??? > PL > PR > bin > boot > dev > etc > home > lib > lib32 > lib64 > lost+found > media > mnt > opt > proc > p?c'?

Re: Btrfs RAID space utilization and bitrot reconstruction

2012-07-01 Thread Hugo Mills
On Sun, Jul 01, 2012 at 01:50:39PM +0200, Waxhead wrote: > As far as I understand btrfs stores all data in huge chunks that are > striped, mirrored or "raid5/6'ed" throughout all the disks added to > the filesystem/volume. Well, RAID-5/6 hasn't landed yet, but yes. > How does btrfs deal with d

Btrfs RAID space utilization and bitrot reconstruction

2012-07-01 Thread Waxhead
As far as I understand btrfs stores all data in huge chunks that are striped, mirrored or "raid5/6'ed" throughout all the disks added to the filesystem/volume. How does btrfs deal with different sized disks? let's say that you for example have 10 different disks that are 100GB,200GB,300GB...10

Re: btrfs_print_tree?

2012-07-01 Thread Zhi Yong Wu
On Sun, Jul 1, 2012 at 6:16 PM, Jeff Liu wrote: > On 07/01/2012 05:49 PM, Zhi Yong Wu wrote: > >> On Sun, Jul 1, 2012 at 5:41 PM, Mike Fleetwood >> wrote: >>> On 1 July 2012 05:53, Zhi Yong Wu wrote: HI, Do anyone know where btrfs_print_tree is invoked? thanks. -- R

Re: [PATCH] Btrfs: fix dio write vs buffered read race V3

2012-07-01 Thread Miao Xie
On Thu, 28 Jun 2012 09:09:04 -0400, Josef Bacik wrote: > fs/btrfs/file.c | 13 > fs/btrfs/inode.c | 55 + > 2 files changed, 50 insertions(+), 18 deletions(-) > > diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c > index 70dc8ca..

Re: [PATCH] Btrfs: fix dio write vs buffered read race V2

2012-07-01 Thread Miao Xie
On Fri, 29 Jun 2012 09:05:10 -0400, Chris Mason wrote: > On Thu, Jun 28, 2012 at 08:18:35PM -0600, Miao Xie wrote: >> On Thu, 28 Jun 2012 08:34:23 -0400, Josef Bacik wrote: >>> On Wed, Jun 27, 2012 at 09:35:08PM -0600, Miao Xie wrote: On Tue, 26 Jun 2012 09:42:56 -0400, Josef Bacik wrote:

Re: btrfs_print_tree?

2012-07-01 Thread Andreas Philipp
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01.07.2012 12:16, Jeff Liu wrote: > On 07/01/2012 05:49 PM, Zhi Yong Wu wrote: > >> On Sun, Jul 1, 2012 at 5:41 PM, Mike Fleetwood >> wrote: >>> On 1 July 2012 05:53, Zhi Yong Wu wrote: HI, Do anyone know where btrfs_print_tree i

Re: btrfs_print_tree?

2012-07-01 Thread Jeff Liu
On 07/01/2012 05:49 PM, Zhi Yong Wu wrote: > On Sun, Jul 1, 2012 at 5:41 PM, Mike Fleetwood > wrote: >> On 1 July 2012 05:53, Zhi Yong Wu wrote: >>> HI, >>> >>> Do anyone know where btrfs_print_tree is invoked? thanks. >>> >>> -- >>> Regards, >>> >>> Zhi Yong Wu >> >> Is this the answer you are

Re: btrfs_print_tree?

2012-07-01 Thread Andreas Philipp
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01.07.2012 11:49, Zhi Yong Wu wrote: > On Sun, Jul 1, 2012 at 5:41 PM, Mike Fleetwood > wrote: >> On 1 July 2012 05:53, Zhi Yong Wu wrote: >>> HI, >>> >>> Do anyone know where btrfs_print_tree is invoked? thanks. >>> >>> -- >>> Regards, >>> >>>

Re: btrfs_print_tree?

2012-07-01 Thread Zhi Yong Wu
On Sun, Jul 1, 2012 at 5:41 PM, Mike Fleetwood wrote: > On 1 July 2012 05:53, Zhi Yong Wu wrote: >> HI, >> >> Do anyone know where btrfs_print_tree is invoked? thanks. >> >> -- >> Regards, >> >> Zhi Yong Wu > > Is this the answer you are after? > > $ grep -r btrfs_print_tree fs/btrfs/ > fs/btrfs/

Re: btrfs_print_tree?

2012-07-01 Thread Mike Fleetwood
On 1 July 2012 05:53, Zhi Yong Wu wrote: > HI, > > Do anyone know where btrfs_print_tree is invoked? thanks. > > -- > Regards, > > Zhi Yong Wu Is this the answer you are after? $ grep -r btrfs_print_tree fs/btrfs/ fs/btrfs/print-tree.c:void btrfs_print_tree(struct btrfs_root *root, struct extent