Re: [PATCH] Btrfs: fix dio write vs buffered read race V2

2012-07-02 Thread Christoph Hellwig
On Fri, Jun 29, 2012 at 09:05:10AM -0400, Chris Mason wrote: It is better that update i_size in endio, I think. because during endio, we are sure that the data is flushed into the disk successfully, and can update i_size at ease. and if the error happens when flushing the data into the

Mounting subvolumes and FS-wide mount options?

2012-07-02 Thread Roman Mamedov
Hello, Suppose I have in /etc/fstab: /dev/sda2 /mnt/p2 btrfs noatime 0 0 /dev/sda2 /home btrfs subvol=/home0 0 /dev/sda2 /srv btrfs subvol=/srv 0 0 Now I want to add mount options like space_cache and inode_cache. As far as I

Re: [PATCH 2/3] Btrfs-progs: make get default report correctly

2012-07-02 Thread Ilya Dryomov
On Mon, Jul 02, 2012 at 09:39:45AM +0800, Liu Bo wrote: On 06/29/2012 06:36 PM, Ilya Dryomov wrote: On Fri, Jun 29, 2012 at 06:00:37PM +0800, Liu Bo wrote: We have both set-default and get-default, but actually our get-default does not show which one is the default one. This patch

Re: [PATCH 1/3] Btrfs-progs: add support to set subvolume/snapshot readonly

2012-07-02 Thread Ilya Dryomov
On Mon, Jul 02, 2012 at 10:07:42AM +0800, Liu Bo wrote: On 06/29/2012 06:21 PM, Ilya Dryomov wrote: On Fri, Jun 29, 2012 at 06:00:36PM +0800, Liu Bo wrote: Setting subvolume/snapshot readonly has been missing for a long time. With this patch, we can set a subvolume/snapshot readonly

kmem_cache_destroy called for cache that still has objects

2012-07-02 Thread Martin Ziegler
When I umounted my USB-disk today, I got the following message: FSSync '/usb' = BUG btrfs_transaction_cache (Tainted: GW ): Objects remaining on kmem_cache_close()

Re: fio reports data corruption with btrfs

2012-07-02 Thread Alex Lyakas
Hi Josef, which branch from your (or another?) repo should I try this on: remotes/origin/HEAD - origin/master remotes/origin/enospc3c78455 Btrfs: fall back to non-inline if we don't have enough space remotes/origin/for-chris 7e9ce65 Btrfs: hold a ref on the inode during writepages

Re: [PATCH] Btrfs: fix dio write vs buffered read race V3

2012-07-02 Thread Josef Bacik
On Sun, Jul 01, 2012 at 04:34:44AM -0600, Miao Xie wrote: On Thu, 28 Jun 2012 09:09:04 -0400, Josef Bacik wrote: fs/btrfs/file.c | 13 fs/btrfs/inode.c | 55 + 2 files changed, 50 insertions(+), 18 deletions(-)

Re: kmem_cache_destroy called for cache that still has objects

2012-07-02 Thread Josef Bacik
On Mon, Jul 02, 2012 at 05:06:27AM -0600, Martin Ziegler wrote: When I umounted my USB-disk today, I got the following message: FSSync '/usb' = BUG btrfs_transaction_cache (Tainted: GW ): Objects

Re: fio reports data corruption with btrfs

2012-07-02 Thread Josef Bacik
On Mon, Jul 02, 2012 at 05:48:43AM -0600, Alex Lyakas wrote: Hi Josef, which branch from your (or another?) repo should I try this on: Master, and make sure you've checked out a more recent fio from git to make sure it's not a bug in fio. Thanks, Josef -- To unsubscribe from this list: send

Re: Please hammer my for-linus branch

2012-07-02 Thread Josef Bacik
On Sun, Jul 01, 2012 at 09:35:01PM -0600, Daniel J Blueman wrote: Hi everyone, I've got a nice set of fixes from Josef, Jan, Ilya and others in my for-linus branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus Some of the changes are fixes for

Re: kmem_cache_destroy called for cache that still has objects

2012-07-02 Thread Martin Ziegler
I print the insteresting part of syslog below. I mount the disk with mount -t btrfs -o compress,noatime,nodiratime,noacl,noexec,nosuid /dev/sdb1 /usb The error parts in the syslog come from the the mistaken mount /usb and the line /dev/sdb1 /usbauto

Re: xfstests/224 lockup/slowdown (was: Please hammer my for-linus branch)

2012-07-02 Thread David Sterba
Hi, I'm seeing a machine lockup in xfstests/224, logs attached. Friday's xfstests round with 3.5-rc4 was ok, all tests passed. The 'dd' processes are in D-state with this stacktraces 5597 pts/0D+ 0:00 dd status=noxfer if=/dev/zero of=/mnt/a2/testfile.8 bs=4k conv=notrunc

Re: xfstests/224 lockup/slowdown (was: Please hammer my for-linus branch)

2012-07-02 Thread David Sterba
On Mon, Jul 02, 2012 at 04:10:52PM +0200, David Sterba wrote: Finishing this report anyway, and will redo the tests again. Looking again into the logs, the first process snapshot (only D-state processes) is much longer than process snapshot of containing all, unfortuntelly I don't have

Re: kmem_cache_destroy called for cache that still has objects

2012-07-02 Thread Jan Schmidt
I print the insteresting part of syslog below. I mount the disk with mount -t btrfs -o compress,noatime,nodiratime,noacl,noexec,nosuid /dev/sdb1 /usb The error parts in the syslog come from the the mistaken mount /usb and the line /dev/sdb1 /usbauto

Re: Feature request: true RAID-1 mode

2012-07-02 Thread H. Peter Anvin
On 06/25/2012 04:00 PM, H. Peter Anvin wrote: I am aware of that, and it is not a problem... the one-device bootloader can find out *which* disk it is talking to by comparing uuids, and the btrfs data structures will tell it how to find the data on that specific disk. It does of course mean

Re: xfstests/224 lockup/slowdown (was: Please hammer my for-linus branch)

2012-07-02 Thread David Sterba
On Mon, Jul 02, 2012 at 04:34:53PM +0200, David Sterba wrote: Bisection in progress. commit cae76522b19735c576803bec273f49062aa418ab Author: Josef Bacik jba...@fusionio.com Date: Thu Jun 21 14:05:49 2012 -0400 Btrfs: flush delayed inodes if we're short on space Those crazy gentoo

Re: Strange directories in /

2012-07-02 Thread Martin Steigerwald
Am Sonntag, 1. Juli 2012 schrieb Markus Rothe: Hello, Hi! I am running btrfs for a few months now. I just realized that I have a few strange directories in / % ls / -1 ? ???J?? QӇ?? PL PR This might be a corrupted filesystem. Can you show ls -l / If size is ? or

Re: Btrfs RAID space utilization and bitrot reconstruction

2012-07-02 Thread Martin Steigerwald
Am Sonntag, 1. Juli 2012 schrieb Waxhead: As far as I understand btrfs stores all data in huge chunks that are striped, mirrored or raid5/6'ed throughout all the disks added to the filesystem/volume. Not through all disks. At least not with the current RAID-1 implementation. It stores two

Testing permanent IO errors with btrfs

2012-07-02 Thread Alex Lyakas
Hi everybody, I am interested to test how btrfs behaves when the underlying block device starts returning permanent IO errors. To test this, I set up a linear device-mapper, mapped to the block device and start IOs. At some point, I switch the device-mapper's table to error table (using dmsetup

Re: Long btrfs hangs during suspend to RAM / BTRFS warning (device dm-0): Aborting unused transaction

2012-07-02 Thread Marc MERLIN
On Fri, Jun 29, 2012 at 05:36:24AM -0700, Marc MERLIN wrote: On Tue, Jun 26, 2012 at 10:20:12PM -0700, Marc MERLIN wrote: On Tue, Jun 26, 2012 at 06:38:18PM -0700, Marc MERLIN wrote: Now, I'm also seeing these below and I have this again (86% CPU): 6076 root 20 0 000 R

Re: Please hammer my for-linus branch

2012-07-02 Thread Chris Mason
On Sat, Jun 30, 2012 at 09:22:59PM -0400, Chris Mason wrote: Hi everyone, I've got a nice set of fixes from Josef, Jan, Ilya and others in my for-linus branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus Some of the changes are fixes for the tree

[PATCH] Btrfs: rework shrink_delalloc

2012-07-02 Thread Josef Bacik
So shrink_delalloc has grown all sorts of cruft over the years thanks to many reworkings of how we track enospc. What happens now as we fill up the disk is we will loop for freaking ever hoping to reclaim a arbitrary amount of space of metadata, this was from when everybody flushed at the same

no dev_stats entry found / OK on first mount after mkfs

2012-07-02 Thread Christian Kujau
Hi, after upgrading from 3.4.0 to 3.5.0-rc5 on this powerpc machine, the following is printed during bootup: [ 18.630750] device fsid ce8c9df5-0a93-47c6-adf6-25084f352a4f devid 1 transid 11061 /dev/hda7 [ 18.637193] btrfs: disk space caching is enabled [ 18.706423] btrfs: no

Re: no dev_stats entry found / OK on first mount after mkfs

2012-07-02 Thread Ilya Dryomov
On Mon, Jul 02, 2012 at 02:46:11PM -0700, Christian Kujau wrote: Hi, after upgrading from 3.4.0 to 3.5.0-rc5 on this powerpc machine, the following is printed during bootup: [ 18.630750] device fsid ce8c9df5-0a93-47c6-adf6-25084f352a4f devid 1 transid 11061 /dev/hda7 [

Re: no dev_stats entry found / OK on first mount after mkfs

2012-07-02 Thread Christian Kujau
On Tue, 3 Jul 2012 at 01:41, Ilya Dryomov wrote: after upgrading from 3.4.0 to 3.5.0-rc5 on this powerpc machine, the following is printed during bootup: [ 18.630750] device fsid ce8c9df5-0a93-47c6-adf6-25084f352a4f devid 1 transid 11061 /dev/hda7 [ 18.637193] btrfs: disk

btrfs GPF in read_extent_buffer() while scrubbing with kernel 3.4.2

2012-07-02 Thread Sami Liedes
Hi, I just got this oops on a computer running 3.4.2. A few minutes before I had started btrfs device scrub / and had a watcher process running btrfs scrub status / every 5 seconds. After a few gigabytes of scrubbing, I got this crash. The oops is transcribed from photos, so it may contain some

Re: btrfs GPF in read_extent_buffer() while scrubbing with kernel 3.4.2

2012-07-02 Thread Sami Liedes
On Tue, Jul 03, 2012 at 02:01:21AM +0300, Sami Liedes wrote: The oops is transcribed from photos, so it may contain some errors. I tried to be careful, and double checked the backtrace. Forgot to menion, the fs is a two-partition filesystem, with both data and metadata mirrored.

[PATCH] Check for failure in open_ctree() call. (LP: #926186)

2012-07-02 Thread Shawn Landden
--- btrfstune.c |4 1 file changed, 4 insertions(+) diff --git a/btrfstune.c b/btrfstune.c index 47830c5..f746e14 100644 --- a/btrfstune.c +++ b/btrfstune.c @@ -107,6 +107,10 @@ int main(int argc, char *argv[]) } root = open_ctree(device, 0, 1); + if (!root) { +

Re: [PATCH 2/3] Btrfs-progs: make get default report correctly

2012-07-02 Thread Liu Bo
On 07/02/2012 05:45 PM, Ilya Dryomov wrote: On Mon, Jul 02, 2012 at 09:39:45AM +0800, Liu Bo wrote: On 06/29/2012 06:36 PM, Ilya Dryomov wrote: On Fri, Jun 29, 2012 at 06:00:37PM +0800, Liu Bo wrote: We have both set-default and get-default, but actually our get-default does not show which

Re: [PATCH 1/3] Btrfs-progs: add support to set subvolume/snapshot readonly

2012-07-02 Thread Liu Bo
On 07/02/2012 06:00 PM, Ilya Dryomov wrote: On Mon, Jul 02, 2012 at 10:07:42AM +0800, Liu Bo wrote: On 06/29/2012 06:21 PM, Ilya Dryomov wrote: On Fri, Jun 29, 2012 at 06:00:36PM +0800, Liu Bo wrote: Setting subvolume/snapshot readonly has been missing for a long time. With this patch, we

Re: raid10 make_request failure during iozone benchmark upon btrfs

2012-07-02 Thread NeilBrown
On Tue, 03 Jul 2012 03:13:33 +0100 Kerin Millar kerfra...@gmail.com wrote: Hi, On 03/07/2012 02:39, NeilBrown wrote: [snip] Could you please double check that you are running a kernel with commit aba336bd1d46d6b0404b06f6915ed76150739057 Author: NeilBrownne...@suse.de Date:

Re: Please hammer my for-linus branch

2012-07-02 Thread Daniel J Blueman
On 2 July 2012 21:34, Josef Bacik jba...@fusionio.com wrote: On Sun, Jul 01, 2012 at 09:35:01PM -0600, Daniel J Blueman wrote: Hi everyone, I've got a nice set of fixes from Josef, Jan, Ilya and others in my for-linus branch:

[PATCH] Seg fault when csum-tree root is corrupted.

2012-07-02 Thread Anand jain
From: Anand Jain anand.j...@oracle.com Segmentation fault with the following trace when csum-tree is deliberately corrupted using btrfs-corrupt-block read block failed check_tree_block Couldn't setup csum tree checking extents Check tree block failed, want=29376512, have=0 :: read block failed

[PATCH] btrfs read error corrected message floods the console during recovery

2012-07-02 Thread Anand jain
From: Anand Jain anand.j...@oracle.com Changing printk_in_rcu to printk_ratelimited_in_rcu will suffice --- fs/btrfs/extent_io.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c index aaa12c1..5ad8743 100644 ---