Re: [PATCH V5] Btrfs: snapshot-aware defrag

2013-01-17 Thread Mitch Harder
On Thu, Jan 17, 2013 at 6:53 PM, Liu Bo wrote: > On Thu, Jan 17, 2013 at 08:42:46AM -0600, Mitch Harder wrote: >> On Wed, Jan 16, 2013 at 6:36 AM, Liu Bo wrote: >> > This comes from one of btrfs's project ideas, >> > As we defragment files, we break any sharing from other snapshots. >> > The bala

Re: [PATCH V2] mm/slab: add a leak decoder callback

2013-01-17 Thread Liu Bo
On Wed, Jan 16, 2013 at 01:34:38PM +0800, Miao Xie wrote: > On wed, 16 Jan 2013 11:03:13 +0800, Liu Bo wrote: > > This adds a leak decoder callback so that slab destruction > > can use to generate debugging output for the allocated objects. > > > > Callers like btrfs are using their own leak track

Re: [PATCH V2] mm/slab: add a leak decoder callback

2013-01-17 Thread Liu Bo
On Wed, Jan 16, 2013 at 03:20:57PM +, Christoph Lameter wrote: > On Wed, 16 Jan 2013, Liu Bo wrote: > > > --- a/include/linux/slub_def.h > > +++ b/include/linux/slub_def.h > > @@ -93,6 +93,7 @@ struct kmem_cache { > > gfp_t allocflags; /* gfp flags to use on each alloc */ > > int

Re: [PATCH V2] mm/slab: add a leak decoder callback

2013-01-17 Thread Liu Bo
On Thu, Jan 17, 2013 at 05:34:46PM +0900, Joonsoo Kim wrote: > Hello, Liu Bo. > > On Wed, Jan 16, 2013 at 11:03:13AM +0800, Liu Bo wrote: > > This adds a leak decoder callback so that slab destruction > > can use to generate debugging output for the allocated objects. > > > > Callers like btrfs a

Re: [PATCH V5] Btrfs: snapshot-aware defrag

2013-01-17 Thread Liu Bo
On Thu, Jan 17, 2013 at 08:42:46AM -0600, Mitch Harder wrote: > On Wed, Jan 16, 2013 at 6:36 AM, Liu Bo wrote: > > This comes from one of btrfs's project ideas, > > As we defragment files, we break any sharing from other snapshots. > > The balancing code will preserve the sharing, and defrag needs

Re: [PATCH 4/4] fs: remove obsolete simple_strto

2013-01-17 Thread Andrew Morton
On Fri, 7 Dec 2012 17:25:19 +0530 Abhijit Pawar wrote: > This patch replace the obsolete simple_strto with kstrto > The XFS part (or something like it) has been applied. > > ... > > --- a/fs/9p/v9fs.c > +++ b/fs/9p/v9fs.c > @@ -112,7 +112,7 @@ static int v9fs_parse_options(struct v9fs_session

Re: [GIT PULL] btrfs-progs: more bugfixes for 0.20-rc1

2013-01-17 Thread Chris Mason
On Thu, Jan 17, 2013 at 10:47:21AM -0700, David Sterba wrote: > Hi Chris, > > please pull a few more fixes to the 0.20-rc series. I have reviewed and > verified them where possible. There are the long awaited ARM fixes, help > updates and unsorted code fixes. > > git://repo.or.cz/btrfs-progs-un

[GIT PULL] btrfs-progs: more bugfixes for 0.20-rc1

2013-01-17 Thread David Sterba
Hi Chris, please pull a few more fixes to the 0.20-rc series. I have reviewed and verified them where possible. There are the long awaited ARM fixes, help updates and unsorted code fixes. git://repo.or.cz/btrfs-progs-unstable/devel.git for-chris Based on top of master commit 91d9eec1ff044394f2

Re: [PATCH] remove "device show" from btrfs man page

2013-01-17 Thread David Sterba
On Wed, Jan 09, 2013 at 03:14:13PM +0800, Jeff Liu wrote: > Hi Simon, > > For the next time when you post btrfs-progs related patches, please > indicate it with a suffix "Btrfs-progs: " on the subject. And please add a Signed-off-by: line (no need to resend the patch). david -- To unsubscribe fr

[PATCH] trivial patch for btrfs-progs

2013-01-17 Thread Arvin Schnell
Hi, please find attached a trivial patch for btrfs-progs. Likely not strictly needed but I noticed valgrind complaining about uninitialised memory in the ioctl call. Regards, Arvin -- Arvin Schnell, Senior Software Engineer, Research & Development SUSE LINUX Products GmbH, GF: Jeff Hawn, Je

Re: [PATCH V5] Btrfs: snapshot-aware defrag

2013-01-17 Thread Mitch Harder
On Wed, Jan 16, 2013 at 6:36 AM, Liu Bo wrote: > This comes from one of btrfs's project ideas, > As we defragment files, we break any sharing from other snapshots. > The balancing code will preserve the sharing, and defrag needs to grow this > as well. > > Now we're able to fill the blank with thi

Re: kernel BUG at fs/btrfs/volumes.c:3707 still not fixed in 3.7.1 (btrfs-zero-log required) but shown as "RIP btrfs_num_copies"

2013-01-17 Thread Marc MERLIN
On Thu, Jan 17, 2013 at 12:31:22PM +0100, David Sterba wrote: > On Sat, Jan 12, 2013 at 07:12:12PM -0800, Marc MERLIN wrote: > > On Fri, Jan 11, 2013 at 09:49:52AM -0500, Josef Bacik wrote: > > > Probably just related to whatever corruption it is you are seeing. > > > > So I have no corruption af

Re: kernel BUG at fs/btrfs/volumes.c:3707 still not fixed in 3.7.1 (btrfs-zero-log required) but shown as "RIP btrfs_num_copies"

2013-01-17 Thread David Sterba
On Sat, Jan 12, 2013 at 07:12:12PM -0800, Marc MERLIN wrote: > On Fri, Jan 11, 2013 at 09:49:52AM -0500, Josef Bacik wrote: > > Probably just related to whatever corruption it is you are seeing. > > So I have no corruption afterall, correct? > > That's good news, but then it does mean that uncle

Re: [PATCH V2] mm/slab: add a leak decoder callback

2013-01-17 Thread Joonsoo Kim
Hello, Liu Bo. On Wed, Jan 16, 2013 at 11:03:13AM +0800, Liu Bo wrote: > This adds a leak decoder callback so that slab destruction > can use to generate debugging output for the allocated objects. > > Callers like btrfs are using their own leak tracking which will > manage allocated objects in a

[PATCH 1/2] Btrfs: ignore orphan qgroup relations

2013-01-17 Thread Arne Jansen
If a qgroup that has still assignments is deleted by the user, the corresponding relations are left in the tree. This leads to an unmountable filesystem. With this patch, those relations are simple ignored. Reported-by: Eric Hopper Signed-off-by: Arne Jansen --- fs/btrfs/qgroup.c |7 +++

[PATCH 2/2] Btrfs: prevent qgroup destroy when there are still relations

2013-01-17 Thread Arne Jansen
Currently you can just destroy a qgroup even though it is in use by other qgroups or has qgroups assigned to it. This patch prevents destruction of qgroups unless they are completely unused. Otherwise destroy will return EBUSY. Reported-by: Eric Hopper Signed-off-by: Arne Jansen --- fs/btrfs/q

[PATCH 0/2] Btrfs: prevent qgroup config corruption by qgroup destroy

2013-01-17 Thread Arne Jansen
When destroying an active qgroup with qgroup destroy, the internal config will become corrupt. This series adds 2 fixes: the first add a recovery, if the config is already corrupt, and the second prevents the destroy if it is still active. Arne Jansen (2): btrfs: ignore orphan qgroup relations

Re: Rendering a btrfs filesystem unmountable with the btrfs command

2013-01-17 Thread Arne Jansen
Hi Eric, thanks for reporting this. I sent a small patch series to the list to fix this. Sorry I forgot to CC you, will send the patches to you directly again. It would be great if you could give it some testing. Thanks, Arne On 15.01.2013 21:44, hop...@omnifarious.org wrote: > mkfs.btrfs /dev/s