Re: [PATCH V2] btrfs-progs: remove "device show" from btrfs man page

2013-01-21 Thread XU Simon
Add SOB line: Signed-off-by: Simon Xu Thanks David for pointing this out. Simon On 2013/1/9 15:31, Simon Xu wrote: Remove "device show" from btrfs man page as it's not supported by the btrfs utility. --- man/btrfs.8.in | 2 -- 1 file changed, 2 deletions(-) diff --git a/man/btrfs.8.in b/

Re: [PATCH] xfstests: fix 284 ENOENT error

2013-01-21 Thread Ben Myers
Hey Liu, On Sun, Jan 06, 2013 at 10:30:38PM +0800, Liu Bo wrote: > 284 misses a 'mkdir' operation. > > Signed-off-by: Liu Bo Reviewed-by: Ben Myers Applied to git://oss.sgi.com/xfs/cmds/xfstests.git Regards, Ben -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs

Re: btrfs: failed to read chunk tree on vde1 (f18 anaconda crash)

2013-01-21 Thread Reartes Guillermo
Thanks for asking, but in the end it was not btrfs related at all. Virt-Manager failed to issue a warning (for yet unknown reasons) and a single hard disk image was being accessed as two different devices... I spent quite a bit of time until i found it. (normally, virt-manager prevents this) Che

Re: [PATCH 05/13] Add btrfs-show-super

2013-01-21 Thread Stefan Behrens
On 01/21/2013 20:54, Goffredo Baroncelli wrote: On 01/21/2013 07:04 PM, David Sterba wrote: On Sun, Jan 20, 2013 at 04:04:10PM -0500, Gene Czarcinski wrote: From: Goffredo Baroncelli What I'm missing here is Stefan's S-o-B line, as he's the original author of the tool, adding it, JFYI. I am

Re: BTRFS dmesg error

2013-01-21 Thread Skender
Here are a couple of lines before and after. Cheers, Skender Haxhimolla [432770.724678] virtuoso-t[17472]: segfault at 8 ip 007f4147 sp 7fff69250848 error 4 in virtuoso-t[40+9ad000] [615597.825359] mythtranscode[10886]: segfault at 4 ip 004243c9 sp 7fff27970368 err

Re: [PATCH 05/13] Add btrfs-show-super

2013-01-21 Thread Goffredo Baroncelli
On 01/21/2013 07:04 PM, David Sterba wrote: On Sun, Jan 20, 2013 at 04:04:10PM -0500, Gene Czarcinski wrote: From: Goffredo Baroncelli What I'm missing here is Stefan's S-o-B line, as he's the original author of the tool, adding it, JFYI. I am not sure if he want to Sign it. During the revi

[PATCH 1/1] Btrfs-progs: Fix typo in balance start usage; filetrs -> filters.

2013-01-21 Thread Andreas Fischer
From: Andreas Fischer Fix typo in "btrfs balance start" usage documentation: 'filetrs' should have been 'filters'. Signed-off-by: Andreas Fischer --- cmds-balance.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmds-balance.c b/cmds-balance.c index 38a7426..dfa0dfe 100

btrfs_start_delalloc_inodes livelocks when creating snapshot under IO

2013-01-21 Thread Alex Lyakas
Greetings all, I see the following issue during snap creation under IO: Transaction commit calls btrfs_start_delalloc_inodes() that locks the delalloc_inodes list, fetches the first inode, unlocks the list, triggers btrfs_alloc_delalloc_work/btrfs_queue_worker for this inode and then locks the lis

Re: [PATCH 00/13] Btrfs-progs: more patches for integration (integration-20130121)

2013-01-21 Thread David Sterba
into an integration branch git://repo.or.cz/btrfs-progs-unstable/devel.git integration-20130121 I've modified the signed-off-by lines when I knew who was the author or contributed to the patch. Please let me know if I've messed the credits and fame attribution. There are three more pat

Re: [PATCH 05/13] Add btrfs-show-super

2013-01-21 Thread David Sterba
On Sun, Jan 20, 2013 at 04:04:10PM -0500, Gene Czarcinski wrote: > From: Goffredo Baroncelli > What I'm missing here is Stefan's S-o-B line, as he's the original author of the tool, adding it, JFYI. > Signed-off-by: Goffredo Baroncelli > Signed-off-by: Gene Czarcinski david -- To unsubscribe

Re: [PATCH 13/13] trivial patch for btrfs-progs

2013-01-21 Thread David Sterba
On Sun, Jan 20, 2013 at 04:04:18PM -0500, Gene Czarcinski wrote: > From: Arvin Schnell > > Hi, > > please find attached a trivial patch for btrfs-progs. Likely not > strictly needed but I noticed valgrind complaining about > uninitialised memory in the ioctl call. > > Regards, > Arvin > > Si

kernel BUG at fs/btrfs/extent-tree.c:5151

2013-01-21 Thread Richard Cooper
Hi All, I have has a machine doesn't get on with btrfs at all. I've been using it as a testbed for several months and it never seems to last more than a couple of weeks before FS corruption. My versions are: - OS - CentOS 6.3 - Kernel - 3.7.1-2 from http://elrepo.org/tiki/kernel-ml - btrfs-pro

Re: [PATCH 06/13] btrfs-show-super.c

2013-01-21 Thread David Sterba
On Sun, Jan 20, 2013 at 04:04:11PM -0500, Gene Czarcinski wrote: > remove extra blank line at EOF The patch contents and description do not match. > --- a/man/Makefile > +++ b/man/Makefile > @@ -1,4 +1,4 @@ > -GZIP=gzip > +GZIPCMD=gzip I'm not sure if this change is needed, does it stick to some

Re: [PATCH 02/13] Btrfs-progs: fix resolving of loop devices

2013-01-21 Thread David Sterba
On Sun, Jan 20, 2013 at 04:04:07PM -0500, Gene Czarcinski wrote: > From: Nirbheek Chauhan > > The LOOP_GET_STATUS ioctl truncates filenames to 64 characters. We should get > the backing file for a given loop device from /sys/. This is how losetup does > it > as well. > > Signed-off-by: Gene Cza

Re: [PATCH 01/13] btrfs-progs: btrfs-image.c: Added NULL pointer check.

2013-01-21 Thread David Sterba
On Sun, Jan 20, 2013 at 04:04:06PM -0500, Gene Czarcinski wrote: > From: Nageswara R Sastry > > Check for the return value of 'open_ctree()' before dereferencing it. > > --- a/btrfs-image.c > +++ b/btrfs-image.c > @@ -491,6 +491,7 @@ static int create_metadump(const char *input, FILE *out, > in

Re: [PATCH 12/13] Btrfs-progs: disable qgroupid 0 for quota_tree

2013-01-21 Thread Gene Czarcinski
At the request of the patch's author, this should be dropped as it has been addressed by a patch to the kernel. On 01/20/2013 04:04 PM, Gene Czarcinski wrote: From: Wang Shilong In kernel, qgroupid 0 is a special number when we run the quota group limit command. So, we should not be able to

[PATCH] Btrfs: fix a regression in balance usage filter

2013-01-21 Thread Ilya Dryomov
Commit 3fed40cc ("Btrfs: cleanup duplicated division functions"), which was merged into 3.8-rc1, has introduced a regression by removing logic that was guarding us against bad user input. Bring it back. Signed-off-by: Ilya Dryomov --- fs/btrfs/volumes.c |9 - 1 files changed, 8 inse

Re: [PATCH 6/6] Btrfs-progs: detect if the disk we are formatting is a ssd

2013-01-21 Thread David Sterba
On Sat, Jan 19, 2013 at 11:14:09PM +0200, Brendan Hide wrote: > On 2013/01/19 08:06 PM, Gene Czarcinski wrote: > >Signed-off-by: Josef Bacik > >Signed-off-by: Gene Czarcinski > >--- > >-values are raid0, raid1, raid10 or single. > >+values are raid0, raid1, raid10, single or dup. Single device w

Re: [PATCH 0/5] Mutually exclusive ops fixes

2013-01-21 Thread David Sterba
On Sun, Jan 20, 2013 at 05:22:27PM +0200, Ilya Dryomov wrote: > This is a set of fixes for mutually exclusive ops stuff added by Stefan > as part of the dev-replace patchset. The main one here is the first > patch, it fixes a regression in balancing interface. The second patch > brings EINVAL err

Re: scrub fails, any way to recover?

2013-01-21 Thread David Sterba
On Sun, Jan 20, 2013 at 09:54:38AM -0600, Neil Schemenauer wrote: > I have a ~350 GB Btrfs filesystem that is corrupted. I think the > damage was caused by a bad SATA cable. I can mount the filesystem > and read most of the data (I already have backups of most everything). > > The scrub is abort

Re: BTRFS dmesg error

2013-01-21 Thread David Sterba
On Mon, Jan 21, 2013 at 05:01:36PM +1100, Skender wrote: > I noticed in the dmesg logs that there seems to be a bug/issue with btrfs. > Here is the trace/message from dmesg. Im going by the instructions from > the > https://btrfs.wiki.kernel.org/index.php/Problem_FAQ#How_do_I_report_bugs_and_iss

Re: [GIT PULL] btrfs-progs: more bugfixes for 0.20-rc1

2013-01-21 Thread David Sterba
On Fri, Jan 18, 2013 at 04:02:09PM -0500, Gene Czarcinski wrote: > >Please send them to the list. > > > Josef Bacik is the current Fedora maintainer as > indicated in bugzilla. > > Currently in Fedora 18, btrfs-progs is the "v0.20-rc1 with git commit id >

Re: [PATCH 2/2] On a diff-send, avoid sending PREALLOC extent

2013-01-21 Thread Alex Lyakas
Hi Josef, I have resent the patches. There are still some "please, no space before tabs" warnings, which I am not sure how to correct, because I don't see space before tab in that place. If there is still a problem, can you please advise what is wrong. Thanks, Alex. On Mon, Jan 14, 2013 at 8:45

[PATCH 2/2] V2 On a diff-send, avoid sending PREALLOC extents

2013-01-21 Thread Alex Lyakas
On a diff-send, avoid sending PREALLOC extents, if the parent root has only PREALLOC extents on an appropriate file range. This does not fully avoid sending PREALLOC extents, because on full-send or on new inode we need a new send command to do that. But this patch improves the situation by handli

Re: [PATCH 00/11 V3] add show command to the subvol sub command

2013-01-21 Thread Anand Jain
Gene, I should do that in couple of days. Thanks. Anand On 01/21/2013 08:19 AM, Gene Czarcinski wrote: On 01/10/2013 06:41 AM, Anand Jain wrote: This is an attempt to make btrfs cli more end user friendly. And adds show subcommand to display all known (as of now) information of the given s

[PATCH 1/2] V2 Avoid sending disknr==0 extents when possible.

2013-01-21 Thread Alex Lyakas
In the following cases we do not send disknr==0 extents: 1) full send 2) new inode in a diff-send 3) when disknr==0 extents are added to the end of an inode Original-version-by: Chen Yang Signed-off-by: Alex Lyakas --- fs/btrfs/send.c | 30 -- 1 file changed, 28 in

[PATCH 0/2] send: Avoid sending disknr==0 and PREALLOC extents when possible V2

2013-01-21 Thread Alex Lyakas
These two patches address the issue of sending unneeded zero data for disknr==0 and PREALLOC extents. There is room for additional improvement for PREALLOC extents, but it requires adding a new send command, so for now this is not addressed. Changes in V2: no functional change; previous patchset w