Re: [PATCH V2 1/6] Btrfs: introduce a mutex lock for btrfs quota operations

2013-03-30 Thread Wang Shilong
Hello Arne, > On 03/28/13 11:53, Wang Shilong wrote: >> From: Wang Shilong >> >> This patch introduces mutex lock 'quota_lock', and makes >> all the user change for quota protected by quota_lock. >> >> Signed-off-by: Wang Shilong >> Reviewed-by: Miao Xie >> --- >> fs/btrfs/ctree.h |3 ++

Re: [PATCH V2 2/6] Btrfs: remove some unnecessary spin_lock usages

2013-03-30 Thread Arne Jansen
On 03/28/13 11:54, Wang Shilong wrote: > From: Wang Shilong > > We use mutex_lock to protect all the user change operaions. > So when we are calling find_qgroup_rb() to check whether > qgroup exists, we don't have to hold spin_lock. > > Besides, when enabling/disabling quota,it must be single >

Re: [PATCH V2 1/6] Btrfs: introduce a mutex lock for btrfs quota operations

2013-03-30 Thread Arne Jansen
On 03/28/13 11:53, Wang Shilong wrote: > From: Wang Shilong > > This patch introduces mutex lock 'quota_lock', and makes > all the user change for quota protected by quota_lock. > > Signed-off-by: Wang Shilong > Reviewed-by: Miao Xie > --- > fs/btrfs/ctree.h |3 +++ > fs/btrfs/disk-io.c

Re: [PATCH] Btrfs: limit the global reserve to 512mb

2013-03-30 Thread Roman Mamedov
On Tue, 26 Mar 2013 15:34:06 -0400 Josef Bacik wrote: > A user reported a problem where he was getting early ENOSPC with hundreds of > gigs of free data space and 6 gigs of free metadata space. This is because > the > global block reserve was taking up the entire free metadata space. This is >

Re: [PATCH] Btrfs: cleanup to remove reduplicate code in iterate_extent_inode()

2013-03-30 Thread Arne Jansen
On 03/30/13 12:55, Wang Shilong wrote: > > >> On 03/29/13 14:42, Wang Shilong wrote: >>> From: Wang Shilong >>> >>> Just remove the unnecessary check and assignment. >>> >>> Signed-off-by: Wang Shilong >>> --- >>> fs/btrfs/backref.c | 3 +-- >>> 1 file changed, 1 insertion(+), 2 deletions(-) >>>

Re: [PATCH] Btrfs: cleanup to remove reduplicate code in iterate_extent_inode()

2013-03-30 Thread Wang Shilong
> On 03/29/13 14:42, Wang Shilong wrote: >> From: Wang Shilong >> >> Just remove the unnecessary check and assignment. >> >> Signed-off-by: Wang Shilong >> --- >> fs/btrfs/backref.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/fs/btrfs/backref.c b/fs/btrfs/bac

Re: [PATCH] Btrfs: cleanup to remove reduplicate code in iterate_extent_inode()

2013-03-30 Thread Wang Shilong
Hello, > On 03/29/13 14:42, Wang Shilong wrote: >> From: Wang Shilong >> >> Just remove the unnecessary check and assignment. >> >> Signed-off-by: Wang Shilong >> --- >> fs/btrfs/backref.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/fs/btrfs/backref.c b/fs/bt

Re: [PATCH] Btrfs: cleanup to remove reduplicate code in iterate_extent_inode()

2013-03-30 Thread Arne Jansen
On 03/29/13 14:42, Wang Shilong wrote: > From: Wang Shilong > > Just remove the unnecessary check and assignment. > > Signed-off-by: Wang Shilong > --- > fs/btrfs/backref.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c > ind