Re: [PATCH 0/2] Btrfs: quota rescan for 3.10

2013-04-06 Thread Wang Shilong
Hello Jan, Would you please add more lines to the changelog(Just as what you have taught me~~) It will be easier for us to review and test the patch before it comes into 3.10. Thanks, Wang The kernel side for rescan, which is needed if you want to enable qgroup tracking on a

Re: [BUG?] Btrfs quota: overwritten space is counted twice

2013-04-06 Thread Arne Jansen
On 04/05/13 23:03, Koen De Wit wrote: When data in a file is overwritten, starting somewhere in the middle of the file, the overwritten space is counted twice against the space usage numbers. Is this a bug, or did I something wrong? Neither. This is a result of how btrfs allocates and

[PATCH 2/4] fsfreeze: manage kill signal when sb_start_write is called

2013-04-06 Thread Marco Stornelli
In every place where sb_start_write was called now we must manage the error code and return -EINTR. Signed-off-by: Marco Stornelli marco.storne...@gmail.com --- fs/btrfs/file.c|9 +++-- fs/cifs/file.c |4 +++- fs/ext4/mmp.c |3 ++- fs/ext4/super.c|4 +++-

[PATCH 3/4] fsfreeze: manage kill signal when sb_start_pagefault is called

2013-04-06 Thread Marco Stornelli
In every place where sb_start_pagefault was called now we must manage the error code and return VM_FAULT_RETRY. Signed-off-by: Marco Stornelli marco.storne...@gmail.com --- fs/btrfs/inode.c |4 +++- fs/buffer.c|4 +++- fs/ext4/inode.c|4 +++- fs/f2fs/file.c |4

Re: [PATCH 3/4] fsfreeze: manage kill signal when sb_start_pagefault is called

2013-04-06 Thread Matthew Wilcox
On Sat, Apr 06, 2013 at 12:05:52PM +0200, Marco Stornelli wrote: In every place where sb_start_pagefault was called now we must manage the error code and return VM_FAULT_RETRY. Erm ... in patch 1/4: static inline void sb_start_pagefault(struct super_block *sb) { - __sb_start_write(sb,

Re: [PATCH 2/4] fsfreeze: manage kill signal when sb_start_write is called

2013-04-06 Thread Matthew Wilcox
On Sat, Apr 06, 2013 at 12:04:52PM +0200, Marco Stornelli wrote: In every place where sb_start_write was called now we must manage the error code and return -EINTR. If we must manage the error code, then these functions should be marked __must_check. -- Matthew Wilcox

Re: [PATCH 2/4] fsfreeze: manage kill signal when sb_start_write is called

2013-04-06 Thread Marco Stornelli
Il 06/04/2013 15:17, Matthew Wilcox ha scritto: On Sat, Apr 06, 2013 at 12:04:52PM +0200, Marco Stornelli wrote: In every place where sb_start_write was called now we must manage the error code and return -EINTR. If we must manage the error code, then these functions should be marked

Re: [PATCH 3/4] fsfreeze: manage kill signal when sb_start_pagefault is called

2013-04-06 Thread Marco Stornelli
Il 06/04/2013 15:20, Matthew Wilcox ha scritto: On Sat, Apr 06, 2013 at 12:05:52PM +0200, Marco Stornelli wrote: In every place where sb_start_pagefault was called now we must manage the error code and return VM_FAULT_RETRY. Erm ... in patch 1/4: static inline void

--mixed and --nodesize together

2013-04-06 Thread Hugo Mills
--mixed seems to prevent selection of alternative leaf/node/sector sizes: $ sudo mkfs.btrfs --mixed -n 16384 -s 16384 -d single -m single /dev/mapper/ca-store Created a data/metadata chunk of size 8388608 fs created label (null) on /dev/mapper/ca-store nodesize 16384 leafsize 16384

btrfs-progs: re-add send-test

2013-04-06 Thread Eric Sandeen
From: Mark Fasheh mfas...@suse.de btrfs-progs: re-add send-test send-test.c links against libbtrfs and uses the send functionality provided to decode and print a send stream to the console. 66819df btrfs-progs: add send-test contained this file when submitted, but somehow got lost on commit.

Re: [PATCH 2/4] fsfreeze: manage kill signal when sb_start_write is called

2013-04-06 Thread Al Viro
On Sat, Apr 06, 2013 at 12:04:52PM +0200, Marco Stornelli wrote: In every place where sb_start_write was called now we must manage the error code and return -EINTR. Now go and look for callers of mnt_want_write() ;-/ The really painful one is in do_last(), but kern_path_create() is not much

Re: btrfs-progs: undefined reference to `blkid_probe_get_wholedisk_devno'

2013-04-06 Thread Lin Ming
(Add list) On Sun, Apr 7, 2013 at 9:38 AM, Lin Ming min...@gmail.com wrote: Hi, Build latest git://git.kernel.org/pub/scm/linux/kernel/git/mason/btrfs-progs.git ~/btrfs-progs$ make [LD] mkfs.btrfs mkfs.o: In function `is_ssd': /home/mlin/btrfs-progs/mkfs.c:1234: undefined

[BUG] btrfs.fsck failing to fix corrupted block

2013-04-06 Thread Shripad Ratnaparkhi
Hi there, I am newbie and recently started using btrfs. Now facing a weird problem. FWIW, I am on archlinux, kenel v3.8.0, having Btrfs v0.20-rc1. After an abnormal reboot, getting these errors while boot: systemd.fsck[289]: checking extents systemd.fsck[289]: checking fs roots

Re: [BUG] btrfs.fsck failing to fix corrupted block

2013-04-06 Thread Shripad Ratnaparkhi
[Replying to my own email] Found a patch which seems to be discusses the fix in a patch provided here: https://patchwork.kernel.org/patch/1946561/ Still now sure whether that is already there in v0.20-rc1 or applicable to fix my issue. thanks, ~shripadr PS: BCC'ing the patch provider. On Sun,

Re: [BUG] btrfs.fsck failing to fix corrupted block

2013-04-06 Thread Harald Glatt
On Sun, Apr 7, 2013 at 3:56 AM, Shripad Ratnaparkhi shripad.ratnapar...@gmail.com wrote: [Replying to my own email] Found a patch which seems to be discusses the fix in a patch provided here: https://patchwork.kernel.org/patch/1946561/ Still now sure whether that is already there in

Re: [BUG] btrfs.fsck failing to fix corrupted block

2013-04-06 Thread Shripad Ratnaparkhi
Yup, that is exactly the case. I got to know about no support of fsck.btrfs at boot up, so symlinked btrfsck and built the initrd. I will try to re-build without btrfsck now and try. Thanks for you quick reply and solution, Herald. thanks, ~shripadr On Sun, Apr 7, 2013 at 7:32 AM, Harald Glatt

Re: btrfs-progs: undefined reference to `blkid_probe_get_wholedisk_devno'

2013-04-06 Thread Lin Ming
Hi, I already installed these packages. sudo apt-get install uuid-dev libattr1-dev zlib1g-dev libacl1-dev e2fslibs-dev libblkid-dev liblzo2-dev Maybe my blkid library is too old. Could you help to check if there is blkid_probe_get_wholedisk_devno in your /usr/include/blkid/blkid.h? Thanks, Lin

Re: btrfs-progs: undefined reference to `blkid_probe_get_wholedisk_devno'

2013-04-06 Thread Wang Shilong
Hello, Hi, I already installed these packages. sudo apt-get install uuid-dev libattr1-dev zlib1g-dev libacl1-dev e2fslibs-dev libblkid-dev liblzo2-dev Maybe my blkid library is too old. Could you help to check if there is blkid_probe_get_wholedisk_devno Yes i do have this.. Thanks,