Re: WARNING: CPU: 2 PID: 1543 at fs/btrfs/ctree.c:1322 btrfs_search_old_slot+0x338/0x81d [btrfs]()

2013-10-21 Thread Tomasz Chmielewski
And yet again on 3.12-rc6. Note the BTRFS critical (device sdd1): unable to find logical 7598242613674844160 len 4096 there; after that, the fs freezes and system won't reboot; has to be power cycled. [ 9138.478015] [ cut here ] [ 9138.478039] WARNING: CPU: 4 PID: 22882

Re: WARNING: CPU: 2 PID: 1543 at fs/btrfs/ctree.c:1322 btrfs_search_old_slot+0x338/0x81d [btrfs]()

2013-10-21 Thread Liu Bo
On Mon, Oct 21, 2013 at 03:10:32PM +0900, Tomasz Chmielewski wrote: And yet again on 3.12-rc6. Looks like this can be reproduced reliable, can you show the steps here? thanks, -liubo Note the BTRFS critical (device sdd1): unable to find logical 7598242613674844160 len 4096 there; after

Re: WARNING: CPU: 2 PID: 1543 at fs/btrfs/ctree.c:1322 btrfs_search_old_slot+0x338/0x81d [btrfs]()

2013-10-21 Thread Tomasz Chmielewski
Not really. I'm running backup in a following way: - rsync --inplace --delete -H ... from remote to local btrfs filesystem - snapshot - remove old snapshots - repeat for a different server While previously this system would hang every few days (oom, allocation failures; see a different thread,

task btrfs-transacti:1076 blocked for more than 120 seconds

2013-10-21 Thread david pu
hello, I'm running into btrfs-transaction hang issue with below call trace from dmesg[1]. when this issue happens, all filesystem r/w access will be blocked and no response in terminal. I'm using Ubuntu raring(linux 3.2 kernel) 64bit kernel as below: Linux dpu-e6410 3.2.0-36-generic #57-Ubuntu SMP

Re: Lots of trouble hanging when rm files with many extents

2013-10-21 Thread Duncan
Tomasz Chmielewski posted on Mon, 21 Oct 2013 13:36:44 +0900 as excerpted: I'll do some more tests with lots of extents to see if it's reproducible here as well. Interestingly, I've generally had qgroups enabled here as well, possibly on all of these systems. Could that be the culprit?

[PATCH] Btrfs: fix check_int 'leaf item out of bounce' regression

2013-10-21 Thread Stefan Behrens
Yet another cleanup patch broke code for which no xfstest exists. Signed-off-by: Stefan Behrens sbehr...@giantdisaster.de --- fs/btrfs/check-integrity.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/btrfs/check-integrity.c b/fs/btrfs/check-integrity.c index

Re: [patch] Btrfs: fix access_ok() check in btrfs_ioctl_send()

2013-10-21 Thread David Sterba
On Thu, Jan 10, 2013 at 11:57:25AM +0300, Dan Carpenter wrote: The closing parenthesis is in the wrong place. We want to check sizeof(*arg-clone_sources) * arg-clone_sources_count instead of sizeof(*arg-clone_sources * arg-clone_sources_count). Signed-off-by: Dan Carpenter

Re: task btrfs-transacti:1076 blocked for more than 120 seconds

2013-10-21 Thread David Sterba
On Mon, Oct 21, 2013 at 04:36:41PM +0800, david pu wrote: I'm running into btrfs-transaction hang issue with below call trace from dmesg[1]. when this issue happens, all filesystem r/w access will be blocked and no response in terminal. I'm using Ubuntu raring(linux 3.2 kernel) 64bit kernel

Re: WARNING: CPU: 2 PID: 1543 at fs/btrfs/ctree.c:1322 btrfs_search_old_slot+0x338/0x81d [btrfs]()

2013-10-21 Thread David Sterba
On Mon, Oct 21, 2013 at 03:10:32PM +0900, Tomasz Chmielewski wrote: Note the BTRFS critical (device sdd1): unable to find logical 7598242613674844160 len 4096 there; after that, the fs freezes and system won't reboot; has to be power cycled. From the first mail: [67893.390592] BTRFS critical

Re: btrfs send 'leaks' open files

2013-10-21 Thread David Sterba
On Sun, Oct 20, 2013 at 11:33:56AM +0100, Phil Davis wrote: I also found Robert Buhren reporting very similar issue back in April 2013: http://comments.gmane.org/gmane.comp.file-systems.btrfs/24795 If further information is needed, i'd be happy to help. Please open bug at

Re: Lots of trouble hanging when rm files with many extents

2013-10-21 Thread John Goerzen
On 10/20/2013 11:36 PM, Tomasz Chmielewski wrote: I'll do some more tests with lots of extents to see if it's reproducible here as well. Interestingly, I've generally had qgroups enabled here as well, possibly on all of these systems. Could that be the culprit? Possibly. Is there a reliable

Re: [PATCH 1/3 v4] btrfs-progs: use kernel for mounted disk for show

2013-10-21 Thread Josef Bacik
On Tue, Oct 15, 2013 at 07:13:33PM +0200, David Sterba wrote: On Tue, Oct 08, 2013 at 11:41:38AM +0800, Anand Jain wrote: As of now btrfs filesystem show reads directly from disks. So sometimes output can be stale, mainly when user wants to cross verify their operation like, label or

Re: task btrfs-transacti:1076 blocked for more than 120 seconds

2013-10-21 Thread david pu
On Mon, Oct 21, 2013 at 8:37 PM, David Sterba dste...@suse.cz wrote: On Mon, Oct 21, 2013 at 04:36:41PM +0800, david pu wrote: I'm running into btrfs-transaction hang issue with below call trace from dmesg[1]. when this issue happens, all filesystem r/w access will be blocked and no response

Re: [PATCH 2/8] xfstests: add regression test for kernel bz 60673

2013-10-21 Thread Eric Sandeen
On 10/18/13 1:26 PM, Josef Bacik wrote: There was a problem with send trying to overwrite a file that wasn't actually the same. This is a test to check this particular case where receive fails when it should succeed properly. I tested this to verify it fails without my fix and passes

Re: [PATCH 3/8] xfstests: stat the dev we're removing to make sure its' really gone V2

2013-10-21 Thread Eric Sandeen
On 10/18/13 1:26 PM, Josef Bacik wrote: I've been periodically failing btrfs/003 because my box sometimes takes a little longer to unregister the device when we remove it and so the output from btrfs dev show doesn't match what we are wanting since it still sees the device. To fix this just

Re: [PATCH 2/8] xfstests: add regression test for kernel bz 60673

2013-10-21 Thread Josef Bacik
On Mon, Oct 21, 2013 at 10:03:10AM -0500, Eric Sandeen wrote: On 10/18/13 1:26 PM, Josef Bacik wrote: There was a problem with send trying to overwrite a file that wasn't actually the same. This is a test to check this particular case where receive fails when it should succeed

Re: [PATCH 2/8] xfstests: add regression test for kernel bz 60673

2013-10-21 Thread Eric Sandeen
On 10/21/13 10:09 AM, Josef Bacik wrote: On Mon, Oct 21, 2013 at 10:03:10AM -0500, Eric Sandeen wrote: On 10/18/13 1:26 PM, Josef Bacik wrote: There was a problem with send trying to overwrite a file that wasn't actually the same. This is a test to check this particular case where

Re: [PATCH 2/8] xfstests: add regression test for kernel bz 60673

2013-10-21 Thread Eric Sandeen
On 10/21/13 10:14 AM, Eric Sandeen wrote: On 10/21/13 10:09 AM, Josef Bacik wrote: On Mon, Oct 21, 2013 at 10:03:10AM -0500, Eric Sandeen wrote: On 10/18/13 1:26 PM, Josef Bacik wrote: There was a problem with send trying to overwrite a file that wasn't actually the same. This is a test to

Re: [PATCH 4/8] xfstests: btrfs/016: a hole punching send test

2013-10-21 Thread Eric Sandeen
On 10/18/13 1:26 PM, Josef Bacik wrote: I recently added a patch to avoid sending holes with btrfs send, but I screwed it up by not sending a hole when we did a hole punch. This is an xfstest version of the test I wrote to show that I had a bug and to verify I was fixing it properly. This

Re: [PATCH 5/8] xfstests: generic/274 increase scratch fs size to 2g

2013-10-21 Thread Eric Sandeen
On 10/18/13 1:26 PM, Josef Bacik wrote: With 1 gig btrfs defaults to mixed block groups, so we ENOSPC in this test because we run out of metadata space, not data space. Increasing to 2g allows us to use our normal setup and allows us to pass this test. Thanks, Signed-off-by: Josef Bacik

Re: [PATCH 6/8] xfstests: generic/311: add a few more test cases

2013-10-21 Thread Eric Sandeen
On 10/18/13 1:26 PM, Josef Bacik wrote: Btrfs had some issues with fsync()'ing directories and fsync()'ing after renames. These three new tests cover the 3 different issues we were seeing. Thanks, Signed-off-by: Josef Bacik jba...@fusionio.com I'd prefer that you copy 311 to a new test w/

btrfs raid5

2013-10-21 Thread lilofile
hi: since RAID 5/6 code merged into Btrfs from 2013.2, no update and bug are found in maillist? is any development plan with btrfs raid5? such as adjusting stripe width、 reconstruction? compared to md raid5 what is advantage in btrfs raid5 ? -- To unsubscribe from this list: send the

BTRFS_INODE_NODATACOW

2013-10-21 Thread lilofile
BTRFS_INODE_NODATACOW what does this macro means? -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] xfstests: wipefs new device in btrfs/003

2013-10-21 Thread Josef Bacik
We changed btrfs device add to check and see if there is an existing fs on the device we are adding, so you now have to do -f if you want to do this. In order to get around checking to see if we have this version of btrfs-progs just wipefs the device we're adding to make sure the device add will

Re: BTRFS_INODE_NODATACOW

2013-10-21 Thread Hugo Mills
On Mon, Oct 21, 2013 at 11:53:42PM +0800, lilofile wrote: BTRFS_INODE_NODATACOW what does this macro means? A file with that attribute set will be modified in place, rather than have extents CoWed when they're modified. This is the implementation of the +C attribute. Hugo. -- ===

[PATCH] xfstests: use -F for mkfs.ext4 in btrfs/012

2013-10-21 Thread Josef Bacik
I noticed this test was hanging because mkfs.ext4 wanted to make sure it was ok to mkfs an entire device. We need -F so it doesn't ask this question. Thanks, Signed-off-by: Josef Bacik jba...@fusionio.com --- tests/btrfs/012 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

btrfs flush data cache

2013-10-21 Thread lilofile
transaction_kthread can periodically commit data and metedata to disk,similarly btrfs_writepages can write data page to disk, in which situation btrfs_writepages function is called? and i cannot find btrfs_writepages is called in btrfs code? who can tell me? -- To unsubscribe from this list:

System crash with recursive btrfs defrag on kernel 3.11.5

2013-10-21 Thread Hans-Kristian Bakke
Hi I decided to try full defrag on my btrfs array today. Sadly the system crashed after a few hours. No data lost as far as I have seen after reboot and the filesystem is mounted and seemingly ok now. Any ideas? Hardware: CPU: Intel Xeon X3430 MB: Supermicro X8SI6-F RAM: 16GB (4x4GB) Samsung

[PATCH] xfstests: stat the dev we're removing to make sure its' really gone V3

2013-10-21 Thread Josef Bacik
I've been periodically failing btrfs/003 because my box sometimes takes a little longer to unregister the device when we remove it and so the output from btrfs dev show doesn't match what we are wanting since it still sees the device. To fix this just stat and sleep if we still see the device

Re: WARNING: CPU: 2 PID: 1543 at fs/btrfs/ctree.c:1322 btrfs_search_old_slot+0x338/0x81d [btrfs]()

2013-10-21 Thread Tomasz Chmielewski
On Mon, 21 Oct 2013 14:53:17 +0200 David Sterba dste...@suse.cz wrote: On Mon, Oct 21, 2013 at 03:10:32PM +0900, Tomasz Chmielewski wrote: Note the BTRFS critical (device sdd1): unable to find logical 7598242613674844160 len 4096 there; after that, the fs freezes and system won't reboot;

Re: [PATCH] xfstests: add regression test for kernel bz 60673 V2

2013-10-21 Thread Eric Sandeen
On 10/21/13 12:52 PM, Josef Bacik wrote: There was a problem with send trying to overwrite a file that wasn't actually the same. This is a test to check this particular case where receive fails when it should succeed properly. I tested this to verify it fails without my fix and passes

Re: [PATCH] xfstests: use -F for mkfs.ext4 in btrfs/012

2013-10-21 Thread Eric Sandeen
On 10/21/13 11:05 AM, Josef Bacik wrote: I noticed this test was hanging because mkfs.ext4 wanted to make sure it was ok to mkfs an entire device. We need -F so it doesn't ask this question. Thanks, Signed-off-by: Josef Bacik jba...@fusionio.com Reviewed-by: Eric Sandeen

Re: [PATCH] xfstests: wipefs new device in btrfs/003

2013-10-21 Thread Eric Sandeen
On 10/21/13 10:53 AM, Josef Bacik wrote: We changed btrfs device add to check and see if there is an existing fs on the device we are adding, so you now have to do -f if you want to do this. In order to get around checking to see if we have this version of btrfs-progs just wipefs the

[patch 13/13] btrfs: add tracing for failed reservations

2013-10-21 Thread Jeff Mahoney
When debugging ENOSPC issues, it's nice to be able to see which reservations failed as well as the ones which succeeded. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/extent-tree.c |7 +++ 1 file changed, 7 insertions(+) --- a/fs/btrfs/extent-tree.c2013-10-21

[patch 02/13] kobject: export kobj_sysfs_ops

2013-10-21 Thread Jeff Mahoney
struct kobj_attribute implements the baseline attribute functionality that can be used all over the place. We should export the ops associated with it. Signed-off-by: Jeff Mahoney je...@suse.com --- lib/kobject.c |1 + 1 file changed, 1 insertion(+) --- a/lib/kobject.c 2013-10-21

[patch 12/13] btrfs: publish fs label in sysfs

2013-10-21 Thread Jeff Mahoney
This adds a writeable attribute which describes the label. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/sysfs.c | 44 1 file changed, 44 insertions(+) --- a/fs/btrfs/sysfs.c 2013-10-21 16:20:06.395804741 -0400 +++ b/fs/btrfs/sysfs.c

[patch 06/13] btrfs: publish unknown feature bits in sysfs

2013-10-21 Thread Jeff Mahoney
With the compat and compat-ro bits, it's possible for file systems to exist that have features that aren't supported by the kernel's file system implementation yet still be mountable. This patch publishes read-only info on those features using a prefix:number format, where the number is the bit

[patch 09/13] btrfs: add ioctl to export size of global metadata reservation

2013-10-21 Thread Jeff Mahoney
btrfs filesystem df output will show the size of the metadata space and how much of it is used, and the user assumes that the difference is all usable space. Since that's not actually the case due to the global metadata reservation, we should provide the full picture to the user. This patch adds

[patch 03/13] btrfs: publish supported featured in sysfs

2013-10-21 Thread Jeff Mahoney
This patch adds the ability to publish supported features to sysfs under /sys/fs/btrfs/features. The files are module-wide and export which features the kernel supports. The content, for now, is just 0\n. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/sysfs.c | 44

[patch 08/13] btrfs: use feature attribute names to print better error messages

2013-10-21 Thread Jeff Mahoney
Now that we have the feature name strings available in the kernel via the sysfs attributes, we can use them for printing better failure messages from the ioctl path. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/ioctl.c | 35 ++- fs/btrfs/sysfs.c |

[patch 04/13] btrfs: publish per-super attributes in sysfs

2013-10-21 Thread Jeff Mahoney
This patch adds per-super attributes to sysfs. It doesn't publish any attributes yet, but does the proper lifetime handling as well as the basic infrastructure to add new attributes. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/ctree.h |2 ++ fs/btrfs/disk-io.c |9 +

[patch 07/13] btrfs: add ability to change features via sysfs

2013-10-21 Thread Jeff Mahoney
This patch adds the ability to change (set/clear) features while the file system is mounted. A bitmask is added for each feature set for the support to set and clear the bits. A message indicating which bit has been set or cleared is issued when it's been changed and also when permission or

[patch 05/13] btrfs: publish per-super features in sysfs

2013-10-21 Thread Jeff Mahoney
This patch publishes information on which features are enabled in the file system on a per-super basis. At this point, it only publishes information on features supported by the file system implementation. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/sysfs.c | 81

[patch 01/13] btrfs: add ioctls to query/change feature bits online

2013-10-21 Thread Jeff Mahoney
There are some feature bits that require no offline setup and can be enabled online. I've only reviewed extended irefs, but there will probably be more. We introduce three new ioctls: - BTRFS_IOC_GET_SUPPORTED_FEATURES: query the kernel for supported features. - BTRFS_IOC_GET_FEATURES: query the

[patch 11/13] btrfs: publish device membership in sysfs

2013-10-21 Thread Jeff Mahoney
Now that we have the infrastructure for per-super attributes, we can publish device membership in /sys/fs/btrfs/fsid/devices. The information is published as symlinks to the block devices. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/ctree.h |1 + fs/btrfs/sysfs.c | 32

Re: [PATCH v2] Btrfs: improve inode hash function/inode lookup

2013-10-21 Thread David Sterba
On Fri, Oct 11, 2013 at 06:20:16PM +0100, Filipe David Manana wrote: Good point David. However it would be a rather radical behaviour change imho. A radical step to prevent this practictly impossible but nasty bug to happen :) I think it should be a separate change if there are no objections

Re: [PATCH v2] Btrfs: improve inode hash function/inode lookup

2013-10-21 Thread Filipe David Manana
On Tue, Oct 22, 2013 at 12:21 AM, David Sterba dste...@suse.cz wrote: On Fri, Oct 11, 2013 at 06:20:16PM +0100, Filipe David Manana wrote: Good point David. However it would be a rather radical behaviour change imho. A radical step to prevent this practictly impossible but nasty bug to happen

btrfs flush data cache

2013-10-21 Thread shuo lv
transaction_kthread can periodically commit data and metedata to disk,similarly btrfs_writepages can write data page to disk, in which situation btrfs_writepages function is called? and i cannot find btrfs_writepages is called in btrfs code? who can tell me? -- To unsubscribe from this list: send

btrfs raid5

2013-10-21 Thread shuo lv
hi: since RAID 5/6 code merged into Btrfs from 2013.2, no update and bug are found in maillist? is any development plan with btrfs raid5? such as adjusting stripe width、 reconstruction? compared to md raid5 what is advantage in btrfs raid5 ? -- To unsubscribe from this list: send the line

Seed device + small device = Oops

2013-10-21 Thread Dan Greene
If you create a seed device with btrfstune and then try to add a small (32MB) device to it, the kernel will oops and the attempt to add the device will fail. I have attached a transcript of the shell session that demonstrates this. (This was generated by piping UML to tee and then cleaning up the

[PATCH 1/2] btrfs-progs: make get_btrfs_mount callable

2013-10-21 Thread Anand Jain
get_btrfs_mount is reusable function but it is printing errors, this removes it. Here the parent function of open_path_or_dev_mnt does print error msg on error. Signed-off-by: Anand Jain anand.j...@oracle.com --- utils.c |6 ++ utils.h |1 + 2 files changed, 3 insertions(+), 4

[PATCH 2/2] btrfs-progs: filesystem show of specified mounted disk should work

2013-10-21 Thread Anand Jain
Originally, thinking was user will use mount point if the disk is mounted. But thats not really true, actually user don't (or shouldn't) care to check if disk mounted, so whether disk is mounted/unmounted when disk path is specified it should work. Signed-off-by: Anand Jain anand.j...@oracle.com

Re: [PATCH 1/3 v4] btrfs-progs: use kernel for mounted disk for show

2013-10-21 Thread Anand Jain
On 10/21/13 10:44 PM, Josef Bacik wrote: On Tue, Oct 15, 2013 at 07:13:33PM +0200, David Sterba wrote: On Tue, Oct 08, 2013 at 11:41:38AM +0800, Anand Jain wrote: As of now btrfs filesystem show reads directly from disks. So sometimes output can be stale, mainly when user wants to cross