Re: OOPS on 3.11.6

2013-11-05 Thread Duncan
Andy Lutomirski posted on Mon, 04 Nov 2013 15:11:44 -0800 as excerpted: (This is Fedora's kernel 3.11.6-200.fc19.x86_64) I have a file on my btrfs filesystem. Reading it results in: [ 170.261789] general protection fault: [#1] SMP I had a similar case recently (running 3.12-rc5+ at

Re: [PATCH 0/9] btrfs: remove unused variables

2013-11-05 Thread David Sterba
On Mon, Nov 04, 2013 at 10:34:20PM +0100, Valentina Giusti wrote: With this patchset I removed the unused variables found with make W=1 fs/btrfs/ Valentina Giusti (9): btrfs: remove unused variable from btrfs_search_forward btrfs: remove unused variable from btrfs_new_inode

Re: [PATCH] FS: BTRFS: fixed coding style issues

2013-11-05 Thread David Sterba
On Mon, Nov 04, 2013 at 03:27:38PM +0200, Aldo Iljazi wrote: Fixed three coding style issues. Replaced spaces with tabs. Signed-off-by: Aldo Iljazi m...@aldo.io --- fs/btrfs/dev-replace.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/btrfs/dev-replace.c

Re: [PATCH] FS: BTRFS: fixed coding style issues

2013-11-05 Thread Aldo Iljazi
David Sterba wrote: On Mon, Nov 04, 2013 at 03:27:38PM +0200, Aldo Iljazi wrote: Fixed three coding style issues. Replaced spaces with tabs. Signed-off-by: Aldo Iljazi m...@aldo.io --- fs/btrfs/dev-replace.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

Re: [PATCH] FS: BTRFS: fixed coding style issues

2013-11-05 Thread David Sterba
On Tue, Nov 05, 2013 at 12:32:37PM +0200, Aldo Iljazi wrote: David Sterba wrote: On Mon, Nov 04, 2013 at 03:27:38PM +0200, Aldo Iljazi wrote: Fixed three coding style issues. Replaced spaces with tabs. Signed-off-by: Aldo Iljazi m...@aldo.io --- fs/btrfs/dev-replace.c | 6

Re: [PATCH] FS: BTRFS: fixed coding style issues

2013-11-05 Thread Aldo Iljazi
David Sterba wrote: On Tue, Nov 05, 2013 at 12:32:37PM +0200, Aldo Iljazi wrote: David Sterba wrote: On Mon, Nov 04, 2013 at 03:27:38PM +0200, Aldo Iljazi wrote: Fixed three coding style issues. Replaced spaces with tabs. Signed-off-by: Aldo Iljazi m...@aldo.io ---

Re: csum failure messages

2013-11-05 Thread David Sterba
On Tue, Nov 05, 2013 at 07:15:57AM +0100, Hans-Kristian Bakke wrote: As you were in the process of a rebalance these errors may actually be caused by this serious bug Btrfs: relocate csums properly with prealloc extents. I hit that myself with several preallocated files made by rtorrent

Re: [PATCH] FS: BTRFS: fixed coding style issues

2013-11-05 Thread David Sterba
On Tue, Nov 05, 2013 at 12:40:16PM +0200, Aldo Iljazi wrote: I replaced the spaces with tabs, as the kernel coding style suggests. I repeat: Whitespace changes are just noise, we don't need them at this point of development phase of btrfs. david Okay then ignore the patch.

Re: [PATCH 1/7] Btrfs: remove unnecessary initialization and memory barrior in shrink_delalloc()

2013-11-05 Thread David Sterba
On Mon, Nov 04, 2013 at 11:13:20PM +0800, Miao Xie wrote: Signed-off-by: Miao Xie mi...@cn.fujitsu.com Reviewed-by: David Sterba dste...@suse.cz Would be nice to say why it's safe to remove the barrier. The percpu counters do not need it, they use a spinlock. The barrier was there due to access

Partition broken, btrfsck segfaults or asserts

2013-11-05 Thread Dennis Schridde
Hello! I have a serious problem with inaccessible data and segfaulting btrfsck for the /var partition on my computer. The reason is not entirely clear to me. The only extraordinary things happening today were an empty CMOS battery and me accidentally enabling C1E support when reconfiguring the

Re: csum failure messages

2013-11-05 Thread Russell Coker
On Tue, 5 Nov 2013, Hans-Kristian Bakke hkba...@gmail.com wrote: As you were in the process of a rebalance these errors may actually be caused by this serious bug Btrfs: relocate csums properly with prealloc extents. I hit that myself with several preallocated files made by rtorrent during

Re: [PATCH] FS: BTRFS: fixed coding style issues

2013-11-05 Thread Aldo Iljazi
David Sterba wrote: On Tue, Nov 05, 2013 at 12:40:16PM +0200, Aldo Iljazi wrote: I replaced the spaces with tabs, as the kernel coding style suggests. I repeat: Whitespace changes are just noise, we don't need them at this point of development phase of btrfs. david

Re: csum failure messages

2013-11-05 Thread Hans-Kristian Bakke
I gave up on getting the filesystem to a concistent state, but my corruption was much more severe than yours. Several 100 000's. As the fs was still usable and mountable I just moved all the files to another filesystem, patched the kernel recreated the original btrfs fs and ran a rebalance. This

umount waiting for 12 hours and still running

2013-11-05 Thread John Goerzen
Hello, More than 12 hours ago, I tried to umount a btrfs filesystem. Something involving btrfs-cleaner and btrfs-transacti is still running, but I don't know what. I have noticed excessively long umount times before, and it is a significant concern for me. A bit of background: The filesystem

Re: [PATCH 6/9] mtip32xx: handle arbitrary size bios

2013-11-05 Thread Josef Bacik
On Mon, Nov 04, 2013 at 03:36:24PM -0800, Kent Overstreet wrote: We get a measurable performance increase by handling this in the driver when we're already looping over the biovec, instead of handling it separately in generic_make_request() (or bio_add_page() originally) Signed-off-by: Kent

Re: [PATCH 1/9] block: Convert various code to bio_for_each_segment()

2013-11-05 Thread Josef Bacik
On Mon, Nov 04, 2013 at 03:36:19PM -0800, Kent Overstreet wrote: With immutable biovecs we don't want code accessing bi_io_vec directly - the uses this patch changes weren't incorrect since they all own the bio, but it makes the code harder to audit for no good reason - also, this will help

Re: Partition broken, btrfsck segfaults or asserts

2013-11-05 Thread Duncan
Dennis Schridde posted on Tue, 05 Nov 2013 13:04:59 +0100 as excerpted: I have a serious problem with inaccessible data and segfaulting btrfsck for the /var partition on my computer. I can mount it[.] When I access certain directories, however, I get a message like this one: ls: cannot

Re: umount waiting for 12 hours and still running

2013-11-05 Thread Duncan
John Goerzen posted on Tue, 05 Nov 2013 07:42:02 -0600 as excerpted: Hello, More than 12 hours ago, I tried to umount a btrfs filesystem. Something involving btrfs-cleaner and btrfs-transacti is still running, but I don't know what. I have noticed excessively long umount times before,

Re: csum failure messages

2013-11-05 Thread Chris Murphy
On Nov 5, 2013, at 5:16 AM, Russell Coker russ...@coker.com.au wrote: I presume that my filesystem is still corrupt. I'm the original reporter of the bug. The file system itself isn't corrupt, but the affected files probably are. In my case, systemd journal files were reported as corrupt by

Re: csum failure messages

2013-11-05 Thread Hugo Mills
On Tue, Nov 05, 2013 at 07:26:54AM -0700, Chris Murphy wrote: On Nov 5, 2013, at 5:16 AM, Russell Coker russ...@coker.com.au wrote: I presume that my filesystem is still corrupt. I'm the original reporter of the bug. The file system itself isn't corrupt, but the affected files

Re: umount waiting for 12 hours and still running

2013-11-05 Thread John Goerzen
Duncan 1i5t5.duncan at cox.net writes: John Goerzen posted on Tue, 05 Nov 2013 07:42:02 -0600 as excerpted: The filesystem in question involves two 2TB USB hard drives. It is 49% full. Data is RAID0, metadata is RAID1. The files stored on it are for BackupPC, meaning there are many,

[PATCH] Btrfs: don't BUG_ON() if we get an error walking backrefs

2013-11-05 Thread Josef Bacik
We can just return false for this so we stop doing the snapshot aware defrag stuff. Thanks, Signed-off-by: Josef Bacik jba...@fusionio.com --- fs/btrfs/inode.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index f167ced..aa67387 100644

Re: umount waiting for 12 hours and still running

2013-11-05 Thread Duncan
John Goerzen posted on Tue, 05 Nov 2013 16:11:56 + as excerpted: Duncan 1i5t5.duncan at cox.net writes: John Goerzen posted on Tue, 05 Nov 2013 07:42:02 -0600 as excerpted: The filesystem in question involves two 2TB USB hard drives. It is 49% full. Data is RAID0, metadata is

Re: umount waiting for 12 hours and still running

2013-11-05 Thread Tomasz Chmielewski
More than 12 hours ago, I tried to umount a btrfs filesystem. Something involving btrfs-cleaner and btrfs-transacti is still running, but I don't know what. Does iostat -x 1 or iostat -k 1 show any disk activity? Anything interesting in dmesg? -- Tomasz Chmielewski http://wpkg.org -- To

Re: umount waiting for 12 hours and still running

2013-11-05 Thread John Goerzen
On 11/05/2013 12:46 PM, Tomasz Chmielewski wrote: More than 12 hours ago, I tried to umount a btrfs filesystem. Something involving btrfs-cleaner and btrfs-transacti is still running, but I don't know what. Does iostat -x 1 or iostat -k 1 show any disk activity? Yes. For instance, from

Re: OK to take hourly snapshots, then cull older ones?

2013-11-05 Thread Matthias G. Eckermann
Hello Marc and all, On Mon, Nov 04, 2013 at 06:51:11PM -0800 Marc MERLIN wrote: On Sun, Nov 03, 2013 at 12:50PM +0100, Matthias G. Eckermann wrote: On Mon, Oct 14, 2013 at 21:05 David Madden wrote: I'd like to use BTRFS to do something like the old NetApp snapshot system: every hour

Re: csum failure messages

2013-11-05 Thread John Williams
On Tue, Nov 5, 2013 at 6:34 AM, Hugo Mills h...@carfax.org.uk wrote: On Tue, Nov 05, 2013 at 07:26:54AM -0700, Chris Murphy wrote: On Nov 5, 2013, at 5:16 AM, Russell Coker russ...@coker.com.au wrote: I presume that my filesystem is still corrupt. I'm the original reporter of the bug. The

Re: [PATCH 1/7] Btrfs: remove unnecessary initialization and memory barrior in shrink_delalloc()

2013-11-05 Thread Miao Xie
On Tue, 5 Nov 2013 12:45:16 +0100, David Sterba wrote: On Mon, Nov 04, 2013 at 11:13:20PM +0800, Miao Xie wrote: Signed-off-by: Miao Xie mi...@cn.fujitsu.com Reviewed-by: David Sterba dste...@suse.cz Would be nice to say why it's safe to remove the barrier. The percpu counters do not need

3.11.5 kernel infinite loop

2013-11-05 Thread Russell Coker
I have a system running the Debian package of 3.11.5 with an Amd Opteron 1212 processor (2*64bit cores), 8G of RAM, and an Intel 120G SSD for the root and home subvols. It has a RAID-1 array of 2*3TB disks for bulk storage (movies etc) but that probably isn't relevant to this problem. On the

mount (ro, ro,recovery, and recovery) fail with open_ctree failed

2013-11-05 Thread Cody Schafer
After a hard shutdown (by holding down the power button), mount (ro, ro,recovery, and recovery) fails with some error output. Further, btrfs-image (v0.20-rc1-358-g194aa4a) produces an empty output file. --- root@sysresccd /mnt/backup/g/btrfs-progs % ./btrfs-image /dev/mapper/nb205--ssd-main

[PATCH 1/2] Btrfs/tracepoint: fix to report right flags for ordered extent

2013-11-05 Thread Liu Bo
We use set_bit() to assign ordered extent's flags, but in the related tracepoint we don't do the same thing, which makes the trace output not to parse flags correctly. Also, since the flags are bits stuff, we change to use __print_flags with a 'delim' instead of __print_symbolic. Signed-off-by:

[PATCH 2/2] Btrfs/tracepoint: update new flags for ordered extent TP

2013-11-05 Thread Liu Bo
Flag BTRFS_ORDERED_TRUNCATED is a new one, update the tracepoint to support it. Signed-off-by: Liu Bo bo.li@oracle.com --- include/trace/events/btrfs.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/trace/events/btrfs.h b/include/trace/events/btrfs.h index

[PATCH V2 1/7] Btrfs: remove unnecessary initialization and memory barrior in shrink_delalloc()

2013-11-05 Thread Miao Xie
- The variant nr_pages is assigned before we use it, so the initialization at the beginning is unnecessary. - If we enter the branch of the first if statement, the initialization of the variant loops is also unnecessary. - The memory barriers here are misused, the barrier is used to prevent

Re: btrfsck errors is it save to fix?

2013-11-05 Thread Hendrik Friedel
Hello, sorry, I was totally unaware still being on 3.11rc2. I re-ran btrfsck with the same result: ./btrfs-progs/btrfsck /dev/sdc1 Checking filesystem on /dev/sdc1 UUID: 989306aa-d291-4752-8477-0baf94f8c42f checking extents checking free space cache checking fs roots root 256 inode 9579 errors