[PATCH 2/2] Btrfs: remove dead codes from ctree.h

2013-11-12 Thread Wang Shilong
These two functions are only stated but undefined. Signed-off-by: Wang Shilong wangsl.f...@cn.fujitsu.com --- fs/btrfs/ctree.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h index 7038acc..254209e 100644 --- a/fs/btrfs/ctree.h +++ b/fs/btrfs/ctree.h

[PATCH 1/2] Btrfs: remove unused function btrfs_get_inode_ref_index()

2013-11-12 Thread Wang Shilong
Since commit d52be818e6(Btrfs: simplify unlink reservations), btrfs_get_inode_ref_index() is no loner called. Signed-off-by: Wang Shilong wangsl.f...@cn.fujitsu.com --- fs/btrfs/ctree.h | 6 - fs/btrfs/inode-item.c | 65 --- 2 files

[PATCH 2/5] Btrfs-progs: introduce btrfs property subgroup

2013-11-12 Thread Filipe David Borba Manana
From: Alexander Block abloc...@googlemail.com btrfs filesystem property is a generic interface to set/get properties on filesystem objects (inodes/subvolumes/filesystems /devs). This patch adds the generic framework for properties and also implements two properties. The first is the read-only

[PATCH 5/5] Btrfs-progs: add support for the compression property

2013-11-12 Thread Filipe David Borba Manana
With this property, one can enable compression for individual files without the need to mount the filesystem with the compress or compress-force options, and specify the compression algorithm. When applied against a directory, files created under that directory will inherit the compression

[PATCH 3/5] Btrfs-progs: fix detection of root objects in cmds-property.c

2013-11-12 Thread Filipe David Borba Manana
Several fixes: 1) The function check_is_root() returns 0 if the object is root; 2) Don't treat any error from get fsid ioctl as meaning the target is root. Only -ENOTTY means it's a root (parent directory is not a btrfs fs) and a -ENOTDIR means our target object is not a directory,

[PATCH 0/5] Add support for object properties

2013-11-12 Thread Filipe David Borba Manana
This is a revised version of the original proposal/work from Alexander Block to introduce a generic framework to set properties on btrfs filesystem objects (inodes, subvolumes, filesystems, devices). I preserved most of Alexander's work, rebasing only his main patch against latest integration

[PATCH 4/5] Btrfs-progs: add type root to label property

2013-11-12 Thread Filipe David Borba Manana
So that we can get the label of a mounted filesystem. Before this change: $ btrfs prop get /mnt/btrfs label ERROR: object is not compatible with property $ btrfs prop get /dev/sdb3 label ERROR: dev /dev/sdb3 is mounted, use mount point ERROR: failed to

[PATCH 1/5] Btrfs-progs: let get_label return the label instead of printing it

2013-11-12 Thread Filipe David Borba Manana
get_label prints the label at the moment. Change this so that the label is returned and printing is done by the caller. Signed-off-by: Filipe David Borba Manana fdman...@gmail.com --- cmds-filesystem.c | 14 +++--- utils.c | 15 ++- utils.h |2 +-

[RFC PATCH] Btrfs: add support for inode properties

2013-11-12 Thread Filipe David Borba Manana
This change adds infrastructure to allow for generic properties for inodes via a new ioctl. Properties are name/value pairs that can be associated with inodes for different purposes. They're stored as xattrs with the prefix btrfs. Properties can be inherited - this means when a directory inode

Re: [PATCH] BTRFS: fixed coding style issues

2013-11-12 Thread David Sterba
On Tue, Nov 05, 2013 at 09:02:01AM +0200, Aldo Iljazi wrote: Line 4989: Inserted a space after the comma. Lines 7986 and 8274: Inserted a space before the open parenthesis. Hm, I don't know why my message from yesterday did not make it to the list, but I'm objecting against flow of such changes

Re: [PATCH 0/9] btrfs: remove unused variables

2013-11-12 Thread David Sterba
On Mon, Nov 04, 2013 at 10:34:20PM +0100, Valentina Giusti wrote: With this patchset I removed the unused variables found with make W=1 fs/btrfs/ Valentina Giusti (9): btrfs: remove unused variable from btrfs_search_forward btrfs: remove unused variable from btrfs_new_inode

Re: [PATCH v3] xfstests: add regression test for running btrfs balance and defrag concurrently

2013-11-12 Thread Rich Johnston
This has been committed. Thanks --Rich commit 6bd85c0a995af4df28b354450e6df658257b559b Author: Liu Bo bo.li@oracle.com Date: Thu Oct 31 09:34:22 2013 + xfstests: add regression test for running btrfs balance and defrag concurrently -- To unsubscribe from this list: send the

Re: [PATCH 1/2] Btrfs: remove unused function btrfs_get_inode_ref_index()

2013-11-12 Thread David Sterba
On Tue, Nov 12, 2013 at 07:32:03PM +0800, Wang Shilong wrote: Since commit d52be818e6(Btrfs: simplify unlink reservations), btrfs_get_inode_ref_index() is no loner called. Signed-off-by: Wang Shilong wangsl.f...@cn.fujitsu.com http://www.spinics.net/lists/linux-btrfs/msg26646.html

Re: [PATCH] Btrfs: Fixup usage of btrfs: prefix in syslog

2013-11-12 Thread David Sterba
On Mon, Nov 11, 2013 at 02:27:15AM -0500, Frank Holton wrote: Change all uses of printk to use the btrfs: prefix for easier grepping of kernel log. There is a set of functions that wrap the printed messages (btrfs_info, btrfs_err, ...) and enhance them with device info etc. Please use them

Re: [PATCH] FS: BTRFS: fixed coding style issues

2013-11-12 Thread Aldo Iljazi
David Sterba wrote: On Mon, Nov 04, 2013 at 03:27:38PM +0200, Aldo Iljazi wrote: Fixed three coding style issues. Replaced spaces with tabs. Signed-off-by: Aldo Iljazi m...@aldo.io --- fs/btrfs/dev-replace.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

Re: [PATCH v3 03/17] btrfs: Add high priority workqueue support for btrfs_workqueue_struct

2013-11-12 Thread David Sterba
On Fri, Nov 08, 2013 at 08:53:00AM +0800, Qu Wenruo wrote: On Thu, 7 Nov 2013 17:41:34 +0100, David Sterba wrote: On Thu, Nov 07, 2013 at 01:51:53PM +0800, Qu Wenruo wrote: @@ -753,6 +754,19 @@ struct btrfs_workqueue_struct *btrfs_alloc_workqueue(char *name, } } + if

Re: [RFC PATCH] Btrfs: add support for inode properties

2013-11-12 Thread Goffredo Baroncelli
Hi Filipe, On 2013-11-12 14:42, Filipe David Borba Manana wrote: This change adds infrastructure to allow for generic properties for inodes via a new ioctl. I am sure that there is a valid reason, but I was not able to find it: why implement a new ioctl instead of using the *{set,get)xattr(2)

Re: btrfsck errors is it save to fix?

2013-11-12 Thread Kai Krakow
Duncan 1i5t5.dun...@cox.net schrieb: 100 is I_ERR_FILE_EXTENT_DISCOUNT. I'm not sure what kind of problem this indicates but btrfsck does not seem to fix this currently - it just detects it. Interesting... I wish it were documented what it technically means and what implications each

[PATCH] Btrfs: incompatible format change to remove hole extents V4

2013-11-12 Thread Josef Bacik
Btrfs has always had these filler extent data items for holes in inodes. This has made somethings very easy, like logging hole punches and sending hole punches. However for large holey files these extent data items are pure overhead. So add an incompatible feature to no longer add hole extents

Re: [RFC PATCH] Btrfs: add support for inode properties

2013-11-12 Thread Filipe David Manana
On Tue, Nov 12, 2013 at 7:24 PM, Goffredo Baroncelli kreij...@libero.it wrote: Hi Filipe, Hi On 2013-11-12 14:42, Filipe David Borba Manana wrote: This change adds infrastructure to allow for generic properties for inodes via a new ioctl. I am sure that there is a valid reason, but I was

Re: [RFC PATCH] Btrfs: add support for inode properties

2013-11-12 Thread Hugo Mills
On Tue, Nov 12, 2013 at 08:04:47PM +, Filipe David Manana wrote: On Tue, Nov 12, 2013 at 7:24 PM, Goffredo Baroncelli kreij...@libero.it wrote: Hi Filipe, Hi On 2013-11-12 14:42, Filipe David Borba Manana wrote: This change adds infrastructure to allow for generic properties

[PATCH] Btrfs: make sure to copy everything if we rename

2013-11-12 Thread Josef Bacik
If we rename a file that is already in the log and we fsync again we will lose the new name. This is because we just log the inode update and not the new ref. To fix this we just need to check if we are logging the new name of the inode and copy all the metadata instead of just updating the inode

[PATCH v2 0/2] Change printk to btrfs_* where applicable

2013-11-12 Thread Frank Holton
I've replaced pr_ and printk statments by btrfs_ output macros where I could find a fs_info structure. There may be a few remaining cases where a fs_info structure could be obtained from one of the inputs but I wasn't sure how. For all the of the remaining pr_ and printk statements I've made sure

[PATCH 2/2] Btrfs: make btrfs_debug match pr_debug handling related to DEBUG

2013-11-12 Thread Frank Holton
The kernel macro pr_debug is defined as a empty statement when DEBUG is not defined. Make btrfs_debug match pr_debug to avoid spamming the kernel log with debug messages Signed-off-by: Frank Holton fhol...@gmail.com --- fs/btrfs/ctree.h |6 ++ 1 file changed, 6 insertions(+) diff --git

Re: [RFC PATCH] Btrfs: add support for inode properties

2013-11-12 Thread Filipe David Manana
On Tue, Nov 12, 2013 at 8:07 PM, Hugo Mills h...@carfax.org.uk wrote: On Tue, Nov 12, 2013 at 08:04:47PM +, Filipe David Manana wrote: On Tue, Nov 12, 2013 at 7:24 PM, Goffredo Baroncelli kreij...@libero.it wrote: Hi Filipe, Hi On 2013-11-12 14:42, Filipe David Borba Manana wrote:

Re: [PATCH v3 03/17] btrfs: Add high priority workqueue support for btrfs_workqueue_struct

2013-11-12 Thread Qu Wenruo
On Tue, 12 Nov 2013 17:59:23 +0100, David Sterba wrote: On Fri, Nov 08, 2013 at 08:53:00AM +0800, Qu Wenruo wrote: On Thu, 7 Nov 2013 17:41:34 +0100, David Sterba wrote: On Thu, Nov 07, 2013 at 01:51:53PM +0800, Qu Wenruo wrote: @@ -753,6 +754,19 @@ struct btrfs_workqueue_struct

[PATCH 5/5 V2] Btrfs-progs: add support for the compression property

2013-11-12 Thread Filipe David Borba Manana
With this property, one can enable compression for individual files without the need to mount the filesystem with the compress or compress-force options, and specify the compression algorithm. When applied against a directory, files created under that directory will inherit the compression

[PATCH V2] Btrfs: add support for inode properties

2013-11-12 Thread Filipe David Borba Manana
This change adds infrastructure to allow for generic properties for inodes. Properties are name/value pairs that can be associated with inodes for different purposes. They're stored as xattrs with the prefix btrfs. Properties can be inherited - this means when a directory inode has inheritable

Re: [PATCH 1/2] Btrfs: remove unused function btrfs_get_inode_ref_index()

2013-11-12 Thread Wang Shilong
On 11/13/2013 12:02 AM, David Sterba wrote: On Tue, Nov 12, 2013 at 07:32:03PM +0800, Wang Shilong wrote: Since commit d52be818e6(Btrfs: simplify unlink reservations), btrfs_get_inode_ref_index() is no loner called. Signed-off-by: Wang Shilong wangsl.f...@cn.fujitsu.com