[PATCH v2 1/2] btrfs: cleanup: removed unused 'btrfs_get_inode_ref_index'

2013-11-13 Thread Wang Shilong
From: Sergei Trofimovich sly...@gentoo.org Found by uselex.rb: btrfs_get_inode_ref_index: [R]: exported from: fs/btrfs/inode-item.o fs/btrfs/btrfs.o fs/btrfs/built-in.o Signed-off-by: Sergei Trofimovich sly...@gentoo.org Reviewed-by: David Stebra dste...@suse.cz Signed-off-by: Wang Shilong

Re: [PATCH] Btrfs-progs: try harder to make btrfs receive successfully

2013-11-13 Thread Stefan Behrens
On Wed, 13 Nov 2013 17:25:46 +0800, Wang Shilong wrote: Steps to reproduce: # mkfs.btrfs -f dev # mount dev mnt # mkdir mnt/backup # btrfs sub create mnt/subv # btrfs sub snapshot -r mnt/subv mnt/snap1 # btrfs sub snapshot -r mnt/subv mnt/snap2 #

Re: [PATCH] Btrfs-progs: allow --init-extent-tree to work when extent tree is borked

2013-11-13 Thread Martin
On 11/11/13 22:52, Martin wrote: On 07/11/13 01:25, Martin wrote: OK so Chris Mason and the Gentoo sys-fs/btrfs-progs- came to the rescue to give: # btrfs version Btrfs v0.20-rc1-591-gc652e4e From that, I've tried running again: # btrfsck --repair /dev/sdc giving thus far:

Re: btrfsck errors is it save to fix?

2013-11-13 Thread Duncan
Kai Krakow posted on Tue, 12 Nov 2013 20:37:57 +0100 as excerpted: BTW, my first impression was that errors 400 means something like 400 errors - but that is just a hex bitmask which shows what errors have been found. So errors 100 is just _one_ bit set, thus only _one_ error. Same

Re: btrfsck errors is it save to fix?

2013-11-13 Thread Duncan
Kai Krakow posted on Tue, 12 Nov 2013 20:37:57 +0100 as excerpted: Possible? Yes. Although I did not implicitly mention it, you would combine clear_cache and nospace_cache - that should do the trick. Then unmount and check. Thanks and mentally noted for further reference. I didn't think

Re: Error from Trying to Mount Btrfs

2013-11-13 Thread Duncan
gatlin sullivan posted on Sun, 27 Oct 2013 16:17:05 -0700 as excerpted: I have the attached error from trying to mount btrfs on external hard drive. The F.S. was my primary system, then I dd'd it to an external and reinstalled Fedora. I tried to follow

Re: [PATCH] Btrfs-progs: allow --init-extent-tree to work when extent tree is borked

2013-11-13 Thread Duncan
Martin posted on Wed, 13 Nov 2013 12:08:50 + as excerpted: Which comes to a request: Can the options -v (for verbose) and -s (to continuously show status) be added to btrfsck to give some indication of progress and what is happening? The -s should report progress by whatever

NMI from btrfs cron jobs in 3.11.6

2013-11-13 Thread Russell Coker
Nov 14 00:00:01 workstation /USR/SBIN/CRON[30993]: (root) CMD (/usr/local/sbin/btrfs-make-snapshot minutes /home /var/log/snapshot.log)

Re: invalid opcode: 0000 [#1] SMP

2013-11-13 Thread Duncan
Franziska Näpelt posted on Tue, 12 Nov 2013 08:49:12 +0100 as excerpted: we are using a btrfs RAID 1 with four 2TB hard drives (WD Caviar green) on a Debian 7.2 with Kernel 3.11.6 Now we had an 'invalid opcode: [#1] SMP' when a sector fails in messages log. After that, access over smb

Re: NMI from btrfs cron jobs in 3.11.6

2013-11-13 Thread Duncan
Russell Coker posted on Thu, 14 Nov 2013 01:45:29 +1100 as excerpted: It appears that running two scripts that create snapshots at the same time as a script that removes maybe 97 snapshots causes an NMI. This is a known bug in 3.11 (and presumably earlier). Snapshot manipulation concurrency

Re: invalid opcode: 0000 [#1] SMP

2013-11-13 Thread Hugo Mills
On Wed, Nov 13, 2013 at 03:03:37PM +, Duncan wrote: Franziska Näpelt posted on Tue, 12 Nov 2013 08:49:12 +0100 as excerpted: we are using a btrfs RAID 1 with four 2TB hard drives (WD Caviar green) on a Debian 7.2 with Kernel 3.11.6 Now we had an 'invalid opcode: [#1] SMP' when

Re: [PATCH 1/5] Btrfs-progs: let get_label return the label instead of printing it

2013-11-13 Thread David Sterba
On Tue, Nov 12, 2013 at 01:41:42PM +, Filipe David Borba Manana wrote: get_label prints the label at the moment. Change this so that the label is returned and printing is done by the caller. Signed-off-by: Filipe David Borba Manana fdman...@gmail.com FYI, I'll add this patch to

Re: [PATCH] btrfs-progs: make it static if function isn't called outside

2013-11-13 Thread David Sterba
On Wed, Nov 13, 2013 at 04:19:39PM +0800, Anand Jain wrote: --- a/cmds-dedup.c +++ b/cmds-dedup.c @@ -31,7 +31,7 @@ static const char * const dedup_cmd_group_usage[] = { NULL }; -int dedup_ctl(char *path, struct btrfs_ioctl_dedup_args *args) +static int dedup_ctl(char *path,

Re: [PATCH] btrfs-progs: make it static if function isn't called outside

2013-11-13 Thread Liu Bo
On Wed, Nov 13, 2013 at 04:50:30PM +0100, David Sterba wrote: On Wed, Nov 13, 2013 at 04:19:39PM +0800, Anand Jain wrote: --- a/cmds-dedup.c +++ b/cmds-dedup.c @@ -31,7 +31,7 @@ static const char * const dedup_cmd_group_usage[] = { NULL }; -int dedup_ctl(char *path, struct

Re: [PATCH 0/5] Add support for object properties

2013-11-13 Thread David Sterba
On Tue, Nov 12, 2013 at 01:41:41PM +, Filipe David Borba Manana wrote: This is a revised version of the original proposal/work from Alexander Block to introduce a generic framework to set properties on btrfs filesystem objects (inodes, subvolumes, filesystems, devices). Thank you very much

[PATCH] Btrfs: print bytenr instead of page pointer in check-int

2013-11-13 Thread Stefan Behrens
The page pointer information was useless. The bytenr is what you want when you search for submitted write bios. Additionally, a new bit in the print mask is added that allows to selectively enable the check-int submit_bio verbose mode. Before, the global verbose mode had to be enabled leading to

Re: [PATCH 2/6] Btrfs-progs: add btrfsck functionality to btrfs

2013-11-13 Thread David Sterba
Hi, On Sun, Jun 02, 2013 at 05:47:38PM +0200, Dieter Ries wrote: For this to have any effect, 'h' must be added to getopt_long(), see attached patch 1. However, this results in btrfsck -h and --help doing different things: --help prints the usage message to stdout and exits with exit(0).

Re: [PATCH V2] Btrfs: add support for inode properties

2013-11-13 Thread Goffredo Baroncelli
Hi Filipe, my comments below On 2013-11-13 02:21, Filipe David Borba Manana wrote: This change adds infrastructure to allow for generic properties for inodes. Properties are name/value pairs that can be associated with inodes for different purposes. They're stored as xattrs with the prefix

Re: Sync() causes null pointer dereference and warning message in run_clustered_refs()

2013-11-13 Thread Pedro Fonseca
Hi, Does anyone have an idea about what could be causing this null pointer bug? Pedro On 11/09/2013 06:30 PM, Pedro Fonseca wrote: Hi, I've encountered a bug that triggers a warning message (list_del corruption. next-prev should be d9d0ae28, but was d9d5d5e8) and subsequently causes a

re: btrfs: add tracing for failed reservations

2013-11-13 Thread Dan Carpenter
Hello Jeff Mahoney, This is a semi-automatic email about new static checker warnings. The patch cab45e22da48: btrfs: add tracing for failed reservations from Oct 16, 2013, leads to the following Smatch complaint: fs/btrfs/extent-tree.c:3710 btrfs_check_data_free_space() error: we

[PATCH] Btrfs: fix check-integrity to look at the referenced data properly

2013-11-13 Thread Josef Bacik
We were looking at file_extent_num_bytes unconditionally when looking at referenced data bytes, but this isn't correct for compression. Fix this by checking the compression of the file extent we are and setting num_bytes to disk_num_bytes in the case of compression so that we are marking the

Re: Sync() causes null pointer dereference and warning message in run_clustered_refs()

2013-11-13 Thread Liu Bo
On Sat, Nov 09, 2013 at 09:30:50AM -0800, Pedro Fonseca wrote: Hi, I've encountered a bug that triggers a warning message (list_del corruption. next-prev should be d9d0ae28, but was d9d5d5e8) and subsequently causes a null pointer dereference while running a custom test case on btrfs