[PATCH] btrfs: scrub maintenance event should be recorded in the messages

2013-11-25 Thread Anand Jain
so to help problem understanding and solving Signed-off-by: Anand Jain anand.j...@oracle.com --- fs/btrfs/ioctl.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index d237af8..ba980fb 100644 --- a/fs/btrfs/ioctl.c +++

[PATCH] xfstests,btrfs: add wrong compress type regression test

2013-11-25 Thread Miao Xie
A test to check if the oops will happen when the users write some data into the files whose compress flag is set but the compression of the fs is disabled. Signed-off-by: Miao Xie mi...@cn.fujitsu.com --- tests/btrfs/022 | 82 +

[PATCH v2] btrfs: scrub maintenance event should be recorded in the messages

2013-11-25 Thread Anand Jain
so to help problem understanding and solving Signed-off-by: Anand Jain anand.j...@oracle.com --- v2: log shoud be starting instead of started fs/btrfs/ioctl.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index

Re: btrfs scrub ioprio

2013-11-25 Thread Austin S Hemmelgarn
On 2013-11-24 22:45, Jim Salter wrote: TL;DR scrub's ioprio argument isn't really helpful - a scrub murders system performance til it's done. My system: 3.11 kernel (from Ubuntu Saucy) btrfs-tools from 2013-07 (from Debian Sid) Opteron 8-core CPU 32GB RAM 4 WD 1TB Black drives in a

Re: btrfs scrub ioprio

2013-11-25 Thread Jim Salter
Can you elaborate on this please? I'm not directly familiar with cgroups, I'd greatly appreciate a quick-and-dirty example of using BIO cgroup to limit I/O bandwidth. Limiting bandwidth definitely would ameliorate the problem for me; I already use pv's bw-limiting feature to make btrfs send

Re: btrfs scrub ioprio

2013-11-25 Thread Austin S Hemmelgarn
On 2013-11-25 07:55, Jim Salter wrote: Can you elaborate on this please? I'm not directly familiar with cgroups, I'd greatly appreciate a quick-and-dirty example of using BIO cgroup to limit I/O bandwidth. Limiting bandwidth definitely would ameliorate the problem for me; I already use

Re: [PATCH] Btrfs: relocate csums properly with prealloc extents

2013-11-25 Thread David Sterba
On Fri, Sep 27, 2013 at 09:37:00AM -0400, Josef Bacik wrote: A user reported a problem where they were getting csum errors when running a balance and running systemd's journal. This is because systemd is awesome and fallocate()'s its log space and writes into it. Unfortunately we assume that

Re: Triple parity and beyond

2013-11-25 Thread Pasi Kärkkäinen
On Fri, Nov 22, 2013 at 07:12:39PM +1100, Russell Coker wrote: On Thu, 21 Nov 2013 18:30:49 Stan Hoeppner wrote: I suggest that anyone in the future needing fast random write IOPS is going to move those workloads to SSD, which is steadily increasing in capacity. And I suggest anyone

btrfsck errors - what to do ?

2013-11-25 Thread Miguel Negrão
Hi I have a filesystem which I can mount without problems and use. I've done a scrub on it two days ago which came back with 0 errors. Today I ran a btrfsck which displayed quite a lot of errors, I tried correcting them with the --repair flat, but after, running btrfsck without the --repair again

Re: [PATCH] xfstests,btrfs: add wrong compress type regression test

2013-11-25 Thread Dave Chinner
On Mon, Nov 25, 2013 at 06:28:44PM +0800, Miao Xie wrote: A test to check if the oops will happen when the users write some data into the files whose compress flag is set but the compression of the fs is disabled. Signed-off-by: Miao Xie mi...@cn.fujitsu.com --- tests/btrfs/022 | 82

Re: [PATCH] Btrfs: relocate csums properly with prealloc extents

2013-11-25 Thread Greg KH
On Mon, Nov 25, 2013 at 05:51:16PM +0100, David Sterba wrote: On Fri, Sep 27, 2013 at 09:37:00AM -0400, Josef Bacik wrote: A user reported a problem where they were getting csum errors when running a balance and running systemd's journal. This is because systemd is awesome and

Re: [PATCH] BTRFS-PROG: recursively subvolume snapshot and delete

2013-11-25 Thread Goffredo Baroncelli
Hi all, nobody is interested in these new features ? On 2013-11-16 18:09, Goffredo Baroncelli wrote: Hi All, the following patches implement the recursively snapshotting and deleting of a subvolume. To snapshot recursively you must pass the -R switch: # btrfs subvolume create sub1

Re: [PATCH 1/2] xfstests: add generic/321 to test fsync() on directories V2

2013-11-25 Thread Josef Bacik
On Mon, Nov 25, 2013 at 08:12:16AM -0800, Christoph Hellwig wrote: On Fri, Nov 15, 2013 at 01:01:03PM -0500, Josef Bacik wrote: Btrfs had some issues with fsync()'ing directories and fsync()'ing after renames. These three new tests cover the 3 different issues we were seeing. This breaks

[PATCH 1/2] xfstests: add generic/321 to test fsync() on directories V2

2013-11-25 Thread Josef Bacik
Btrfs had some issues with fsync()'ing directories and fsync()'ing after renames. These three new tests cover the 3 different issues we were seeing. This breaks out the dmflakey stuff into a common helper to be shared between generic/311 and generic/321. Thanks, Signed-off-by: Josef Bacik

[PATCH 2/2] xfstests: add a rename fsync test

2013-11-25 Thread Josef Bacik
Btrfs was screwing up rename+fsync, add some regression tests for the various scenarios it was screwing up. Thanks, Signed-off-by: Josef Bacik jba...@fusionio.com --- tests/generic/322 | 111 ++ tests/generic/322.out | 7

btrfs-progs tagged as v3.12

2013-11-25 Thread Chris Mason
Hi everyone, I've tagged the current btrfs-progs repo as v3.12. The new idea is that instead of making the poor distros pull from git, I'll be creating tagged releases at roughly the same pace as Linus cuts kernels. Given the volume of btrfs-progs patches, we should have enough new code and

Re: btrfs-progs tagged as v3.12

2013-11-25 Thread Martin
I'm humbly totally unqualified to comment but that sounds like an excellent idea. Thanks. I can't say for others but I was put off by the 0.19 forever eternal version which pushed me to investigate GIT... I'm sure that has been putting off many people including distro assemblers. Just for some

Re: btrfsck --repair /dev/sdc (Was: [PATCH] Btrfs-progs: allow --init-extent-tree to work when extent tree is borked)

2013-11-25 Thread Martin
On 20/11/13 20:00, Martin wrote: On 20/11/13 17:08, Duncan wrote: Martin posted on Wed, 20 Nov 2013 06:51:20 + as excerpted: It's now gone back to a pattern from a full week ago: (gdb) bt #0 0x0042d576 in read_extent_buffer () #1 0x0041ee79 in btrfs_check_node () #2

Re: btrfs scrub ioprio

2013-11-25 Thread Holger Hoffstaette
On Sun, 24 Nov 2013 22:45:59 -0500, Jim Salter wrote: TL;DR scrub's ioprio argument isn't really helpful - a scrub murders system performance til it's done. My system: 3.11 kernel (from Ubuntu Saucy) I don't run Ubuntu, but *maybe* they use the deadline IO scheduler by default, which

Re: [PATCH v3 00/17] Replace btrfs_workers with kernel workqueue based btrfs_workqueue_struct

2013-11-25 Thread Qu Wenruo
On Thu, 7 Nov 2013 12:54:56 -0500, Chris Mason wrote: Quoting Qu Wenruo (2013-11-07 00:51:50) Add a new btrfs_workqueue_struct which use kernel workqueue to implement most of the original btrfs_workers, to replace btrfs_workers. With this patchset, redundant workqueue codes are replaced with

[PATCH v2] xfstests,btrfs: add wrong compress type regression test

2013-11-25 Thread Miao Xie
Btrfs would crash when the users wrote some data into a file with compress flag but the compression of the fs was disabled. This test case is to check this bug still happen or not. Signed-off-by: Miao Xie mi...@cn.fujitsu.com --- Changlog v1 - v2: - address the commit from Dave Chinner. ---

missing /sbin/fsck.btrfs

2013-11-25 Thread Chris Murphy
Hi, Is there supposed to be an /sbin/fsck.btrfs? I'm seeing a handful of threads indicating some idea of having it just do a no-op like fsck.xfs does, but then also the idea that /etc/fstab should correctly set fs_passno to 0 instead of such trickery. I ask due to systemd-fstab-generator

Re: [PATCH v2] xfstests,btrfs: add wrong compress type regression test

2013-11-25 Thread Dave Chinner
On Tue, Nov 26, 2013 at 02:01:17PM +0800, Miao Xie wrote: Btrfs would crash when the users wrote some data into a file with compress flag but the compression of the fs was disabled. This test case is to check this bug still happen or not. Signed-off-by: Miao Xie mi...@cn.fujitsu.com ---

[PATCH v3] xfstests,btrfs: add wrong compress type regression test

2013-11-25 Thread Miao Xie
Btrfs would crash when the users wrote some data into a file with compress flag but the compression of the fs was disabled. This test case is to check this bug still happen or not. Signed-off-by: Miao Xie mi...@cn.fujitsu.com --- tests/btrfs/022 | 83

Re: [PATCH v2] xfstests,btrfs: add wrong compress type regression test

2013-11-25 Thread Miao Xie
On tue, 26 Nov 2013 17:41:07 +1100, Dave Chinner wrote: On Tue, Nov 26, 2013 at 02:01:17PM +0800, Miao Xie wrote: Btrfs would crash when the users wrote some data into a file with compress flag but the compression of the fs was disabled. This test case is to check this bug still happen or not.

Re: missing /sbin/fsck.btrfs

2013-11-25 Thread Duncan
Chris Murphy posted on Mon, 25 Nov 2013 23:40:49 -0700 as excerpted: Is there supposed to be an /sbin/fsck.btrfs? I'm seeing a handful of threads indicating some idea of having it just do a no-op like fsck.xfs does, but then also the idea that /etc/fstab should correctly set fs_passno to 0

Re: [PATCH v3 00/17] Replace btrfs_workers with kernel workqueue based btrfs_workqueue_struct

2013-11-25 Thread Liu Bo
On Tue, Nov 26, 2013 at 09:39:59AM +0800, Qu Wenruo wrote: On Thu, 7 Nov 2013 12:54:56 -0500, Chris Mason wrote: Quoting Qu Wenruo (2013-11-07 00:51:50) Add a new btrfs_workqueue_struct which use kernel workqueue to implement most of the original btrfs_workers, to replace btrfs_workers.

Re: missing /sbin/fsck.btrfs

2013-11-25 Thread dima
On 11/26/2013 04:18 PM, Duncan wrote: Chris Murphy posted on Mon, 25 Nov 2013 23:40:49 -0700 as excerpted: Is there supposed to be an /sbin/fsck.btrfs? I'm seeing a handful of threads indicating some idea of having it just do a no-op like fsck.xfs does, but then also the idea that /etc/fstab