Re: [PATCH v3] btrfs: allocate raid type kobjects dynamically

2014-05-27 Thread David Sterba
A different lockdep chain, from test btrfs/014: [ 229.850151] == [ 229.850788] [ INFO: possible circular locking dependency detected ] [ 229.850788] 3.15.0-rc7-default+ #146 Tainted: GW [ 229.850788]

Re: [PATCH v3] btrfs: allocate raid type kobjects dynamically

2014-05-27 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 5/27/14, 7:26 AM, David Sterba wrote: A different lockdep chain, from test btrfs/014: Are you sure this one was with the new patch? We shouldn't be holding groups_sem anymore in btrfs_remove_block_group while performing the kobject ops. - -Jeff

Re: [PATCH v3] btrfs: allocate raid type kobjects dynamically

2014-05-27 Thread David Sterba
On Tue, May 27, 2014 at 08:14:11AM -0400, Jeff Mahoney wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 5/27/14, 7:26 AM, David Sterba wrote: A different lockdep chain, from test btrfs/014: Are you sure this one was with the new patch? We shouldn't be holding groups_sem anymore

Re: [PATCH v2] Btrfs: set dead flag on the right root when destroying snapshot

2014-05-27 Thread David Sterba
On Sun, May 25, 2014 at 03:55:44AM +0100, Filipe David Borba Manana wrote: We were setting the BTRFS_ROOT_SUBVOL_DEAD flag on the root of the parent of our target snapshot, instead of setting it in the target snapshot's root. This is easy to observe by running the following scenario:

Re: [PATCH v3] btrfs: allocate raid type kobjects dynamically

2014-05-27 Thread Chris Mason
On 05/26/2014 09:35 PM, Jeff Mahoney wrote: We are currently allocating space_info objects in an array when we allocate space_info. When a user does something like: # btrfs balance start -mconvert=raid1 -dconvert=raid1 /mnt # btrfs balance start -mconvert=single -dconvert=single /mnt -f #

Re: [PATCH] Btrfs: clear compress-force when remounting with compress option

2014-05-27 Thread David Sterba
On Fri, May 23, 2014 at 11:36:52AM +0800, Wang Shilong wrote: --- a/fs/btrfs/super.c +++ b/fs/btrfs/super.c @@ -513,6 +513,14 @@ int btrfs_parse_options(struct btrfs_root *root, char *options) btrfs_info(root-fs_info,

[PATCH v4] btrfs: allocate raid type kobjects dynamically

2014-05-27 Thread Jeff Mahoney
We are currently allocating space_info objects in an array when we allocate space_info. When a user does something like: # btrfs balance start -mconvert=raid1 -dconvert=raid1 /mnt # btrfs balance start -mconvert=single -dconvert=single /mnt -f # btrfs balance start -mconvert=raid1 -dconvert=raid1

Re: [PATCH v4] btrfs: allocate raid type kobjects dynamically

2014-05-27 Thread Chris Mason
On 05/27/2014 12:59 PM, Jeff Mahoney wrote: We are currently allocating space_info objects in an array when we allocate space_info. When a user does something like: # btrfs balance start -mconvert=raid1 -dconvert=raid1 /mnt # btrfs balance start -mconvert=single -dconvert=single /mnt -f #

Re: [PATCH v4] btrfs: allocate raid type kobjects dynamically

2014-05-27 Thread Chris Mason
On 05/27/2014 01:08 PM, Chris Mason wrote: On 05/27/2014 12:59 PM, Jeff Mahoney wrote: We are currently allocating space_info objects in an array when we allocate space_info. When a user does something like: # btrfs balance start -mconvert=raid1 -dconvert=raid1 /mnt # btrfs balance start

Re: [PATCH v4] btrfs: allocate raid type kobjects dynamically

2014-05-27 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 5/27/14, 1:22 PM, Chris Mason wrote: On 05/27/2014 01:08 PM, Chris Mason wrote: On 05/27/2014 12:59 PM, Jeff Mahoney wrote: We are currently allocating space_info objects in an array when we allocate space_info. When a user does something

Re: [PATCH v4] btrfs: allocate raid type kobjects dynamically

2014-05-27 Thread Chris Mason
On 05/27/2014 01:20 PM, Jeff Mahoney wrote: - gpg control packet On 5/27/14, 1:22 PM, Chris Mason wrote: On 05/27/2014 01:08 PM, Chris Mason wrote: On 05/27/2014 12:59 PM, Jeff Mahoney wrote: We are currently allocating space_info objects in an array when we allocate space_info. When a

[PATCH] btrfs: free delayed node outside of root-inode_lock

2014-05-27 Thread Jeff Mahoney
On heavy workloads, we're seeing soft lockup warnings on root-inode_lock in __btrfs_release_delayed_node. The low hanging fruit is to reduce the size of the critical section. Signed-off-by: Jeff Mahoney je...@suse.com --- fs/btrfs/delayed-inode.c | 7 +-- 1 file changed, 5 insertions(+), 2

3.15-rc6 - btrfs-transacti:4157 blocked for more than 120 seconds.

2014-05-27 Thread Torbjørn
Hi, Btrfs-transaction keeps blocking for me on all 3.15-rc versions. 3.14 does not have this issue. The process never gets unstuck. btrfs fi sync does not help. A hard reboot seems to be the only way to recover. The volume is still readable when it's in this state. dmesg + sysrq-w is

Re: 3.15-rc6 - btrfs-transacti:4157 blocked for more than 120 seconds.

2014-05-27 Thread Chris Mason
On 05/27/2014 02:11 PM, Torbjørn wrote: Hi, Btrfs-transaction keeps blocking for me on all 3.15-rc versions. 3.14 does not have this issue. The process never gets unstuck. btrfs fi sync does not help. A hard reboot seems to be the only way to recover. The volume is still readable when

Re: 3.15.0-rc5: now sync and mount are hung on call_rwsem_down_write_failed

2014-05-27 Thread Chris Mason
On 05/23/2014 07:13 PM, Marc MERLIN wrote: On Fri, May 23, 2014 at 04:24:49PM -0400, Chris Mason wrote: I was able to kill btrfs send and receive, but mencoder is very hung, and sync does not finish either: 10654 merlin syncsync_inodes_sb 17191 merlin sync

Re: 3.15-rc6 - btrfs-transacti:4157 blocked for more than 120 seconds.

2014-05-27 Thread Torbjørn
On 05/27/2014 10:08 PM, Torbjørn wrote: On 05/27/2014 09:09 PM, Chris Mason wrote: On 05/27/2014 02:11 PM, Torbjørn wrote: Hi, Btrfs-transaction keeps blocking for me on all 3.15-rc versions. 3.14 does not have this issue. The process never gets unstuck. btrfs fi sync does not help. A hard

Re: 3.15-rc6 - btrfs-transacti:4157 blocked for more than 120 seconds.

2014-05-27 Thread Chris Mason
On 05/27/2014 04:42 PM, Torbjørn wrote: On 05/27/2014 10:08 PM, Torbjørn wrote: On 05/27/2014 09:09 PM, Chris Mason wrote: On 05/27/2014 02:11 PM, Torbjørn wrote: Hi, Btrfs-transaction keeps blocking for me on all 3.15-rc versions. 3.14 does not have this issue. The process never gets

Re: 3.15-rc6 - btrfs-transacti:4157 blocked for more than 120 seconds.

2014-05-27 Thread Chris Mason
On 05/27/2014 04:50 PM, Chris Mason wrote: On 05/27/2014 04:42 PM, Torbjørn wrote: On 05/27/2014 10:08 PM, Torbjørn wrote: On 05/27/2014 09:09 PM, Chris Mason wrote: On 05/27/2014 02:11 PM, Torbjørn wrote: Hi, Btrfs-transaction keeps blocking for me on all 3.15-rc versions. 3.14 does not

Re: [PATCH] Btrfs: clear compress-force when remounting with compress option

2014-05-27 Thread Wang Shilong
Hi David, On 05/28/2014 12:22 AM, David Sterba wrote: On Fri, May 23, 2014 at 11:36:52AM +0800, Wang Shilong wrote: --- a/fs/btrfs/super.c +++ b/fs/btrfs/super.c @@ -513,6 +513,14 @@ int btrfs_parse_options(struct btrfs_root *root, char *options)

Re: [PATCH] Btrfs-progs: fsck: add an option to check data csums

2014-05-27 Thread Wang Shilong
On 05/16/2014 11:40 PM, David Sterba wrote: On Thu, May 08, 2014 at 09:26:49AM +0800, Wang Shilong wrote: This patch adds an option '--check-data-csum' to verify data csums. fsck won't check data csums unless users specify this option explictly. Nice. +static int read_extent_data(struct

Re: 3.15-rc6 - btrfs-transacti:4157 blocked for more than 120 seconds.

2014-05-27 Thread Torbjørn
On 27. mai 2014 23:15, Chris Mason wrote: On 05/27/2014 04:50 PM, Chris Mason wrote: On 05/27/2014 04:42 PM, Torbjørn wrote: On 05/27/2014 10:08 PM, Torbjørn wrote: On 05/27/2014 09:09 PM, Chris Mason wrote: On 05/27/2014 02:11 PM, Torbjørn wrote: Hi, Btrfs-transaction keeps blocking for