Re: 3.15-rc5 deadlocked a 2nd time after I was copying photos from an sdcard + common code path that deadlocks all btrfs filesystems

2014-06-17 Thread Satoru Takeuchi
Hi Marc, (2014/05/19 22:49), Marc MERLIN wrote: Ok, that's 2 out of 2. I was copying pictures from an sdcard (through mmcblk0), and the filesystem deadlocked. Unfortunately, when this happens, I copied my pictures (which were still in RAM) to my 2nd drive which was also btrfs. From your

[PATCH v3] btrfs-progs: Add human readable flags output for chunk/block group type.

2014-06-17 Thread Qu Wenruo
Current btrfs-debug-tree output chunk/block group type as numbers, which makes it hard to understand and need to check the source to understand the meaning. This patch will convert numeric type output to human readable strings. Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com --- changelog: v2:

Re: Slow startup of systemd-journal on BTRFS

2014-06-17 Thread Duncan
Martin Steigerwald posted on Sun, 15 Jun 2014 23:31:07 +0200 as excerpted: I always thought that the whole point of fallocate is that it *doesn´t* write out anything, but just reserves the space. Thus I don´t see how COW can have any adverse effect here. Tying up loose ends... I was wrong on

Re: [systemd-devel] Slow startup of systemd-journal on BTRFS

2014-06-17 Thread Martin
On 17/06/14 02:13, cwillu wrote: It's not a mmap problem, it's a small writes with an msync or fsync after each one problem. And for logging, that is exactly what is wanted to see why whatever crashed... Except... Whilst logging, hold off on the msync/fsync unless the next log message to be

[PATCH 16/24] btrfs: return actual error on btrfs_init_sysfs

2014-06-17 Thread Jeff Liu
From: Jie Liu jeff@oracle.com Return the actual error code if call kset_create_and_add() failed Cc: Chris Mason c...@fb.com Cc: Josef Bacik jba...@fb.com Signed-off-by: Jie Liu jeff@oracle.com --- fs/btrfs/sysfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

frustrations with handling of crash reports

2014-06-17 Thread Marc MERLIN
On Tue, Jun 17, 2014 at 03:29:19PM +0900, Satoru Takeuchi wrote: after that? Here try to reproduce with 3.16-rc1 is desirable. As for 3.16-rc1, my problem, and this is not targetted at you, just a general unfortunate observation of my last months of btrfs testing and reorts. I use btrfs on real

No more snapshot aware defrag ?

2014-06-17 Thread Swâmi Petaramesh
Hi there, Heck ! I discovered from the wiki https://btrfs.wiki.kernel.org/index.php/UseCases#How_do_I_defragment_many_files.3F ...That defrag, which used to be snapshot-aware, isn't anymore :-/ ...And /me am still defraggging my snapshotted system on a regular basis :-( Is there any plan to

Re: [systemd-devel] Slow startup of systemd-journal on BTRFS

2014-06-17 Thread Chris Murphy
On Jun 16, 2014, at 7:13 PM, cwillu cwi...@cwillu.com wrote: It's not a mmap problem, it's a small writes with an msync or fsync after each one problem. For the case of sequential writes (via write or mmap), padding writes to page boundaries would help, if the wasted space isn't an issue.

Re: No more snapshot aware defrag ?

2014-06-17 Thread Chris Murphy
On Jun 17, 2014, at 11:27 AM, Swâmi Petaramesh sw...@petaramesh.org wrote: Hi there, Heck ! I discovered from the wiki https://btrfs.wiki.kernel.org/index.php/UseCases#How_do_I_defragment_many_files.3F ...That defrag, which used to be snapshot-aware, isn't anymore :-/ ...And /me am

Re: Transaction commit: none (default)

2014-06-17 Thread Marc MERLIN
On Mon, Jun 16, 2014 at 07:06:08AM +, Holger Hoffstätte wrote: If it annoys other people, maybe having a -q (quiet) that removes this message would be useful? IMHO it should be the reverse: be quiet by default and require -v, just as more explicit behaviour also requires additional

[3.16-rc1] BUG: fsync not finishing during rootfs mount (getty doesn't finish)

2014-06-17 Thread Jérôme Carretero
Hi, I updated 2 computers to 3.16-rc1 and they both did the same thing when mounting the rootfs: after entering the login/password, the shell didn't appear. 120 seconds later, there is a message about a hung task, it's about fsync not finishing, with a traceback showing SyS_fsync / ... /

Re: frustrations with handling of crash reports

2014-06-17 Thread Marc MERLIN
On Tue, Jun 17, 2014 at 07:59:57AM -0700, Marc MERLIN wrote: It is also ok to answer Any FS created or used before kernel 3.x can be corrupted due to bugs we fixed in 3.y, thank you for your report but it's not a good use of our time to investigate this (although newer kernels should not just

Re: btrfs balance crash BUG ON fs/btrfs/relocation.c:1062 or RIP build_backref_tree+0x9fc/0xcc4

2014-06-17 Thread Josef Bacik
On 06/09/2014 04:40 PM, Marc MERLIN wrote: I did a balance on a system that had 3.11 (yes, I know, it's old). It hung. So, I rebooted with 3.13, and it failed in fs/btrfs/relocation Problem #1: I cannot stop the relocation. It starts on its own as soon as I mount the FS, and I can't stop it. Is

Re: [systemd-devel] Slow startup of systemd-journal on BTRFS

2014-06-17 Thread Filipe Brandenburger
On Mon, Jun 16, 2014 at 6:13 PM, cwillu cwi...@cwillu.com wrote: For the case of sequential writes (via write or mmap), padding writes to page boundaries would help, if the wasted space isn't an issue. Another approach, again assuming all other writes are appends, would be to periodically (but

Re: btrfs balance crash BUG ON fs/btrfs/relocation.c:1062 or RIP build_backref_tree+0x9fc/0xcc4

2014-06-17 Thread Marc MERLIN
On Tue, Jun 17, 2014 at 11:29:57AM -0700, Josef Bacik wrote: I'm sure that filesystem is damaged in some way, but the kernel of course should not crash. I don't have this mail client setup right to send patches, can you just go into relocation.c in build_backref_tree and remove the

Re: [PATCH v3] Btrfs: fix hang on error (such as ENOSPC) when writing extent pages

2014-06-17 Thread Marc MERLIN
On Fri, May 09, 2014 at 05:17:40PM +0100, Filipe David Borba Manana wrote: When running low on available disk space and having several processes doing buffered file IO, I got the following trace in dmesg: I was building 3.15.1 and noticed this patch didn't make it in (your other 2 btrfs send

Re: [systemd-devel] Slow startup of systemd-journal on BTRFS

2014-06-17 Thread Goffredo Baroncelli
On 06/17/2014 08:46 PM, Filipe Brandenburger wrote: On Mon, Jun 16, 2014 at 6:13 PM, cwillu cwi...@cwillu.com wrote: For the case of sequential writes (via write or mmap), padding writes to page boundaries would help, if the wasted space isn't an issue. Another approach, again assuming all

Re: [systemd-devel] Slow startup of systemd-journal on BTRFS

2014-06-17 Thread Lennart Poettering
On Mon, 16.06.14 09:05, Josef Bacik (jba...@fb.com) wrote: So you are doing all the right things from what I can tell, I'm just a little confused about when you guys run fsync. From what I can tell it's only when you open the journal file and when you switch it to offline. I didn't look too

Re: [PATCH v4] lib: add size unit t/p/e to memparse

2014-06-17 Thread David Rientjes
On Fri, 13 Jun 2014, Gui Hecheng wrote: For modern filesystems such as btrfs, t/p/e size level operations are common. add size unit t/p/e parsing to memparse Signed-off-by: Gui Hecheng guihc.f...@cn.fujitsu.com Acked-by: David Rientjes rient...@google.com Sorry, didn't do this before.

Re: [PATCH v4] lib: add size unit t/p/e to memparse

2014-06-17 Thread Satoru Takeuchi
Hi Gui, (2014/06/18 7:21), David Rientjes wrote: On Fri, 13 Jun 2014, Gui Hecheng wrote: For modern filesystems such as btrfs, t/p/e size level operations are common. add size unit t/p/e parsing to memparse Signed-off-by: Gui Hecheng guihc.f...@cn.fujitsu.com Acked-by: David Rientjes

Re: [PATCH 16/24] btrfs: return actual error on btrfs_init_sysfs

2014-06-17 Thread Jeff Liu
Hi, On 06/17/2014 22:32 PM, Jeff Liu wrote: From: Jie Liu jeff@oracle.com Return the actual error code if call kset_create_and_add() failed Cc: Chris Mason c...@fb.com Cc: Josef Bacik jba...@fb.com Signed-off-by: Jie Liu jeff@oracle.com Please ignore this patch because Greg

Re: commit 762380a block: add notion of a chunk size for request merging stops io on btrfs

2014-06-17 Thread Jens Axboe
On 2014-06-17 14:35, Konstantinos Skarlatos wrote: Hi all, with 3.16-rc1 rsync stops writing to my btrfs filesystem and stays at a D+ state. git bisect showed that the problematic commit is: 762380ad9322951cea4ce9d24864265f9c66a916 is the first bad commit commit

Re: [PATCH] Fix a use-after-free in the volumes code.

2014-06-17 Thread Satoru Takeuchi
Hi Adam, (2014/06/14 8:43), Adam Buchbinder wrote: When a struct btrfs_fs_devices was being torn down by btrfs_close_devices(), there was an invalidated pointer in the global list fs_uuids which still pointed to it; if a device was closed and then reopened (which btrfs-convert does), freed

[PATCH] btrfs-progs: clean fsck noise for free inode generation 0

2014-06-17 Thread Gui Hecheng
When we write a btrfs to full and then we have no space left for free space cache. The btrfs check will output msg as follows which is noise indeed: # free space inode generation (0) did not match free space cache generation (XXX) When the free space cache is not written out