On 06/18/2014 07:23 PM, Joseph Salisbury wrote:
BugLink: http://bugs.launchpad.net/bugs/1324953
Hello,
Please consider including upstream commit c41570c9 in the next v3.13.y
release. It was included upstream as of v3.14-rc2. It has been tested and
confirmed to resolve
Hi Chris,
any reason why the patches 1-5 were not added to 3.16 queue?
On Tue, Jun 03, 2014 at 11:35:58AM +0800, Anand Jain wrote:
btrfs: rename add_device_membership to btrfs_kobj_add_device
btrfs: dev delete should remove sysfs entry
btrfs: dev add should add its sysfs entry
btrfs:
Hi Chris,
two minor fixups for patches merged in rc1
You can also pull that from
git://repo.or.cz/linux-2.6/btrfs-unstable.git for-chris/3.16-rc2
with top commit b934864cc8b08eb358748b06468b9cca64026c1e,
based on current for-linus 8408c716d7a4ddd5954ce33f53a7d3cd2876cf65
Thanks.
David Sterba
Commit fcebe4562dec83b3f8d3088d77584727b09130b2 (Btrfs: rework qgroup
accounting) removed the qgroup accounting after delayed refs.
Signed-off-by: David Sterba dste...@suse.cz
---
fs/btrfs/transaction.c |5 -
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git
Return codes got updated in 60e1975acb48fc3d74a3422b21dde74c977ac3d5
(btrfs: return errno instead of -1 from compression)
lzo wrapper returns E2BIG in this case, do the same for zlib.
Signed-off-by: David Sterba dste...@suse.cz
---
fs/btrfs/zlib.c |2 +-
1 files changed, 1 insertions(+), 1
The comment applied when there was a BUG_ON.
Signed-off-by: David Sterba dste...@suse.cz
---
fs/btrfs/transaction.c |5 +
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/fs/btrfs/transaction.c b/fs/btrfs/transaction.c
index 511839c04f11..da77045785dc 100644
---
Hi Chris,
this is a set of whole-directory changes that have low impact on stability
(xfstests passed), but touch almost all files aiming for simpler code.
I did not catch the merge window train, so I'm leaving it to your consideration
if you add it to the upcomming pull request(s).
I'm sending
Signed-off-by: David Sterba dste...@suse.cz
---
fs/btrfs/relocation.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/fs/btrfs/relocation.c b/fs/btrfs/relocation.c
index 65245a07275b..b3329ad34522 100644
--- a/fs/btrfs/relocation.c
+++ b/fs/btrfs/relocation.c
@@ -4096,7
There's no user of the return value and we can get rid of the comment in
put_super.
Signed-off-by: David Sterba dste...@suse.cz
---
fs/btrfs/disk-io.c |4 +---
fs/btrfs/disk-io.h |2 +-
fs/btrfs/super.c |8 +---
3 files changed, 3 insertions(+), 11 deletions(-)
diff --git
The nodesize and leafsize were never of different values. Unify the
usage and make nodesize the one. Cleanup the redundant checks and
helpers.
Shaves a few bytes from .text:
textdata bss dec hex filename
852418 24560 23112 900090 dbbfa btrfs.ko.before
851074 24584
The naming is confusing, generic yet used for a specific cache. Add a
prefix 'ino_' or rename appropriately.
Signed-off-by: David Sterba dste...@suse.cz
---
fs/btrfs/ctree.h| 10 +++---
fs/btrfs/disk-io.c |6 ++--
fs/btrfs/free-space-cache.c | 14
Only wraps the ALIGN macro.
Signed-off-by: David Sterba dste...@suse.cz
---
fs/btrfs/extent-tree.c | 11 +--
1 files changed, 1 insertions(+), 10 deletions(-)
diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
index 177a544630ff..1cfc12f075a3 100644
---
The form
(value + PAGE_CACHE_SIZE - 1) PAGE_CACHE_SHIFT
is equivalent to
(value + PAGE_CACHE_SIZE - 1) / PAGE_CACHE_SIZE
The rest is a simple subsitution, no difference in the generated
assembly code.
Signed-off-by: David Sterba dste...@suse.cz
---
fs/btrfs/check-integrity.c |3 +--
btrfs_set_key_type and btrfs_key_type are used inconsistently along with
open coded variants. Other members of btrfs_key are accessed directly
without any helpers anyway.
Signed-off-by: David Sterba dste...@suse.cz
---
fs/btrfs/backref.c |4 ++--
fs/btrfs/delayed-inode.c |8
Steps to reproduce:
# mkfs.btrfs -f /dev/sda9 -b 2g
# mount /dev/sda9 /mnt
# dd if=/dev/zero of=/mnt/data bs=4k oflag=direct
# btrfs file df /mnt
Data, single: total=1.66GiB, used=1.66GiB
System, single: total=4.00MiB, used=16.00KiB
Metadata, single: total=200.00MiB,
On Thu, Jun 19, 2014 at 04:17:25PM -0700, Josef Bacik wrote:
We don't pay attention to the return value, we should probably abort the
transaction if there is a problem.
Abort or log an error and continue? I ask because technically we could
continue with the subvolume drop but obviously
The level should express the severity, so anything that leads to a
failed mount gets ERROR level, if it's possible continue then WARNING,
and informative messages are INFO.
Signed-off-by: David Sterba dste...@suse.cz
---
fs/btrfs/disk-io.c | 32
1 file changed,
The level should express the severity, so anything that leads to a
failed mount gets ERROR level, if it's possible continue then WARNING,
and informative messages are INFO.
Signed-off-by: David Sterba dste...@suse.cz
---
v2: s/btrfs_error/btrfs_err/, unrefreshed patch sent
fs/btrfs/disk-io.c |
On 06/18/2014 09:52 PM, Ben Hutchings wrote:
On Wed, 2014-06-18 at 14:32 -0400, Joseph Salisbury wrote:
From: Sander Eikelenboom li...@eikelenboom.it
BugLink: http://bugs.launchpad.net/bugs/1319457
This (widely used) construction:
if(printk_ratelimit())
dev_dbg()
Causes the
On Fri, Jun 20, 2014 at 01:25:34PM +0200, David Sterba wrote:
On Thu, Jun 19, 2014 at 04:17:25PM -0700, Josef Bacik wrote:
We don't pay attention to the return value, we should probably abort the
transaction if there is a problem.
Abort or log an error and continue? I ask because
On 06/20/2014 05:53 AM, David Sterba wrote:
Hi Chris,
any reason why the patches 1-5 were not added to 3.16 queue?
On Tue, Jun 03, 2014 at 11:35:58AM +0800, Anand Jain wrote:
btrfs: rename add_device_membership to btrfs_kobj_add_device
btrfs: dev delete should remove sysfs entry
On 06/20/2014 05:53 AM, David Sterba wrote:
Hi Chris,
any reason why the patches 1-5 were not added to 3.16 queue?
On Tue, Jun 03, 2014 at 11:35:58AM +0800, Anand Jain wrote:
btrfs: rename add_device_membership to btrfs_kobj_add_device
btrfs: dev delete should remove sysfs entry
On 06/19/2014 05:53 PM, Marc MERLIN wrote:
On Thu, Jun 19, 2014 at 03:50:16PM -0700, Josef Bacik wrote:
Ok same drill as before, reset and apply this, hopefully no panic this time
diff --git a/fs/btrfs/relocation.c b/fs/btrfs/relocation.c
index 65245a0..bca5240 100644
Ok I see what it is
On 06/20/2014 08:29 AM, Mark Fasheh wrote:
On Fri, Jun 20, 2014 at 01:25:34PM +0200, David Sterba wrote:
On Thu, Jun 19, 2014 at 04:17:25PM -0700, Josef Bacik wrote:
We don't pay attention to the return value, we should probably abort the
transaction if there is a problem.
Abort or log an
Hi Linus,
Please pull my for-linus branch:
git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus
This fixes some lockups in btrfs reported with rc1. It probably has
some performance impact because it is backing off our spinning locks
more often and switching to a
We had intended to return a negative error code here, but we use the
wrong variable so it returns success.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/fs/btrfs/tests/btrfs-tests.c b/fs/btrfs/tests/btrfs-tests.c
index 9626252..8e7225f 100644
---
Maybe else if was meant, but because of the goto out_unlock, it
doesn't make a difference. Anyway, I chose the only whitespace fix.
Signed-off-by: Rasmus Villemoes li...@rasmusvillemoes.dk
---
fs/btrfs/tree-log.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
Signed-off-by: Nils Steinger g...@n-st.de
---
Documentation/Makefile | 4
Makefile | 9 +
2 files changed, 13 insertions(+)
diff --git a/Documentation/Makefile b/Documentation/Makefile
index 45299bb..5c9780b 100644
--- a/Documentation/Makefile
+++
I compiled and installed the btrfs-progs from the git repo on several systems,
but later decided to switch back to the version from Debian's package
repository.
The Makefile did not contain an 'uninstall' target to complement 'install', so
I created one that reverses all changes made by 'install'
On 06/20/2014 12:51 PM, Rasmus Villemoes wrote:
Maybe else if was meant, but because of the goto out_unlock, it
doesn't make a difference. Anyway, I chose the only whitespace fix.
Signed-off-by: Rasmus Villemoes li...@rasmusvillemoes.dk
---
fs/btrfs/tree-log.c | 3 ++-
1 file changed, 2
Hi,
It may be caused by an corrupted btrfs filesystem due to the repeating hanging
during the test. As long as your guys don't any problem, I am happy with the
patch.
Thank,
Longman
-Original Message-
From: Tsutomu Itoh [mailto:t-i...@jp.fujitsu.com]
Sent: Thursday, June 19, 2014
31 matches
Mail list logo
