Re: [PATCH v5] Btrfs: make fsync work after cloning into a file

2014-06-29 Thread Chris Mason
On 06/08/2014 10:48 PM, Filipe David Borba Manana wrote: When cloning into a file, we were correctly replacing the extent items in the target range and removing the extent maps. However we weren't replacing the extent maps with new ones that point to the new extents - as a consequence, an

Scrub being stuck

2014-06-29 Thread Florian Lindner
Hello, I've just completed a scrub on my home filesystem and now I wanted to start on my Archiv btrfs RAID 0. root@horus ~ # uname - a

Re: Scrub being stuck

2014-06-29 Thread Florian Lindner
Florian Lindner wrote: Hello, I've just completed a scrub on my home filesystem and now I wanted to start on my Archiv btrfs RAID 0. Amendment: anything btrfs related dmesg shows is [ 38.240950] BTRFS info (device sdd1): csum failed ino 314 off 4129595392 csum 1774389615 expected csum

btrfs send/receive test failing

2014-06-29 Thread Sam Bull
I'm trying out the btrfs send|receive command as shown on the incremental backup wiki page, but the command is failing. I've tried it with sudo as it had not permitted errors, but still no luck. The output is: s@s-Air:~$ btrfs send /home/BACKUP | btrfs receive

[PATCH] Btrfs: fix use-after-free when cloning a trailing file hole

2014-06-29 Thread Filipe David Borba Manana
The transaction handle was being used after being freed. Cc: Chris Mason c...@fb.com Signed-off-by: Filipe David Borba Manana fdman...@gmail.com --- fs/btrfs/ioctl.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index

Re: [PATCH] Btrfs: fix use-after-free when cloning a trailing file hole

2014-06-29 Thread Chris Mason
On 06/29/2014 03:43 PM, Filipe David Borba Manana wrote: The transaction handle was being used after being freed. Cc: Chris Mason c...@fb.com Signed-off-by: Filipe David Borba Manana fdman...@gmail.com --- fs/btrfs/ioctl.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-)

Re: [PATCH] Btrfs: fix use-after-free when cloning a trailing file hole

2014-06-29 Thread Filipe David Manana
On Sun, Jun 29, 2014 at 8:23 PM, Chris Mason c...@fb.com wrote: On 06/29/2014 03:43 PM, Filipe David Borba Manana wrote: The transaction handle was being used after being freed. Cc: Chris Mason c...@fb.com Signed-off-by: Filipe David Borba Manana fdman...@gmail.com --- fs/btrfs/ioctl.c | 6

[PATCH v2] Btrfs: fix use-after-free when cloning a trailing file hole

2014-06-29 Thread Filipe David Borba Manana
The transaction handle was being used after being freed. Cc: Chris Mason c...@fb.com Signed-off-by: Filipe David Borba Manana fdman...@gmail.com --- V2: Removed file extent item argument to clone_update_extent_map() for more clarity. fs/btrfs/ioctl.c | 20 +--- 1 file

Re: Blocked tasks on 3.15.1

2014-06-29 Thread Cody P Schafer
On Fri, Jun 27, 2014 at 7:22 PM, Chris Samuel ch...@csamuel.org wrote: On Fri, 27 Jun 2014 05:20:41 PM Duncan wrote: If I'm not mistaken the fix for the 3.16 series bug was: ea4ebde02e08558b020c4b61bb9a4c0fcf63028e Btrfs: fix deadlocks with trylock on tree nodes. That patch applies

Re: Blocked tasks on 3.15.1

2014-06-29 Thread Cody P Schafer
On Sun, Jun 29, 2014 at 3:02 PM, Cody P Schafer d...@codyps.com wrote: On Fri, Jun 27, 2014 at 7:22 PM, Chris Samuel ch...@csamuel.org wrote: On Fri, 27 Jun 2014 05:20:41 PM Duncan wrote: If I'm not mistaken the fix for the 3.16 series bug was: ea4ebde02e08558b020c4b61bb9a4c0fcf63028e

Re: Scrub being stuck

2014-06-29 Thread Holger Hoffstätte
On Sun, 29 Jun 2014 19:14:28 +0200, Florian Lindner wrote: A scrub I started at Jan 02 seems to be stuck somehow. The command outputs above were generated right now. http://marc.merlins.org/perso/btrfs/post_2014-04-26_Btrfs-Tips_-Cancel-A- Btrfs-Scrub-That-Is-Already-Stopped.html cheers

Re: [PATCH 5/6] btrfs-progs: limit minimal num of args for btrfs-image

2014-06-29 Thread Gui Hecheng
On Fri, 2014-06-27 at 14:35 +0200, David Sterba wrote: On Thu, Jun 26, 2014 at 10:53:05AM +0800, Gui Hecheng wrote: @@ -2521,6 +2521,9 @@ int main(int argc, char *argv[]) } argc = argc - optind; + if (argc 2) Please use the check_argc_min helper instead. Thanks. Yes,

Re: [PATCH] btrfs: fix nossd and ssd_spread mount option regression

2014-06-29 Thread Qu Wenruo
Oh, my bad, sorry for the SSD related mount options mess. Thanks for the patch fixing the bug, comments inlined below. Original Message Subject: [PATCH] btrfs: fix nossd and ssd_spread mount option regression From: Eric Sandeen sand...@redhat.com To: linux-btrfs

Re: Can't mount subvolume with ro option

2014-06-29 Thread Qu Wenruo
Original Message Subject: Re: Can't mount subvolume with ro option From: Sébastien ROHAUT sebastien.roh...@free.fr To: Chris Murphy li...@colorremedies.com Date: 2014年06月28日 19:02 Le 28/06/2014 00:12, Chris Murphy a écrit : On Jun 27, 2014, at 4:08 PM, Chris Murphy

Re: Blocked tasks on 3.15.1

2014-06-29 Thread Rich Freeman
On Fri, Jun 27, 2014 at 8:22 PM, Chris Samuel ch...@csamuel.org wrote: On Fri, 27 Jun 2014 05:20:41 PM Duncan wrote: If I'm not mistaken the fix for the 3.16 series bug was: ea4ebde02e08558b020c4b61bb9a4c0fcf63028e Btrfs: fix deadlocks with trylock on tree nodes. That patch applies

[PATCH v2] Btrfs: clear compress-force when remounting with compress option

2014-06-29 Thread Wang Shilong
Steps to reproduce: # mkfs.btrfs -f /dev/sdb # mount /dev/sdb /mnt -o compress-force=lzo # mount /dev/sdb /mnt -o remount,compress=zlib # cat /proc/mounts Remounting from compress-force to compress could not clear compress-force option. The problem is there is no way for users to clear

Re: Can't mount subvolume with ro option

2014-06-29 Thread Qu Wenruo
Original Message Subject: Re: Can't mount subvolume with ro option From: Qu Wenruo quwen...@cn.fujitsu.com To: Sébastien ROHAUT sebastien.roh...@free.fr, Chris Murphy li...@colorremedies.com Date: 2014年06月30日 10:19 Original Message Subject: Re: Can't mount

Re: Can't mount subvolume with ro option

2014-06-29 Thread Chris Murphy
On Jun 29, 2014, at 8:57 PM, Qu Wenruo quwen...@cn.fujitsu.com wrote: Finally find the stable method to reproduce the problem on 3.16-rc2, the point is if we mount subvol,ro first, then you can't mount the hole device: # mkfs.btrfs -f /dev/sda6 # mount /dev/sda6 /mnt/btrfs/ # btrfs

[PATCH] Btrfs: fix race of using total_bytes_pinned

2014-06-29 Thread Liu Bo
This percpu counter @total_bytes_pinned is introduced to skip unnecessary operations of 'commit transaction', it accounts for those space we may free but are stuck in delayed refs. And we zero out @space_info-total_bytes_pinned every transaction period so we have a better idea of how much space

[PATCH v2 2/2] btrfs-progs: limit minimal num of args for btrfs-image

2014-06-29 Thread Gui Hecheng
The btrfs-image requires at least 2 args to run, one for the source dev/file, the other for the target dev/file. This patch depends on patch: btrfs-progs: move the check_argc_* functions into utils.c Signed-off-by: Gui Hecheng guihc.f...@cn.fujitsu.com --- changelog v1-v2: use

[PATCH 1/2] btrfs-progs: move the check_argc_* functions into utils.c

2014-06-29 Thread Gui Hecheng
To let the independent tools(e.g. btrfs-image, btrfs-convert, etc.) share the convenience of check_argc_* functions, just move it into utils.c. Also add a new function set_argv0 to set the correct tool name: *btrfs-image*: too few arguments The original btrfs* tools work as before.