[PATCH v2] btrfs-progs: fix uninitialized warining in btrfs_calc_stripe_index

2014-10-07 Thread Anand Jain
From: Anand Jain anand.j...@oracle.com chunk-recover.c: In function ‘btrfs_calc_stripe_index’: chunk-recover.c:1481: warning: ‘index’ may be used uninitialized in this function Signed-off-by: Anand Jain anand.j...@oracle.com --- v2: Accept David review comment chunk-recover.c | 4 +++- 1 file

[PATCH v3] btrfs-progs: fix uninitialized warning in btrfs_calc_stripe_index

2014-10-07 Thread Anand Jain
From: Anand Jain anand.j...@oracle.com chunk-recover.c: In function ‘btrfs_calc_stripe_index’: chunk-recover.c:1481: warning: ‘index’ may be used uninitialized in this function Signed-off-by: Anand Jain anand.j...@oracle.com --- v3: fix typo in commit v2: Accept David review comment

[PATCH v4] btrfs-progs: fix uninitialized warning in btrfs_calc_stripe_index

2014-10-07 Thread Anand Jain
From: Anand Jain anand.j...@oracle.com chunk-recover.c: In function btrfs_calc_stripe_index chunk-recover.c:1481: warning: index may be used uninitialized in this function Signed-off-by: Anand Jain anand.j...@oracle.com --- v4: remove some unintended char in commit, sorry v3: fix typo in commit

[PATCH] btrfs-progs: Always return positive value to avoid meaningless return value

2014-10-07 Thread Qu Wenruo
btrfs command may return minus value, however most shell only supports return value in range [0,255], so minus return value will overflow, which is quite confusing for end user. This patch will do the minus check return value check before return it to shell for all the btrfs-progs commands. Also

[PATCH] btrfs: test mount btrfs subvolume with selinux context

2014-10-07 Thread Eryu Guan
If one subvolume was mounted with selinux context, other subvolumes should be able to be mounted with the same selinux context too. Cc: Qu Wenruo quwen...@cn.fujitsu.com Signed-off-by: Eryu Guan eg...@redhat.com --- Note that this is based on my btrfs stress test patches. [PATCH v5 00/15]

[PATCH] btrfs-progs: btrfs_scan_block_devices is unused function delete it

2014-10-07 Thread Anand Jain
After Patch: remove BTRFS_SCAN_PROC scan method There isn't any consumer for btrfs_scan_block_devices() so delete it. Signed-off-by: Anand Jain anand.j...@oracle.com --- utils.c | 83 - utils.h | 1 - 2 files changed, 84

Check ping

2014-10-07 Thread Gui Hecheng
Check ping -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Fwd: Re: [PATCH] btrfs: add more superblock checks

2014-10-07 Thread Qu Wenruo
Previous reply seems failed to be delivered. Resend. 转发的消息 主题: Re: [PATCH] btrfs: add more superblock checks 日期: Tue, 07 Oct 2014 16:44:07 +0800 发件人:Qu Wenruo quwen...@cn.fujitsu.com 收件人:David Sterba dste...@suse.cz, linux-btrfs@vger.kernel.org Thanks a lot

Identify mounted subvolume

2014-10-07 Thread Juan Orti Alcaine
I cannot find the answer to this one. How can I determine which subvolume I have mounted in a certain path? I'm looking through /sys but no clue. Thank you. -- Juan Orti https://miceliux.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to

Re: Identify mounted subvolume

2014-10-07 Thread Hugo Mills
On Tue, Oct 07, 2014 at 10:47:56AM +0200, Juan Orti Alcaine wrote: I cannot find the answer to this one. How can I determine which subvolume I have mounted in a certain path? I'm looking through /sys but no clue. Rumour has it that /proc/self/mountinfo is meant to have the information, but

Re: Identify mounted subvolume

2014-10-07 Thread Qu Wenruo
Original Message Subject: Re: Identify mounted subvolume From: Hugo Mills h...@carfax.org.uk To: Juan Orti Alcaine juan.o...@miceliux.com Date: 2014年10月07日 17:06 On Tue, Oct 07, 2014 at 10:47:56AM +0200, Juan Orti Alcaine wrote: I cannot find the answer to this one. How can I

Re: btrfs send and kernel 3.17

2014-10-07 Thread Chris Mason
On Tue, Oct 7, 2014 at 1:25 AM, David Arendt ad...@prnet.org wrote: I did a revert of this commit. After creating a snapshot, the filesystem was no longer usable, even with kernel 3.16.3 (crashes 10 seconds after mount without error message) . Maybe there was some previous damage that just

[Bug] 3.17.0 mixed-bg enospc but both btrfs fi show and btrfs fi df say there's plenty

2014-10-07 Thread Duncan
This is with my small 256 MiB btrfs mixed-bg dup-mode /boot, or actually, with its backup (same size partition, different device). Kernel 3.17.0, btrfs-progs 3.16.1 (both actually from git), gentoo. It was time to renew my backups so I did a mkfs.btrfs on the backup to start fresh:

Re: [Bug] 3.17.0 mixed-bg enospc but both btrfs fi show and btrfs fi df say there's plenty

2014-10-07 Thread Duncan
Duncan posted on Tue, 07 Oct 2014 13:41:49 + as excerpted: FWIW, if I try to cp it instead of using mc, 14208 KiB copies before I get the enospc. Interesting workaround I just found: 1) cp the file and let the cp abort. 2) delete the partial copy 3) mc-copy the file. 4) watch the full

[PATCH] btrfs-progs: add option to disable backtrace usage

2014-10-07 Thread Gustavo Zacarias
This commit adds the support for a make variable named DISABLE_BACKTRACE which allows to disable the support for backtrace() usage on ASSERT(), BUG() and BUG_ON() calls. This is useful because some alternative C libraries like uClibc have optional support for backtrace() which is rarely built when

[PATCH] Btrfs: fix incorrect compression ratio detection

2014-10-07 Thread Wang Shilong
Steps to reproduce: # mkfs.btrfs -f /dev/sdb # mount -t btrfs /dev/sdb /mnt -o compress=lzo # dd if=/dev/zero of=/mnt/data bs=$((33*4096)) count=1 after previous steps, inode will be detected as bad compression ratio, and NOCOMPRESS flag will be set for that inode. Reason is that compress

Re: [x86, locking/rwlocks, btrfs] INFO: rcu_sched self-detected stall on CPU

2014-10-07 Thread Waiman Long
On 10/04/2014 06:06 AM, Chuck Ebbert wrote: On Fri, 03 Oct 2014 23:27:58 -0400 Waiman Longwaiman.l...@hp.com wrote: On 10/03/2014 09:33 AM, Fengguang Wu wrote: Hi Waiman, FYI, we noticed the below changes on commit bd01ec1a13f9a327950c8e3080096446c7804753 (x86, locking/rwlocks: Enable

[PATCH] xfstests: add regression for inode bad compression ratio detection

2014-10-07 Thread Wang Shilong
This test add a regression test to make sure btrfs dosen't set inode NOCOMPRESS flag when a small write(=blocksize) happens. Signed-off-by: Wang Shilong wangshilong1...@gmail.com --- Test is a little relying on btrfs now have a max 128k limit write, not sure whether it is good since it is

[PATCH] btrfs-progs: rework calculations of fi usage

2014-10-07 Thread David Sterba
This patch reworks the basic calculations of 'fi usage'. It does not address all problems but should make the code more prepared to do so. The original code tries to estimate the free space that could lead to negative numbers for some raid profiles: Data, RAID1: total=147.00GiB, used=141.92GiB

Re: [PATCH] xfstests: add regression for inode bad compression ratio detection

2014-10-07 Thread Dave Chinner
On Tue, Oct 07, 2014 at 07:20:49PM -0400, Wang Shilong wrote: This test add a regression test to make sure btrfs dosen't set inode NOCOMPRESS flag when a small write(=blocksize) happens. Signed-off-by: Wang Shilong wangshilong1...@gmail.com ... +rm -f $seqres.full + +_scratch_mkfs

Re: btrfs send and kernel 3.17

2014-10-07 Thread David Arendt
On 10/07/2014 03:19 PM, Chris Mason wrote: On Tue, Oct 7, 2014 at 1:25 AM, David Arendt ad...@prnet.org wrote: I did a revert of this commit. After creating a snapshot, the filesystem was no longer usable, even with kernel 3.16.3 (crashes 10 seconds after mount without error message) . Maybe

Re: btrfs send and kernel 3.17

2014-10-07 Thread Chris Mason
On Tue, Oct 7, 2014 at 4:45 PM, David Arendt ad...@prnet.org wrote: On 10/07/2014 03:19 PM, Chris Mason wrote: On Tue, Oct 7, 2014 at 1:25 AM, David Arendt ad...@prnet.org wrote: I did a revert of this commit. After creating a snapshot, the filesystem was no longer usable, even with

Re: 3.16.2 btrfs deadlock

2014-10-07 Thread Chris Mason
On Sun, Oct 5, 2014 at 4:29 PM, Marc MERLIN m...@merlins.org wrote: Deadlocks have been less frequent (good), but here is one. An rsync from 5 days ago got stuck on btrfs it seems, and things just started piling up on top until the system deadlocked I see btrfs-transaction saying wait on

Re: 3.16.2 btrfs deadlock

2014-10-07 Thread Marc MERLIN
On Tue, Oct 07, 2014 at 05:22:52PM -0400, Chris Mason wrote: Here's the trace: SysRq : Show Blocked State taskPC stack pid father md8_raid5 D 88017028cb80 0 675 2 0x 88020fd67aa8 0046 812f1799 88020fd67fd8

[PATCH] btrfs: move struct btrfs_ioctl_defrag_range_args from ctree.h to linux/btrfs.h

2014-10-07 Thread Marios Titas
include/uapi/linux/btrfs.h is a more logical place to put the struct btrfs_ioctl_defrag_range_args as it is being used by the BTRFS_IOC_DEFRAG_RANGE IOCTL which is defined in that file. Additionally, this is where the btrfs-progs defines that struct. Thus this patches reduces the gap between the

[PATCH v2] btrfs: Make btrfs handle security mount options internally to avoid losing security label.

2014-10-07 Thread Qu Wenruo
[BUG] Originally when mount btrfs with -o subvol= mount option, btrfs will lose all security lable. And if the btrfs fs is mounted somewhere else, due to the lost of security lable, SELinux will refuse to mount since the same super block is being mounted using different security lable.

Re: [PATCH v2] btrfs: Make btrfs handle security mount options internally to avoid losing security label.

2014-10-07 Thread Qu Wenruo
Cc Chris: The delta of the v2 patch is only the following lines: diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c index 1eb7858..6f64411 100644 --- a/fs/btrfs/super.c +++ b/fs/btrfs/super.c @@ -1248,6 +1248,7 @@ static int setup_security_options(struct btrfs_fs_info *fs_info, if (ret)

Re: [PATCH v2] btrfs: Make btrfs handle security mount options internally to avoid losing security label.

2014-10-07 Thread Chris Mason
On Tue, Oct 7, 2014 at 10:12 PM, Qu Wenruo quwen...@cn.fujitsu.com wrote: changelog: v2: Fix a compile error when CONFIG_SECURITY is not set. Thanks, could you please send this as an incremental? Your original patch is in my integration tree now. -chris -- To unsubscribe from this

[PATCH] btrfs: Fix compile error when CONFIG_SECURITY is not set.

2014-10-07 Thread Qu Wenruo
Fix the following compile error when CONFIG_SECURITY is not set: error: 'struct security_mnt_opts' has no member named 'num_mnt_opts' Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com --- This is the delta patch of the v2 patch. --- fs/btrfs/super.c | 2 ++ 1 file changed, 2 insertions(+) diff

[PATCH v2] xfstests: add regression for inode bad compression ratio detection

2014-10-07 Thread Wang Shilong
This test add a regression test to make sure btrfs dosen't set inode NOCOMPRESS flag when a small write(=blocksize) happens. Signed-off-by: Wang Shilong wangshilong1...@gmail.com --- v1-v2: switch _extent_count() helper. Test relies on btrfs have a max 128k limit write, not sure whether

[PATCH 1/2] xfstests,btrfs/010: use _extent_count() helper

2014-10-07 Thread Wang Shilong
cleanup to swith _extent_count(), this way we remove a dependence on filefrag. Signed-off-by: Wang Shilong wangshilong1...@gmail.com --- tests/btrfs/010 | 8 1 file changed, 4 insertions(+), 4 deletions(-) mode change 100755 = 100644 tests/btrfs/010 diff --git a/tests/btrfs/010

[PATCH 2/2] xfstests,btrfs/004: use FILEFRAG_PROG macro

2014-10-07 Thread Wang Shilong
Signed-off-by: Wang Shilong wangshilong1...@gmail.com --- i didn't find a way to remove filefrag here, but let us use macro firstly... --- tests/btrfs/004 | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/btrfs/004 b/tests/btrfs/004 index 1d5b816..1f59963 100755 ---

Re: [PATCH 2/2] xfstests,btrfs/004: use FILEFRAG_PROG macro

2014-10-07 Thread Dave Chinner
On Wed, Oct 08, 2014 at 06:35:22AM -0400, Wang Shilong wrote: Signed-off-by: Wang Shilong wangshilong1...@gmail.com --- i didn't find a way to remove filefrag here, but let us use macro firstly... YOu shoul dbe able to use fiemap to calculate the same output. i.e. _check_file_extents()

Re: [PATCH 2/2] xfstests,btrfs/004: use FILEFRAG_PROG macro

2014-10-07 Thread Wang Shilong
Cc list On Wed, Oct 08, 2014 at 06:35:22AM -0400, Wang Shilong wrote: Signed-off-by: Wang Shilong wangshilong1...@gmail.com --- i didn't find a way to remove filefrag here, but let us use macro firstly... YOu shoul dbe able to use fiemap to calculate the same output. i.e.

Re: [PATCH 2/2] xfstests,btrfs/004: use FILEFRAG_PROG macro

2014-10-07 Thread Dave Chinner
On Wed, Oct 08, 2014 at 01:31:24PM +0800, Wang Shilong wrote: Cc list On Wed, Oct 08, 2014 at 06:35:22AM -0400, Wang Shilong wrote: Signed-off-by: Wang Shilong wangshilong1...@gmail.com --- i didn't find a way to remove filefrag here, but let us use macro firstly... YOu shoul dbe