Re: price to pay for nocow file bit?

2015-01-07 Thread Duncan
Josef Bacik posted on Wed, 07 Jan 2015 15:10:06 -0500 as excerpted: >> Does this have any effect on functionality? As I understood snapshots >> still work fine for files marked like that, and so do reflinks. Any >> drawback functionality-wise? Apparently file compression support is >> lost if the

Re: BTRFS free space handling still needs more work: Hangs again (no complete lockups, "just" tasks stuck for some time)

2015-01-07 Thread Duncan
Martin Steigerwald posted on Wed, 07 Jan 2015 20:08:50 +0100 as excerpted: > No BTRFS developers commented yet on this, neither in this thread nor in > the bug report at kernel.org I made. Just a quick general note on this point... There has in the past (and I believe referenced on the wiki) bee

Re: [PATCH v3 0/3] Btrfs: Enhancment for qgroup.

2015-01-07 Thread Dongsheng Yang
On 01/07/2015 08:49 AM, Satoru Takeuchi wrote: > Hi Yang, > > On 2015/01/05 15:16, Dongsheng Yang wrote: >> Hi Josef and others, >> >> This patch set is about enhancing qgroup. >> >> [1/3]: fix a bug about qgroup leak when we exceed quota limit, >> It is reviewd by Josef. >> [2/3]: introduce a

Re: [PATCH] btrfs: introduce shrinker for rb_tree that keeps valid btrfs_devices

2015-01-07 Thread Gui Hecheng
[ping] On Wed, 2014-12-10 at 15:39 +0800, Gui Hecheng wrote: > The following patch: > btrfs: remove empty fs_devices to prevent memory runout > > introduces @valid_dev_root aiming at recording @btrfs_device objects that > have corresponding block devices with btrfs. > But if a block device

[PATCH] btrfs-progs: doc: fix format of btrfs-replace

2015-01-07 Thread Tsutomu Itoh
Current 'man btrfs-replace' is as follows: ... ... -f force using and overwriting even if it looks like containing a valid btrfs filesystem. A valid filesystem is assu

Re: kernel BUG at /home/apw/COD/linux/fs/btrfs/inode.c:3123!

2015-01-07 Thread Tomasz Chmielewski
On 2015-01-07 15:58, Satoru Takeuchi wrote: Create subvolume './subvolume' # dd if=/dev/urandom of=bigfile.img bs=64k Does it really this command? I consider it will fill up whole /dev/vdb. It normally would fill the fs if left for long, but I've pressed ctrl+c after about 6 GB. And is

Re: [PATCH] btrfs-progs: Fix a copy-n-paste bug in btrfs_read_fs_root().

2015-01-07 Thread Satoru Takeuchi
On 2015/01/07 18:23, Qu Wenruo wrote: > Signed-off-by: Qu Wenruo Reviewed-by: Satoru Takeuchi > --- > disk-io.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/disk-io.c b/disk-io.c > index 2bf8586..b853f66 100644 > --- a/disk-io.c > +++ b/disk-io.c > @@ -693,7 +693

Re: price to pay for nocow file bit?

2015-01-07 Thread Josef Bacik
On 01/07/2015 04:05 PM, Goffredo Baroncelli wrote: I am trying to understand the pros and cons of turning this bit on, before I can make this change. So far I see one big pro, but I wonder if there's any major con I should think about? Nope there's no real con other than you don't get csums,

Re: BTRFS free space handling still needs more work: Hangs again (no complete lockups, "just" tasks stuck for some time)

2015-01-07 Thread Zygo Blaxell
On Wed, Jan 07, 2015 at 08:08:50PM +0100, Martin Steigerwald wrote: > Am Dienstag, 6. Januar 2015, 15:03:23 schrieb Zygo Blaxell: > > ext3 has a related problem when it's nearly full: it will try to search > > gigabytes of block allocation bitmaps searching for a free block, which > > can result i

Re: price to pay for nocow file bit?

2015-01-07 Thread Goffredo Baroncelli
> >> I am trying to understand the pros and cons of turning this bit >> on, before I can make this change. So far I see one big pro, but I >> wonder if there's any major con I should think about? >> > > Nope there's no real con other than you don't get csums, but that > doesn't really matter for

Re: price to pay for nocow file bit?

2015-01-07 Thread Josef Bacik
On 01/07/2015 12:43 PM, Lennart Poettering wrote: Heya! Currently, systemd-journald's disk access patterns (appending to the end of files, then updating a few pointers in the front) result in awfully fragmented journal files on btrfs, which has a pretty negative effect on performance when access

Re: BTRFS free space handling still needs more work: Hangs again (no complete lockups, "just" tasks stuck for some time)

2015-01-07 Thread Martin Steigerwald
Am Dienstag, 6. Januar 2015, 15:03:23 schrieb Zygo Blaxell: > On Mon, Dec 29, 2014 at 10:32:00AM +0100, Martin Steigerwald wrote: > > Am Sonntag, 28. Dezember 2014, 21:07:05 schrieb Zygo Blaxell: > > > On Sat, Dec 27, 2014 at 08:23:59PM +0100, Martin Steigerwald wrote: […] > > > > Zygo, was is the

ssd mode on rotational media

2015-01-07 Thread Kyle Gates
What issues would arise if ssd mode is activated because of a block layer setting the rotational flag to zero? This happens for me running btrfs on bcache. Would it be beneficial to pass the no_ssd flag? Thanks, Kyle -- To unsubscribe from this list: send

price to pay for nocow file bit?

2015-01-07 Thread Lennart Poettering
Heya! Currently, systemd-journald's disk access patterns (appending to the end of files, then updating a few pointers in the front) result in awfully fragmented journal files on btrfs, which has a pretty negative effect on performance when accessing them. Now, to improve things a bit, I yesterday

Re: btrfs_inode_item's otime?

2015-01-07 Thread Christoph Hellwig
On Wed, Jan 07, 2015 at 02:57:35PM +0100, Lennart Poettering wrote: > Exposig this as xattr sounds great to me too. NAK - exposing random stat data as xattr only creates problems. Given that we don't seem to be able to get a new stat format anytime soon we should add a generic ioctl to expose it,

Re: btrfs_inode_item's otime?

2015-01-07 Thread Lennart Poettering
On Tue, 06.01.15 19:26, David Sterba (dste...@suse.cz) wrote: > > (Of course, even without xstat(), I think it would be good to have an > > unprivileged ioctl to query the otime in btrfs... the TREE_SEARCH > > ioctl after all requires privileges...) > > Adding this interface is a different questi

Re: Data recovery after RBD I/O error

2015-01-07 Thread Austin S Hemmelgarn
On 2015-01-06 23:11, Jérôme Poulin wrote: On Mon, Jan 5, 2015 at 6:59 AM, Austin S Hemmelgarn wrote: Secondly, I would highly recommend not using ANY non-cluster-aware FS on top of a clustered block device like RBD For my use-case, this is just a single server using the RBD device. No cluste

Re: BTRFS_IOC_TREE_SEARCH ioctl

2015-01-07 Thread Lennart Poettering
On Mon, 05.01.15 19:14, Nehemiah Dacres (vivacar...@gmail.com) wrote: > Is libbtrfs documented or even stable yet? What stage of development is it > in anyway? is there a design spec yet? Note that the code we use in systemd is not based on libbtrfs, we just call the ioctls directly. Lennart --

Re: [PATCH] btrfs: get the accurate value of used_bytes in btrfs_get_block_group_info().

2015-01-07 Thread Dongsheng Yang
On 01/07/2015 05:22 PM, Qu Wenruo wrote: Hi Satoru-san Hi Dongsheng, On 2015/01/05 20:19, Dongsheng Yang wrote: Ping. IOCTL of BTRFS_IOC_SPACE_INFO currently does not report the data used but not synced to user. Then btrfs fi df will give user a wrong numbers before sync. This patch sol

Re: [PATCH] btrfs: get the accurate value of used_bytes in btrfs_get_block_group_info().

2015-01-07 Thread Qu Wenruo
Hi Satoru-san Hi Dongsheng, On 2015/01/05 20:19, Dongsheng Yang wrote: Ping. IOCTL of BTRFS_IOC_SPACE_INFO currently does not report the data used but not synced to user. Then btrfs fi df will give user a wrong numbers before sync. This patch solve this problem. On 10/27/2014 08:38 PM,

[PATCH] btrfs-progs: Fix a copy-n-paste bug in btrfs_read_fs_root().

2015-01-07 Thread Qu Wenruo
Signed-off-by: Qu Wenruo --- disk-io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/disk-io.c b/disk-io.c index 2bf8586..b853f66 100644 --- a/disk-io.c +++ b/disk-io.c @@ -693,7 +693,7 @@ struct btrfs_root *btrfs_read_fs_root(struct btrfs_fs_info *fs_info, if (loca

[RFC PATCH] Btrfs: use asynchronous submit for large DIO io in single profile

2015-01-07 Thread Liu Bo
Commit 1ae399382512 ("Btrfs: do not use async submit for small DIO io's") benefits small DIO io's. However, if we're owning the SINGLE profile, this also affects large DIO io's since in that case, map_length is (chunk_length - bio's offset_in_chunk), it's farily large so that it's very likely to b

Re: [PATCH] btrfs: get the accurate value of used_bytes in btrfs_get_block_group_info().

2015-01-07 Thread Satoru Takeuchi
Hi Dongsheng, On 2015/01/05 20:19, Dongsheng Yang wrote: Ping. IOCTL of BTRFS_IOC_SPACE_INFO currently does not report the data used but not synced to user. Then btrfs fi df will give user a wrong numbers before sync. This patch solve this problem. On 10/27/2014 08:38 PM, Dongsheng Yang