Re: Raid10 performance issues during copy and balance, only half the spindles used for reading data

2015-03-09 Thread Duncan
Sven Witterstein posted on Tue, 10 Mar 2015 00:45:23 +0100 as excerpted: > During balance or copies, the second image of the stripeset A + B | A' + > B' is never used, thus throwing away about 40% of performance, e.g. it > NEVER used A' + B' to read from even if 50% of the needed assembled data >

Re: [PATCH] btrfs-progs: tests, clean up scripts

2015-03-09 Thread Qu Wenruo
Original Message Subject: [PATCH] btrfs-progs: tests, clean up scripts From: David Sterba To: Date: 2015年03月09日 19:33 Rename variables, use caps, call true by full path, add quotation to variables and a few wording fixes. Signed-off-by: David Sterba Much better than my

Raid10 performance issues during copy and balance, only half the spindles used for reading data

2015-03-09 Thread Sven Witterstein
Hello, I have used btrfs and zfs for some years and feel pretty confident about their administration - and both with ther snaps and subvols saved me quite often. I had to grow my 4x250GB Raid10-Backup-Array to a 6x500GB raid10-backup array - the slower half of 4 1TB 2.5" Spinpoint M8's. were

[PATCH 18/26] Btrfs: sysfs: make btrfs_sysfs_add_device() non static

2015-03-09 Thread Anand Jain
Signed-off-by: Anand Jain --- fs/btrfs/sysfs.h | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/btrfs/sysfs.h b/fs/btrfs/sysfs.h index aaff124..ac06b5c 100644 --- a/fs/btrfs/sysfs.h +++ b/fs/btrfs/sysfs.h @@ -76,4 +76,5 @@ int btrfs_kobj_rm_device(struct btrfs_fs_devices *fs_devices,

[PATCH 16/26] Btrfs: sysfs btrfs_kobj_rm_device() pass fs_devices instead of fs_info

2015-03-09 Thread Anand Jain
since btrfs_kobj_rm_device() does nothing with fs_info Signed-off-by: Anand Jain --- fs/btrfs/dev-replace.c | 2 +- fs/btrfs/sysfs.c | 12 ++-- fs/btrfs/sysfs.h | 2 +- fs/btrfs/volumes.c | 4 ++-- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/fs/btr

[PATCH 15/26] Btrfs: sysfs btrfs_kobj_add_device() pass fs_devices instead of fs_info

2015-03-09 Thread Anand Jain
btrfs_kobj_add_device() does not need fs_info any more. Signed-off-by: Anand Jain --- fs/btrfs/dev-replace.c | 2 +- fs/btrfs/sysfs.c | 7 +++ fs/btrfs/sysfs.h | 2 +- fs/btrfs/volumes.c | 2 +- 4 files changed, 6 insertions(+), 7 deletions(-) diff --git a/fs/btrfs/dev-repla

[PATCH 25/26] Btrfs: sysfs: support seed devices in the sysfs layout v3

2015-03-09 Thread Anand Jain
This adds an enhancement to show the seed fsid and devices. The way sprouting handles fs_devices: clone seed fs_devices and add to the fs_uuids mem copy seed fs_devices and assign to fs_devices->seed (move dev_list) evacuate seed fs_devices contents to hold sprout fs devices cont

[PATCH 14/26] Btrfs: sysfs: provide framework to remove all fsid sysfs kobject v2

2015-03-09 Thread Anand Jain
just a helper function to clean up the sysfs fsid kobjects v2: update commit Signed-off-by: Anand Jain --- fs/btrfs/sysfs.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c index 95d6257..a8ee136 100644 --- a/fs/btrfs/sysfs

[PATCH 22/26] Btrfs: sysfs: don't fail seeding for the sake of sysfs kobject issue v2

2015-03-09 Thread Anand Jain
v2: accept David comment Signed-off-by: Anand Jain --- fs/btrfs/volumes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index 549f978..58232bc 100644 --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@ -2249,7 +2249,7 @@ int btrfs_in

Re: [PATCH 22/24] Btrfs: sysfs: don't fail seeding for the sake of sysfs kobject issue

2015-03-09 Thread Anand Jain
On 02/13/2015 11:15 AM, David Sterba wrote: On Thu, Feb 12, 2015 at 11:22:38AM +0800, Anand Jain wrote: On 02/12/2015 02:40 AM, David Sterba wrote: On Mon, Feb 09, 2015 at 07:56:23AM +0800, Anand Jain wrote: Signed-off-by: Anand Jain --- fs/btrfs/volumes.c | 3 ++- 1 file changed, 2

[PATCH 17/26] Btrfs: sysfs: make btrfs_sysfs_add_fsid() non static

2015-03-09 Thread Anand Jain
Signed-off-by: Anand Jain --- fs/btrfs/sysfs.c | 2 +- fs/btrfs/sysfs.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c index 5055809..42ed7a7 100644 --- a/fs/btrfs/sysfs.c +++ b/fs/btrfs/sysfs.c @@ -727,7 +727,7 @@ u64 btrfs_debugfs_test;

[PATCH 11/26] Btrfs: sysfs: move super_kobj and device_dir_kobj from fs_info to btrfs_fs_devices

2015-03-09 Thread Anand Jain
From: Anand Jain This patch will provide a framework and help to create attributes from the structure btrfs_fs_devices which are available even before fs_info is created. So by moving the parent kobject super_kobj from fs_info to btrfs_fs_devices, it will help to create attributes from the btrfs_

[PATCH 04/26] Btrfs: sysfs: fix, kobject pointer clean up needed after kobject release

2015-03-09 Thread Anand Jain
From: Anand Jain The sysfs clean up self test like in the below code fails, since fs_info->device_dir_kobject still points to its stale kobject. Reseting this pointer will help to fix this. open_ctree() { ret = btrfs_sysfs_add_one(fs_info); :: + btrfs_sysfs_remove_one(fs_info); + re

[PATCH 26/26] Btrfs: create sys/fs/btrfs/fsid when scanned instead of when mounted

2015-03-09 Thread Anand Jain
This patch changes the life cycle of the exisiting sysfs kobjects /sys/fs/btrfs/ and /sys/fs/btrfs//devices, from that they are created and destroyed by mount and unmount event respectively, to created and destroyed by scanned-registered and module-unload respectively. So that information from the

[PATCH 23/26] Btrfs: free the stale device

2015-03-09 Thread Anand Jain
Signed-off-by: Anand Jain --- fs/btrfs/volumes.c | 51 +++ 1 file changed, 51 insertions(+) diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index 58232bc..452abb3 100644 --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@ -446,6 +446,55 @@ st

Re: [PATCH 23/24] Btrfs: sysfs: support seed devices in the sysfs layout

2015-03-09 Thread Anand Jain
Hi Dave, Sorry for the delay I was caught up some issues... (hope I didn't miss any of the email). On 02/13/2015 12:33 PM, David Sterba wrote: On Thu, Feb 12, 2015 at 02:25:32PM +0800, Anand Jain wrote: On 02/12/2015 02:52 AM, David Sterba wrote: On Mon, Feb 09, 2015 at 07:56:24AM +0800

[PATCH 12/26] Btrfs: introduce btrfs_get_fs_uuids to get fs_uuids v2

2015-03-09 Thread Anand Jain
v2: commit update Signed-off-by: Anand Jain --- fs/btrfs/volumes.c | 4 fs/btrfs/volumes.h | 1 + 2 files changed, 5 insertions(+) diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index 218a14a..c1b1038 100644 --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@ -52,6 +52,10 @@ static v

[PATCH 21/26] Btrfs: sysfs: add support to add parent for fsid

2015-03-09 Thread Anand Jain
To support seed sysfs layout and represent seed fsid under the sprout we need the facility to create fsid under the specified parent. Signed-off-by: Anand Jain --- fs/btrfs/sysfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c index b

[PATCH 24/26] Btrfs: sysfs: add support to show replacing target in the sysfs

2015-03-09 Thread Anand Jain
This patch will add support to show the replacing target in sysfs during the process of replacement. Signed-off-by: Anand Jain --- fs/btrfs/dev-replace.c | 5 - fs/btrfs/volumes.c | 3 +++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/fs/btrfs/dev-replace.c b/fs/btrfs/dev

[PATCH 00/26 v4] provide framework so that sysfs attributs from the fs_devices can be added

2015-03-09 Thread Anand Jain
This patch set will provide a framework and help to create attributes from the structure btrfs_fs_devices which are available even before fs_info is created. So by moving the parent kobject super_kobj from fs_info to btrfs_fs_devices, it will help to create attributes from the btrfs_fs_devices as w

[PATCH 09/26] Btrfs: sysfs: let default_attrs be separate from the kset

2015-03-09 Thread Anand Jain
From: Anand Jain As of now btrfs_attrs are provided using the default_attrs through the kset. Separate them and create the default_attrs using the sysfs_create_files instead. By doing this we will have the flexibility that device discovery thread could create fsid kobject. Signed-off-by: Anand J

[PATCH 13/26] Btrfs: sysfs: add pointer to access fs_info from fs_devices v2

2015-03-09 Thread Anand Jain
From: Anand Jain adds fs_info pointer with struct btrfs_fs_devices. v2: Fix a bug:d update fs_info pointer in open_seed_devices() Signed-off-by: Anand Jain --- fs/btrfs/sysfs.c | 4 fs/btrfs/volumes.c | 18 ++ fs/btrfs/volumes.h | 3 +++ 3 files changed, 25 insertions

[PATCH 10/26] Btrfs: sysfs: separate device kobject and its attribute creation

2015-03-09 Thread Anand Jain
From: Anand Jain Separate device kobject and its attribute creation so that device kobject can be created from the device discovery thread. Signed-off-by: Anand Jain --- fs/btrfs/sysfs.c | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/fs/btrfs/sysfs.c

[PATCH 19/26] Btrfs: sysfs: btrfs_sysfs_remove_fsid() make it non static

2015-03-09 Thread Anand Jain
Signed-off-by: Anand Jain --- fs/btrfs/sysfs.c | 2 +- fs/btrfs/sysfs.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c index 42ed7a7..1d34538 100644 --- a/fs/btrfs/sysfs.c +++ b/fs/btrfs/sysfs.c @@ -529,7 +529,7 @@ static void __btrfs_sysf

[PATCH 07/26] Btrfs: sysfs: rename __btrfs_sysfs_remove_one to btrfs_sysfs_remove_fsid

2015-03-09 Thread Anand Jain
From: Anand Jain Signed-off-by: Anand Jain --- fs/btrfs/sysfs.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c index c3e7f06..c923e8b 100644 --- a/fs/btrfs/sysfs.c +++ b/fs/btrfs/sysfs.c @@ -508,7 +508,7 @@ static int addrm_unknow

[PATCH 20/26] Btrfs: sysfs: separate kobject and attribute creation

2015-03-09 Thread Anand Jain
Signed-off-by: Anand Jain --- fs/btrfs/disk-io.c | 18 +- fs/btrfs/sysfs.c | 15 ++- 2 files changed, 19 insertions(+), 14 deletions(-) diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c index 0cd6550..4b7f3b8 100644 --- a/fs/btrfs/disk-io.c +++ b/fs/btrfs/disk-io

[PATCH 02/26] Btrfs: sysfs: fix, fs_info kobject_unregister has init_completion() twice

2015-03-09 Thread Anand Jain
From: Anand Jain kobject_unregister is to handle the release of the kobject, its completion init is being called in btrfs_sysfs_add_one(), so we don't have to do the same in the open_ctree() again. Signed-off-by: Anand Jain --- fs/btrfs/disk-io.c | 1 - 1 file changed, 1 deletion(-) diff --gi

[PATCH 05/26] Btrfc: sysfs: fix, check if device_dir_kobj is init before destroy

2015-03-09 Thread Anand Jain
From: Anand Jain Since the failure code in the btrfs_sysfs_add_one() can call btrfs_sysfs_remove_one() even before device_dir_kobj has been created we need to check if its null. Signed-off-by: Anand Jain --- fs/btrfs/sysfs.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) dif

[PATCH 08/26] Btrfs: sysfs: introduce function btrfs_sysfs_add_fsid() to create sysfs fsid

2015-03-09 Thread Anand Jain
From: Anand Jain We need it in a seperate function so that it can be called from the device discovery thread as well. Signed-off-by: Anand Jain --- fs/btrfs/sysfs.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c index c92

[PATCH 06/26] Btrfs: sysfs: reorder the kobject creations

2015-03-09 Thread Anand Jain
From: Anand Jain As of now the order in which the kobjects are created at btrfs_sysfs_add_one() is.. fsid features unknown features (dynamic features) devices. Since we would move fsid and device kobject to fs_devices from fs_info structure, this patch will reorder in which the kobjects are

[PATCH 01/26] Btrfs: sysfs: fix, btrfs_release_super_kobj() should to clean up the kobject data

2015-03-09 Thread Anand Jain
From: Anand Jain The following test case fails indicating that, thread tried to init an initialized object. kernel: [232104.016513] kobject (880006c1c980): tried to init an initialized object, something is seriously wrong. btrfs_sysfs_remove_one() self test code: open_tree() { ::

[PATCH 03/26] Btrfs: sysfs: fix, undo sysfs device links

2015-03-09 Thread Anand Jain
From: Anand Jain Theoritically need to remove the device links attributes, but since its entire device kobject was removed, so there wasn't any issue of about it. Just do it nicely. Signed-off-by: Anand Jain --- fs/btrfs/sysfs.c | 17 + 1 file changed, 17 insertions(+) diff -

Re: [PATCH 2/2] Btrfs: send, don't leave without decrementing clone root's send_progress

2015-03-09 Thread David Sterba
On Mon, Mar 02, 2015 at 08:53:53PM +, Filipe Manana wrote: > If the clone root was not readonly or the dead flag was set on it, we were > leaving without decrementing the root's send_progress counter (and before > we just incremented it). If a concurrent snapshot deletion was in progress > and

Re: Lock-ups, assertion failure in btrfsck, scrub reporting super=4

2015-03-09 Thread Chris Murphy
Maybe try btrfs-progs-3.19rc3? You have the data backed up, and progs 3.18.2 fails so it seems worth a shot. Chris Murphy -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/

Re: [PATCH 1/2] Btrfs: send, add missing check for dead clone root

2015-03-09 Thread David Sterba
On Mon, Mar 02, 2015 at 08:53:52PM +, Filipe Manana wrote: > After we locked the root's root item, a concurrent snapshot deletion > call might have set the dead flag on it. So check if the dead flag > is set and abort if it is, just like we do for the parent root. > > Signed-off-by: Filipe Man

Re: btrfs oops while mounting fuzzed btrfs image

2015-03-09 Thread David Sterba
On Fri, Mar 06, 2015 at 02:01:13AM -0800, Omar Sandoval wrote: > + > + if (ret && btrfs_super_generation(disk_sb) < 10) { > + printk(KERN_WARNING "btrfs: super block crcs don't > match, older mkfs detected\n"); > + ret = 0; > + } > I

Re: Status: converting raid levels

2015-03-09 Thread Marcel Ritter
Hi, I tried to revert the mentioned patch set (kernel 4.0.0-rc2). Starting a new re-balance with this kernel, while running my I/O test (big dd write) on the same btrfs volume (14 disks) resulted in "cpu stuck" messages - system was unusable just a few seconds later. With a plain 4.0.0-rc2 kerne

Re: Lock-ups, assertion failure in btrfsck, scrub reporting super=4

2015-03-09 Thread Tobias Getzner
On Fr, 2015-03-06 at 00:10 +, Duncan wrote: > Tobias Getzner posted on Thu, 05 Mar 2015 12:48:00 +0100 as excerpted: > > > I booted back into the graphical system, and when not running Firefox, I > > did not get any immediate lock-ups anymore. > > > > I’d welcome any advice on how to proceed,

Btrfs progs pre-release 3.19-rc3

2015-03-09 Thread David Sterba
Hi, the 3.19 release is close, rc3 should be the last one. ETA for the release is tomorrow, please give it, we can still add minor fixups. Then, I'm hoping to return back to the more frequent releases, ie. bi-weekly and merge features of smaller scale, cleanups and doc updates. The next version i

Re: [PATCH] btrfs: fix size_t format string

2015-03-09 Thread David Sterba
On Mon, Mar 09, 2015 at 12:39:36PM +0100, Arnd Bergmann wrote: > This warning has been rather annoying because it shows up in every > 'allmodconfig' build. I assume others have reported it before, but > please apply some fix for it, ideally before 4.0. Sorry about that, we're aware of the warning

[PATCH] btrfs: fix size_t format string

2015-03-09 Thread Arnd Bergmann
This resolves a harmless gcc warning in btrfs_check_super_valid that results from a size_t value being printed as %lu: fs/btrfs/disk-io.c:3927:21: warning: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'unsigned int' [-Wformat=] On all Linux systems, size_t i

[PATCH] btrfs-progs: tests, clean up scripts

2015-03-09 Thread David Sterba
Rename variables, use caps, call true by full path, add quotation to variables and a few wording fixes. Signed-off-by: David Sterba --- tests/common | 43 ++-- tests/fsck-tests/012-leaf-corruption/test.sh | 10 +++ 2 files changed, 27 i

Re: [PATCH v2] btrfs-progs: fsck-test: Add check_sudo to check valid root/sudo privilege

2015-03-09 Thread David Sterba
On Mon, Mar 02, 2015 at 11:41:50AM +0800, Qu Wenruo wrote: > New '_sudo' command will do credential check if needed to avoid such > problem. > > Signed-off-by: Qu Wenruo > --- > v2: > Add support for old sudo. > Remove 'have_root_helper' variant > Integrate 'check_root' into root_helper fun

[PATCH] btrfs-progs: convert, add option to disable progress

2015-03-09 Thread David Sterba
With progress turned on by default we should be able to disable it as well. Reported-by: Jérôme Poulin Signed-off-by: David Sterba --- Documentation/btrfs-convert.txt | 2 ++ btrfs-convert.c | 14 +- 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/Doc

Re: [PATCH] btrfs-progs: convert: show progress by default

2015-03-09 Thread David Sterba
On Wed, Mar 04, 2015 at 01:21:02AM -0500, Jérôme Poulin wrote: > On Fri, Feb 27, 2015 at 10:32 AM, David Sterba wrote: > > > > + printf("\t-p show converting progress (default)\n"); > > A quick look a this it looks like you've added a mandatory «option» > since the "case" which ha

Re: [PATCH] btrfs-progs: use less memory for pretty_size_mode buffers

2015-03-09 Thread David Sterba
On Fri, Mar 06, 2015 at 02:21:30PM -0500, Anand Jain wrote: > Program received signal SIGSEGV, Segmentation fault. > 0x087caf18 in __vsnprintf_chk () from /lib64/libc.so.6 > Missing separate debuginfos, use: debuginfo-install > glibc-2.12-1.132.0.8.el6.sparc64 libblkid-2.17.2-12.14.0.2.el6