Re: [PATCH v6 00/20] xfstests: minor fixes for the reflink/dedupe tests

2016-07-12 Thread Darrick J. Wong
On Tue, Jul 05, 2016 at 12:31:30PM +0800, Eryu Guan wrote: > Hi Darrick, > > On Thu, Jun 16, 2016 at 06:46:02PM -0700, Darrick J. Wong wrote: > > Hi all, > > > > This is the sixth revision of a patchset that adds to xfstests > > support for testing reverse-mappings of physical blocks to file and

Re: FIDEDUPERANGE with src_length == 0

2016-07-12 Thread Darrick J. Wong
On Mon, Jul 11, 2016 at 05:35:37PM -0700, Omar Sandoval wrote: > Hey, Darrick, > > generic/182 is failing on Btrfs for me with the following output: > > --- tests/generic/182.out 2016-07-07 19:51:54.0 -0700 > +++ /tmp/fixxfstests/xfstests/results//generic/182.out.bad

Re: [PATCH] btrfs-progs: add option to run balance as daemon

2016-07-12 Thread Andrei Borzenkov
12.07.2016 15:25, Austin S. Hemmelgarn пишет: > > I'm not changing my init system just to add functionality that should > already exist in btrfs-progs. The fact that the balance ioctl is > synchronous was a poor design choice, and we need to provide the option > to work around that independent

[PATCH] Btrfs: fix extent buffer bitmap tests on big-endian systems

2016-07-12 Thread Omar Sandoval
From: Omar Sandoval The in-memory bitmap code manipulates words and is therefore sensitive to endianness, while the extent buffer bitmap code addresses bytes and is byte-order agnostic. Because the byte addressing of the extent buffer bitmaps is equivalent to a little-endian

REPLY BACK.

2016-07-12 Thread Mr.Tom Crist
-- A gift of 850 for you -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: btrfs module does not load on sparc64

2016-07-12 Thread Omar Sandoval
On Mon, Jul 11, 2016 at 12:06:46PM +0200, David Sterba wrote: > On Thu, Jul 07, 2016 at 05:29:35PM +0300, Anatoly Pugachev wrote: > > Compiled linux kernel (git version 4.7.0-rc6+) using my own kernel > > config file, enabling : > > > > CONFIG_BTRFS_FS_RUN_SANITY_TESTS=y > > CONFIG_BTRFS_DEBUG=y

[BUG] Btrfs scrub sometime recalculate wrong parity in raid5: take two

2016-07-12 Thread Goffredo Baroncelli
Hi All, I developed a new btrfs command "btrfs insp phy"[1] to further investigate this bug [2]. Using "btrfs insp phy" I developed a script to trigger the bug. The bug is not always triggered, but most of time yes. Basically the script create a raid5 filesystem (using three loop-device on

New btrfs sub command: btrfs inspect physical-find

2016-07-12 Thread Goffredo Baroncelli
Hi All, the enclosed patch adds a new btrfs sub command: "btrfs inspect physical-find". The aim of this new command is to show the physical placement on the disk of a file. Currently it handles all the profiles (single, dup, raid1/10/5/6). I develop this command in order to show some bug in

Re: [PATCH] btrfs-progs: add option to run balance as daemon

2016-07-12 Thread Austin S. Hemmelgarn
On 2016-07-12 11:22, Duncan wrote: Austin S. Hemmelgarn posted on Tue, 12 Jul 2016 08:25:24 -0400 as excerpted: As far as daemonization, I have no man-page called daemon in section seven, yet I have an up-to-date upstream copy of the Linux man pages. My guess is that this is a systemd man

[PATCH v3] Btrfs: fix unexpected balance crash due to BUG_ON

2016-07-12 Thread Liu Bo
Mounting a btrfs can resume previous balance operations asynchronously. An user got a crash when one drive has some corrupt sectors. Since balance can cancel itself in case of any error, we can gracefully return errors to upper layers and let balance do the cancel job. Reported-by: sash

Re: [PATCH v2] Btrfs: fix panic in balance due to EIO

2016-07-12 Thread Chris Mason
On 07/12/2016 01:29 PM, Liu Bo wrote: During build_backref_tree(), if we fail to read a btree node, we can eventually run into BUG_ON(cache->nr_nodes) that we put in backref_cache_cleanup(), meaning we have at least one memory leak. This frees the backref_node that we's allocated at the very

Re: [PATCH v3] Btrfs: fix eb memory leak due to readpage failure

2016-07-12 Thread David Sterba
On Mon, Jul 11, 2016 at 10:39:07AM -0700, Liu Bo wrote: > eb->io_pages is set in read_extent_buffer_pages(). > > In case of readpage failure, for pages that have been added to bio, > it calls bio_endio and later readpage_io_failed_hook() does the work. > > When this eb's page (couldn't be the

[PATCH v2] Btrfs: fix panic in balance due to EIO

2016-07-12 Thread Liu Bo
During build_backref_tree(), if we fail to read a btree node, we can eventually run into BUG_ON(cache->nr_nodes) that we put in backref_cache_cleanup(), meaning we have at least one memory leak. This frees the backref_node that we's allocated at the very beginning of build_backref_tree().

Voy a estar esperando por su respuesta

2016-07-12 Thread CHAN CHAK
Hola, Mi nombre es Chan Chak un gerente de banco con un banco de inversión, tengo un negocio de beneficio mutuo que implica la transferencia de grandes sumas de dinero. Volver a mí para obtener más información si está interesado.(chanjohnc...@gmail.com) CHAN CHAK -- To unsubscribe from this

Re: [PATCH] Btrfs: fix panic in balance due to EIO

2016-07-12 Thread Liu Bo
On Tue, Jul 12, 2016 at 11:05:48AM -0400, Chris Mason wrote: > > > On 07/11/2016 08:37 PM, Liu Bo wrote: > > During build_backref_tree(), if we fail to read a btree node, > > we can eventually run into BUG_ON(cache->nr_nodes) that we put > > in backref_cache_cleanup(), meaning we have at least

Re: Hello world, python-btrfs

2016-07-12 Thread David Sterba
On Fri, Jun 24, 2016 at 01:29:22AM +0200, Hans van Kranenburg wrote: > > I can imagine creating scripts to > > craft images for testing or verifying results of fsck, so it would be > > more convenient to keep them in one place (but using a git submodule > > instead would not be a big deal). > >

Re: [PATCH] Btrfs: change BUG_ON()'s to ASSERT()'s in backref_cache_cleanup()

2016-07-12 Thread David Sterba
On Mon, Jul 11, 2016 at 06:52:57PM -0700, Liu Bo wrote: > Since it is just an in-memory building of the backrefs of several > btree blocks, nothing is fatal other than memory leaks, so this > changes BUG_ON()'s to ASSERT()'s. Agreed, this a good justification. Sometimes the BUG_ON serves as a

Re: [PATCH v2] btrfs: fix free space calculation in dump_space_info()

2016-07-12 Thread David Sterba
On Mon, Jul 11, 2016 at 07:30:04PM +0800, Wang Xiaoguang wrote: > In btrfs, btrfs_space_info's bytes_may_use is treated as fs used > space, as what we do in reserve_metadata_bytes() or > btrfs_alloc_data_chunk_ondemand(), so in dump_space_info(), when > calculating free space, we should also minus

Re: [PATCH V20 19/19] Btrfs: subpage-blocksize: Rate limit scrub error message

2016-07-12 Thread David Sterba
On Mon, Jul 04, 2016 at 10:04:39AM +0530, Chandan Rajendra wrote: > btrfs/073 invokes scrub ioctl in a tight loop. In subpage-blocksize > scenario this results in a lot of "scrub: size assumption sectorsize != > PAGE_SIZE " messages being printed on the console. To reduce the number > of such

Re: [PATCH] btrfs: Add ratelimiting to printing facility

2016-07-12 Thread David Sterba
On Tue, Jul 12, 2016 at 04:47:53PM +0300, Nikolay Borisov wrote: > > > On 07/12/2016 04:20 PM, David Sterba wrote: > > On Tue, Jul 12, 2016 at 03:20:12PM +0300, Nikolay Borisov wrote: > >> Currently the btrfs printk infrastructure doesn't implement any > >> kind of ratelimiting. > > > > If you

Re: 64-btrfs.rules and degraded boot

2016-07-12 Thread Austin S. Hemmelgarn
On 2016-07-11 17:07, Chris Murphy wrote: On Fri, Jul 8, 2016 at 6:24 AM, Austin S. Hemmelgarn wrote: To clarify, I'm not trying to argue against adding support, I'm arguing against it being mandatory. By "D-Bus support" I did not mean to indicate mandating it, just

Re: [PATCH] btrfs-progs: add option to run balance as daemon

2016-07-12 Thread Duncan
Austin S. Hemmelgarn posted on Tue, 12 Jul 2016 08:25:24 -0400 as excerpted: > As far as daemonization, I have no man-page called daemon in section > seven, yet I have an up-to-date upstream copy of the Linux man pages. My > guess is that this is a systemd man page, which in turn means it does a

Re: [PATCH] Btrfs: fix panic in balance due to EIO

2016-07-12 Thread Chris Mason
On 07/11/2016 08:37 PM, Liu Bo wrote: During build_backref_tree(), if we fail to read a btree node, we can eventually run into BUG_ON(cache->nr_nodes) that we put in backref_cache_cleanup(), meaning we have at least one memory leak. This frees the backref_node that we allocate at the very

Re: [PATCH] btrfs: Add ratelimiting to printing facility

2016-07-12 Thread Nikolay Borisov
On 07/12/2016 04:20 PM, David Sterba wrote: > On Tue, Jul 12, 2016 at 03:20:12PM +0300, Nikolay Borisov wrote: >> Currently the btrfs printk infrastructure doesn't implement any >> kind of ratelimiting. > > If you count the whole infrastructure, it does. See ctree.h and macros > ending with _rl

Re: [PATCH] btrfs: Add ratelimiting to printing facility

2016-07-12 Thread David Sterba
On Tue, Jul 12, 2016 at 03:20:12PM +0300, Nikolay Borisov wrote: > Currently the btrfs printk infrastructure doesn't implement any > kind of ratelimiting. If you count the whole infrastructure, it does. See ctree.h and macros ending with _rl (btrfs_err_rl), and should be used where the messages

Re: [PATCH] btrfs-progs: add option to run balance as daemon

2016-07-12 Thread Austin S. Hemmelgarn
On 2016-07-11 12:58, Tomasz Torcz wrote: On Mon, Jul 11, 2016 at 07:17:28AM -0400, Austin S. Hemmelgarn wrote: On 2016-07-11 03:26, Tomasz Torcz wrote: On Tue, Jun 21, 2016 at 11:16:59AM -0400, Austin S. Hemmelgarn wrote: Currently, balance operations are run synchronously in the foreground.

[PATCH] btrfs: Add ratelimiting to printing facility

2016-07-12 Thread Nikolay Borisov
Currently the btrfs printk infrastructure doesn't implement any kind of ratelimiting. Recently I came accross a case where due to FS corruption an excessive amount of printk caused the softlockup detector to trigger and reset the server. This patch aims to avoid two types of issue: * I want to

ERROR: ioctl(DEV_REPLACE_START) failed on "/mnt": Read-only file system

2016-07-12 Thread Tamas Baumgartner-Kis
Hi, I have a problem with the current BTRFS 4.6 I'm running a Archlinux in a KVM to test BTRFS. First I played with one device and subvolumes. After that I added a second device to make a raid1. # btrfs device add /dev/sdb /mnt # btrfs balance start -dconvert=raid1 -mconvert=raid1 /mnt To

Re: [PATCH v2] Btrfs: fix unexpected balance crash due to BUG_ON

2016-07-12 Thread David Sterba
On Mon, Jul 11, 2016 at 10:21:35AM -0700, Liu Bo wrote: > + } > > trans = btrfs_start_transaction(dev_root, 0); > - BUG_ON(IS_ERR(trans)); > + if (IS_ERR(trans)) { > + ret = PTR_ERR(trans); > +

[PATCH v2 3/3] btrfs: test that send does not issue invalid rmdir operations

2016-07-12 Thread fdmanana
From: Filipe Manana Test that an incremental send operation does not prematurely issues rmdir operations under a particular scenario (the rmdir operation is sent before the target directory is empty). This issue is fixed by the following patch for the linux kernel: "Btrfs:

[PATCH v2 2/3] btrfs: add test for incremental send after removing a directory

2016-07-12 Thread fdmanana
From: Filipe Manana Test that, under a particular scenario, an incremental send operation does not leak memory (which used to emit a warning in dmesg/syslog). This is a regression test for a btrfs kernel fix that has the title: "Btrfs: send, fix warning due to late freeing of

[PATCH v2 1/3] btrfs: add test for an incremental send after moving directories around

2016-07-12 Thread fdmanana
From: Filipe Manana Test that an incremental send operation works after doing radical changes in the directory hierarchy that involve switching the inode that directory entries point to. This test exercises scenarios used to fail in btrfs and are fixed by the following

Re: [PATCH v2] Btrfs: fix unexpected balance crash due to BUG_ON

2016-07-12 Thread Filipe Manana
On Mon, Jul 11, 2016 at 6:21 PM, Liu Bo wrote: > Mounting a btrfs can resume previous balance operations asynchronously. > An user got a crash when one drive has some corrupt sectors. > > Since balance can cancel itself in case of any error, we can gracefully > return errors

Re: [PATCH 1/3] btrfs: add test for an incremental send after moving directories around

2016-07-12 Thread Filipe Manana
On Tue, Jul 12, 2016 at 4:58 AM, Eryu Guan wrote: > On Sat, Jul 02, 2016 at 01:32:08PM +0100, fdman...@kernel.org wrote: >> From: Filipe Manana >> >> Test that an incremental send operation works after doing radical changes >> in the directory hierarchy that