[PATCH] Btrfs: fix em leak in find_first_block_group

2016-08-18 Thread Josef Bacik
We need to call free_extent_map() on the em we look up.Btrfs: fix em leak in find_first_block_group We need to call free_extent_map() on the em we look up. Signed-off-by: Josef Bacik --- fs/btrfs/extent-tree.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs

Re: [PATCH v2] Btrfs: fix file/data loss caused by fsync after rename and new inode

2016-08-18 Thread Chris Mason
On Wed, Mar 30, 2016 at 11:37:21PM +0100, fdman...@kernel.org wrote: From: Filipe Manana If we rename an inode A (be it a file or a directory), create a new inode B with the old name of inode A and under the same parent directory, fsync inode B and then power fail, at log tree replay time we en

Re: [PATCH] btrfs: Change RAID stripesize to a user-configurable option

2016-08-18 Thread Hugo Mills
On Thu, Aug 18, 2016 at 03:26:58PM +0200, David Sterba wrote: > On Thu, Jul 28, 2016 at 11:42:55AM -0400, Sanidhya Solanki wrote: > > > I'll comment on the overall approach and skip code-specific comments. > > > > > > The changelog does not explain why there's a need for a new blockgroup > > > typ

Re: [PATCH] btrfs: do not background blkdev_put()

2016-08-18 Thread Anand Jain
On 08/18/2016 08:46 PM, David Sterba wrote: On Fri, Jul 22, 2016 at 06:04:53AM +0800, Anand Jain wrote: From: Anand Jain At the end of unmount/dev-delete, if the device exclusive open is not actually closed, then there might be a race with another program in the userland who is trying to ope

Re: [PATCH] btrfs: Change RAID stripesize to a user-configurable option

2016-08-18 Thread David Sterba
On Thu, Jul 28, 2016 at 11:42:55AM -0400, Sanidhya Solanki wrote: > > I'll comment on the overall approach and skip code-specific comments. > > > > The changelog does not explain why there's a need for a new blockgroup > > type and what's the relation to the existing types. It seems that it > > ex

Re: [PATCH] btrfs: do not background blkdev_put()

2016-08-18 Thread David Sterba
On Fri, Jul 22, 2016 at 06:04:53AM +0800, Anand Jain wrote: > From: Anand Jain > > At the end of unmount/dev-delete, if the device exclusive open is not > actually closed, then there might be a race with another program in > the userland who is trying to open the device in exclusive mode and > it

Re: [PATCH v2] Btrfs: clarify do_chunk_alloc()'s return value

2016-08-18 Thread David Sterba
On Fri, Jul 29, 2016 at 11:09:50AM -0700, Liu Bo wrote: > Function start_transaction() can return ERR_PTR(1) when flush is > BTRFS_RESERVE_FLUSH_LIMIT, so the call graph is > > start_transaction (return ERR_PTR(1)) > -> btrfs_block_rsv_add (return 1) > -> reserve_metadata_bytes (return 1) >

Re: [PATCH v4] btrfs: fix fsfreeze hang caused by delayed iputs deal

2016-08-18 Thread David Sterba
On Mon, Aug 01, 2016 at 01:28:08PM +0800, Wang Xiaoguang wrote: > v3: we introduce a atomic_t fs_frozen, and if fs_frozen is 1, we can not > handle delayed iputs. > v4: change atomic_t fs_frozen to be int. As it is now, I think the barriers are not needed. The freeze callback sets it and then