Looks fine,
Reviewed-by: Christoph Hellwig
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Apr 14, 2017 at 07:02:54AM -0500, Goldwyn Rodrigues wrote:
> From: Goldwyn Rodrigues
>
> A new bio operation flag REQ_NOWAIT is introduced to identify bio's
s/bio/block/
> @@ -1232,6 +1232,11 @@ static struct request *get_request(struct
> request_queue *q, unsigned int op,
> if (
Looks fine,
Reviewed-by: Christoph Hellwig
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
> }
>
> -
> /* prevent overflows */
Weird whitespace change.
> @@ -1593,6 +1593,11 @@ static int io_submit_one(struct kioctx *ctx, struct
> iocb __user *user_iocb,
> }
>
> req->common.ki_flags |= iocb_rw_flags(iocb->aio_rw_flags);
> + if ((req->common.ki_flags & I
On Fri, Apr 14, 2017 at 07:02:50AM -0500, Goldwyn Rodrigues wrote:
> From: Goldwyn Rodrigues
>
> RWF_* flags is used for preadv2/pwritev2 calls. Port to use
> it for aio operations as well. For this, aio_rw_flags is
> introduced in struct iocb (using aio_reserved1) which will
> carry these flags.
On 04/18/2017 09:54 PM, David Sterba wrote:
On Thu, Apr 06, 2017 at 11:22:47AM +0800, Anand Jain wrote:
As of now we do alloc an empty bio and then use the flag REQ_PREFLUSH
to flush the device cache, instead we can use blkdev_issue_flush()
for this puspose.
This would change the scheduling
On 04/14/2017 02:41 AM, Liu Bo wrote:
On Thu, Apr 06, 2017 at 11:22:47AM +0800, Anand Jain wrote:
As of now we do alloc an empty bio and then use the flag REQ_PREFLUSH
to flush the device cache, instead we can use blkdev_issue_flush()
for this puspose.
Also now no need to check the return whe
At 04/18/2017 08:41 PM, Werner Braun wrote:
Hi,
i have a WD WD40EZRX with strange beaviour off btrfs check vs. btrfs scrub
running btrfs check --check-data-csum returns no errors on the disk
running btrfs scrub on the disk finds tons of errors
i could clear the disk and send it to anyone in
At 04/18/2017 11:09 PM, David Sterba wrote:
The WARN_ON and warning from report_reserved_underflow can become very
noisy and is visible unconditionally although this is namely for
debugging. The patch "btrfs: Add WARN_ON for qgroup reserved underflow"
(18dc22c19bef520cca11ce4c0807ac9dec48d31f)
Werner Braun posted on Tue, 18 Apr 2017 14:41:49 +0200 as excerpted:
> Hi,
>
> i have a WD WD40EZRX with strange beaviour off btrfs check vs. btrfs
> scrub
>
> running btrfs check --check-data-csum returns no errors on the disk
>
> running btrfs scrub on the disk finds tons of errors
A dev cou
Hi,
i have to try to create a new extent-tree after checksum error not solveable
with srub or init-csum-tree.
Now i got this failure output from btrfs --repair:
ERROR: errors found in extent allocation tree or chunk allocation
Fixed 0 roots.
checking free space cache
checking fs roots
root 5 m
The WARN_ON and warning from report_reserved_underflow can become very
noisy and is visible unconditionally although this is namely for
debugging. The patch "btrfs: Add WARN_ON for qgroup reserved underflow"
(18dc22c19bef520cca11ce4c0807ac9dec48d31f) went to 4.11-rc1 and the plan
was to get the fix
On Thu, Apr 06, 2017 at 11:22:53AM +0800, Anand Jain wrote:
> The blkdev_issue_flush() will check if the write cache is enabled
> before submitting the flush. This will add a code to fail fast if
> its not.
>
> Signed-off-by: Anand Jain
> ---
Reviewed-by: David Sterba
--
To unsubscribe from thi
On Thu, Apr 06, 2017 at 11:22:52AM +0800, Anand Jain wrote:
> The last consumer of nobarriers is removed by the commit [1] and sync
> won't fail with EOPNOTSUPP anymore. Thus, now when write cache is write
> through it just return success without actually transpiring such a
> request to the block d
On Thu, Apr 06, 2017 at 11:22:51AM +0800, Anand Jain wrote:
> We have already assigned q from bdev_get_queue() so use it.
> And rearrange the code for better view.
>
> Signed-off-by: Anand Jain
> Reviewed-by: David Sterba
JFYI, this patch has been added to 4.12
--
To unsubscribe from this list:
On Thu, Apr 06, 2017 at 11:22:47AM +0800, Anand Jain wrote:
> As of now we do alloc an empty bio and then use the flag REQ_PREFLUSH
> to flush the device cache, instead we can use blkdev_issue_flush()
> for this puspose.
This would change the scheduling characteristics. Right now, the caller
threa
So you think this might be a bug in the Kernel? In fact I wanted to
try with a newer kernel, but could no longer reproduce the issue.
In addition, I did a scrub on the partition and there were no errors.
So wither there was some transient disk issue that affected only that
partition, or there is a
On 2017-04-18 09:02, Imran Geriskovan wrote:
On 4/17/17, Austin S. Hemmelgarn wrote:
Regarding BTRFS specifically:
* Given my recently newfound understanding of what the 'ssd' mount
option actually does, I'm inclined to recommend that people who are
using high-end SSD's _NOT_ use it as it will
On 18.04.2017 15:15, Hugo Mills wrote:
On Tue, Apr 18, 2017 at 02:41:49PM +0200, Werner Braun wrote:
Hi,
i have a WD WD40EZRX with strange beaviour off btrfs check vs. btrfs scrub
running btrfs check --check-data-csum returns no errors on the disk
running btrfs scrub on the disk finds tons
On Tue, Apr 18, 2017 at 02:41:49PM +0200, Werner Braun wrote:
> Hi,
>
> i have a WD WD40EZRX with strange beaviour off btrfs check vs. btrfs scrub
>
> running btrfs check --check-data-csum returns no errors on the disk
>
> running btrfs scrub on the disk finds tons of errors
>
> i could clear t
On 4/17/17, Austin S. Hemmelgarn wrote:
> Regarding BTRFS specifically:
> * Given my recently newfound understanding of what the 'ssd' mount
> option actually does, I'm inclined to recommend that people who are
> using high-end SSD's _NOT_ use it as it will heavily increase
> fragmentation and wil
Hi,
i have a WD WD40EZRX with strange beaviour off btrfs check vs. btrfs scrub
running btrfs check --check-data-csum returns no errors on the disk
running btrfs scrub on the disk finds tons of errors
i could clear the disk and send it to anyone intrested in ;-)
--
Werner Braun
+49 178 145 87
On 2017-04-17 15:22, Imran Geriskovan wrote:
On 4/17/17, Roman Mamedov wrote:
"Austin S. Hemmelgarn" wrote:
* Compression should help performance and device lifetime most of the
time, unless your CPU is fully utilized on a regular basis (in which
case it will hurt performance, but still imp
On Tue, Apr 18, 2017 at 07:31:34AM -0400, Austin S. Hemmelgarn wrote:
> On 2017-04-17 15:39, Chris Murphy wrote:
> >On Mon, Apr 17, 2017 at 1:26 PM, Austin S. Hemmelgarn
> > wrote:
> >>On 2017-04-17 14:34, Chris Murphy wrote:
[...]
> >It's almost like we need these things to not fsync at all, a
On Fri, Apr 14, 2017 at 07:02:57AM -0500, Goldwyn Rodrigues wrote:
> From: Goldwyn Rodrigues
>
> Return EAGAIN if any of the following checks fail
> + i_rwsem is not lockable
> + NODATACOW or PREALLOC is not set
> + Cannot nocow at the desired location
> + Writing beyond end of file which is
On 2017-04-17 15:39, Chris Murphy wrote:
On Mon, Apr 17, 2017 at 1:26 PM, Austin S. Hemmelgarn
wrote:
On 2017-04-17 14:34, Chris Murphy wrote:
Nope. The first paragraph applies to NVMe machine with ssd mount
option. Few fragments.
The second paragraph applies to SD Card machine with ssd_spr
On Fri, Apr 14, 2017 at 08:35:54AM +0800, Qu Wenruo wrote:
> Unlike mirror based profiles, RAID5/6 recovery needs to read out the
> whole full stripe.
>
> And if we don't do proper protect, it can easily cause race condition.
>
> Introduce 2 new functions: lock_full_stripe() and unlock_full_strip
On Fri, Apr 14, 2017 at 08:35:55AM +0800, Qu Wenruo wrote:
> When scrubbing a RAID5 which has recoverable data corruption (only one
> data stripe is corrupted), sometimes scrub will report more csum errors
> than expected. Sometimes even unrecoverable error will be reported.
>
> The problem can be
Nice. With this new option, it should be possible to achieve something
like RAID56 corruption test-script say,
https://patchwork.kernel.org/patch/9583455/ right?
Cheers,
Lakshmipathi.G
FOSS Programmer.
http://www.giis.co.in http://www.webminal.org
On Mon, Apr 17, 2017 at 8:56 AM, Qu Wenruo
29 matches
Mail list logo
