Re: [PATCH v2 3/4] btrfs: Add zstd support

2017-07-10 Thread Nick Terrell
On 7/10/17, 5:36 AM, "Austin S. Hemmelgarn" wrote: > On 2017-07-07 23:07, Adam Borowski wrote: >> On Sat, Jul 08, 2017 at 01:40:18AM +0200, Adam Borowski wrote: >>> On Fri, Jul 07, 2017 at 11:17:49PM +, Nick Terrell wrote: On 7/6/17, 9:32 AM, "Adam Borowski"

Re: [PATCH v2] btrfs: Correct assignment of pos

2017-07-10 Thread Liu Bo
On Tue, Jul 04, 2017 at 10:33:07PM -0500, Goldwyn Rodrigues wrote: > From: Goldwyn Rodrigues > > Assigning pos for usage early messes up in append mode, where > the pos is re-assigned in generic_write_checks(). Assign > pos later to get the correct position to write from

[PATCH] btrfs-progs: Tighten integer types in print-tree.

2017-07-10 Thread Adam Buchbinder
There are likely more places where the wrong size types are used, but these tripped Clang's warnings because they eventually get passed to printf. Signed-off-by: Adam Buchbinder --- print-tree.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH] btrfs-progs: Fix missing internal deps in tests.

2017-07-10 Thread Adam Buchbinder
Doing a straight 'make test' would fail because some misc and fsck tests require particular tools to already be built. Add dependencies at the Makefile and shell-script level. Signed-off-by: Adam Buchbinder --- Makefile| 5 +++-- tests/fsck-tests.sh | 1 +

Re: [PATCH v2 3/4] btrfs: Add zstd support

2017-07-10 Thread Clemens Eisserer
> So, I don't see any problem making the level configurable. +1 - configureable compression level would be very appreciated from my side. Can't wait until zstd support is mainline :) Thanks and br, Clemens -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a

Re: [PATCH v2 3/4] btrfs: Add zstd support

2017-07-10 Thread Nick Terrell
On 7/10/17, 5:36 AM, "Austin S. Hemmelgarn" wrote: > On 2017-07-07 23:07, Adam Borowski wrote: >> On Sat, Jul 08, 2017 at 01:40:18AM +0200, Adam Borowski wrote: >>> On Fri, Jul 07, 2017 at 11:17:49PM +, Nick Terrell wrote: On 7/6/17, 9:32 AM, "Adam Borowski"

Re: [PATCH v4 0/6] Chunk level degradable check

2017-07-10 Thread Dmitrii Tcvetkov
On Wed, 28 Jun 2017 13:43:29 +0800 Qu Wenruo wrote: > The patchset can be fetched from my github repo: > https://github.com/adam900710/linux/tree/degradable > > The patchset is based on David's for-4.13-part1 branch. > > Btrfs currently uses

Re: [PATCH] Btrfs: add skeleton code for compression heuristic

2017-07-10 Thread David Sterba
On Tue, Jul 04, 2017 at 08:28:15PM +0300, Timofey Titovets wrote: > For now that code just return true > Later more complex heuristic code will be added > > Signed-off-by: Timofey Titovets > --- > fs/btrfs/compression.c | 22 ++ > fs/btrfs/compression.h

Re: [PATCH v2 1/2] btrfs: account for pinned bytes in should_alloc_chunk

2017-07-10 Thread David Sterba
On Thu, Jun 22, 2017 at 09:51:47AM -0400, je...@suse.com wrote: > From: Jeff Mahoney > > In a heavy write scenario, we can end up with a large number of pinned bytes. > This can translate into (very) premature ENOSPC because pinned bytes > must be accounted for when allowing a

Re: [PATCH v2 00/13] use rbtrees for preliminary backrefs

2017-07-10 Thread David Sterba
On Wed, Jun 28, 2017 at 09:56:52PM -0600, Edmund Nadolski wrote: > Edmund Nadolski (6): > btrfs: btrfs_check_shared should manage its own transaction > btrfs: remove ref_tree implementation from backref.c > btrfs: convert prelimary reference tracking to use rbtrees > btrfs: add

Re: [PATCH v2 08/13] btrfs: convert prelimary reference tracking to use rbtrees

2017-07-10 Thread David Sterba
On Wed, Jun 28, 2017 at 09:57:00PM -0600, Edmund Nadolski wrote: > It's been known for a while that the use of multiple lists > that are periodically merged was an algorithmic problem within > btrfs. There are several workloads that don't complete in any > reasonable amount of time (e.g.

Re: [PATCH v2 07/13] btrfs: remove ref_tree implementation from backref.c

2017-07-10 Thread David Sterba
On Wed, Jun 28, 2017 at 09:56:59PM -0600, Edmund Nadolski wrote: > Commit afce772e87c3 ("btrfs: fix check_shared for fiemap ioctl") added > the ref_tree code in backref.c to reduce backref searching for > shared extents under the FIEMAP ioctl. This code will not be > compatible with the upcoming

Re: [PATCH v2 06/13] btrfs: btrfs_check_shared should manage its own transaction

2017-07-10 Thread David Sterba
On Wed, Jun 28, 2017 at 09:56:58PM -0600, Edmund Nadolski wrote: > Commit afce772e87c3 ("btrfs: fix check_shared for fiemap ioctl") added > transaction semantics around calls to btrfs_check_shared() in order to > provide accurate accounting of delayed refs. The transaction management > should be

Re: [PATCH 01/14] VFS: Don't use save/replace_mount_options if not using generic_show_options

2017-07-10 Thread David Sterba
On Wed, Jul 05, 2017 at 04:24:09PM +0100, David Howells wrote: > btrfs, debugfs, reiserfs and tracefs call save_mount_options() and reiserfs > calls replace_mount_options(), but they then implement their own > ->show_options() methods and don't touch s_options, rendering the saved > options

[GIT PULL] Urgent nowait aio fixup for btrfs

2017-07-10 Thread David Sterba
Hi, please pull the following patch that fixes a user-visible bug introduced by the nowait-aio patches merged in this cycle. The branch is based on the closest merge in Jens' block changes that contained the nowait-aio patches, the patch does not apply to current btrfs branch. As the fix is

Re: [PATCH] btrfs: resume qgroup rescan on rw remount

2017-07-10 Thread Nikolay Borisov
On 10.07.2017 16:12, Nikolay Borisov wrote: > > > On 4.07.2017 14:49, Aleksa Sarai wrote: >> Several distributions mount the "proper root" as ro during initrd and >> then remount it as rw before pivot_root(2). Thus, if a rescan had been >> aborted by a previous shutdown, the rescan would

Re: [PATCH] btrfs: resume qgroup rescan on rw remount

2017-07-10 Thread Nikolay Borisov
On 4.07.2017 14:49, Aleksa Sarai wrote: > Several distributions mount the "proper root" as ro during initrd and > then remount it as rw before pivot_root(2). Thus, if a rescan had been > aborted by a previous shutdown, the rescan would never be resumed. > > This issue would manifest itself as

linxi★广交会 —— 2017广州国际进出口汽车配件展览会 [地右P4/L100-Z]

2017-07-10 Thread zwt2
【通过本邮件参展优惠500元一展位,需回信专用邮箱“12809...@qq.com”报名】    尊敬的 linxi 企业领导/公司负责人:      诚邀参加中国最大汽配外贸展 —— APF 2017   汽配行业品牌盛会,外贸企业最佳选择,全球采购首选平台!    ★ 与“广交会”同期同地举行, ★ 以“广交会”庞大的客流量为依托,买家互动,借势兴展, ★ 共享来自全球数十万采购商资源•••       【 基 本 信 息 】    中文名称: 2017广州国际进出口汽车配件展览会 英文名称: The Guangzhou International Import and

Re: Chunk root problem

2017-07-10 Thread Austin S. Hemmelgarn
On 2017-07-10 00:21, Daniel Brady wrote: On 7/7/2017 1:06 AM, Daniel Brady wrote: On 7/6/2017 11:48 PM, Roman Mamedov wrote: On Wed, 5 Jul 2017 22:10:35 -0600 Daniel Brady wrote: parent transid verify failed Typically in Btrfs terms this means "you're screwed", fsck

Re: raid10 array lost with single disk failure?

2017-07-10 Thread Austin S. Hemmelgarn
On 2017-07-09 22:13, Adam Bahe wrote: I have finished all of the above suggestions, ran a scrub, remounted, rebooted, made sure the system didn't hang, and then kicked off another balance on the entire pool. It completed rather quickly but something still does not seem right. Label:

Re: [PATCH v2 3/4] btrfs: Add zstd support

2017-07-10 Thread Austin S. Hemmelgarn
On 2017-07-07 23:07, Adam Borowski wrote: On Sat, Jul 08, 2017 at 01:40:18AM +0200, Adam Borowski wrote: On Fri, Jul 07, 2017 at 11:17:49PM +, Nick Terrell wrote: On 7/6/17, 9:32 AM, "Adam Borowski" wrote: Got a reproducible crash on amd64: Thanks for the bug

Re: Commit edf064e7c (btrfs: nowait aio support) breaks shells

2017-07-10 Thread David Sterba
On Fri, Jul 07, 2017 at 08:09:28PM -0600, Jens Axboe wrote: > On 07/07/2017 07:51 PM, Goldwyn Rodrigues wrote: > > On 07/04/2017 05:16 PM, Jens Axboe wrote: > >> > >> Please expedite getting this upstream, asap. > > > > I have posted an updated patch [1] and it is acked by David. Would you > >

Re: btrfs device ready purpose

2017-07-10 Thread Austin S. Hemmelgarn
On 2017-07-07 13:40, Chris Murphy wrote: On Fri, Jul 7, 2017 at 10:59 AM, Andrei Borzenkov wrote: 07.07.2017 19:42, Chris Murphy пишет: I'm digging through piles of list emails and not really finding an answer to this. Maybe it's Friday and I'm just confused...

Re: Can I drop/reset files with corrupted data if they are in a read only snapshot?

2017-07-10 Thread Marc MERLIN
Thanks for the Cc/ping, I appreciate it On Sun, Jul 09, 2017 at 11:38:51AM +, Duncan wrote: > At your own risk you can try using btrfs property to set the ro snapshot > to rw. Then you can delete the corrupted files and reset the snapshot > back to ro. > > Of course you'll need to do the