Re: btrfs-cleaner causing heavy load

Brennecke, Simon posted on Tue, 18 Jul 2017 07:32:12 + as excerpted: > I disabled quotas and seconds later btrfs-cleaner returned to idle. > I will now run a couple of checks and then close this issue. Thanks. Another night-and-day result to chalk up for the next time it comes up on the

Re: BTRFS error on my raid1

Jul 17 06:55:13 black kernel: sd 2:0:0:0: [sda] Write cache: enabled, read cache: enabled, doesn't support DPO or FUA Jul 17 06:55:13 black kernel: sd 12:0:0:0: [sdb] Write cache: enabled, read cache: enabled, doesn't support DPO or FUA Jul 17 06:55:13 black kernel: sd 13:0:1:0: [sdc] Write cache:

Re: bind mounts on btrfs cause mountinfo confusion

18.07.2017 10:24, Duncan пишет: > > Before the kernel started printing that subvol= stuff, this information > was missing, as it still is for non-btrfs. > Huh? tail -1 /proc/self/mountinfo 215 25 8:4 /tmp/from /tmp/to rw,relatime shared:1 - ext4 /dev/sda4 rw,errors=remount-ro,data=ordered

Re: "detect-zeroes=unmap" support in Btrfs?

On Tue, 18 Jul 2017 16:57:10 +0500 Roman Mamedov wrote: > if a block written consists of zeroes entirely, instead of writing zeroes to > the backing storage, converts that into an "unmap" operation > (FALLOC_FL_PUNCH_HOLE[1]). BTW I found that it is very easy to "offline"

Re: [PATCH v2 3/4] btrfs: Add zstd support

On Thu, Jun 29, 2017 at 12:41:07PM -0700, Nick Terrell wrote: > +static void zstd_free_workspace(struct list_head *ws) > +{ > + struct workspace *workspace = list_entry(ws, struct workspace, list); > + > + vfree(workspace->mem); > + kfree(workspace->buf); > + kfree(workspace); > +}

Re: [PATCH v4 1/6] btrfs: Introduce a function to check if all chunks a OK for degraded rw mount

On Fri, Jul 14, 2017 at 04:19:07PM +0800, Qu Wenruo wrote: > On 2017年07月14日 15:44, Nikolay Borisov wrote: > > On 28.06.2017 08:43, Qu Wenruo wrote: > >> Introduce a new function, btrfs_check_rw_degradable(), to check if all > >> chunks in btrfs is OK for degraded rw mount. > >> > >> It provides

Re: [PATCH v2] btrfs: Remove find_raid56_stripe_len

On Fri, Jul 14, 2017 at 09:55:41AM +0300, Nikolay Borisov wrote: > find_raid56_stripe_len statically returns SZ_64K which equals > BTRFS_STRIPE_LEN. > It's sole caller is __btrfs_alloc_chunk and it assigns the return value to ai > variable which is already set to BTRFS_STRIPE_LEN. So remove the

Re: [PATCH 2/3] btrfs: Remove unused parameters from volume.c functions

On Thu, Jul 13, 2017 at 11:37:42AM +0300, Nikolay Borisov wrote: > This also adjusts the respective callers in other files. Those were found with > -Wunused-parameter. > > Signed-off-by: Nikolay Borisov Same comment as for 1/3, please document when and possibly why the

Re: [PATCH 1/3] btrfs: Remove unused variables

For dead code removal, please document when it was last used and what's the possible cause the code became unused. It's mostly for obvious reasons, but sometimes it can reveal potential problems. On Thu, Jul 13, 2017 at 11:37:41AM +0300, Nikolay Borisov wrote: > Signed-off-by: Nikolay Borisov

[PATCH 1/4] btrfs: merge alloc_device helpers

There are two helpers called in chain from one location, we can merge the functionaliy. Originally, alloc_fs_devices could fill the device uuid randomly if we we didn't give the uuid buffer. This happens for seed devices but the fsid is generated in btrfs_prepare_sprout, so we can remove it.

[PATCH 2/4] btrfs: refactor find_device helper

Polish the helper: * drop underscores, no special meaning here * pass fs_devices, as this is what the API implements * drop noinline, no apparent reason for such simple helper * constify uuid * add comment Signed-off-by: David Sterba --- fs/btrfs/volumes.c | 19

[PATCH 4/4] btrfs: use named constant for bdev blocksize

Superblock is read and written using buffer heads, we need to set the bdev blocksize. The magic constant has been hardcoded in several places, so replace it with a named constant. Signed-off-by: David Sterba --- fs/btrfs/check-integrity.c | 6 +++--- fs/btrfs/disk-io.c

[PATCH 3/4] btrfs: split write_dev_supers to two functions

There are two independent parts, one that writes the superblocks and another that waits for completion. No functional changes, but cleanups, reformatting and comment updates. Signed-off-by: David Sterba --- fs/btrfs/disk-io.c | 129

[PATCH 0/4] Device helper cleanups

David Sterba (4): btrfs: merge alloc_device helpers btrfs: refactor find_device helper btrfs: split write_dev_supers to two functions btrfs: use named constant for bdev blocksize fs/btrfs/check-integrity.c | 6 +- fs/btrfs/disk-io.c | 136

Re: [PATCH] btrfs: Use explicit round_down macro in btrfs resize ioctl handler

On Tue, Jul 18, 2017 at 03:39:08PM +0300, Nikolay Borisov wrote: > No functional changes, just make the code more self-explanatory. > > Signed-off-by: Nikolay Borisov Reviewed-by: David Sterba -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH] btrfs: btrfs_inherit_iflags() can be static

On Tue, Jul 18, 2017 at 05:37:05PM +0800, Anand Jain wrote: > btrfs_new_inode() is the only consumer move it to inode.c, > from ioctl.c. Yes, moving the functions out of ioctl.c is ok. Reviewed-by: David Sterba -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH] btrfs: make use of inode_need_compress()

On Tue, Jul 18, 2017 at 05:37:47PM +0800, Anand Jain wrote: > Its better to have the policy enforcement going through a function, > so that we have better control and visibility of the decision logic. > > Signed-off-by: Anand Jain > --- > fs/btrfs/inode.c | 7 +++ > 1

Attention To me and get back to me urgent

Attention:Beneficiary I am Meliana Trump, and I am writing to inform you about your Bank Check Draft brought back 16/07/2017 by the United Embassy Mr John Moore from the government of Benin Republic in the white house Washington DC been mandated to be deliver to your home address once you

[PATCH] btrfs: Use explicit round_down macro in btrfs resize ioctl handler

No functional changes, just make the code more self-explanatory. Signed-off-by: Nikolay Borisov --- fs/btrfs/ioctl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index fa1b78cf25f6..5101515b4a14 100644 ---

"detect-zeroes=unmap" support in Btrfs?

Hello, Qemu/KVM has this nice feature in its storage layer, "detect-zeroes=unmap". Basically the VM host detects if a block written by the guest consists of zeroes entirely, and instead of writing zeroes to the backing storage, converts that into an "unmap" operation (FALLOC_FL_PUNCH_HOLE[1]). I

[PATCH] btrfs: make use of inode_need_compress()

Its better to have the policy enforcement going through a function, so that we have better control and visibility of the decision logic. Signed-off-by: Anand Jain --- fs/btrfs/inode.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git

[PATCH] btrfs: btrfs_inherit_iflags() can be static

btrfs_new_inode() is the only consumer move it to inode.c, from ioctl.c. Signed-off-by: Anand Jain --- fs/btrfs/ctree.h | 1 - fs/btrfs/inode.c | 31 +++ fs/btrfs/ioctl.c | 31 --- 3 files changed, 31 insertions(+),

Re: btrfs-cleaner causing heavy load

 Hi Duncan, Thanks a lot! I disabled quotas and seconds later btrfs-cleaner returned to idle. I will now run a couple of checks and then close this issue. Regards Simon-- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org

Re: bind mounts on btrfs cause mountinfo confusion

Chris Murphy posted on Mon, 17 Jul 2017 15:47:20 -0600 as excerpted: > Example during boot: > > Executing: /usr/bin/mount > /sysroot/ostree/deploy/fedora-workstation/var /var -o bind > > cat /proc/self/mounts > > /dev/sda6 /var btrfs >

Re: btrfs-cleaner causing heavy load

Brennecke, Simon posted on Mon, 17 Jul 2017 08:03:33 + as excerpted: > I understand that purging snapshots is a complex operation, but we > somehow need to reduce the load this causes during working hours. > Are there any ways to tell btrfs-cleaner to suspend or reduce its > operations? > >

[PATCH 00/15] Btrfs-progs offline scrub

For any one who wants to try it, it can be get from my repo: https://github.com/gujx2017/btrfs-progs/tree/offline_scrub In this v5, just make some small fixups of comments on the left 15 patches, according to problems pointed out by David when mergering the first 5 patches of this patchset. And