Re: [PATCH] btrfs: Don't generate UUID for non-fs tree

2018-01-03 Thread Qu Wenruo
On 2018年01月03日 22:37, David Sterba wrote: > On Tue, Oct 31, 2017 at 02:08:16PM +0800, Qu Wenruo wrote: >> btrfs_create_tree() will unconditionally generate UUID for any root. >> So for quota tree and data reloc tree created by kernel, they will have >> unique UUIDs. >> >> However UUID in root ite

Re: [PATCH v3 06/10] writeback: introduce super_operations->write_metadata

2018-01-03 Thread Dave Chinner
On Wed, Jan 03, 2018 at 02:59:21PM +0100, Jan Kara wrote: > On Wed 03-01-18 13:32:19, Dave Chinner wrote: > > I think we could probably block ->write_metadata if necessary via a > > completion/wakeup style notification when a specific LSN is reached > > by the log tail, but realistically if there's

Re: [PATCH v4 18/19] btrfs: only dirty the inode in btrfs_update_time if something was changed

2018-01-03 Thread Jeff Layton
On Fri, 2017-12-22 at 07:05 -0500, Jeff Layton wrote: > From: Jeff Layton > > At this point, we know that "now" and the file times may differ, and we > suspect that the i_version has been flagged to be bumped. Attempt to > bump the i_version, and only mark the inode dirty if that actually > occur

Re: [PATCH v3 06/10] writeback: introduce super_operations->write_metadata

2018-01-03 Thread Josef Bacik
On Wed, Jan 03, 2018 at 05:26:03PM +0100, Jan Kara wrote: > On Wed 03-01-18 10:49:33, Josef Bacik wrote: > > On Wed, Jan 03, 2018 at 02:59:21PM +0100, Jan Kara wrote: > > > On Wed 03-01-18 13:32:19, Dave Chinner wrote: > > > > On Tue, Jan 02, 2018 at 11:13:06AM -0500, Josef Bacik wrote: > > > > > O

Re: [PATCH v4 05/19] afs: convert to new i_version API

2018-01-03 Thread David Howells
Jeff Layton wrote: > Thanks! I updated that part of the the commit log to read: > > Note that AFS has quite a different definition for this counter. AFS > only increments it on changes to the data to the data in regular files > and contents of the directories. Inode metadata changes

Re: [PATCH v3 06/10] writeback: introduce super_operations->write_metadata

2018-01-03 Thread Jan Kara
On Wed 03-01-18 10:49:33, Josef Bacik wrote: > On Wed, Jan 03, 2018 at 02:59:21PM +0100, Jan Kara wrote: > > On Wed 03-01-18 13:32:19, Dave Chinner wrote: > > > On Tue, Jan 02, 2018 at 11:13:06AM -0500, Josef Bacik wrote: > > > > On Wed, Dec 20, 2017 at 03:30:55PM +0100, Jan Kara wrote: > > > > > O

Re: [PATCH v3 06/10] writeback: introduce super_operations->write_metadata

2018-01-03 Thread Josef Bacik
On Wed, Jan 03, 2018 at 02:59:21PM +0100, Jan Kara wrote: > On Wed 03-01-18 13:32:19, Dave Chinner wrote: > > On Tue, Jan 02, 2018 at 11:13:06AM -0500, Josef Bacik wrote: > > > On Wed, Dec 20, 2017 at 03:30:55PM +0100, Jan Kara wrote: > > > > On Wed 20-12-17 08:35:05, Dave Chinner wrote: > > > > >

Re: [PATCH] Btrfs: replace raid56 stripe bubble sort with insert sort

2018-01-03 Thread Timofey Titovets
2018-01-03 14:40 GMT+03:00 Filipe Manana : > On Thu, Dec 28, 2017 at 3:28 PM, Timofey Titovets > wrote: >> Insert sort are generaly perform better then bubble sort, >> by have less iterations on avarage. >> That version also try place element to right position >> instead of raw swap. >> >> I'm no

Re: [PATCH] btrfs: Don't generate UUID for non-fs tree

2018-01-03 Thread David Sterba
On Tue, Oct 31, 2017 at 02:08:16PM +0800, Qu Wenruo wrote: > btrfs_create_tree() will unconditionally generate UUID for any root. > So for quota tree and data reloc tree created by kernel, they will have > unique UUIDs. > > However UUID in root item is only referred by UUID tree, which only > reco

Re: [PATCH v3 06/10] writeback: introduce super_operations->write_metadata

2018-01-03 Thread Jan Kara
On Wed 03-01-18 13:32:19, Dave Chinner wrote: > On Tue, Jan 02, 2018 at 11:13:06AM -0500, Josef Bacik wrote: > > On Wed, Dec 20, 2017 at 03:30:55PM +0100, Jan Kara wrote: > > > On Wed 20-12-17 08:35:05, Dave Chinner wrote: > > > > On Tue, Dec 19, 2017 at 01:07:09PM +0100, Jan Kara wrote: > > > > >

Re: [PATCH] btrfs: not a disk error if the bio_add_page fails

2018-01-03 Thread Anand Jain
On 01/03/2018 07:34 PM, Filipe Manana wrote: On Wed, Jan 3, 2018 at 8:07 AM, Anand Jain wrote: bio_add_page() can fail for logical reasons as from the bio_add_page() comments:- 'This will only fail if either bio->bi_vcnt == bio->bi_max_vecs or it's a cloned bio.' Don't inc the write error sta

[PATCH v2] btrfs: not a disk error if the bio_add_page fails

2018-01-03 Thread Anand Jain
bio_add_page() can fail for logical reasons as from the bio_add_page() comments:- 'This will only fail if either bio->bi_vcnt == bio->bi_max_vecs or it's a cloned bio.' Don't inc the write error statistics for this. And set -EINVAL instead of -EIO. Signed-off-by: Anand Jain --- v1->v2: Add missin

Re: [PATCH] Btrfs: replace raid56 stripe bubble sort with insert sort

2018-01-03 Thread Filipe Manana
On Thu, Dec 28, 2017 at 3:28 PM, Timofey Titovets wrote: > Insert sort are generaly perform better then bubble sort, > by have less iterations on avarage. > That version also try place element to right position > instead of raw swap. > > I'm not sure how many stripes per bio raid56, > btrfs try to

Re: [PATCH] btrfs: not a disk error if the bio_add_page fails

2018-01-03 Thread Filipe Manana
On Wed, Jan 3, 2018 at 8:07 AM, Anand Jain wrote: > bio_add_page() can fail for logical reasons as from the bio_add_page() > comments:- 'This will only fail if either > bio->bi_vcnt == bio->bi_max_vecs or it's a cloned bio.' Don't inc the > write error statistics for this. And set -EINVAL instead

Re: Kernel crash during btrfs scrub

2018-01-03 Thread Qu Wenruo
On 2018年01月03日 18:14, Dmitry Katsubo wrote: > On 2018-01-03 05:58, Qu Wenruo wrote: >> On 2018年01月03日 09:12, Dmitry Katsubo wrote: >>> Dear btrfs team, >>> >>> I send a kernel crash report which I have observed recently during btrfs >>> scrub. >>> It looks like scrub itself has completed without

Re: Kernel crash during btrfs scrub

2018-01-03 Thread Dmitry Katsubo
On 2018-01-03 05:58, Qu Wenruo wrote: > On 2018年01月03日 09:12, Dmitry Katsubo wrote: >> Dear btrfs team, >> >> I send a kernel crash report which I have observed recently during btrfs >> scrub. >> It looks like scrub itself has completed without errors. > > It's not a kernel crash (if I didn't mis

Re: [PATCH 0/5] Cleanups for later btrfs_alloc_chunk() rework

2018-01-03 Thread Su Yue
On 01/03/2018 03:13 PM, Qu Wenruo wrote: Just small cleanups for incoming btrfs_alloc_chunk() rework, which is designed to allow btrfs_alloc_chunk() to be able to alloc meta chunk, even current meta chunks are already full. The cleanups are quite small, most of them are just removing unnecessa

[PATCH] btrfs: rename btrfs_device::scrub_device to scrub_ctx

2018-01-03 Thread Anand Jain
btrfs_device::scrub_device is not a device which is being scrubbed, but it holds the scrub context, so rename to reflect the same. No functional changes here. Signed-off-by: Anand Jain --- fs/btrfs/scrub.c | 14 +++--- fs/btrfs/volumes.h | 2 +- 2 files changed, 8 insertions(+), 8 del

[PATCH] btrfs: not a disk error if the bio_add_page fails

2018-01-03 Thread Anand Jain
bio_add_page() can fail for logical reasons as from the bio_add_page() comments:- 'This will only fail if either bio->bi_vcnt == bio->bi_max_vecs or it's a cloned bio.' Don't inc the write error statistics for this. And set -EINVAL instead of -EIO. Signed-off-by: Anand Jain --- fs/btrfs/scrub.c