[PATCH] btrfs-progs: print-tree: remove dead code from btrfs_print_tree

2018-04-08 Thread Lu Fengqi
Since the out label has been deleted, this free_extent_buffer will never be executed. Fixes: f37ae8d275c2 ("btrfs-progs: print-tree: Enhance warning on tree block level mismatch and error handling") Signed-off-by: Lu Fengqi --- print-tree.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/p

Re: [PATCH] btrfs: print-tree: output enhancement

2018-04-08 Thread Lu Fengqi
On Mon, Apr 09, 2018 at 02:05:37PM +0800, Qu Wenruo wrote: >This patch enhance the following things: > >- tree block header > * add generation and owner output for node and leaf >- node pointer generation output >- allow btrfs_print_tree() to not follow nodes > * just like btrfs-progs > >Please n

[PATCH] btrfs: print-tree: output enhancement

2018-04-08 Thread Qu Wenruo
This patch enhance the following things: - tree block header * add generation and owner output for node and leaf - node pointer generation output - allow btrfs_print_tree() to not follow nodes * just like btrfs-progs Please note that, although function btrfs_print_tree() is not called by anyo

[PATCH] btrfs-progs: remove unused function path_cat and path_cat3

2018-04-08 Thread Gu Jinxiang
Since function path_cat and path_cat3 are not used anymore, remove them. Signed-off-by: Gu Jinxiang --- send-utils.c | 25 - send-utils.h | 9 - 2 files changed, 34 deletions(-) diff --git a/send-utils.c b/send-utils.c index b5289e76..3ecbdea6 100644 --- a/send-

[PATCH v3] fstests: btrfs/159 superblock corruption test case

2018-04-08 Thread Anand Jain
Verify if the superblock corruption is handled correctly. Signed-off-by: Anand Jain --- v2->v3: Provide the disk to be corrupted as an arg, instead of swapping the devices, so drop mount_opt_minus_args(). 159.out slightly changed. v1->v2: $subject slightly changed Added more info about the

Re: [PATCH v2] fstests: btrfs/159 superblock corruption test case

2018-04-08 Thread Anand Jain
+mount_opt_minus_args() +{ + local nr + local mnt_opt="" + + nr=`_scratch_mount_options | awk '{print NF}'` + if [ $nr -eq 4 ]; then Seems this only works with "scratch_mount_options" returns something like: "-o opt dev mnt" or "-o opt1,opt2 dev mnt" but not "-oopt

[PATCH] btrfs-progs: mark -f option of btrfs scrub start deprecated

2018-04-08 Thread Gu Jinxiang
Since in the commit below detect the scrub information automatically, -f option is no more need. Let's make it deprecated. commit d5fd05a773e2 ("btrfs-progs: scrub, detect stale information in the status file") Signed-off-by: Gu Jinxiang --- Documentation/btrfs-scrub.asciidoc | 9 ++--- cmds

Re: [PATCH] btrfs: Fix possible softlock on single core machines

2018-04-08 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed because it contains a "Fixes:" tag, fixing commit: 6d74119f1a3e Btrfs: avoid taking the chunk_mutex in do_chunk_alloc. The bot has also determined it's probably a bug fixing patch. (score: 55.2868) The bot has tested the following

btrfs check lowmem, referencer count mismatch

2018-04-08 Thread Chris Murphy
Hi, btrfs-progs 4.16, kernel 4.16 --mode original comes up with no errors, --mode lowmem comes up with a bunch of "referencer count mismatch" messages and also ERROR: errors found in extent allocation tree or chunk allocation, and most of the byte totals differ as well. lowmem found 80724172390

Re: Unable to compile btrfs progs 4.16 on ubuntu Xenial

2018-04-08 Thread Menion
Ok, that was missing, also python3—setuptools is required. I think it is worth to add in the wiki the packages dependencies Bye 2018-04-08 10:51 GMT+02:00 Nikolay Borisov : > > > On 7.04.2018 20:16, Menion wrote: >> Hi all >> Apparently it is not possible to compile with python bindings the >> bt

Re: [PATCH] fstests: generic test for fsync after fallocate

2018-04-08 Thread Filipe Manana
On Sun, Apr 8, 2018 at 3:07 AM, Eryu Guan wrote: > On Thu, Apr 05, 2018 at 10:56:14PM +0100, fdman...@kernel.org wrote: >> From: Filipe Manana >> >> Test that fsync operations preserve extents allocated with fallocate(2) >> that are placed beyond a file's size. >> >> This test is motivated by a b

Re: Unable to compile btrfs progs 4.16 on ubuntu Xenial

2018-04-08 Thread Nikolay Borisov
On 7.04.2018 20:16, Menion wrote: > Hi all > Apparently it is not possible to compile with python bindings the > btrfs progs on ubuntu xenial > > checking for a Python interpreter with version >= 3.4... python3 > checking for python3... /usr/bin/python3 > checking for python3 version... 3.5 > c

Re: [PATCH v2] fstests: test btrfs fsync after hole punching with no-holes mode

2018-04-08 Thread Filipe Manana
On Sun, Apr 8, 2018 at 8:46 AM, Eryu Guan wrote: > On Wed, Mar 28, 2018 at 12:55:30PM +0100, fdman...@kernel.org wrote: >> From: Filipe Manana >> >> Test that when we have the no-holes mode enabled and a specific metadata >> layout, if we punch a hole and fsync the file, at replay time the whole

Re: Unable to compile btrfs progs 4.16 on ubuntu Xenial

2018-04-08 Thread Nikolay Borisov
On 8.04.2018 11:11, Menion wrote: > ./configure --prefix=/usr --disable-documentation --enable-zstd I was able to reproduce with --prefix added, thanks. > > 2018-04-08 9:17 GMT+02:00 Nikolay Borisov : >> >> >> On 7.04.2018 23:40, Menion wrote: >>> I am adding - - prefix=/usr that seems you ar

Re: Unable to compile btrfs progs 4.16 on ubuntu Xenial

2018-04-08 Thread Menion
./configure --prefix=/usr --disable-documentation --enable-zstd 2018-04-08 9:17 GMT+02:00 Nikolay Borisov : > > > On 7.04.2018 23:40, Menion wrote: >> I am adding - - prefix=/usr that seems you are not using >> > > Clearly you haven't shared all the necessary information, post your > entire confi

Re: [PATCH v2] fstests: test btrfs fsync after hole punching with no-holes mode

2018-04-08 Thread Eryu Guan
On Wed, Mar 28, 2018 at 12:55:30PM +0100, fdman...@kernel.org wrote: > From: Filipe Manana > > Test that when we have the no-holes mode enabled and a specific metadata > layout, if we punch a hole and fsync the file, at replay time the whole > hole was preserved. > > This issue is fixed by the f

Re: Unable to compile btrfs progs 4.16 on ubuntu Xenial

2018-04-08 Thread Nikolay Borisov
On 7.04.2018 23:40, Menion wrote: > I am adding - - prefix=/usr that seems you are not using > Clearly you haven't shared all the necessary information, post your entire configure line > 2018-04-07 21:55 GMT+02:00 Nikolay Borisov : >> >> >> On 7.04.2018 20:16, Menion wrote: >>> Hi all >>> Ap