Re: [PATCH RFC 0/3] btrfs: Performance profiler support

2019-03-08 Thread Qu Wenruo
On 2019/3/9 下午2:21, Nikolay Borisov wrote: > > > On 7.03.19 г. 18:12 ч., David Sterba wrote: >> On Thu, Mar 07, 2019 at 10:18:49PM +0800, Qu Wenruo wrote: Well, most of that is answered by 'figure out how to use tracepoints and perf for that'. If there were not a whole subs

Re: [PATCH RFC 0/3] btrfs: Performance profiler support

2019-03-08 Thread Nikolay Borisov
On 7.03.19 г. 18:12 ч., David Sterba wrote: > On Thu, Mar 07, 2019 at 10:18:49PM +0800, Qu Wenruo wrote: >>> Well, most of that is answered by 'figure out how to use tracepoints and >>> perf for that'. >>> >>> If there were not a whole substystem, actively maintained and >>> documented, implemen

Re: [PATCH 1/3] btrfs: tree-checker: Verify chunk items

2019-03-08 Thread Nikolay Borisov
On 8.03.19 г. 9:29 ч., Qu Wenruo wrote: > We already have btrfs_check_chunk_valid() to verify each chunk before > tree-checker. > > Merge that function into tree-checker, and update its error message to > be more readable. > > Old error message would be something like: > BTRFS error (device

Re: [PATCH v5 9/9] btrfs: kill btrfs_setxattr

2019-03-08 Thread Anand Jain
On 3/8/19 10:56 PM, David Sterba wrote: On Fri, Mar 01, 2019 at 12:34:55PM +0800, Anand Jain wrote: Now btrfs_setxattr() is a very small function with just check for readonly FS and redirect the call to do_setxattr(). So instead move that checks to the parent functions and call do_setxattr()

Re: [PATCH v5 0/9] Misc props.c cleanups

2019-03-08 Thread Anand Jain
On 3/8/19 11:01 PM, David Sterba wrote: On Fri, Mar 01, 2019 at 12:34:46PM +0800, Anand Jain wrote: v5: drops patch [PATCH v4 03/10] btrfs: trivial, fix c coding style Chanegs are mainly to use BUG_ON instead of ASSERT as in the original code in patches 5-7/9. Fix ASSERT in 8/

Re: Full balance put me in read only state

2019-03-08 Thread Tyler Richmond
I was getting some random hangs reading/writing to my FS, and I hadn't done a full rebalance for a while. I took all of my services offline and let the balance run for a few days. However, it appears to have screwed me. Here's what my fs show looks like now: Total devices 6 FS bytes used 20537

Re: [PATCH] generic: add test for fsync after shrinking truncate and rename

2019-03-08 Thread Vijay Chidambaram
On Thu, Mar 7, 2019 at 10:35 PM Dave Chinner wrote: > > On Thu, Mar 07, 2019 at 05:19:51PM -0600, Jayashree Mohan wrote: > > Hi Amir, > > > > > I went back to look at similar fsync tests by Filipe: > > > generic/{106,107,335,336,341,342,343,348,498,501,502,509,510,512} > > > > > > I found some all

Re: [PATCH v5 0/9] Misc props.c cleanups

2019-03-08 Thread David Sterba
On Fri, Mar 01, 2019 at 12:34:46PM +0800, Anand Jain wrote: > v5: drops patch > [PATCH v4 03/10] btrfs: trivial, fix c coding style > Chanegs are mainly to use BUG_ON instead of ASSERT as in the > original code in patches 5-7/9. Fix ASSERT in 8/9. And add > a rename in 9/9. Each

Re: [PATCH v5 9/9] btrfs: kill btrfs_setxattr

2019-03-08 Thread David Sterba
On Fri, Mar 01, 2019 at 12:34:55PM +0800, Anand Jain wrote: > Now btrfs_setxattr() is a very small function with just check for > readonly FS and redirect the call to do_setxattr(). So instead > move that checks to the parent functions and call do_setxattr() > directly. Delete original btrfs_setxa

Re: [PATCH v5 6/9] btrfs: start transaction in btrfs_set_acl

2019-03-08 Thread David Sterba
On Fri, Mar 01, 2019 at 12:34:52PM +0800, Anand Jain wrote: > The main motivation is to avoid NULL for the trans argument reaching > btrfs_set_xattr(). This patch does the following in btrfs_set_acl(). > Create transaction and handle the inode changes update, (copies code > from btrfs_setxatt

Re: [PATCH v5 4/9] btrfs: refactor btrfs_set_prop add btrfs_set_prop_trans

2019-03-08 Thread David Sterba
On Fri, Mar 01, 2019 at 12:34:50PM +0800, Anand Jain wrote: > btrfs_set_prop() accepts transaction pointer as the first argument, > however in ioctl.c for the purpose of setting the compression property, > we call btrfs_set_prop() with NULL transaction pointer. Down in > the call chain btrfs_setxa

Re: [PATCH] Btrfs: fix incorrect file size after shrinking truncate and fsync

2019-03-08 Thread David Sterba
On Mon, Mar 04, 2019 at 02:06:12PM +, fdman...@kernel.org wrote: > From: Filipe Manana > > If we do a shrinking truncate against an inode which is already present > in the respective log tree and then rename it, as part of logging the new > name we end up logging an inode item that reflects t

Re: Reproducer for "compressed data + hole data corruption bug, 2018 edition" still works on 4.20.7

2019-03-08 Thread Austin S. Hemmelgarn
On 2019-03-07 15:07, Zygo Blaxell wrote: On Mon, Mar 04, 2019 at 04:34:39PM +0100, Christoph Anton Mitterer wrote: Hey. Thanks for your elaborate explanations :-) On Fri, 2019-02-15 at 00:40 -0500, Zygo Blaxell wrote: The problem occurs only on reads. Data that is written to disk will be O

Re: Reproducer for "compressed data + hole data corruption bug, 2018 edition" still works on 4.20.7

2019-03-08 Thread Filipe Manana
On Thu, Mar 7, 2019 at 8:14 PM Zygo Blaxell wrote: > > On Mon, Mar 04, 2019 at 04:34:39PM +0100, Christoph Anton Mitterer wrote: > > Hey. > > > > > > Thanks for your elaborate explanations :-) > > > > > > On Fri, 2019-02-15 at 00:40 -0500, Zygo Blaxell wrote: > > > The problem occurs only on reads