Re: "btrfs: harden agaist duplicate fsid" spams syslog

2019-07-11 Thread Christoph Anton Mitterer
I'm also seeing these since quite a while on Debian sid: Jul 11 13:33:56 heisenberg kernel: BTRFS info (device dm-0): device fsid 60[...]3c devid 1 moved old:/dev/mapper/system new:/dev/dm-0 Jul 11 13:33:56 heisenberg kernel: BTRFS info (device dm-0): device fsid 60[...]3c devid 1 moved old:/dev

Re: [PATCH 3/5] Btrfs: only associate the locked page with one async_cow struct

2019-07-11 Thread Chris Mason
On 11 Jul 2019, at 12:00, Nikolay Borisov wrote: > On 10.07.19 г. 22:28 ч., Tejun Heo wrote: >> From: Chris Mason >> >> The btrfs writepages function collects a large range of pages flagged >> for delayed allocation, and then sends them down through the COW code >> for processing. When compressi

Re: "btrfs: harden agaist duplicate fsid" spams syslog

2019-07-11 Thread Graham Cobb
On 11/07/2019 03:46, Anand Jain wrote: > Now the question I am trying to understand, why same device is being > scanned every 2 mins, even though its already mount-ed. I am guessing > its toggling the same device paths trying to mount the device-path > which is not mounted. So autofs's check for th

Re: [PATCH 3/5] Btrfs: only associate the locked page with one async_cow struct

2019-07-11 Thread Nikolay Borisov
On 10.07.19 г. 22:28 ч., Tejun Heo wrote: > From: Chris Mason > > The btrfs writepages function collects a large range of pages flagged > for delayed allocation, and then sends them down through the COW code > for processing. When compression is on, we allocate one async_cow nit: The code no

[PATCH] btrfs: free checksum hash on in close_ctree

2019-07-11 Thread Johannes Thumshirn
fs_info::csum_hash gets initialized in btrfs_init_csum_hash() which is called by open_ctree(). But it only gets freed if open_ctree() fails, not on normal operation. This leads to a memory leak like the following found by kmemleak: unreferenced object 0x888132cb8720 (size 96): comm "mount",

Re: [PATCH 2/5] Btrfs: delete the entire async bio submission framework

2019-07-11 Thread Nikolay Borisov
On 10.07.19 г. 22:28 ч., Tejun Heo wrote: > From: Chris Mason > > Now that we're not using btrfs_schedule_bio() anymore, delete all the > code that supported it. > > Signed-off-by: Chris Mason > Reviewed-by: Josef Bacik Reviewed-by: Nikolay Borisov > --- > fs/btrfs/ctree.h | 1 - > f

Re: [PATCH 1/5] Btrfs: stop using btrfs_schedule_bio()

2019-07-11 Thread Nikolay Borisov
On 10.07.19 г. 22:28 ч., Tejun Heo wrote: > From: Chris Mason > > btrfs_schedule_bio() hands IO off to a helper thread to do the actual > submit_bio() call. This has been used to make sure async crc and > compression helpers don't get stuck on IO submission. To maintain good > performance, o

Re: Btrfs Bug Report

2019-07-11 Thread Qu Wenruo
On 2019/7/9 上午8:49, Jungyeon Yoon wrote: > Hi btrfs developers, > > I'm Jungyeon Yoon. I have reported btrfs bug before. > Some of them have marked to fixed thanks to your efforts. > Additionally following bugs seems also fixed as I've checked. > If okay, I would like to close following bugs, to