Re: [PATCH 5.10.x] btrfs: fix crash after non-aligned direct IO write with O_DSYNC

Hi, > This bug only affects 5.10 kernels, and the regression was introduced in > 5.10-rc1 by commit 0eb79294dbe328 ("btrfs: dio iomap DSYNC workaround"). > The bug does not exist in 5.11 kernels due to commit ecfdc08b8cc65d > ("btrfs: remove dio iomap DSYNC workaround"), which depends on other > c

Re: is BTRFS_IOC_DEFRAG behavior optimal?

On Thu, Feb 11, 2021 at 01:46:07AM -0700, Chris Murphy wrote: > On Wed, Feb 10, 2021 at 11:12 PM Zygo Blaxell > wrote: > > > > > > If we want the data compressed (and who doesn't? journal data compresses > > 8:1 with btrfs zstd) then we'll always need to make a copy at close. > > Because system

Re: [PATCH RFC 4/6] btrfs: Check if the filesystem is has mixed type of devices

On Fri, Feb 12, 2021 at 06:26:41PM +, Michal Rostecki wrote: > On Wed, Feb 10, 2021 at 05:08:05AM +0100, Michał Mirosław wrote: > > On Tue, Feb 09, 2021 at 09:30:38PM +0100, Michal Rostecki wrote: > > > From: Michal Rostecki > > > > > > Add the btrfs_check_mixed() function which checks if the

Re: [PATCH RFC 4/6] btrfs: Check if the filesystem is has mixed type of devices

On Wed, Feb 10, 2021 at 05:08:05AM +0100, Michał Mirosław wrote: > On Tue, Feb 09, 2021 at 09:30:38PM +0100, Michal Rostecki wrote: > > From: Michal Rostecki > > > > Add the btrfs_check_mixed() function which checks if the filesystem has > > the mixed type of devices (non-rotational and rotationa

Re: [PATCH 0/5] btrfs: support fsverity

On Thu, Feb 11, 2021 at 08:19:45PM -0500, Zygo Blaxell wrote: > On Thu, Feb 04, 2021 at 10:58:19PM -0800, Boris Burkov wrote: > > On Thu, Feb 04, 2021 at 10:13:54PM -0800, Eric Biggers wrote: > > > On Thu, Feb 04, 2021 at 03:21:36PM -0800, Boris Burkov wrote: > > > > This patchset provides support

Re: [PATCH RFC 6/6] btrfs: Add roundrobin raid1 read policy

Hi Anand, re: inflight calculation On Thu, Feb 11, 2021 at 03:55:33PM +, Michal Rostecki wrote: > > It is better to have random workloads in the above three categories > > of configs. > > > > Apart from the above three configs, there is also > > all-non-rotational with hetero > > For exampl

Re: [PATCH 4/5] btrfs: scrub_checksum_tree_block() drop its function declaration

On Wed, Feb 10, 2021 at 09:25:18PM -0800, Anand Jain wrote: > Move the static function scrub_checksum_tree_block() before its use in > the scrub.c, and drop its declaration. > > No functional changes. We've rejected patches that move static function within one file unless there's another reason f

Re: [PATCH] btrfs: initialize btrfs_fs_info::csum_size earlier in open_ctree()

On Thu, Feb 11, 2021 at 04:38:28PM +0800, Su Yue wrote: > User reported that btrfs-progs misc-tests/028-superblock-recover fails: > [TEST/misc] 028-superblock-recover > unexpected success: mounted fs with corrupted superblock > test failed for case 028-superblock-recover > > The test case ex