Re: [PATCH] fscrypt: rename fscrypt_info => fscrypt_inode_info

2023-10-09 Thread Neal Gompa
On Sun, Oct 8, 2023 at 11:44 PM Eric Biggers wrote: > > On Sun, Oct 08, 2023 at 02:11:36AM -0400, Neal Gompa wrote: > > > > Looks reasonable to me. > > > > Reviewed-by: Neal Gompa > > > > Thanks. BTW, please only quote the part that you're replying to. > Well, I was replying to the whole patch,

Re: [PATCH][next] btrfs: Add __counted_by for struct btrfs_delayed_item and use struct_size()

2023-10-09 Thread David Sterba
On Mon, Oct 09, 2023 at 02:44:54PM -0600, Gustavo A. R. Silva wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time via CONFIG_UBSAN_BOUNDS (for > array

Re: [PATCH][next] btrfs: Add __counted_by for struct btrfs_delayed_item and use struct_size()

2023-10-09 Thread Kees Cook
On Mon, Oct 09, 2023 at 02:44:54PM -0600, Gustavo A. R. Silva wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time via CONFIG_UBSAN_BOUNDS (for > array

[PATCH][next] btrfs: Add __counted_by for struct btrfs_delayed_item and use struct_size()

2023-10-09 Thread Gustavo A. R. Silva
Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family functions). W

Re: [syzbot] [zstd] UBSAN: array-index-out-of-bounds in FSE_decompress_wksp_body_bmi2

2023-10-09 Thread Kees Cook
On Sat, Oct 07, 2023 at 02:05:56PM -0700, Eric Biggers wrote: > Hi Nick, > > On Wed, Aug 30, 2023 at 12:49:53AM -0700, syzbot wrote: > > UBSAN: array-index-out-of-bounds in lib/zstd/common/fse_decompress.c:345:30 > > index 33 is out of range for type 'FSE_DTable[1]' (aka 'unsigned int[1]') > > Zs