Re: [PATCH v3 19/25] cxl/region/extent: Expose region extent information in sysfs

2024-08-22 Thread Ira Weiny
Dave Jiang wrote: > > > On 8/16/24 7:44 AM, ira.we...@intel.com wrote: > > From: Navneet Singh > > > > Extent information can be helpful to the user to coordinate memory usage > > with the external orchestrator and FM. > > > > Expose the details of region extents by creating the following > >

Re: [PATCH v3 18/25] cxl/extent: Process DCD events and realize region extents

2024-08-22 Thread Ira Weiny
Dave Jiang wrote: > > > On 8/16/24 7:44 AM, ira.we...@intel.com wrote: > > From: Navneet Singh > > [snip] > > > > Process DCD events and create region devices. > > > > Signed-off-by: Navneet Singh > > Co-developed-by: Ira Weiny > > Signed-off-by: Ira Weiny > > A few nits below, but in g

Re: [PATCH v3 11/25] cxl/mem: Expose DCD partition capabilities in sysfs

2024-08-22 Thread Ira Weiny
Dave Jiang wrote: > > > On 8/16/24 7:44 AM, ira.we...@intel.com wrote: > > From: Navneet Singh > > > > To properly configure CXL regions on Dynamic Capacity Devices (DCD), > > user space will need to know the details of the DC partitions available. > > > > Expose dynamic capacity capabilities

Re: [PATCH v3 09/25] cxl/hdm: Add dynamic capacity size support to endpoint decoders

2024-08-22 Thread Ira Weiny
Dave Jiang wrote: > > > On 8/16/24 7:44 AM, ira.we...@intel.com wrote: > > From: Navneet Singh > > [snip] > > +static int dc_mode_to_region_index(enum cxl_decoder_mode mode) > > +{ > > + return mode - CXL_DECODER_DC0; > > +} > > + > > +static int cxl_request_skip(struct cxl_endpoint_decoder

Re: [PATCH v3 06/25] cxl/mem: Read dynamic capacity configuration from the device

2024-08-22 Thread Ira Weiny
Fan Ni wrote: > On Fri, Aug 16, 2024 at 02:45:47PM -0700, Dave Jiang wrote: [snip] > > > + > > > +/** > > > + * cxl_dev_dynamic_capacity_identify() - Reads the dynamic capacity > > > + *information from the device. > > > + * @mds: The memory device state >

Re: [PATCH v3 06/25] cxl/mem: Read dynamic capacity configuration from the device

2024-08-22 Thread Ira Weiny
Fan Ni wrote: > On Fri, Aug 16, 2024 at 02:45:47PM -0700, Dave Jiang wrote: > > > > > + > > > +/** > > > + * cxl_dev_dynamic_capacity_identify() - Reads the dynamic capacity > > > + *information from the device. > > > + * @mds: The memory device state > > >

Re: [PATCH v3 15/25] cxl/pci: Factor out interrupt policy check

2024-08-22 Thread Fan Ni
On Fri, Aug 16, 2024 at 09:44:23AM -0500, Ira Weiny wrote: > Dynamic Capacity Devices (DCD) require event interrupts to process > memory addition or removal. BIOS may have control over non-DCD event > processing. DCD interrupt configuration needs to be separate from > memory event interrupt confi

Re: [PATCH v3 14/25] cxl/events: Split event msgnum configuration from irq setup

2024-08-22 Thread Fan Ni
On Fri, Aug 16, 2024 at 09:44:22AM -0500, Ira Weiny wrote: > Dynamic Capacity Devices (DCD) require event interrupts to process > memory addition or removal. BIOS may have control over non-DCD event > processing. DCD interrupt configuration needs to be separate from > memory event interrupt confi

Re: [PATCH v3 12/25] cxl/region: Refactor common create region code

2024-08-22 Thread Fan Ni
On Fri, Aug 16, 2024 at 09:44:20AM -0500, Ira Weiny wrote: > create_pmem_region_store() and create_ram_region_store() are identical > with the exception of the region mode. With the addition of DC region > mode this would end up being 3 copies of the same code. > > Refactor create_pmem_region_sto

Re: [PATCH v3 13/25] cxl/region: Add sparse DAX region support

2024-08-22 Thread Fan Ni
On Fri, Aug 16, 2024 at 09:44:21AM -0500, ira.we...@intel.com wrote: > From: Navneet Singh > > Dynamic Capacity CXL regions must allow memory to be added or removed > dynamically. In addition to the quantity of memory available the > location of the memory within a DC partition is dynamic based

Re: [PATCH v3 02/25] printk: Add print format (%par) for struct range

2024-08-22 Thread Andy Shevchenko
On Thu, Aug 22, 2024 at 12:53:32PM -0500, Ira Weiny wrote: > Petr Mladek wrote: > > On Fri 2024-08-16 09:44:10, Ira Weiny wrote: ... > > > + %par[range 0x6000-0x6fff] or > > > > It seems that it is always 64-bit. It prints: > > > > struct range { > > u64 start; > > u64 e

Re: [PATCH v3 02/25] printk: Add print format (%par) for struct range

2024-08-22 Thread Ira Weiny
Petr Mladek wrote: > On Fri 2024-08-16 09:44:10, Ira Weiny wrote: > > The use of struct range in the CXL subsystem is growing. In particular, > > the addition of Dynamic Capacity devices uses struct range in a number > > of places which are reported in debug and error messages. > > > > To wit req