Re: [PATCH v4 21/28] cxl/extent: Process DCD events and realize region extents

2024-10-09 Thread Li, Ming4
On 10/10/2024 3:49 AM, Ira Weiny wrote: > Li, Ming4 wrote: >> On 10/8/2024 7:16 AM, ira.we...@intel.com wrote: >>> From: Navneet Singh >>> [snip] >>> +static int cxl_send_dc_response(struct cxl_memdev_state *mds, int opcode, >>> + struct xarray *extent_array, int cnt) >>>

Re: [PATCH v4 13/28] cxl/mem: Expose DCD partition capabilities in sysfs

2024-10-09 Thread Fan Ni
On Mon, Oct 07, 2024 at 06:16:19PM -0500, ira.we...@intel.com wrote: > From: Navneet Singh > > To properly configure CXL regions on Dynamic Capacity Devices (DCD), > user space will need to know the details of the DC partitions available. > > Expose dynamic capacity capabilities through sysfs. >

Re: [PATCH v4 21/28] cxl/extent: Process DCD events and realize region extents

2024-10-09 Thread Ira Weiny
Li, Ming4 wrote: > On 10/8/2024 7:16 AM, ira.we...@intel.com wrote: > > From: Navneet Singh > > [snip] > > > > Signed-off-by: Navneet Singh > > Co-developed-by: Ira Weiny > > Signed-off-by: Ira Weiny > > > Hi Ira, > > I guess you missed my comments for V3, I comment it again for this patch.

Re: [PATCH v4 12/28] cxl/cdat: Gather DSMAS data for DCD regions

2024-10-09 Thread Fan Ni
On Mon, Oct 07, 2024 at 06:16:18PM -0500, Ira Weiny wrote: > Additional DCD region (partition) information is contained in the DSMAS > CDAT tables, including performance, read only, and shareable attributes. > > Match DCD partitions with DSMAS tables and store the meta data. > > To: Robert Moore

Re: [PATCH v4 09/28] cxl/core: Separate region mode from decoder mode

2024-10-09 Thread Fan Ni
On Mon, Oct 07, 2024 at 06:16:15PM -0500, ira.we...@intel.com wrote: > From: Navneet Singh > > Until now region modes and decoder modes were equivalent in that both > modes were either PMEM or RAM. The addition of Dynamic > Capacity partitions defines up to 8 DC partitions per device. > > The r

Re: [PATCH v4 06/28] cxl/pci: Delay event buffer allocation

2024-10-09 Thread Fan Ni
On Mon, Oct 07, 2024 at 06:16:12PM -0500, Ira Weiny wrote: > The event buffer does not need to be allocated if something has failed in > setting up event irq's. > > In prep for adjusting event configuration for DCD events move the buffer > allocation to the end of the event configuration. > > Rev

Re: [PATCH v4 03/28] cxl/cdat: Use %pra for dpa range outputs

2024-10-09 Thread Fan Ni
On Mon, Oct 07, 2024 at 06:16:09PM -0500, Ira Weiny wrote: > Now that there is a printk specifier for struct range use it in > debug output of CDAT data. > > To: Petr Mladek > To: Steven Rostedt > To: Andy Shevchenko > To: Rasmus Villemoes > To: Sergey Senozhatsky > To: Jonathan Corbet (main

Re: [PATCH v4 02/28] printk: Add print format (%pra) for struct range

2024-10-09 Thread Fan Ni
On Mon, Oct 07, 2024 at 06:16:08PM -0500, Ira Weiny wrote: > The use of struct range in the CXL subsystem is growing. In particular, > the addition of Dynamic Capacity devices uses struct range in a number > of places which are reported in debug and error messages. > > To wit requiring the printi

Re: [PATCH v4 01/28] test printk: Add very basic struct resource tests

2024-10-09 Thread Fan Ni
On Mon, Oct 07, 2024 at 06:16:07PM -0500, Ira Weiny wrote: > The printk tests for struct resource were stubbed out. struct range > printing will leverage the struct resource implementation. > > To prevent regression add some basic sanity tests for struct resource. > > To: Petr Mladek > To: Stev

Re: [PATCH v4 04/28] range: Add range_overlaps()

2024-10-09 Thread Andy Shevchenko
On Wed, Oct 09, 2024 at 05:36:42PM +0200, David Sterba wrote: > On Wed, Oct 09, 2024 at 05:45:10PM +0300, Andy Shevchenko wrote: > > On Tue, Oct 08, 2024 at 06:10:32PM +0200, David Sterba wrote: > > > On Mon, Oct 07, 2024 at 06:16:10PM -0500, Ira Weiny wrote: ... > > > > +static inline bool range

Re: [PATCH v4 04/28] range: Add range_overlaps()

2024-10-09 Thread David Sterba
On Wed, Oct 09, 2024 at 05:45:10PM +0300, Andy Shevchenko wrote: > On Tue, Oct 08, 2024 at 06:10:32PM +0200, David Sterba wrote: > > On Mon, Oct 07, 2024 at 06:16:10PM -0500, Ira Weiny wrote: > > ... > > > > +static inline bool range_overlaps(struct range *r1, struct range *r2) > > > > I've noti

Re: [PATCH v4 04/28] range: Add range_overlaps()

2024-10-09 Thread Andy Shevchenko
On Wed, Oct 09, 2024 at 05:45:10PM +0300, Andy Shevchenko wrote: > On Tue, Oct 08, 2024 at 06:10:32PM +0200, David Sterba wrote: > > On Mon, Oct 07, 2024 at 06:16:10PM -0500, Ira Weiny wrote: ... > > > +static inline bool range_overlaps(struct range *r1, struct range *r2) > > > > I've noticed on

Re: [PATCH v4 04/28] range: Add range_overlaps()

2024-10-09 Thread Andy Shevchenko
On Tue, Oct 08, 2024 at 06:10:32PM +0200, David Sterba wrote: > On Mon, Oct 07, 2024 at 06:16:10PM -0500, Ira Weiny wrote: ... > > +static inline bool range_overlaps(struct range *r1, struct range *r2) > > I've noticed only now, you can constify the arguments, but this applise > to other range_*

Re: [PATCH v4 02/28] printk: Add print format (%pra) for struct range

2024-10-09 Thread Andy Shevchenko
On Wed, Oct 09, 2024 at 01:27:37PM +0100, Jonathan Cameron wrote: > On Tue, 8 Oct 2024 19:56:20 +0300 > Andy Shevchenko wrote: > > On Mon, Oct 07, 2024 at 06:16:08PM -0500, Ira Weiny wrote: ... > > > +static void __init > > > +struct_range(void) > > > +{ > > > + struct range test_range = { > > >

Re: [PATCH v4 12/28] cxl/cdat: Gather DSMAS data for DCD regions

2024-10-09 Thread Rafael J. Wysocki
On Tue, Oct 8, 2024 at 1:17 AM Ira Weiny wrote: > > Additional DCD region (partition) information is contained in the DSMAS > CDAT tables, including performance, read only, and shareable attributes. > > Match DCD partitions with DSMAS tables and store the meta data. > > To: Robert Moore > To: Raf

Re: [PATCH v4 02/28] printk: Add print format (%pra) for struct range

2024-10-09 Thread Andy Shevchenko
On Wed, Oct 09, 2024 at 03:30:14PM +0200, Rasmus Villemoes wrote: ... > Rather than the struct assignments, I think it's easier to read if you > just do > > struct range r; > > r.start = 0xc0ffee00ba5eba11; > r.end = r.start; > ... > > r.start = 0xc0ffee; > r.end = 0xba5eba11;

Re: [PATCH v4 02/28] printk: Add print format (%pra) for struct range

2024-10-09 Thread Rasmus Villemoes
Ira Weiny writes: > --- > Documentation/core-api/printk-formats.rst | 13 > lib/test_printf.c | 26 +++ > lib/vsprintf.c| 55 > +++ > 3 files changed, 88 insertions(+), 6 deletions(-) > > diff -

Re: [PATCH v4 09/28] cxl/core: Separate region mode from decoder mode

2024-10-09 Thread Jonathan Cameron
On Mon, 07 Oct 2024 18:16:15 -0500 ira.we...@intel.com wrote: > From: Navneet Singh > > Until now region modes and decoder modes were equivalent in that both > modes were either PMEM or RAM. The addition of Dynamic > Capacity partitions defines up to 8 DC partitions per device. > > The region

Re: [PATCH v4 08/28] cxl/mem: Read dynamic capacity configuration from the device

2024-10-09 Thread Jonathan Cameron
On Mon, 07 Oct 2024 18:16:14 -0500 ira.we...@intel.com wrote: > From: Navneet Singh > > Devices which optionally support Dynamic Capacity (DC) are configured > via mailbox commands. CXL 3.1 requires the host to issue the Get DC > Configuration command in order to properly configure DCDs. Witho

Re: [PATCH v4 05/28] dax: Document dax dev range tuple

2024-10-09 Thread Jonathan Cameron
On Mon, 07 Oct 2024 18:16:11 -0500 Ira Weiny wrote: > The device DAX structure is being enhanced to track additional DCD > information. > > The current range tuple was not fully documented. Document it prior to > adding information for DC. > > Suggested-by: Jonathan Cameron > Signed-off-by: I

Re: [PATCH v4 03/28] cxl/cdat: Use %pra for dpa range outputs

2024-10-09 Thread Jonathan Cameron
On Mon, 07 Oct 2024 18:16:09 -0500 Ira Weiny wrote: > Now that there is a printk specifier for struct range use it in > debug output of CDAT data. > > To: Petr Mladek > To: Steven Rostedt > To: Andy Shevchenko > To: Rasmus Villemoes > To: Sergey Senozhatsky > To: Jonathan Corbet (maintaine

Re: [PATCH v4 02/28] printk: Add print format (%pra) for struct range

2024-10-09 Thread Jonathan Cameron
On Tue, 8 Oct 2024 19:56:20 +0300 Andy Shevchenko wrote: > On Mon, Oct 07, 2024 at 06:16:08PM -0500, Ira Weiny wrote: > > The use of struct range in the CXL subsystem is growing. In particular, > > the addition of Dynamic Capacity devices uses struct range in a number > > of places which are rep

Re: [PATCH v4 01/28] test printk: Add very basic struct resource tests

2024-10-09 Thread Jonathan Cameron
On Mon, 07 Oct 2024 18:16:07 -0500 Ira Weiny wrote: > The printk tests for struct resource were stubbed out. struct range > printing will leverage the struct resource implementation. > > To prevent regression add some basic sanity tests for struct resource. > > To: Petr Mladek > To: Steven Ro