[PATCH/fstest] btrfs/139: correctly receive clones to mounted subvol

2017-02-22 Thread Benedikt Morbach
+# have an entry with the same name that corresponds to different inodes in each +# snapshot. +# +#------- +# Copyright (C) 2017 Benedikt Morbach. All Rights Reserved. +# Author: Benedikt Morbach +# based on 'btrfs/135',

[PATCH 1/2] btrfs-progs: receive: better error reporting for snapshots

2017-02-22 Thread Benedikt Morbach
subvol /tmp/test/dest.snap At snapshot dest.snap ERROR: creating snapshot . -> dest.snap failed: Read-only file system which is both more helpful and more correct. Signed-off-by: Benedikt Morbach --- cmds-receive.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --g

[PATCH 2/2] btrfs-progs: receive: handle root subvol path in clone

2017-02-22 Thread Benedikt Morbach
path in the target fs, if reachable from the mount point/chroot. This is exactly what process_snapshot does, which gets called on _every_ incremental receive and I'm quite certain is correct in doing so Signed-off-by: Benedikt Morbach --- Hi, I first tried fixing this

[PATCH] btrfs-progs: send-dump: add missing newlines

2017-02-22 Thread Benedikt Morbach
-02-22T11:59:16+0100 ctime=2017-02-22T11:59:16+0100 Signed-off-by: Benedikt Morbach --- send-dump.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/send-dump.c b/send-dump.c index 4c44246..67f7977 100644 --- a/send-dump.c +++ b/send-dump.c @@ -112,8 +112,10 @@ static

Re: [PATCH] receive: strip root subvol path during process_clone

2016-07-11 Thread Benedikt Morbach
Hi David, On Fri, Jun 17, 2016 at 7:18 PM, David Sterba wrote: > thanks for the fix. The mail thread holds enough information to > reproduce the issue, I'll get to that on Monday. I'm not sure about the > use of strstr to match the subvolume name so I want to write the tests > first and craft som

[PATCH] btrfs-progs: receive: handle root subvol path in clone

2016-06-14 Thread Benedikt Morbach
otherwise we get ERROR: cannot open : No such file or directory because / doesn't exist, so openat() will fail below. Signed-off-by: Benedikt Morbach --- resend with 'btrfs-progs:' in the subject. Sorry for the noise cheers cmds-receive.c | 11 +++ 1 f

Re: [PATCH] receive: strip root subvol path during process_clone

2016-06-14 Thread Benedikt Morbach
Hi all, this fixes http://thread.gmane.org/gmane.comp.file-systems.btrfs/56902  for me. I got to this via gdb + good old debug printf and tbh I'm not entirely clear about the semantics of process_clone, so some error handling might be missing here? Cheers Benedikt -- To unsubscribe from this lis

[PATCH] receive: strip root subvol path during process_clone

2016-06-14 Thread Benedikt Morbach
otherwise we get ERROR: cannot open : No such file or directory because / doesn't exist, so openat() will fail below. Signed-off-by: Benedikt Morbach --- cmds-receive.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/cmds-receive.c b/cmds-receive.c index f4a3a4f..a9

Re: [BUG] receive not seeing file that exists

2016-06-14 Thread Benedikt Morbach
Hi all, On Thu, Jun 2, 2016 at 9:26 AM, Benedikt Morbach wrote: > I've encountered a bug in btrfs-receive. When receiving a certain > incremental send, it will error with: > > ERROR: cannot open > backup/detritus/root/root.20160524T1800/var/log/journal/9cbb44cf160f4c108

Re: [BUG] receive not seeing file that exists

2016-06-02 Thread Benedikt Morbach
On Thu, Jun 2, 2016 at 6:35 PM, Chris Murphy wrote: > kernel and btrfs-profs versions? kernel: send:4.5.5 receive: 4.5.4 btrfs-progs (both): 4.5.3 -- Benedikt -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.o

[BUG] receive not seeing file that exists

2016-06-02 Thread Benedikt Morbach
Hi all, I've encountered a bug in btrfs-receive. When receiving a certain incremental send, it will error with: ERROR: cannot open backup/detritus/root/root.20160524T1800/var/log/journal/9cbb44cf160f4c1089f77e32ed376a0b/user-1000.journal: No such file or directory even though that path exist