Re: [PATCH v4 23/27] gfs2: clean up some filemap_* calls

2017-05-10 Thread Bob Peterson
that occur during the write | phase. | | Signed-off-by: Jeff Layton | --- Hi Jeff, This version looks better. ACK. Regards, Bob Peterson Red Hat File Systems -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org

Re: [PATCH v3 20/20] gfs2: clean up some filemap_* calls

2017-04-24 Thread Bob Peterson
Hi, - Original Message - | On Mon, 2017-04-24 at 10:12 -0400, Bob Peterson wrote: | > > + filemap_write_and_wait_range(mapping, gl->gl_vm.start, gl->gl_vm.end); | > | > This should probably have "error = ", no? | > | | This error is discarded in the c

Re: [PATCH v3 20/20] gfs2: clean up some filemap_* calls

2017-04-24 Thread Bob Peterson
metamapping); | - mapping_set_error(metamapping, error); This part doesn't look right at all. There's a big difference in gfs2 between mapping and metamapping. We need to wait for metamapping regardless. (snip) Regards, Bob Peterson Red Hat File Systems -- To unsubscribe from this l