[PATCH] btrfs-progs: check: add experimental flag for lowmem mode

2018-07-03 Thread David Disseldorp
The experimental flag is already carried in the manpage, but was removed from the btrfs check usage message as part of refactoring via 87c1bd13c1fca430c3dbf0da62e9aa33bde609c8. Add it back. Signed-off-by: David Disseldorp Reviewed-by: Nikolay Borisov --- check/main.c | 2 +- 1 file changed, 1

Re: [PATCH RFC 0/3] btrfs-progs: lowmem: delay before lowmem repair

2018-07-02 Thread David Disseldorp
On Mon, 2 Jul 2018 12:43:20 +0300, Nikolay Borisov wrote: > On 2.07.2018 12:28, Su Yue wrote: > > Since lowmem repair is dangerous, it should remind user more obviously. > > The patchset add 10 seconds delay like btrfs balance and add am option > > '--force-repair-lowmem' to skip the delay. >

Re: [PATCH] xfstests: btrfs: add test regarding clearing compression flag/property

2014-09-23 Thread David Disseldorp
in btrfs_ioctl_setflags Signed-off-by: Filipe Manana fdman...@suse.com I would have expected this to fail with MOUNT_OPTIONS=-o compress=no, but it looks as though Btrfs stores the attributes unconditionally. Either way this change looks good to me. Reviewed-by: David Disseldorp dd...@suse.de

[PATCH v2] btrfs-progs: fix typo in subvol list usage

2014-08-18 Thread David Disseldorp
Signed-off-by: David Disseldorp dd...@suse.de --- Documentation/btrfs-subvolume.txt | 2 +- cmds-subvolume.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/btrfs-subvolume.txt b/Documentation/btrfs-subvolume.txt index a519131..c8b9928 100644

[PATCH 0/2] xfstests: add cifs.ko server-side copy helper

2014-06-11 Thread David Disseldorp
the code overlap, I though it suitable to share the same source. Feedback appreciated. -- David Disseldorp (2): src/cloner: check filesystem type src/cloner: add CIFS_IOC_COPYCHUNK_FILE support configure.ac | 1 + src/cloner.c | 123

[PATCH 2/2] src/cloner: add CIFS_IOC_COPYCHUNK_FILE support

2014-06-11 Thread David Disseldorp
-off-by: David Disseldorp dd...@suse.de --- configure.ac | 1 + src/cloner.c | 78 +++- 2 files changed, 68 insertions(+), 11 deletions(-) diff --git a/configure.ac b/configure.ac index 53459d8..d038f95 100644 --- a/configure.ac +++ b

[PATCH 1/2] src/cloner: check filesystem type

2014-06-11 Thread David Disseldorp
Limit clone requests to Btrfs only for the moment. Signed-off-by: David Disseldorp dd...@suse.de --- src/cloner.c | 47 +++ 1 file changed, 47 insertions(+) diff --git a/src/cloner.c b/src/cloner.c index ccc2354..6fb40fa 100644 --- a/src/cloner.c

Re: [PATCH 2/2 v3] xfstests: add test for btrfs ioctl clone operation

2014-05-26 Thread David Disseldorp
by an application/user) regardless of the following options (and any combination): cow/nodatacow/compression. Looks good. Reviewed-by: David Disseldorp dd...@suse.de -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org

Re: [PATCH 1/2] xfstests: add helper require function _require_btrfs_cloner

2014-05-23 Thread David Disseldorp
/cloner + [ -x $CLONER_PROG ] || \ + _notrun cloner binary not present at $CLONER_PROG +} Would prefer to avoid the reliance on $here, but it appears that other common/rc functions make the same assumption. Reviewed-by: David Disseldorp dd...@suse.de Cheers, David

Re: [PATCH 2/2] xfstests: add test for btrfs ioctl clone operation

2014-05-23 Thread David Disseldorp
the source and target files are different. Signed-off-by: Filipe David Borba Manana fdman...@gmail.com Nice work Filipe. Reviewed-by: David Disseldorp dd...@suse.de Cheers, David -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord

Re: [PATCH] btrfs/035: update clone test to expect EOPNOTSUPP

2014-05-08 Thread David Disseldorp
Hi liubo, On Thu, 8 May 2014 12:11:24 +0800, Liu Bo wrote: Something different here, I didn't get EIO on 3.15.0-rc4. Strange, I'm able to consistently reproduce this on a vanilla v3.15-rc4-202-g30321c7 kernel. Does that mean the updated test passes successfully for you? Cheers, David -- To

[PATCH] btrfs/035: update clone test to expect EOPNOTSUPP

2014-05-07 Thread David Disseldorp
-off-by: David Disseldorp dd...@suse.de --- tests/btrfs/035 | 11 +++ tests/btrfs/035.out | 5 + 2 files changed, 16 insertions(+) diff --git a/tests/btrfs/035 b/tests/btrfs/035 index 6808179..c9530f6 100755 --- a/tests/btrfs/035 +++ b/tests/btrfs/035 @@ -57,21 +57,32 @@ src_str

[PATCH] btrfs-progs: fix typo in subvol list usage

2014-04-16 Thread David Disseldorp
Signed-off-by: David Disseldorp dd...@suse.de --- cmds-subvolume.c | 2 +- man/btrfs.8.in | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cmds-subvolume.c b/cmds-subvolume.c index 5e821c7..75a7385 100644 --- a/cmds-subvolume.c +++ b/cmds-subvolume.c @@ -390,7 +390,7

[PATCH] btrfs/035: update clone test to expect EOPNOTSUPP

2014-04-09 Thread David Disseldorp
With kernel commit 00fdf13a2e9f313a044288aa59d3b8ec29ff904a, the first clone-range overwrite attempt now fails with EOPNOTSUPP. FIXME: The second clone-range causes EIO on subsequent read attempts. Signed-off-by: David Disseldorp dd...@suse.de --- tests/btrfs/035 | 10 ++ tests

[PATCH] Btrfs: fix a crash of clone with inline extents's split

2014-04-09 Thread David Disseldorp
Thanks for the BUG_ON() fix here. Strangely, I'm now seeing EIO returned for reads following the second clone-range. Please see the subsequent xfstests patch. Cheers, David -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to

Re: Snapper on Ubuntu

2014-03-15 Thread David Disseldorp
On Sat, 15 Mar 2014 18:47:49 +0100 Hendrik Friedel hend...@friedels.name wrote: I think you may have forgotten to specify the config snapper is supposed to use. Try # snapper -c home create # snapper -c Video create Thanks, that was it. I would have expected an Error-Message

xfstests btrfs/035 (was Re: Testing BTRFS)

2014-03-12 Thread David Disseldorp
Hi Eric, On Tue, 11 Mar 2014 14:08:02 -0500, Eric Sandeen wrote: Indeed, testing 3.8.13-26.2.1.el6uek.x86_64 (which is, I believe, the kernel which Avi referred to) via xfstests, I saw failures on btrfs/009 and btrfs/022; then the box deadlocked on btrfs/024. I rebooted resumed, then

Re: [PATCH v3 0/3] __btrfs_drop_extents() BUG_ON reproducer

2014-02-14 Thread David Disseldorp
Ping, any Btrfsers get a chance to look at this patch series? I'd like to get it into the QA tree. On Fri, 7 Feb 2014 11:35:38 +0100, David Disseldorp wrote: This patch-set provides a reproducer for hitting the 3.14.0-rc1 BUG_ON() at: 692 int __btrfs_drop_extents(struct btrfs_trans_handle

Re: [PATCH v2 3/3] btrfs/035: add new clone overwrite regression test

2014-02-07 Thread David Disseldorp
On Fri, 7 Feb 2014 09:45:09 +1100, Dave Chinner wrote: Not exactly what I intended. If echo fails, it will output some kind of error message, and that will cause the golden image mismatch. Fair enough. I'll resend with the two ' || echo failed to create src' checks removed. Thanks again

[PATCH v3 3/3] btrfs/035: add new clone overwrite regression test

2014-02-07 Thread David Disseldorp
This test uses the newly added cloner binary to dispatch full file and range specific clone (reflink) requests. Signed-off-by: David Disseldorp dd...@suse.de --- tests/btrfs/035 | 77 + tests/btrfs/035.out | 3 +++ tests/btrfs/group | 1

[PATCH v3 0/3] __btrfs_drop_extents() BUG_ON reproducer

2014-02-07 Thread David Disseldorp
This patch-set provides a reproducer for hitting the 3.14.0-rc1 BUG_ON() at: 692 int __btrfs_drop_extents(struct btrfs_trans_handle *trans, ... 839 /* 840 * | range to drop - | 841 * | extent | 842

[PATCH v3 1/3] btrfs: add small program for clone testing

2014-02-07 Thread David Disseldorp
The cloner program is capable of cloning files using the BTRFS_IOC_CLONE and BTRFS_IOC_CLONE_RANGE ioctls. Signed-off-by: David Disseldorp dd...@suse.de --- .gitignore | 1 + src/Makefile | 2 +- src/cloner.c | 188 +++ 3 files

[PATCH v3 2/3] src/cloner: use btrfs/ioctl.h header if present

2014-02-07 Thread David Disseldorp
Check for the btrfsprogs-devel ioctl.h header at configure time. Use it in src/cloner if present, otherwise fall back to using the copied clone ioctl definitions. Signed-off-by: David Disseldorp dd...@suse.de --- configure.ac | 1 + src/cloner.c | 4 2 files changed, 5 insertions(+) diff

Re: [PATCH 1/2] btrfs: add small program for clone testing

2014-02-06 Thread David Disseldorp
Hi Dave, On Thu, 6 Feb 2014 10:09:36 +1100, Dave Chinner wrote: On Wed, Feb 05, 2014 at 12:16:48PM +0100, David Disseldorp wrote: The cloner program is capable of cloning files using the BTRFS_IOC_CLONE and BTRFS_IOC_CLONE_RANGE ioctls. Signed-off-by: David Disseldorp dd...@suse.de

[PATCH v2 0/3] __btrfs_drop_extents() BUG_ON reproducer

2014-02-06 Thread David Disseldorp
This patch-set provides a reproducer for hitting the 3.14.0-rc1 BUG_ON() at: 692 int __btrfs_drop_extents(struct btrfs_trans_handle *trans, ... 839 /* 840 * | range to drop - | 841 * | extent | 842

[PATCH v2 2/3] src/cloner: use btrfs/ioctl.h header if present

2014-02-06 Thread David Disseldorp
Check for the btrfsprogs-devel ioctl.h header at configure time. Use it in src/cloner if present, otherwise fall back to using the copied clone ioctl definitions. Signed-off-by: David Disseldorp dd...@suse.de --- configure.ac | 1 + src/cloner.c | 4 2 files changed, 5 insertions(+) diff

[PATCH v2 1/3] btrfs: add small program for clone testing

2014-02-06 Thread David Disseldorp
The cloner program is capable of cloning files using the BTRFS_IOC_CLONE and BTRFS_IOC_CLONE_RANGE ioctls. Signed-off-by: David Disseldorp dd...@suse.de --- .gitignore | 1 + src/Makefile | 2 +- src/cloner.c | 188 +++ 3 files

[PATCH v2 3/3] btrfs/035: add new clone overwrite regression test

2014-02-06 Thread David Disseldorp
This test uses the newly added cloner binary to dispatch full file and range specific clone (reflink) requests. Signed-off-by: David Disseldorp dd...@suse.de --- tests/btrfs/035 | 77 + tests/btrfs/035.out | 3 +++ tests/btrfs/group | 1

[PATCH] ioctl: add note regarding CLONE_RANGE(len=0) behaviour

2014-02-06 Thread David Disseldorp
A BTRFS_IOC_CLONE_RANGE request with a src_length value of zero has the effect of cloning all data from src_offset through to end-of-file. Document this behaviour in the header file for those who (like me) incorrectly assume that no data is cloned in such a case. Signed-off-by: David Disseldorp

[PATCH 2/2] btrfs/035: add new clone overwrite regression test

2014-02-05 Thread David Disseldorp
This test uses the newly added cloner binary to dispatch full file and range specific clone (reflink) requests. Signed-off-by: David Disseldorp dd...@suse.de --- tests/btrfs/035 | 76 + tests/btrfs/035.out | 3 +++ tests/btrfs/group | 1

[PATCH 0/2] __btrfs_drop_extents() BUG_ON reproducer

2014-02-05 Thread David Disseldorp
This patch-set provides a reproducer for hitting the 3.14.0-rc1 BUG_ON() at: 692 int __btrfs_drop_extents(struct btrfs_trans_handle *trans, ... 839 /* 840 * | range to drop - | 841 * | extent | 842

[PATCH 1/2] btrfs: add small program for clone testing

2014-02-05 Thread David Disseldorp
The cloner program is capable of cloning files using the BTRFS_IOC_CLONE and BTRFS_IOC_CLONE_RANGE ioctls. Signed-off-by: David Disseldorp dd...@suse.de --- src/Makefile | 2 +- src/cloner.c | 168 +++ 2 files changed, 169 insertions